AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
283dba5785
skia2/tools/sk_app/win
History
Tyler Denniston 283dba5785 Revert "Add format-specifier warnings to SkDebugf." 
This reverts commit e58831cd95.

Reason for revert: looks like breaking a few build bots

Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I07848c1bf8992925c9498e916744d0840355a077
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421917
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2021-06-25 13:33:10 +00:00
..
ANGLEWindowContext_win.cpp Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. 2020-09-03 03:41:26 +00:00
D3D12WindowContext_win.cpp Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
DawnD3D12WindowContext_win.cpp Remove the dependency on Dawn's SwapChainUtils. 2020-04-09 20:31:30 +00:00
GLWindowContext_win.cpp Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. 2020-09-03 03:41:26 +00:00
main_win.cpp
RasterWindowContext_win.cpp Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. 2020-09-03 03:41:26 +00:00
VulkanWindowContext_win.cpp tools/sk_app: fWindowContext is unique_ptr<> 2019-08-02 16:16:34 +00:00
Window_win.cpp Fix Viewer crash when starting with vk msaa on windows. 2020-12-16 16:37:56 +00:00
Window_win.h Fix Viewer crash when starting with vk msaa on windows. 2020-12-16 16:37:56 +00:00
WindowContextFactory_win.h Add Direct3D swapchain support 2020-05-14 14:23:02 +00:00