skia2/tools
Brian Osman 2b23c4bf31 Dest color space no longer impacts mipmaps or texture sampling
PS5: Removes SkDestinationSurfaceColorMode, tracking of mipmap
mode on GrTexture, sRGB decode state per-texture. Because we
were often choosing sRGB configs for RGB color types, legacy
rendering would then be incorrect (too dark). So...

PS7: Stops ever using sRGB pixel configs when translating
image info or color type. Also removes a bunch of GrCaps bits
and a GrContextOption that are no longer relevant.

PS9: Adjusts surface creation unit test expectations, and
changes the raster rules accordingly.

At this point, sRGB configs are (obviously) going to be broken.

Locally, I ran 8888, gl, and the gbr- versions of both. Across
all GMs x configs, there are 13 diffs. 12 are GMs that create
surfaces with a color-space attached (and thus, the offscreen
is no longer getting sRGB pixel config). The only remainder
constructs an SkPictureImageGenerator, (with an attached color
space) and renders it to the gbr-gl canvas, which triggers a
a tagged surface inside the generator.

Bug: skia:
Change-Id: Ie5edfa157dd799f3121e8173fc4f97f6c8ed6789
Reviewed-on: https://skia-review.googlesource.com/131282
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-06-01 17:00:26 +00:00
..
android Reuse more upload_to_android and allow removing flag on Android 2017-10-31 14:37:14 +00:00
bookmaker Revert "Reland "remove toString"" 2018-05-31 12:27:44 +00:00
calmbench Add name field to calmbench json 2018-05-03 15:18:02 +00:00
copyright
debugger Remove SK_SUPPORT_GPU checks in tool-only code 2018-05-31 18:59:44 +00:00
fiddle Dest color space no longer impacts mipmaps or texture sampling 2018-06-01 17:00:26 +00:00
flags Dest color space no longer impacts mipmaps or texture sampling 2018-06-01 17:00:26 +00:00
fonts Fix compile when SK_XML undefined 2018-06-01 14:30:56 +00:00
gdb Add a gdb viewer for skbitmap. 2017-10-23 20:45:09 +00:00
gpu Dest color space no longer impacts mipmaps or texture sampling 2018-06-01 17:00:26 +00:00
lottiecap [lottiecap] Fix timestamp calculation to exactly match skottie in DM. 2018-03-20 21:02:57 +00:00
lua Make iOS main() functions normal. 2017-02-06 18:02:41 +00:00
mdbviz Remove carriage returns. 2017-10-09 20:41:14 +00:00
rebaseline Change add to toggle in the comments 2017-11-10 17:19:07 +00:00
sk_app Dest color space no longer impacts mipmaps or texture sampling 2018-06-01 17:00:26 +00:00
skdiff Revert "Simplify call when finished with bitmaps." 2018-01-26 21:44:24 +00:00
skiaserve Remove SK_SUPPORT_GPU checks in tool-only code 2018-05-31 18:59:44 +00:00
skp Omit "espn" from key_mobile_sites_smooth in RecreateSKPs bot 2018-05-20 14:53:16 +00:00
skpbench Dest color space no longer impacts mipmaps or texture sampling 2018-06-01 17:00:26 +00:00
skqp skqp: update apk list script 2018-05-31 16:46:40 +00:00
svg Remove internal files from externally visible markdown documentation 2018-01-10 13:25:19 +00:00
timer Fix MSAN compile error 2017-09-20 19:42:09 +00:00
trace Optimize the size of our JSON 2017-08-17 11:51:26 +00:00
viewer [skottie] Remove inPoint/outPoint/frameRate from public API 2018-06-01 13:10:15 +00:00
__init__.py
add_codereview_message.py Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
AndroidSkDebugToStdOut.cpp
BigPathBench.inc
bisect_roll Add bisect_roll tool 2018-01-11 19:42:55 +00:00
bisect_roll.bat Add bisect_roll tool 2018-01-11 19:42:55 +00:00
bisect_roll.go Add bisect_roll tool 2018-01-11 19:42:55 +00:00
build_command_buffer.py Improvements to build_command_buffer.py 2016-11-04 10:54:54 -07:00
BUILD_simulator.py
build_workaround_header.py Add CheckGeneratedFiles recipe check for gpu workarounds 2018-04-25 19:26:27 +00:00
check-headers-self-sufficient Reland "remove third_party/etc1" 2018-02-20 16:52:43 +00:00
chrome_fuzz.cpp Fix SkFILEStream. 2017-03-10 19:58:46 +00:00
compare_codereview.py
CrashHandler.cpp GOOGLE3 -> SK_BUILD_FOR_GOOGLE3 2017-12-19 14:42:16 +00:00
CrashHandler.h
create_flutter_test_images.cpp Push much of the SkColorSpace_Base interface up to SkColorSpace 2017-12-12 19:34:29 +00:00
DDLPromiseImageHelper.cpp Dest color space no longer impacts mipmaps or texture sampling 2018-06-01 17:00:26 +00:00
DDLPromiseImageHelper.h Remove SK_SUPPORT_GPU checks in tool-only code 2018-05-31 18:59:44 +00:00
DDLTileHelper.cpp Remove SK_SUPPORT_GPU checks in tool-only code 2018-05-31 18:59:44 +00:00
DDLTileHelper.h Remove SK_SUPPORT_GPU checks in tool-only code 2018-05-31 18:59:44 +00:00
doxygen_footer.txt
dump_record.cpp clean up SkDeferredCanvas 2017-11-27 21:31:26 +00:00
DumpRecord.cpp Revert "hide picture virtuals (no public callers)" 2018-01-27 17:30:15 +00:00
DumpRecord.h
embed_resources.py
find_run_binary.py
fix_pythonpath.py
gcov_shim
generate_vk_interface.sh Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time. 2016-02-22 09:56:40 -05:00
get_current_monitor_profile.cpp Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
get_images_from_skps.cpp Make get_images_from_skps always return success 2018-03-15 21:13:26 +00:00
git-sync-deps tools/git-sync-deps: less verbose when fetch is needed 2017-02-13 19:53:27 +00:00
gyp GN 2016-06-23 10:29:30 -07:00
imgblur.cpp Make iOS main() functions normal. 2017-02-06 18:02:41 +00:00
imgslice.cpp Make iOS main() functions normal. 2017-02-06 18:02:41 +00:00
install_dependencies.sh Add header file installation tips for building skia 2018-02-14 13:07:27 +00:00
ios_utils.h Fix bugs with fence sync API on iOS devices 2017-10-10 19:05:13 +00:00
ios_utils.m iOS: cd into Documents folder at startup 2017-02-06 15:06:45 +00:00
jsondiff.py
list_gms.cpp SkQP: replace blacklist with: DoNotExecuteInExperimentalMode and NoScoreInCompatibilityTestMode 2018-01-22 20:11:57 +00:00
list_gpu_unit_tests.cpp SkQP: replace blacklist with: DoNotExecuteInExperimentalMode and NoScoreInCompatibilityTestMode 2018-01-22 20:11:57 +00:00
LsanSuppressions.cpp Build LSAN suppressions into the test binaries. 2016-09-01 07:06:54 -07:00
merge_static_libs.py Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
milestone.py SkPDF: milestone in metadata, also SkMilestone.h 2016-03-29 09:09:29 -07:00
mirror-dev.sh Update mirror-dev for *-dev:amd64 packages. 2017-11-09 22:44:57 +00:00
misc_utils.py
OverwriteLine.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
parse_llvm_coverage.py Walk through files in parse_llvm_coverage.py instead of using 'git ls-files' 2016-04-18 04:18:56 -07:00
pathops_sorter.htm handle degenerate cubic loops 2018-02-02 20:39:09 +00:00
pathops_visualizer.htm Remove carriage returns. 2017-10-09 20:41:14 +00:00
picture_utils.cpp remove append_from_srgb() 2017-12-18 19:48:43 +00:00
picture_utils.h Move DM png code to picture_utils, for use by other tools. 2016-04-19 09:18:11 -07:00
ProcStats.cpp eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
ProcStats.h
public_headers_warnings_check.cpp GN: add public headers warnings check. 2016-11-16 19:27:29 +00:00
random_parse_path.cpp Add unit test to feed valid SVG sequences to make sure that 2016-02-09 10:30:22 -08:00
random_parse_path.h Add unit test to feed valid SVG sequences to make sure that 2016-02-09 10:30:22 -08:00
reformat-json.py
Registry.h move SkTRegister.h into tools 2017-01-11 19:53:36 +00:00
remote_demo.cpp fonts: Reland push font remoting. 2018-05-02 18:39:31 +00:00
ResourceFactory.h SkQP: ResourceFactory 2018-01-29 21:23:33 +00:00
Resources.cpp sk_tools/Resources: optional SK_TOOLS_REQUIRE_RESOURCES flag 2018-04-24 18:08:06 +00:00
Resources.h Revert "Revert "resources: remove most uses of GetResourcePath()"" 2017-12-09 01:27:50 +00:00
retrieve_from_googlesource.py
sanitize_source_files.py Clean up more references to GYP. 2017-02-06 17:55:35 +00:00
sk_pixel_iter.h handle clipping large triangles 2018-01-30 15:56:35 +00:00
sk_tool_utils.cpp Add color fonts. 2018-03-28 20:14:44 +00:00
sk_tool_utils.h Add color fonts. 2018-03-28 20:14:44 +00:00
skhello.cpp Make iOS main() functions normal. 2017-02-06 18:02:41 +00:00
SkJSONCPP.h GOOGLE3 -> SK_BUILD_FOR_GOOGLE3 2017-12-19 14:42:16 +00:00
skp_parser.cpp Remove code that was only used by the old debugger 2018-04-09 13:30:54 +00:00
skpinfo.cpp Make SkStream readers report failure. 2018-05-18 15:06:24 +00:00
skpmaker.cpp Make iOS main() functions normal. 2017-02-06 18:02:41 +00:00
Stats.h
test_all.py
test_pdfs.py
UrlDataManager.cpp
UrlDataManager.h Use sse4.2 CRC32 instructions to hash when available. 2016-08-08 09:06:28 -07:00
using_skia_and_harfbuzz.cpp Make SkShaper a module 2018-05-30 04:04:07 +00:00
valgrind.supp update valgrind suppressions for revised keepalive thread 2017-10-31 15:34:43 +00:00
whitelist_typefaces.cpp Make iOS main() functions normal. 2017-02-06 18:02:41 +00:00
win_dbghelp.cpp
win_dbghelp.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
win_lcid.cpp