AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
35fee4c079
skia2/tests/sksl
History
John Stiles 35fee4c079 Revert "Declare all inlined variables at the topmost scope possible." 
This reverts commit e8e4aca955.

Reason for revert: can break ES2 for-loop rules

Original change's description:
> Declare all inlined variables at the topmost scope possible.
>
> By itself, this is uninteresting and even perhaps slightly
> counterproductive (as it separates vardecl from its initializer,
> increasing LOC). However, this enables a followup CL
> (http://review.skia.org/344665) which allows single-return functions to
> be inlined without the creation of a temporary variable at all. This
> applies to the majority of fragment processors in a typical Ganesh
> hierarchy. This change will greatly reduce the number of inliner-created
> temporary copies when compiling a typical tree of FPs.
>
> Change-Id: I03423a13cf35050637dabace4a32973a08a4ed0a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344764
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: Ica01d6906bcb9cef1f49d22dda714fc9cbfa3885
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345121
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-12-16 18:26:21 +00:00
..
blend Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
errors Revert "Fix incorrect 'unreachable code' error in SkSL" 2020-12-16 18:21:17 +00:00
fp Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
glsl Replace array indexing on vector types with swizzles. 2020-12-07 21:16:40 +00:00
inliner Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
intrinsics Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
metal Improve Metal support for out parameters. 2020-12-09 21:13:57 +00:00
shared Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
spirv Fix various SkSL errors that don't report a line number. 2020-12-14 16:11:13 +00:00
workarounds Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00