82cb86f613
Reason for revert: breaks linker on chrome [04:36:09.966000] [503/5965] LIB obj\chrome\installer_util.lib [04:36:10.466000] FAILED: C:\Users\chrome-bot\buildbot\third_party\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True skia.dll "C:\Users\chrome-bot\buildbot\third_party\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:skia.dll.lib /DLL /OUT:skia.dll @skia.dll.rsp" 2 mt.exe rc.exe "obj\skia\skia.skia.dll.intermediate.manifest" obj\skia\skia.skia.dll.generated.manifest [04:36:10.466000] skia.opts_check_x86.obj : error LNK2019: unresolved external symbol "bool __cdecl SkBoxBlurGetPlatformProcs_SSE4(void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int))" (?SkBoxBlurGetPlatformProcs_SSE4@@YA_NPAP6AXPBIHPAIHHHHH@Z222@Z) referenced in function "bool __cdecl SkBoxBlurGetPlatformProcs(void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int))" (?SkBoxBlurGetPlatformProcs@@YA_NPAP6AXPBIHPAIHHHHH@Z222@Z) [04:36:10.466000] [04:36:10.466000] skia.dll : fatal error LNK1120: 1 unresolved externals Original issue's description: > Add SSE4 version of BlurImage optimizations. > > Adds an SSE4.1 version of the existing BlurImage optimizations. > Performance of blur_image_filter_* benchmarks show a 10-50% > improvement on Linux/Ubuntu Core i7. > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com> > > Committed: https://skia.googlesource.com/skia/+/2830632ce93c97ed7647b13348365ea92e4ea665 R=mtklein@google.com, henrik.smiding@intel.com TBR=henrik.smiding@intel.com, mtklein@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/375503003 |
||
---|---|---|
.. | ||
android_deps.gyp | ||
android_framework_lib.gyp | ||
android_system.gyp | ||
angle.gyp | ||
animator.gyp | ||
apptype_console.gypi | ||
bench.gyp | ||
bench.gypi | ||
chromeos_deps.gyp | ||
common_conditions.gypi | ||
common_variables.gypi | ||
common.gypi | ||
core.gyp | ||
core.gypi | ||
debugger.gyp | ||
dm.gyp | ||
effects.gyp | ||
effects.gypi | ||
etc1.gyp | ||
everything.gyp | ||
experimental.gyp | ||
FileReaderApp.gyp | ||
flags.gyp | ||
freetype.gyp | ||
freetype.gypi | ||
giflib.gyp | ||
gm.gyp | ||
gmslides.gypi | ||
gpu.gyp | ||
gpu.gypi | ||
gputest.gyp | ||
images.gyp | ||
jsoncpp.gyp | ||
ktx.gyp | ||
libjpeg.gyp | ||
libpng.gyp | ||
libwebp.gyp | ||
lua.gyp | ||
most.gyp | ||
nacl.gyp | ||
nanomsg.gyp | ||
opts.gyp | ||
pathops_unittest.gyp | ||
pathops_unittest.gypi | ||
pathops.gypi | ||
pdf.gyp | ||
pdf.gypi | ||
pdfviewer_lib.gyp | ||
pdfviewer.gyp | ||
pixman_test.gyp | ||
poppler.gyp | ||
ports.gyp | ||
public_headers.gypi | ||
record.gypi | ||
SampleApp.gyp | ||
sfnt.gyp | ||
shapeops_demo.gyp | ||
shapeops_edge.gyp | ||
shapeops_tool.gyp | ||
SimpleCocoaApp.gyp | ||
SimpleiOSApp.gyp | ||
skflate.gyp | ||
skia_for_android_framework_defines.gypi | ||
skia_for_chromium_defines.gypi | ||
skia_launcher.gyp | ||
skia_lib.gyp | ||
svg.gyp | ||
tests.gyp | ||
tests.gypi | ||
tools.gyp | ||
utils.gyp | ||
utils.gypi | ||
v8.gyp | ||
views_animated.gyp | ||
views.gyp | ||
webtry.gyp | ||
xml.gyp | ||
xps.gyp | ||
zlib.gyp |