7bf799956d
This is a reland of e58831cd95
Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
Bug: skia:12143
Change-Id: Id3c0c21436ebd13899908d5ed5d44c42a0e23921
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421918
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
218 lines
8.6 KiB
C++
218 lines
8.6 KiB
C++
/*
|
|
* Copyright 2015 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "include/gpu/GrDirectContext.h"
|
|
#include "src/gpu/GrDirectContextPriv.h"
|
|
#include "src/gpu/GrProxyProvider.h"
|
|
#include "src/gpu/GrShaderCaps.h"
|
|
#include "src/gpu/GrSurfaceDrawContext.h"
|
|
#include "src/gpu/GrTexture.h"
|
|
#include "src/gpu/GrTextureProxyPriv.h"
|
|
#include "src/gpu/gl/GrGLGpu.h"
|
|
#include "src/gpu/gl/GrGLUtil.h"
|
|
#include "tests/Test.h"
|
|
#include "tests/TestUtils.h"
|
|
#include "tools/gpu/GrContextFactory.h"
|
|
#include "tools/gpu/ManagedBackendTexture.h"
|
|
#include "tools/gpu/gl/GLTestContext.h"
|
|
|
|
#ifdef SK_GL
|
|
|
|
using sk_gpu_test::GLTestContext;
|
|
|
|
static void cleanup(GLTestContext* glctx0,
|
|
GrGLuint texID0,
|
|
GLTestContext* glctx1,
|
|
sk_sp<GrDirectContext> dContext,
|
|
GrEGLImage image1) {
|
|
if (glctx1) {
|
|
glctx1->makeCurrent();
|
|
if (GR_EGL_NO_IMAGE != image1) {
|
|
glctx1->destroyEGLImage(image1);
|
|
}
|
|
}
|
|
|
|
glctx0->makeCurrent();
|
|
if (texID0) {
|
|
GR_GL_CALL(glctx0->gl(), DeleteTextures(1, &texID0));
|
|
}
|
|
}
|
|
|
|
DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(EGLImageTest, reporter, ctxInfo) {
|
|
auto context0 = ctxInfo.directContext();
|
|
sk_gpu_test::GLTestContext* glCtx0 = ctxInfo.glContext();
|
|
|
|
// Try to create a second GL context and then check if the contexts have necessary
|
|
// extensions to run this test.
|
|
|
|
if (kGLES_GrGLStandard != glCtx0->gl()->fStandard) {
|
|
return;
|
|
}
|
|
GrGLGpu* gpu0 = static_cast<GrGLGpu*>(context0->priv().getGpu());
|
|
if (!gpu0->glCaps().shaderCaps()->externalTextureSupport()) {
|
|
return;
|
|
}
|
|
|
|
std::unique_ptr<GLTestContext> glCtx1 = glCtx0->makeNew();
|
|
if (!glCtx1) {
|
|
return;
|
|
}
|
|
sk_sp<GrDirectContext> context1 = GrDirectContext::MakeGL(sk_ref_sp(glCtx1->gl()));
|
|
GrEGLImage image = GR_EGL_NO_IMAGE;
|
|
GrGLTextureInfo externalTexture;
|
|
externalTexture.fID = 0;
|
|
|
|
if (!context1) {
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
if (!glCtx1->gl()->hasExtension("EGL_KHR_image") ||
|
|
!glCtx1->gl()->hasExtension("EGL_KHR_gl_texture_2D_image")) {
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
///////////////////////////////// CONTEXT 1 ///////////////////////////////////
|
|
|
|
// Use GL Context 1 to create a texture unknown to context 0.
|
|
context1->flushAndSubmit();
|
|
static const int kSize = 100;
|
|
|
|
auto mbet = sk_gpu_test::ManagedBackendTexture::MakeWithoutData(
|
|
context1.get(), kSize, kSize, kRGBA_8888_SkColorType, GrMipmapped::kNo,
|
|
GrRenderable::kNo, GrProtected::kNo);
|
|
|
|
if (!mbet) {
|
|
ERRORF(reporter, "Error creating texture for EGL Image");
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
GrGLTextureInfo texInfo;
|
|
if (!mbet->texture().getGLTextureInfo(&texInfo)) {
|
|
ERRORF(reporter, "Failed to get GrGLTextureInfo");
|
|
return;
|
|
}
|
|
|
|
if (GR_GL_TEXTURE_2D != texInfo.fTarget) {
|
|
ERRORF(reporter, "Expected backend texture to be 2D");
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
// Wrap the texture in an EGLImage
|
|
image = glCtx1->texture2DToEGLImage(texInfo.fID);
|
|
if (GR_EGL_NO_IMAGE == image) {
|
|
ERRORF(reporter, "Error creating EGL Image from texture");
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
// Since we are dealing with two different GL contexts here, we need to call finish so that the
|
|
// clearing of the texture that happens in createTextingOnlyBackendTexture occurs before we call
|
|
// TexSubImage below on the other context. Otherwise, it is possible the calls get reordered and
|
|
// the clearing overwrites the TexSubImage writes.
|
|
GR_GL_CALL(glCtx1->gl(), Finish());
|
|
|
|
// Populate the texture using GL context 1. Important to use TexSubImage as TexImage orphans
|
|
// the EGL image. Also, this must be done after creating the EGLImage as the texture
|
|
// contents may not be preserved when the image is created.
|
|
SkAutoTMalloc<uint32_t> pixels(kSize * kSize);
|
|
for (int i = 0; i < kSize*kSize; ++i) {
|
|
pixels.get()[i] = 0xDDAABBCC;
|
|
}
|
|
GR_GL_CALL(glCtx1->gl(), ActiveTexture(GR_GL_TEXTURE0));
|
|
GR_GL_CALL(glCtx1->gl(), BindTexture(texInfo.fTarget, texInfo.fID));
|
|
GR_GL_CALL(glCtx1->gl(), TexSubImage2D(texInfo.fTarget, 0, 0, 0, kSize, kSize,
|
|
GR_GL_RGBA, GR_GL_UNSIGNED_BYTE, pixels.get()));
|
|
GR_GL_CALL(glCtx1->gl(), Finish());
|
|
// We've been making direct GL calls in GL context 1, let GrDirectContext 1 know its internal
|
|
// state is invalid.
|
|
context1->resetContext();
|
|
|
|
///////////////////////////////// CONTEXT 0 ///////////////////////////////////
|
|
|
|
// Make a new texture ID in GL Context 0 from the EGL Image
|
|
glCtx0->makeCurrent();
|
|
externalTexture.fTarget = GR_GL_TEXTURE_EXTERNAL;
|
|
externalTexture.fID = glCtx0->eglImageToExternalTexture(image);
|
|
externalTexture.fFormat = GR_GL_RGBA8;
|
|
if (0 == externalTexture.fID) {
|
|
ERRORF(reporter, "Error converting EGL Image back to texture");
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
// Wrap this texture ID in a GrTexture
|
|
GrBackendTexture backendTex(kSize, kSize, GrMipmapped::kNo, externalTexture);
|
|
|
|
GrColorInfo colorInfo(GrColorType::kRGBA_8888, kPremul_SkAlphaType, nullptr);
|
|
// TODO: If I make this TopLeft origin to match resolve_origin calls for kDefault, this test
|
|
// fails on the Nexus5. Why?
|
|
GrSurfaceOrigin origin = kBottomLeft_GrSurfaceOrigin;
|
|
sk_sp<GrSurfaceProxy> texProxy = context0->priv().proxyProvider()->wrapBackendTexture(
|
|
backendTex, kBorrow_GrWrapOwnership, GrWrapCacheable::kNo, kRW_GrIOType);
|
|
if (!texProxy) {
|
|
ERRORF(reporter, "Error wrapping external texture in GrTextureProxy.");
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
GrSwizzle swizzle = context0->priv().caps()->getReadSwizzle(texProxy->backendFormat(),
|
|
colorInfo.colorType());
|
|
GrSurfaceProxyView view(std::move(texProxy), origin, swizzle);
|
|
auto surfaceContext = GrSurfaceContext::Make(context0, std::move(view), colorInfo);
|
|
|
|
if (!surfaceContext) {
|
|
ERRORF(reporter, "Error wrapping external texture in GrSurfaceContext.");
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
return;
|
|
}
|
|
|
|
GrTextureProxy* proxy = surfaceContext->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, proxy->mipmapped() == GrMipmapped::kNo);
|
|
REPORTER_ASSERT(reporter, proxy->peekTexture()->mipmapped() == GrMipmapped::kNo);
|
|
|
|
REPORTER_ASSERT(reporter, proxy->textureType() == GrTextureType::kExternal);
|
|
REPORTER_ASSERT(reporter, proxy->peekTexture()->textureType() == GrTextureType::kExternal);
|
|
REPORTER_ASSERT(reporter, proxy->hasRestrictedSampling());
|
|
REPORTER_ASSERT(reporter, proxy->peekTexture()->hasRestrictedSampling());
|
|
|
|
// Should not be able to wrap as a RT
|
|
{
|
|
auto temp = GrSurfaceFillContext::MakeFromBackendTexture(context0,
|
|
colorInfo,
|
|
backendTex,
|
|
1,
|
|
origin,
|
|
/*release helper*/ nullptr);
|
|
if (temp) {
|
|
ERRORF(reporter, "Should not be able to wrap an EXTERNAL texture as a RT.");
|
|
}
|
|
}
|
|
|
|
//TestReadPixels(reporter, context0, surfaceContext.get(), pixels.get(), "EGLImageTest-read");
|
|
|
|
SkDebugf("type: %d\n", (int)surfaceContext->asTextureProxy()->textureType());
|
|
// We should not be able to write to an EXTERNAL texture
|
|
TestWritePixels(reporter, context0, surfaceContext.get(), false, "EGLImageTest-write");
|
|
|
|
// Only test RT-config
|
|
// TODO: why do we always need to draw to copy from an external texture?
|
|
TestCopyFromSurface(reporter,
|
|
context0,
|
|
surfaceContext->asSurfaceProxyRef(),
|
|
surfaceContext->origin(),
|
|
colorInfo.colorType(),
|
|
pixels.get(),
|
|
"EGLImageTest-copy");
|
|
|
|
cleanup(glCtx0, externalTexture.fID, glCtx1.get(), context1, image);
|
|
}
|
|
|
|
#endif // SK_GL
|