AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
408c3eaada
skia2/tools
History
Mike Klein 408c3eaada don't have fm_bot send fm empty sources to run 
Running fm_bot at head I'm confronted with a puzzling error:

    2019/04/03 10:26:01
    out/fm -b cpu -w foo -s big_rrect_rect_aa_effect filterbitmap_image_mandrill_512.png                    #failed (exit status 1):
    Don't understand --source ... bailing out.

    2019/04/03 10:26:05 1 invocations of out/fm failed

And of course running that command works fine.  Puzzling!

To fix this, we must take care not to subslice sources past its end,
which fills with defaults, a bunch of extra "" sources.  And add some ''
around the unknown source to make the error message easier to parse.

Serves me right for not testing this before I landed that tweak...

Change-Id: I5c2abb35733b32a1142b0f42c4323112969ad2bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/205825
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-04-03 15:15:04 +00:00
..
android
calmbench Remove gclient sync from calmbench 2018-08-24 19:18:56 +00:00
copyright Fix pylint check in presubmit 2018-06-22 14:38:28 +00:00
debugger changes to wasm debugger for UI integration 2019-03-28 18:06:13 +00:00
doxygen api.skia.org - Don't document private. 2019-03-11 15:52:21 +00:00
fiddle moar static flags 2019-03-21 17:07:13 +00:00
flags Revert "Remove the NullGL interface (and associated test context)" 2019-04-02 12:48:37 +00:00
fm don't have fm_bot send fm empty sources to run 2019-04-03 15:15:04 +00:00
fonts lazy svg parsing in TestSVGTypeface 2019-03-27 17:27:18 +00:00
gdb Update gdb bitmap viewer. 2018-06-20 21:24:27 +00:00
gpu Revert "Remove the NullGL interface (and associated test context)" 2019-04-02 12:48:37 +00:00
lottiecap [LottieWeb] Fix frames 2018-08-29 17:58:42 +00:00
lua remove Sk prefix from CommandLineFlags 2019-03-20 17:13:22 +00:00
mdbviz de-Sk tools/debugger 2019-03-20 18:27:01 +00:00
rebaseline
sk_app Add support to disable vsync on mac viewer. 2019-03-28 14:57:23 +00:00
skdiff sk_tool_utils -> ToolUtils, and git clang-format 2019-03-20 18:05:42 +00:00
skiaserve DEFINE_int32 + DEFINE_uint32 -> DEFINE_int 2019-03-21 17:20:19 +00:00
skp Remove 4 page sets that are not useful as SKPs 2019-04-01 17:26:54 +00:00
skpbench Fix mkdir_p in skpbench 2019-04-01 19:19:23 +00:00
skqp sk_tool_utils -> ToolUtils, and git clang-format 2019-03-20 18:05:42 +00:00
svg
timer SkAnimTimer -> AnimTimer 2019-03-20 18:26:35 +00:00
trace moar static flags 2019-03-21 17:07:13 +00:00
viewer [sksg] Refactor gradient implementation 2019-04-01 18:43:43 +00:00
__init__.py
add_codereview_message.py
AndroidSkDebugToStdOut.cpp
BigPathBench.inc
bisect_roll
bisect_roll.bat
bisect_roll.go
build_command_buffer.py
BUILD_simulator.py
build_workaround_header.py Add CheckGeneratedFiles recipe check for gpu workarounds 2018-04-25 19:26:27 +00:00
check-headers-self-sufficient Remove all references to jsoncpp (build scripts, DEPS, etc) 2019-02-06 15:15:52 +00:00
chrome_fuzz.cpp
clang-tidy.sh run clang-tidy on headers too 2018-12-12 15:26:22 +00:00
compare_codereview.py
CrashHandler.cpp
CrashHandler.h
DDLPromiseImageHelper.cpp Revert "Revert "Change promise image contract to for when Release and Done are called."" 2019-03-18 19:20:44 +00:00
DDLPromiseImageHelper.h Remove support for SkDeferredDisplayListRecorder::DelayReleaseCallback::kNo. 2019-02-28 19:02:20 +00:00
DDLTileHelper.cpp Connect up YUVA images for testing. 2018-10-12 19:31:08 +00:00
DDLTileHelper.h Revert "Fix bug in GM's DDL drawing mode" 2018-09-26 21:18:28 +00:00
doxygen_footer.txt
dump_record.cpp DEFINE_int32 + DEFINE_uint32 -> DEFINE_int 2019-03-21 17:20:19 +00:00
DumpRecord.cpp Fix occurrences of "-Wextra-semi-stmt" 2018-11-30 23:23:09 +00:00
DumpRecord.h
embed_resources.py [canvaskit] Allow users to load their own fonts 2018-12-12 15:40:08 +00:00
find_run_binary.py
fix_pythonpath.py
gcov_shim
get_current_monitor_profile.cpp
get_images_from_skps.cpp moar static flags 2019-03-21 17:07:13 +00:00
git-sync-deps tools/git-sync-deps: fix 2018-06-20 14:38:34 +00:00
gyp
HashAndEncode.cpp add --backend skp to fm 2019-03-27 19:55:28 +00:00
HashAndEncode.h FM, a dumber new testing tool 2019-03-27 14:00:58 +00:00
hello-opencl.cpp run all available OpenCL devices 2019-02-11 21:29:33 +00:00
imgcvt.cpp Fix bugs and add features to imgcvt 2019-01-04 16:43:07 +00:00
install_dependencies.sh Add header file installation tips for building skia 2018-02-14 13:07:27 +00:00
ios_utils.h
ios_utils.m
jsondiff.py Fix pylint check in presubmit 2018-06-22 14:38:28 +00:00
list_gms.cpp sk_tool::Registry: make an iterator. 2018-08-01 16:59:19 +00:00
list_gpu_unit_tests.cpp sk_tool::Registry: make an iterator. 2018-08-01 16:59:19 +00:00
LsanSuppressions.cpp Upgrade to Mesa 18.3.3 2019-02-12 16:42:30 +00:00
merge_static_libs.py
milestone.py
mirror-dev.sh
misc_utils.py
OverwriteLine.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
parse_llvm_coverage.py
pathops_sorter.htm fix pathops bug 8380 2018-12-21 19:15:54 +00:00
pathops_visualizer.htm fix pathops bug 8380 2018-12-21 19:15:54 +00:00
ProcStats.cpp eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
ProcStats.h
public_headers_warnings_check.cpp
random_parse_path.cpp
random_parse_path.h
reformat-json.py
Registry.h sk_tool::Registry: make an iterator. 2018-08-01 16:59:19 +00:00
remote_demo.cpp add colorspace param to textblobdiff canvas 2019-02-20 04:52:48 +00:00
ResourceFactory.h SkQP: ResourceFactory 2018-01-29 21:23:33 +00:00
Resources.cpp de-common the rest of the flags 2019-03-25 17:39:58 +00:00
Resources.h Change SkTypeface::MakeFromStream to take unique_ptr 2018-09-04 15:24:12 +00:00
retrieve_from_googlesource.py
sanitize_source_files.py
skhello.cpp moar static flags 2019-03-21 17:07:13 +00:00
skp_parser.cpp de-Sk tools/debugger 2019-03-20 18:27:01 +00:00
skpinfo.cpp moar static flags 2019-03-21 17:07:13 +00:00
Stats.h make float divide-by-zero fatal 2018-11-06 21:56:27 +00:00
test_all.py
test_pdfs.py
ToolUtils.cpp Remove ToolUtils::write_pixels 2019-04-01 20:24:55 +00:00
ToolUtils.h Remove ToolUtils::write_pixels 2019-04-01 20:24:55 +00:00
UrlDataManager.cpp
UrlDataManager.h
using_skia_and_harfbuzz.cpp Clean up shaper handler. 2019-04-02 14:56:26 +00:00
valgrind.supp Add valgrind suppression for leak in libGLX_nvidia when caching program binaries 2018-07-18 16:43:51 +00:00
whitelist_typefaces.cpp
win_dbghelp.cpp test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
win_dbghelp.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
win_lcid.cpp
xsan.blacklist turn on alignment sanitizer 2018-08-09 21:13:15 +00:00