AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
48825b11ad
skia2/tools/sk_app
History
Brian Salomon 48825b11ad Redefine the meaning of sample counts in GPU backend. 
Old: 0  -> nonMSAA
     1+ -> MSAA

New:
     0  -> error/unsupported
     1  -> nonMSAA
     2+ -> MSAA

We still allow 0 to mean nonMSAA in three sets of public APIs for backwards compatibility:

1) SkSurface factories
2) GrBackendRenderTarget constructors
3) GrCaps::getSampleCnt()'s requestedCount parameter

However, we immediately clamp to 1 and treat 0 as invalid/non-renderable internally.

This also changes the behavior when using a large sample count. We now fail in that case rather than using the largest sample available sample count. GrCaps::getSampleCount() will return 0 in this case.


Bug: skia:
Change-Id: Ida22c6b22c1365e563c9046b611e88bf5eb3ff33
Reviewed-on: https://skia-review.googlesource.com/101560
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-02-01 18:16:58 +00:00
..
android Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
ios Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
mac Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
unix Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
win Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
Application.h Remove SampleApp and convert HelloWorld to sk_app 2017-11-21 18:37:19 +00:00
CommandSet.cpp eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
CommandSet.h Remove SampleApp and convert HelloWorld to sk_app 2017-11-21 18:37:19 +00:00
DisplayParams.h Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
GLWindowContext.cpp Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
GLWindowContext.h Remove SampleApp and convert HelloWorld to sk_app 2017-11-21 18:37:19 +00:00
RasterWindowContext.h Remove SampleApp and convert HelloWorld to sk_app 2017-11-21 18:37:19 +00:00
VulkanWindowContext.cpp Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
VulkanWindowContext.h Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
Window.cpp Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00
Window.h Move stats code to new layer (with configurable list of timers) 2017-12-20 16:59:04 +00:00
WindowContext.h Redefine the meaning of sample counts in GPU backend. 2018-02-01 18:16:58 +00:00