skia2/tools/trace/SkDebugfTracer.cpp
Brian Osman de6e5bf33f Tracing cleanup and bugfixes
TraceID was unused, remove it.

Simplify casting logic by using the same union helper as the macros.
This fixes a bug that was present in the bool handling - we were
treating the union value as a pointer, so we were dereferencing
random stack memory. Luckily it never crashes, we did get the wrong
values for bools.

Bug: skia:
Change-Id: I15d44756214f34c1f6479980d9a487ac7f3d8f6c
Reviewed-on: https://skia-review.googlesource.com/25801
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-07-21 20:57:27 +00:00

86 lines
3.4 KiB
C++

/*
* Copyright 2017 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "SkDebugfTracer.h"
#include "SkTraceEvent.h"
SkEventTracer::Handle SkDebugfTracer::addTraceEvent(char phase,
const uint8_t* categoryEnabledFlag,
const char* name,
uint64_t id,
int numArgs,
const char** argNames,
const uint8_t* argTypes,
const uint64_t* argValues,
uint8_t flags) {
SkString args;
for (int i = 0; i < numArgs; ++i) {
if (i > 0) {
args.append(", ");
} else {
args.append(" ");
}
skia::tracing_internals::TraceValueUnion value;
value.as_uint = argValues[i];
switch (argTypes[i]) {
case TRACE_VALUE_TYPE_BOOL:
args.appendf("%s=%s", argNames[i], value.as_bool ? "true" : "false");
break;
case TRACE_VALUE_TYPE_UINT:
args.appendf("%s=%u", argNames[i], static_cast<uint32_t>(argValues[i]));
break;
case TRACE_VALUE_TYPE_INT:
args.appendf("%s=%d", argNames[i], static_cast<int32_t>(argValues[i]));
break;
case TRACE_VALUE_TYPE_DOUBLE:
args.appendf("%s=%g", argNames[i], value.as_double);
break;
case TRACE_VALUE_TYPE_POINTER:
args.appendf("%s=0x%p", argNames[i], value.as_pointer);
break;
case TRACE_VALUE_TYPE_STRING:
case TRACE_VALUE_TYPE_COPY_STRING: {
static constexpr size_t kMaxLen = 20;
SkString string(value.as_string);
size_t truncAt = string.size();
size_t newLineAt = SkStrFind(string.c_str(), "\n");
if (newLineAt > 0) {
truncAt = newLineAt;
}
truncAt = SkTMin(truncAt, kMaxLen);
if (truncAt < string.size()) {
string.resize(truncAt);
string.append("...");
}
args.appendf("%s=\"%s\"", argNames[i], string.c_str());
break;
}
default:
args.appendf("%s=<unknown type>", argNames[i]);
break;
}
}
bool open = (phase == TRACE_EVENT_PHASE_COMPLETE);
if (open) {
const char* category = this->getCategoryGroupName(categoryEnabledFlag);
SkDebugf("[% 2d]%s <%s> %s%s #%d {\n", fIndent.size(), fIndent.c_str(), category, name,
args.c_str(), fCnt);
fIndent.append(" ");
} else {
SkDebugf("%s%s #%d\n", name, args.c_str(), fCnt);
}
++fCnt;
return 0;
}
void SkDebugfTracer::updateTraceEventDuration(const uint8_t* categoryEnabledFlag,
const char* name,
SkEventTracer::Handle handle) {
fIndent.resize(fIndent.size() - 1);
SkDebugf("[% 2d]%s } %s\n", fIndent.size(), fIndent.c_str(), name);
}