4e1f0225db
Currently, GrGLGpu doesn't disable blend when the color mask is false. It causes bad happening as follows, * GPU thinks the blend is on so reads FBO unnecessary. * In the case the blend needs SRC1 but shader doesn't have the color attachment, some GPU driver can crash [1] * In the above case, it's undefined behavior according to the spec [2] [1] Mesa on Intel had the issue but it was fixed thank to this test failure. https://patchwork.freedesktop.org/patch/235939/ [2] https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_blend_func_extended.txt TEST: mixedtextblobs in dm or skqp Bug: b/116339546 Change-Id: I71a36defd0ffe48ed914aa428bd351fd0c5f5974 Reviewed-on: https://skia-review.googlesource.com/c/167220 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> Commit-Queue: Greg Daniel <egdaniel@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| dm | ||
| docker | ||
| docs | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| Doxyfile | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.