72743b1654
Reason for revert: win_chromium_compile_dbg_ng FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\skia\src\core\skia.SkBitmapHeap.obj.rsp /c ..\..\third_party\skia\src\core\SkBitmapHeap.cpp /Foobj\third_party\skia\src\core\skia.SkBitmapHeap.obj /Fdobj\skia\skia.cc.pdb e:\b\build\slave\win\build\src\third_party\skia\include\core\skpicture.h(176) : error C2487: 'CURRENT_PICTURE_VERSION' : member of dll interface class may not be declared with dll interface Original issue's description: > Sketch splitting SkPicture into an interface and SkBigPicture. > > Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). > These cover about 89% of draw calls from Blink SKPs, > and about 25% of draw calls from our GMs. > > SkPicture handles: > - serialization and deserialization > - unique IDs > > Everything else is left to the subclasses: > - playback(), cullRect() > - hasBitmap(), hasText(), suitableForGPU(), etc. > - LayerInfo / AccelData if applicable. > > The time to record a 1-op picture improves a good chunk > (2 mallocs to 1), and the time to record a 0-op picture > greatly improves (2 mallocs to none): > > picture_overhead_draw: 450ns -> 350ns > picture_overhead_nodraw: 300ns -> 90ns > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b > > Latest blink_linux_rel: > > http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 > > Committed: https://skia.googlesource.com/skia/+/15877b6eae33a9282458bdb904a6d00440eca0ec TBR=reed@google.com,robertphillips@google.com,fmalita@chromium.org,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1130283004 |
||
---|---|---|
.. | ||
ios | ||
mac | ||
win | ||
SkBoundaryPatch.h | ||
SkCamera.h | ||
SkCanvasStateUtils.h | ||
SkCubicInterval.h | ||
SkCullPoints.h | ||
SkDebugUtils.h | ||
SkDeferredCanvas.h | ||
SkDumpCanvas.h | ||
SkEventTracer.h | ||
SkFrontBufferedStream.h | ||
SkInterpolator.h | ||
SkJSONCPP.h | ||
SkLayer.h | ||
SkLua.h | ||
SkLuaCanvas.h | ||
SkMatrix44.h | ||
SkMeshUtils.h | ||
SkNinePatch.h | ||
SkNoSaveLayerCanvas.h | ||
SkNullCanvas.h | ||
SkNWayCanvas.h | ||
SkPaintFilterCanvas.h | ||
SkParse.h | ||
SkParsePaint.h | ||
SkParsePath.h | ||
SkPictureUtils.h | ||
SkRandom.h | ||
SkRTConf.h | ||
SkTextBox.h |