5a479e187d
There are very few ways that hb_font_create can fail. It will do minimal sanitization if the data begins with a known magic signature, but will otherwise return a valid hb_font which more or less looks like a valid font with no glyphs and upem of 1000. This appears to be the reason gfx is only using hb_face_create_for_tables to avoid the issue where a system font may be understood by FreeType and otherwise be valid, but not recognized by HarfBuzz. Keep the efficiency of hb_font_create when it can be used, but check if the resulting hb_font has no glyphs. If it has no glyphs attempt to use hb_face_create_for_tables instead. See https://github.com/harfbuzz/harfbuzz/issues/248 Change-Id: Iaf82127152cdf6de160274234bcb19b5ccbccc1b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419805 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> |
||
|---|---|---|
| animations | ||
| bazel | ||
| bench | ||
| bin | ||
| build/fuchsia | ||
| build_overrides | ||
| client_utils/android | ||
| demos.skia.org | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| specs | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .bazelignore | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.bazel | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| DIR_METADATA | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| RELEASE_NOTES.txt | ||
| whitespace.txt | ||
| WORKSPACE.bazel | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.