68a76b31b4
In Release mode GCC 8 finds some issue I don't exactly understand when using SkSTArray (or even SkTArray) here with MEM_COPY=true, for both arrays, issuing one -Warray-bounds warning and one -Wstringop-overflow warning for each array, ostensibly about the calls to resize_back(). (Oddly if you remove the initial reservations in the constructors, this drops to just one warning each.) My initial suspicion was some sort of aliasing issue, but I think the SkPoint / 2x GrGLfloat pun might be legal, and even if it weren't, it would not explain why the verbs array warns in the same manner. Anyway I'd care more about this if the pattern of allocating an array of a fixed runtime size weren't served better by SkAutoSTArray. No warnings from GCC now. Change-Id: I6959acc0500df4539e43e5d280c1e872b8c2fca3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257862 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| build/fuchsia | ||
| build_overrides | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| specs | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| RELEASE_NOTES.txt | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.