skia2/tools
Hal Canary 02738a86e5 Revert "hide hinting and flag enums with PAINT_FLAGS"
This reverts commit 5d052dac3a.

Reason for revert: BREAKS CHROMIUM ROLL.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc?l=49
|   FAILED: obj/third_party/blink/renderer/platform/platform/font_platform_data_win.obj
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(49,29):
|     error: no member named 'kLCDRenderText_Flag' in 'SkPaint'
|     if (text_flags & SkPaint::kLCDRenderText_Flag) {
|                      ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(51,36):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|     } else if (text_flags & SkPaint::kAntiAlias_Flag) {
|                             ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(56,52):
|     error: no member named 'kSubpixelText_Flag' in 'SkPaint'
|     font->setSubpixel(SkToBool(text_flags & SkPaint::kSubpixelText_Flag));
|                                             ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(64,29):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|     if (text_flags & SkPaint::kAntiAlias_Flag)
|                      ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(85,27):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|                  ? SkPaint::kAntiAlias_Flag
|                    ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(91,35):
|     error: no member named 'kLCDRenderText_Flag' in 'SkPaint'
|                          ? SkPaint::kLCDRenderText_Flag
|                            ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(93,27):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|       text_flags = SkPaint::kAntiAlias_Flag | lcd_flag;
|                    ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(101,28):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|       text_flags |= SkPaint::kAntiAlias_Flag;
|                     ~~~~~~~~~^
|   8 errors generated.

Original change's description:
> hide hinting and flag enums with PAINT_FLAGS
> 
> A preflight for https://skia-review.googlesource.com/c/skia/+/185460
> 
> Bug: skia:2664
> Change-Id: I83f7f9cd500e8507b559462835477ba8ae7c11ab
> Reviewed-on: https://skia-review.googlesource.com/c/185540
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
> Auto-Submit: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I4d1581a7e29267ad459ed31d4885b823fa00066f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:2664
Reviewed-on: https://skia-review.googlesource.com/c/185680
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-01-21 18:51:39 +00:00
..
android
bookmaker fix bookmaker 2019-01-07 21:06:29 +00:00
calmbench Remove gclient sync from calmbench 2018-08-24 19:18:56 +00:00
copyright Fix pylint check in presubmit 2018-06-22 14:38:28 +00:00
debugger remove blob iterator::applyFontToPaint 2019-01-04 16:11:27 +00:00
fiddle SkDocument: use auto for MakeDocument(). 2019-01-17 19:16:28 +00:00
flags remove --undefok 2019-01-09 18:15:07 +00:00
fonts tools: Remove sk_tool_utils::set_portable_typeface() 2019-01-09 20:35:01 +00:00
gdb Update gdb bitmap viewer. 2018-06-20 21:24:27 +00:00
gpu Rename GrGlyphCache -> GrStrikeCache 2019-01-16 20:15:04 +00:00
lottiecap [LottieWeb] Fix frames 2018-08-29 17:58:42 +00:00
lua Remove picture_utils 2018-08-09 14:14:17 +00:00
mdbviz
rebaseline
sk_app sed s/drawSimpleText/drawString/ 2019-01-08 19:50:09 +00:00
skdiff Revert "SkStream: remove some WStream functions from public api" 2018-09-06 12:22:41 +00:00
skiaserve Remove SkPM4fPriv.h includes, then IWYU 2018-09-28 15:17:04 +00:00
skp Omit "espn" from key_mobile_sites_smooth in RecreateSKPs bot 2018-05-20 14:53:16 +00:00
skpbench test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
skqp SkQP: branching tools updated. 2019-01-17 15:29:50 +00:00
svg
timer Make SkAnimTimer support speed control 2019-01-10 17:38:31 +00:00
trace Align trace event allocations to avoid alignment issues on 32-bit ARM 2018-10-24 17:52:08 +00:00
viewer Revert "hide hinting and flag enums with PAINT_FLAGS" 2019-01-21 18:51:39 +00:00
__init__.py
add_codereview_message.py
AndroidSkDebugToStdOut.cpp
BigPathBench.inc
bisect_roll
bisect_roll.bat
bisect_roll.go
build_command_buffer.py
BUILD_simulator.py
build_workaround_header.py Add CheckGeneratedFiles recipe check for gpu workarounds 2018-04-25 19:26:27 +00:00
check-headers-self-sufficient Restore ETC1 compressed texture support. 2019-01-15 19:56:28 +00:00
chrome_fuzz.cpp
clang-tidy.sh run clang-tidy on headers too 2018-12-12 15:26:22 +00:00
compare_codereview.py
CrashHandler.cpp
CrashHandler.h
DDLPromiseImageHelper.cpp Make SkPromiseImageTexture ref counted. 2019-01-14 16:19:01 +00:00
DDLPromiseImageHelper.h Make SkPromiseImageTexture ref counted. 2019-01-14 16:19:01 +00:00
DDLTileHelper.cpp Connect up YUVA images for testing. 2018-10-12 19:31:08 +00:00
DDLTileHelper.h Revert "Fix bug in GM's DDL drawing mode" 2018-09-26 21:18:28 +00:00
doxygen_footer.txt
dump_record.cpp test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
DumpRecord.cpp Fix occurrences of "-Wextra-semi-stmt" 2018-11-30 23:23:09 +00:00
DumpRecord.h
embed_resources.py [canvaskit] Allow users to load their own fonts 2018-12-12 15:40:08 +00:00
find_run_binary.py
fix_pythonpath.py
gcov_shim
get_current_monitor_profile.cpp
get_images_from_skps.cpp Use SkJSONWriter for get_images_from_skps stats reporting 2018-06-19 20:06:36 +00:00
git-sync-deps tools/git-sync-deps: fix 2018-06-20 14:38:34 +00:00
gyp
hello-opencl.cpp add hello-opencl 2018-06-20 21:50:47 +00:00
imgcvt.cpp Fix bugs and add features to imgcvt 2019-01-04 16:43:07 +00:00
install_dependencies.sh Add header file installation tips for building skia 2018-02-14 13:07:27 +00:00
ios_utils.h
ios_utils.m
jsondiff.py Fix pylint check in presubmit 2018-06-22 14:38:28 +00:00
list_gms.cpp sk_tool::Registry: make an iterator. 2018-08-01 16:59:19 +00:00
list_gpu_unit_tests.cpp sk_tool::Registry: make an iterator. 2018-08-01 16:59:19 +00:00
LsanSuppressions.cpp Add another NVIDIA LSAN suppression. 2018-12-14 19:48:38 +00:00
merge_static_libs.py
milestone.py
mirror-dev.sh
misc_utils.py
OverwriteLine.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
parse_llvm_coverage.py
pathops_sorter.htm fix pathops bug 8380 2018-12-21 19:15:54 +00:00
pathops_visualizer.htm fix pathops bug 8380 2018-12-21 19:15:54 +00:00
ProcStats.cpp eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
ProcStats.h
public_headers_warnings_check.cpp
random_parse_path.cpp
random_parse_path.h
reformat-json.py
Registry.h sk_tool::Registry: make an iterator. 2018-08-01 16:59:19 +00:00
remote_demo.cpp fonts: Reland push font remoting. 2018-05-02 18:39:31 +00:00
ResourceFactory.h SkQP: ResourceFactory 2018-01-29 21:23:33 +00:00
Resources.cpp Remove unused Options parameter from SkImageGenerator::getPixels 2018-10-04 18:22:12 +00:00
Resources.h Change SkTypeface::MakeFromStream to take unique_ptr 2018-09-04 15:24:12 +00:00
retrieve_from_googlesource.py
sanitize_source_files.py
sk_pixel_iter.h handle clipping large triangles 2018-01-30 15:56:35 +00:00
sk_tool_utils.cpp Reland "ccpr: Rework the path cache to support sporadic flushing" 2019-01-07 16:14:31 +00:00
sk_tool_utils.h tools: Remove sk_tool_utils::set_portable_typeface() 2019-01-09 20:35:01 +00:00
skhello.cpp SkDocument: use auto for MakeDocument(). 2019-01-17 19:16:28 +00:00
SkJSONCPP.h
skp_parser.cpp test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
skpinfo.cpp Revert "Revert "SkTypes: extract SkTo"" 2018-06-14 14:55:17 +00:00
Stats.h make float divide-by-zero fatal 2018-11-06 21:56:27 +00:00
test_all.py
test_pdfs.py
UrlDataManager.cpp
UrlDataManager.h
using_skia_and_harfbuzz.cpp Hack up SkShaper to pass additional callback info 2019-01-11 17:04:26 +00:00
valgrind.supp Add valgrind suppression for leak in libGLX_nvidia when caching program binaries 2018-07-18 16:43:51 +00:00
whitelist_typefaces.cpp
win_dbghelp.cpp test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
win_dbghelp.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
win_lcid.cpp
xsan.blacklist turn on alignment sanitizer 2018-08-09 21:13:15 +00:00