c14f144484
Backpedal on node/reval-time-determined damage: nodes cannot control the invalidation order, and shared descendants may be revalidated before a particular ancestor gets to query their state - thus making any decisions based on that invalid. Instead, apply damage suppression at invalidation time, based on node type/traits. Node types which don't generate direct damage are marked as such, and the invalidation logic bubbles damage past them, until it finds a valid damage receiver. Nodes which currently suppress damage: - PaintNode (and subclasses) - GeometryNode (and subclasses) - Matrix TBR= Change-Id: I843e683e64cb6253d8c26d8397c44d02a7d6026f Reviewed-on: https://skia-review.googlesource.com/91421 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
67 lines
1.4 KiB
C++
67 lines
1.4 KiB
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkSGGroup.h"
|
|
|
|
namespace sksg {
|
|
|
|
Group::Group() {}
|
|
|
|
Group::~Group() {
|
|
for (const auto& child : fChildren) {
|
|
child->removeInvalReceiver(this);
|
|
}
|
|
}
|
|
|
|
void Group::addChild(sk_sp<RenderNode> node) {
|
|
// should we allow duplicates?
|
|
for (const auto& child : fChildren) {
|
|
if (child == node) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
node->addInvalReceiver(this);
|
|
fChildren.push_back(std::move(node));
|
|
|
|
this->invalidate();
|
|
}
|
|
|
|
void Group::removeChild(const sk_sp<RenderNode>& node) {
|
|
int origCount = fChildren.count();
|
|
for (int i = 0; i < origCount; ++i) {
|
|
if (fChildren[i] == node) {
|
|
fChildren.removeShuffle(i);
|
|
node->removeInvalReceiver(this);
|
|
break;
|
|
}
|
|
}
|
|
SkASSERT(fChildren.count() == origCount - 1);
|
|
|
|
this->invalidate();
|
|
}
|
|
|
|
void Group::onRender(SkCanvas* canvas) const {
|
|
for (const auto& child : fChildren) {
|
|
child->render(canvas);
|
|
}
|
|
}
|
|
|
|
SkRect Group::onRevalidate(InvalidationController* ic, const SkMatrix& ctm) {
|
|
SkASSERT(this->hasInval());
|
|
|
|
SkRect bounds = SkRect::MakeEmpty();
|
|
|
|
for (const auto& child : fChildren) {
|
|
bounds.join(child->revalidate(ic, ctm));
|
|
}
|
|
|
|
return bounds;
|
|
}
|
|
|
|
} // namespace sksg
|