AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
8355100850
skia2/tools
History
jvanverth 02802f64ea Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/) 
Reason for revert:
Breaking the roll.

E.g. on android_chromium_gn_compile_dbg:

FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/skia/ext/libskia.SkMemory_new_handler.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DDONT_EMBED_BUILD_METADATA -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DSKIA_IMPLEMENTATION=1 -DSK_ARM_HAS_OPTIONAL_NEON -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_DEFAULT_FONT_CACHE_LIMIT=1048576 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DXML_STATIC -I../.. -Igen -I../../third_party/skia/include/private -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/zlib -I../../third_party/expat/files/lib -I../../third_party/freetype-android/include -I../../third_party/freetype-android/src/include -I../../third_party/android_tools/ndk/sources/android/cpufeatures -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Os -fdata-sections -ffunction-sections -fomit-frame-pointer -g1 -Wno-format -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -c ../../skia/ext/SkMemory_new_handler.cpp -o obj/skia/ext/libskia.SkMemory_new_handler.o
../../skia/ext/SkMemory_new_handler.cpp:12:52: fatal error: third_party/skia/include/core/SkThread.h: No such file or directory
 #include "third_party/skia/include/core/SkThread.h"

Original issue's description:
> Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.
>
> SkThread.h doesn't do anything anymore execept include those two,
> and thankfully, it doesn't seem to be mentioned outside Skia.
>
> No public API changes.
> TBR=reed@google.com
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1214603003
2015-07-02 06:42:49 -07:00
..
chromium Cleanup of SSE optimization files. 2014-04-30 14:58:46 +00:00
copyright Script to automatically update copyright notices in C/C++ source code. 2011-07-28 14:29:58 +00:00
flags Remove default for --images in common flags 2015-06-30 09:38:35 -07:00
lua Add wrapper script for computing n-grams from SKPs on Cluster Telemetry 2015-06-30 10:24:03 -07:00
skp Use AddStory instead of deprecated AddUserStory 2015-06-30 09:20:17 -07:00
skpdiff Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/) 2015-07-02 06:42:49 -07:00
timer Have DM and nanobench display times in minutes when they're above 60 seconds. 2015-03-12 10:29:32 -07:00
VisualBench Add benchmarkstream to visualbench 2015-06-30 07:43:14 -07:00
__init__.py Add bench_pictures config 2012-12-12 20:13:26 +00:00
add_codereview_message.py Whitespace fixes for Python tools 2014-06-25 08:40:58 -07:00
AndroidSkDebugToStdOut.cpp Change how SkDebugf is sent to stdout on Android. 2014-12-10 10:23:06 -08:00
bench_pictures_cfg_helper.py Remove SkTileGrid (except for TileGridInfo). 2015-01-09 06:41:48 -08:00
bench_pictures_main.cpp remove SkInstCnt 2015-06-26 11:45:03 -07:00
bench_pictures.cfg Removes Record configs from buildbot bench_pictures runs. 2014-06-18 05:59:55 -07:00
chrome_fuzz.cpp quickie tool to exercise chrome filter fuzz files 2015-05-12 08:36:48 -07:00
compare_codereview.py Further tweak compare_codereview.py. 2014-03-25 18:02:17 +00:00
CopyTilesRenderer.cpp Store context options on caps. 2015-05-22 14:01:46 -07:00
CopyTilesRenderer.h Store context options on caps. 2015-05-22 14:01:46 -07:00
coverage.sh increase coverage of SkPath.cpp, remove unused code 2013-11-14 16:53:22 +00:00
CrashHandler.cpp Remove all code related to NaCl 2015-04-02 12:16:36 -07:00
CrashHandler.h rewrite ambiguous comment 2015-02-10 07:47:31 -08:00
create_test_font.cpp PDF expects fonts to map glyph ID 0 to the missing character. 2015-06-11 09:40:44 -07:00
dm_flags.json Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/) 2015-06-30 14:23:29 -07:00
dm_flags.py Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/) 2015-06-30 14:23:29 -07:00
doxygen_footer.txt Fix update-doxygen, which fails when skia-autogen is reset 2012-09-26 16:09:43 +00:00
dump_record.cpp Make SkStream *not* ref counted. 2015-01-21 12:09:53 -08:00
DumpRecord.cpp option to return drawable from recording 2014-11-24 14:41:51 -08:00
DumpRecord.h Factor out DumpRecord method from dump_record tool for later use 2014-05-15 16:10:37 +00:00
embed_resources.py Add option to embed font data into executable. 2015-03-30 12:53:48 -07:00
filtermain.cpp remove SkInstCnt 2015-06-26 11:45:03 -07:00
find_bad_images_in_skps.py Make image decoding more fault resistant, less verbose. 2013-10-04 12:46:45 +00:00
find_run_binary.py Create a common utility for finding and running binaries in out/ 2014-02-07 18:41:49 +00:00
fix_pythonpath.py Use new common tools in Python scripts 2014-06-25 11:13:27 -04:00
gcov_shim add a way to get code coverage 2013-09-13 19:32:43 +00:00
gen_bench_expectations_from_codereview.py gen_bench_expectations: use subprocess instead of shell_utils due to buildbot-side name collision 2014-07-02 12:52:34 -07:00
generate_fir_coeff.py Fix metrics on Windows. 2013-07-27 20:37:56 +00:00
generate_includes_cpp.py fix for the msvs gyp generator that produces nonposix path separators 2014-11-25 08:25:29 -08:00
git-skia-verify Land http://codereview.appspot.com/6117046/ for Guanqun.Lu@gmail.com 2012-04-24 15:19:23 +00:00
git-sync-deps git-sync-deps: handle recursion and deps_os at the same time 2014-08-26 12:06:47 -07:00
gpuveto.cpp Change SkPicture::draw to playback 2014-09-04 08:42:50 -07:00
image_expectations.cpp Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server. 2014-08-22 04:46:30 -07:00
image_expectations.h Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server. 2014-08-22 04:46:30 -07:00
imgconv.cpp version 0 of imgconv tool 2014-12-17 13:08:17 -08:00
install_dependencies.sh doc: add quickstart to linux and macos 2015-04-28 13:06:54 -07:00
iOSShell.cpp Landing directly for testing the ios buildbot code. 2015-04-21 08:31:59 -07:00
iOSShell.h C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
jsondiff.py tools: Remove reference to svndiff. 2014-10-24 17:21:41 -02:00
LazyDecodeBitmap.cpp change old picture serialization to really handle images 2015-06-22 12:48:26 -07:00
LazyDecodeBitmap.h Add the lazy decoder from PictureFlags to SkImageDecoder 2013-07-16 18:21:46 +00:00
lsan.supp Suppress mystery leak. 2014-09-05 10:36:40 -07:00
merge_static_libs.py Build Skia as a static library 2012-10-10 19:45:51 +00:00
mirror-dev.sh Land Ben's 32-bit symlink script. 2015-02-03 10:43:28 -05:00
misc_utils.py Whitespace fixes for Python tools 2014-06-25 08:40:58 -07:00
nanobench_flags.json nanobench: split CPU and GPU .SKP tile sizes. 2015-06-16 10:41:27 -07:00
nanobench_flags.py nanobench: split CPU and GPU .SKP tile sizes. 2015-06-16 10:41:27 -07:00
OverwriteLine.h ios fixes 2014-07-11 12:14:51 -07:00
pathops_sorter.htm handle large conic strokes better 2015-05-19 11:05:37 -07:00
pathops_visualizer.htm fix builder winding again 2015-05-18 12:56:58 -07:00
picture_utils.cpp "NULL !=" = NULL 2014-09-05 13:34:00 -07:00
picture_utils.h skimage, die die die 2014-12-15 12:47:52 -08:00
PictureBenchmark.cpp Update old tools to allow MultiPictureDraw rendering 2014-10-09 04:59:19 -07:00
PictureBenchmark.h Update old tools to allow MultiPictureDraw rendering 2014-10-09 04:59:19 -07:00
PictureRenderer.cpp Make SkGpuDevice know its alpha type 2015-06-23 14:38:48 -07:00
PictureRenderer.h Convert PictureRenderer to SkPaintFilterCanvas 2015-06-15 11:48:16 -07:00
PictureRenderingFlags.cpp Store context options on caps. 2015-05-22 14:01:46 -07:00
PictureRenderingFlags.h Change the name of SkFlags to SkCommandLineFlags. 2013-03-21 19:43:15 +00:00
PictureResultsWriter.h C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
pinspect.cpp Try out scalar picture sizes 2014-08-29 08:03:56 -07:00
ProcStats.cpp Looks like rssPages * pageSize is overflowing on 32-bit Linux... 2015-04-30 07:35:28 -07:00
ProcStats.h DM+nanobench: print both current and max RSS. 2015-04-30 07:11:22 -07:00
reformat-json.py add reformat-json.py script 2013-07-19 15:45:22 +00:00
render_pdfs_main.cpp C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
render_pictures_main.cpp remove old text contexts and fontcache 2015-04-28 07:04:11 -07:00
Resources.cpp suppress chatty warning about Funkster.ttf not be supported (on mac at least) 2015-06-01 12:51:24 -07:00
Resources.h Move resource fonts to common location. 2015-04-30 17:12:58 -04:00
retrieve_from_googlesource.py Fix submit_try 2014-06-05 07:32:15 -07:00
sanitize_source_files.py Ignore the .git directory in sanitize_source_files, remove .git directory... 2013-09-11 13:01:27 +00:00
sk_tool_utils_flags.h Add standard fonts to all GMs. 2014-07-31 08:58:44 -04:00
sk_tool_utils_font.cpp Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/) 2015-07-02 06:42:49 -07:00
sk_tool_utils.cpp Revert of Revert of make gm background colors 565 compatible (patchset #1 id:1 of https://codereview.chromium.org/1184123002/) 2015-06-15 06:51:08 -07:00
sk_tool_utils.h Revert of Revert of make gm background colors 565 compatible (patchset #1 id:1 of https://codereview.chromium.org/1184123002/) 2015-06-15 06:51:08 -07:00
skdiff_html.cpp fix warnings 2013-01-07 22:26:05 +00:00
skdiff_html.h Add newline at end of tools/skdiff_html.h to happify the housekeeping bot 2012-12-05 20:30:00 +00:00
skdiff_image.cpp "NULL !=" = NULL 2014-09-05 13:34:00 -07:00
skdiff_main.cpp add --listfailingbase option 2015-01-06 07:39:55 -08:00
skdiff_utils.cpp use SkData::NewUninitialized 2014-09-12 12:12:27 -07:00
skdiff_utils.h Sanitizing source files in Skia_Periodic_House_Keeping 2012-12-06 02:01:25 +00:00
skdiff.cpp * Extended skdiff to report alpha channel differences. 2013-01-03 19:23:22 +00:00
skdiff.h Fix usage of SK_BUILD_* defines. 2014-10-06 10:46:51 -07:00
skhello.cpp Propagate SkSurfaceProps to more call sites 2015-06-23 06:26:08 -07:00
skpinfo.cpp Bump min picture version. 2014-12-01 06:56:38 -08:00
skpmaker.cpp Try out scalar picture sizes 2014-08-29 08:03:56 -07:00
Stats.h Add samplingTime mode to nanobench 2015-06-25 19:17:08 -07:00
test_all.py skimage, die die die 2014-12-15 12:47:52 -08:00
test_font_data_chars.cpp Add standard fonts to all GMs. 2014-07-31 08:58:44 -04:00
test_font_data.cpp Add standard fonts to all GMs. 2014-07-31 08:58:44 -04:00
test_font_index.cpp Today's gm include many differences caused by platform font implementations. 2015-06-10 09:31:09 -07:00
test_font_monospace.cpp PDF expects fonts to map glyph ID 0 to the missing character. 2015-06-11 09:40:44 -07:00
test_font_sans_serif.cpp PDF expects fonts to map glyph ID 0 to the missing character. 2015-06-11 09:40:44 -07:00
test_font_serif.cpp PDF expects fonts to map glyph ID 0 to the missing character. 2015-06-11 09:40:44 -07:00
test_gpuveto.py Remove dashing from gpu veto 2014-06-18 07:34:39 -07:00
test_image_decoder.cpp Runtime configuration setting for suppressing JPEG decoder errors. 2013-10-14 20:08:48 +00:00
test_pdfs.py Add an SKP to PDF rendered. test_pdfs.py will be hooked up in buildbot testing later. 2012-10-10 15:20:34 +00:00
tsan.supp Clean up poppler code. 2015-03-11 11:55:14 -07:00
valgrind.supp widen leak supression. looks like start_keepalive is sometimes inlined. 2015-03-16 15:06:00 -07:00
win_dbghelp.cpp More win64 warning fixes. 2015-01-29 07:44:24 -08:00
win_dbghelp.h Collect minidump and print callstack if an app chrashes. 2013-03-08 18:00:16 +00:00
win_lcid.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-04-03 07:01:14 +00:00
xsan_build simplify tools/xsan_build now that make runs ninja 2014-04-24 18:16:13 +00:00