99589af4e3
DM writes out its images in a hierarchy that's a little different than GM, so this can't read GM's output. But it can read its own, written with -w. Example usage: $ out/Release/dm -w /tmp/baseline $ out/Release/dm -r /tmp/baseline -w /tmp/new (and optionally) $ mkdir /tmp/diff; out/Release/skdiff /tmp/baseline /tmp/new /tmp/diff GM's IndividualImageExpectationsSource and Expectations are a little too eager about decoding and hashing the expected images, so I took the opportunity to add DM::Expectations that mostly replaces skiagm::ExpectationsSource and skiagm::Expectations in DM. It mainly exists to move the image decoding and comparison off the main thread, which would otherwise be a major speed bottleneck. I tried to use skiagm code where possible. One notable place where I differed is in this new feature. When -r is a directory of images, DM does no hashing. It considerably faster to read the expected file into an SkBitmap and do a byte-for-byte comparison than to hash the two bitmaps and check those. The example usage above isn't quite working 100% yet. Expectations on some GMs fail, even with no binary change. I haven't pinned down whether this is due to - a bug in DM - flaky GMs - unthreadsafe GMs - flaky image decoding - unthreadsafe image decoding - something else but I intend to. Leon, Derek and I have suspected PNG decoding isn't threadsafe, but are as yet unable to prove it. I also seem to be able to cause malloc to fail on my laptop if I run too many configs at once, though I never seem to be using more than ~1G of RAM. Will track that down too. BUG= R=reed@google.com, bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/108963002 git-svn-id: http://skia.googlecode.com/svn/trunk@12596 2bbb7eff-a529-9590-31e7-b0007b416f81 |
||
|---|---|---|
| .. | ||
| DM.cpp | ||
| DMCpuTask.cpp | ||
| DMCpuTask.h | ||
| DMExpectations.h | ||
| DMExpectationsTask.cpp | ||
| DMExpectationsTask.h | ||
| DMGpuTask.cpp | ||
| DMGpuTask.h | ||
| DMPipeTask.cpp | ||
| DMPipeTask.h | ||
| DMReplayTask.cpp | ||
| DMReplayTask.h | ||
| DMReporter.cpp | ||
| DMReporter.h | ||
| DMSerializeTask.cpp | ||
| DMSerializeTask.h | ||
| DMTask.cpp | ||
| DMTask.h | ||
| DMTaskRunner.cpp | ||
| DMTaskRunner.h | ||
| DMTileGridTask.cpp | ||
| DMTileGridTask.h | ||
| DMUtil.cpp | ||
| DMUtil.h | ||
| DMWriteTask.cpp | ||
| DMWriteTask.h | ||
| README | ||
DM is like GM, but multithreaded. It doesn't do everything GM does yet.
Current approximate list of missing features:
--config pdf
--mismatchPath
--missingExpectationsPath
--writePicturePath
--deferred
DM's design is based around Tasks and a TaskRunner.
A Task represents an independent unit of work that might fail. We make a task
for each GM/configuration pair we want to run. Tasks can kick off new tasks
themselves. For example, a CpuTask can kick off a ReplayTask to make sure
recording and playing back an SkPicture gives the same result as direct
rendering.
The TaskRunner runs all tasks on one of two threadpools, whose sizes are
configurable by --cpuThreads and --gpuThreads. Ideally we'd run these on a
single threadpool but it can swamp the GPU if we shove too much work into it at
once. --cpuThreads defaults to the number of cores on the machine.
--gpuThreads defaults to 1, but you may find 2 or 4 runs a little faster.
So the main flow of DM is:
for each GM:
for each configuration:
kick off a new task
< tasks run, maybe fail, and maybe kick off new tasks >
wait for all tasks to finish
report failures