AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
91fcb3ed58
skia2/src/utils
History
reed 1610835624 Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) 
Reason for revert:
need to update unittest in blink:

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=261368-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DENABLE_OILPAN=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DV8_SHARED -DUSING_V8_SHARED -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../../third_party/WebKit/public/web -I../../third_party/WebKit/Source/web -I../../third_party/WebKit/Source/web/src -I../../third_party/WebKit/public/web/mac -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/libwebp -I../../third_party/zlib -I../../v8/include -Igen/blink -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O0 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -fstack-protector-all  -c ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp -o obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o
../../third_party/WebKit/Source/core/page/PrintContextTest.cpp:54:20: error: no member named 'getAnnotation' in 'SkPaint'
        if (!paint.getAnnotation())
             ~~~~~ ^

Original issue's description:
> move annotations to canvas virtual
>
> In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002
>
> Committed: https://skia.googlesource.com/skia/+/0eda2587cc9233066cb3f3fec08f35c061780f8e

TBR=halcanary@google.com,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1761793003
2016-03-03 09:14:36 -08:00
..
mac Start making all .cpp files compile-able on all platforms. 2015-11-02 10:20:27 -08:00
win Assert when running SampleApp with msaa 16 on Windows 10 2015-11-05 07:48:12 -08:00
SkBase64.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkBase64.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkBitmapSourceDeserializer.cpp Remove SkBitmapSource 2015-09-25 09:15:55 -07:00
SkBitmapSourceDeserializer.h Remove SkBitmapSource 2015-09-25 09:15:55 -07:00
SkBitSet.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkBitSet.h
SkBoundaryPatch.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkCamera.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkCanvasStack.cpp
SkCanvasStack.h C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
SkCanvasStateUtils.cpp Hide SkCanvas::{set,get}DrawFilter 2016-01-21 18:47:11 -08:00
SkDashPath.cpp resolution dependent path measure 2016-01-21 07:07:02 -08:00
SkDashPathPriv.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkDumpCanvas.cpp Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) 2016-03-03 09:14:36 -08:00
SkEventTracer.cpp Have /src files use header directly. 2015-09-29 09:37:59 -07:00
SkFloatUtils.h
SkFrontBufferedStream.cpp Remove position from FrontBufferedStream 2016-02-18 05:59:25 -08:00
SkImageGeneratorUtils.cpp Move Budgeted enum out of SkSurface, use in GrTextureProvider 2016-02-25 08:33:02 -08:00
SkImageGeneratorUtils.h add gm for image->newShader 2015-08-20 12:30:20 -07:00
SkInterpolator.cpp remove cruft from SkTypes.h, including SkBool 2015-12-27 12:47:25 -08:00
SkLayer.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkLua.cpp Fix for rounded-rect clips with filters. 2016-02-02 18:44:16 -08:00
SkLuaCanvas.cpp change signature for virtual related to saveLayer, passing SaveLayerRec 2015-12-18 07:09:18 -08:00
SkMatrix22.cpp
SkMatrix22.h
SkMatrix44.cpp Fix infinite matrix during an invert. 2015-06-30 13:36:04 -07:00
SkMD5.cpp
SkMD5.h SkCodec: add wbmp class 2015-03-27 12:16:53 -07:00
SkMeshUtils.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkNinePatch.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkNullCanvas.cpp Style Change: SkNEW->new; SkDELETE->delete 2015-08-26 13:07:49 -07:00
SkNWayCanvas.cpp Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) 2016-03-03 09:14:36 -08:00
SkOSFile.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkPaintFilterCanvas.cpp SkTCopyOnFirstWrite-based SkPaintFilterCanvas API 2016-01-12 07:21:11 -08:00
SkParse.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkParseColor.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkParsePath.cpp Add unit test to feed valid SVG sequences to make sure that 2016-02-09 10:30:22 -08:00
SkPatchGrid.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkPatchGrid.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkPatchUtils.cpp move more geometry to simd 2016-01-26 17:02:30 -08:00
SkPatchUtils.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkRGBAToYUV.cpp Add ability to extract YUV planes from SkImage 2016-02-01 13:16:14 -08:00
SkRGBAToYUV.h Add ability to extract YUV planes from SkImage 2016-02-01 13:16:14 -08:00
SkRTConf.cpp Eliminate SkFILE: it always is the same as FILE. 2015-11-20 13:47:49 -08:00
SkTextBox.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTextureCompressor_ASTC.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTextureCompressor_ASTC.h Even more win64 warning fixes 2014-12-12 15:11:18 -08:00
SkTextureCompressor_Blitter.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTextureCompressor_LATC.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTextureCompressor_LATC.h Even more win64 warning fixes 2014-12-12 15:11:18 -08:00
SkTextureCompressor_R11EAC.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTextureCompressor_R11EAC.h Even more win64 warning fixes 2014-12-12 15:11:18 -08:00
SkTextureCompressor_Utils.h Add utils to better quantize grayscale values to three bit indices while 2014-10-23 13:18:50 -07:00
SkTextureCompressor.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTextureCompressor.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkTFitsIn.h Start using <type_traits> and <utility> (C++11). 2016-01-05 14:59:40 -08:00
SkThreadUtils_pthread.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SkThreadUtils_pthread.h
SkThreadUtils_win.cpp Start making all .cpp files compile-able on all platforms. 2015-11-02 10:20:27 -08:00
SkThreadUtils_win.h
SkThreadUtils.h Remove SkThread::setProcessorAffinity() 2015-10-20 11:05:06 -07:00
SkWhitelistChecksums.cpp Update SkWhitelistChecksums.cpp with the checksums of the fonts on the CT slave machines. 2015-09-14 12:50:22 -07:00
SkWhitelistTypefaces.cpp Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks 2016-02-25 10:58:49 -08:00