6e3ce40bd9
This demonstrates a new kind of hybrid unit test/GM. It creates a grid of cells. In each cell, we do two renders that are expected to produce the same result. For each cell, we render the two results overlaid, and highlight any differing pixels in red. Assuming there is a diff, the area around the largest diff is drawn zoomed in from both images. Matching cells are outlined in green, failing cells are outlined in red. Triaging this GM just involves answering the question: "Are there any red boxes?" "Good" example: https://screenshot.googleplex.com/909P3tvS55f.png "Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png To get more tests to pass, (and fix an assert in Ganesh), I've gone ahead and enforced that user supplied rects (in drawRect and drawOval) are always sorted once they hit the canvas virtuals. Currently, drawArc rejects empty ovals, but I added the same assert to onDrawArc, if we decide to change the strategy there. Re-land of: https://skia-review.googlesource.com/c/16983/ Bug: skia: Change-Id: I48f85de5f2bcb7fdc9558c2fd80cb1f20800b244 Reviewed-on: https://skia-review.googlesource.com/17270 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com> |
||
---|---|---|
.. | ||
__init__.py | ||
android_framework_defines.gni | ||
ar.py | ||
bench.gni | ||
BUILD.gn | ||
BUILDCONFIG.gn | ||
core.gni | ||
cp.py | ||
effects.gni | ||
find_headers.py | ||
find_ios_sysroot.py | ||
gm.gni | ||
gn_helpers.py | ||
gn_meta_sln.py | ||
gn_to_bp.py | ||
gn_to_cmake.py | ||
gpu.gni | ||
gypi_to_gn.py | ||
is_clang.py | ||
opts.gni | ||
package_ios.py | ||
pdf.gni | ||
push_to_android.py | ||
samples.gni | ||
shared_sources.gni | ||
sksl.gni | ||
tests.gni | ||
utils.gni | ||
xps.gni |