353e2c65c9
OpenGL docs specifically insist that the sequence (comma) operator should not be treated as a constant-expression so that attempts to declare multidimensional arrays with a comma will fail: http://screen/vJEpAe9yNmbzZTm (See "12.43 Sequence operator and constant expressions" in the OpenGL ES3 documentation or read skia:13311 for details.) In practice, we don't get much benefit from optimizing away unused comma-expressions; it improves some synthetic tests, but realistically this will not help Skia in any real-world scenario. The constant folder no longer attempts this optimization, and comma-expressions are now rejected in a constant-expression context. Change-Id: Ic5dea6ff90e36614b548c1ce89a444e81da944ae Bug: skia:13311 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539565 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
22 lines
527 B
Metal
22 lines
527 B
Metal
#include <metal_stdlib>
|
|
#include <simd/simd.h>
|
|
using namespace metal;
|
|
struct Uniforms {
|
|
half4 colorGreen;
|
|
};
|
|
struct Inputs {
|
|
};
|
|
struct Outputs {
|
|
half4 sk_FragColor [[color(0)]];
|
|
};
|
|
fragment Outputs fragmentMain(Inputs _in [[stage_in]], constant Uniforms& _uniforms [[buffer(0)]], bool _frontFacing [[front_facing]], float4 _fragCoord [[position]]) {
|
|
Outputs _out;
|
|
(void)_out;
|
|
array<int, 1> x;
|
|
int y = 0;
|
|
int z = 0;
|
|
(0, x[y = z]);
|
|
_out.sk_FragColor = _uniforms.colorGreen;
|
|
return _out;
|
|
}
|