Go to file
Greg Daniel 9838b49b2e Revert "Revert "long rect dash fix with guards""
This reverts commit fa6b6c2d1b.

Reason for revert: Looks like this was actually caused by another change but happen to fail a test that looked very related to this

Original change's description:
> Revert "long rect dash fix with guards"
> 
> This reverts commit 93ceab1b59.
> 
> Reason for revert: breaking layout test
> 
> Original change's description:
> > long rect dash fix with guards
> > 
> > long rect dash with guards
> > 
> > check dash fix back in with
> > guards against changing
> > chrome layout test results
> > 
> > original change clipped against wrong rectangle
> > some of the time, causing tiled drawing to fail.
> > Always clip against outset rectangle.
> > 
> > original CL: skia-review.googlesource.com/c/skia/+/84862
> > 
> > efficiently dash very large rectangles and very long lines
> > Speed up dashing when lines and rects are absurdly large.
> > 
> > Prior to this CL, only horizontal lines were detected.
> > 
> > Also folded in a change to handle dashing of zero length lines.
> > 
> > TBR=egdaniel@google.com
> > Bug: skia:7311
> > Change-Id: Ic3c68ec8ea35d0597c892c3b26ba7bb077045990
> > Reviewed-on: https://skia-review.googlesource.com/87768
> > Reviewed-by: Cary Clark <caryclark@skia.org>
> > Commit-Queue: Cary Clark <caryclark@skia.org>
> 
> TBR=egdaniel@google.com,caryclark@skia.org
> 
> Change-Id: I56ef771ccb281887d7381c2bd8a2553acbd30621
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:7311
> Reviewed-on: https://skia-review.googlesource.com/88421
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,caryclark@skia.org

Change-Id: Iecdd072544e6623bc4de8d5aab1402378112512d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7311
Reviewed-on: https://skia-review.googlesource.com/88424
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-12-21 14:55:11 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench add serialprocs to MultiDocument, hide redundant methods 2017-12-21 12:36:30 +00:00
bin bin/try: No prompt for a single matching job 2017-12-11 18:32:08 +00:00
debugger Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
dm make InternalOnly_ functions actually private 2017-12-20 19:32:36 +00:00
docs working on image docs 2017-12-15 16:47:08 +00:00
example Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
experimental Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
fuzz fuzz/FuzzCanvas: range in inclucive, not half-open 2017-12-20 16:41:04 +00:00
gm Revert "Revert "long rect dash fix with guards"" 2017-12-21 14:55:11 +00:00
gn Revert "CCPR: Initial semi-optimized vertex shader Impl" 2017-12-20 22:15:48 +00:00
include add serialprocs to MultiDocument, hide redundant methods 2017-12-21 12:36:30 +00:00
infra Switch CQ from IntelIris540 to 640 for Ubuntu bot. 2017-12-20 21:25:36 +00:00
platform_tools SkQP: better error report workflow 2017-12-20 19:23:46 +00:00
resources Fix Adobe RGB color space in Skia 2017-12-20 14:09:34 +00:00
samplecode Revert "CCPR: Initial semi-optimized vertex shader Impl" 2017-12-20 22:15:48 +00:00
site working on image docs 2017-12-15 16:47:08 +00:00
src Revert "Revert "long rect dash fix with guards"" 2017-12-21 14:55:11 +00:00
tests add serialprocs to MultiDocument, hide redundant methods 2017-12-21 12:36:30 +00:00
third_party Update Windows clang asset 2017-12-08 16:55:10 +00:00
tools add serialprocs to MultiDocument, hide redundant methods 2017-12-21 12:36:30 +00:00
.clang-format Mark flatennable macros as block beginning/ending in .clang-format 2017-01-09 15:31:36 +00:00
.gitignore Ignore generated README.recipes.md 2017-10-26 18:07:27 +00:00
.gn Basic standalone GN configs. 2016-07-21 12:25:45 -07:00
AUTHORS fix use of uninitialized flag in SkCodec 2017-10-09 19:17:05 +00:00
BUILD.gn Move stats code to new layer (with configurable list of timers) 2017-12-20 16:59:04 +00:00
codereview.settings Make uploading to Gerrit the default for Skia 2016-11-09 19:07:56 +00:00
CONTRIBUTING Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
CQ_COMMITTERS Moved committer list to chrome-infra-auth and deleted it from the repo 2015-09-02 13:37:54 -07:00
DEPS Roll skia/third_party/externals/angle2/ c6faa9745..62fcf62ae (1 commit) 2017-12-21 06:44:29 +00:00
Doxyfile Make the housekeeper upload doxygen to a newer bucket 2016-10-04 13:23:57 -07:00
LICENSE BUG=skia:5602 2016-09-02 11:19:34 -07:00
OWNERS add OWNERS file 2017-12-01 19:50:19 +00:00
PRESUBMIT.py PostUploadHook needs to return something 2017-12-07 18:40:09 +00:00
public.bzl add flag to fix google3 2017-12-21 14:37:36 +00:00
README Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
README.chromium Update README.chromium. 2015-06-11 13:19:24 -07:00
whitespace.txt Removed general bot upload permissions, whitespace change to test 2017-12-04 13:03:34 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.