6ef29333cb
The alpha versions are impossible to triage (the bleed is barely perceptible). Image and bitmap no longer go through separate code paths in SkGpuDevice so we don't need bitmap variants. Alpha image/ shader interaction is orthogonal to the rest of what's being tested here and makes triaging even harder. Change-Id: I85dffa01de0f4f06cb9cbe04fb1d039a8b61416a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290118 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
384 lines
17 KiB
C++
384 lines
17 KiB
C++
/*
|
|
* Copyright 2013 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "gm/gm.h"
|
|
#include "include/core/SkBitmap.h"
|
|
#include "include/core/SkBlurTypes.h"
|
|
#include "include/core/SkCanvas.h"
|
|
#include "include/core/SkColor.h"
|
|
#include "include/core/SkFilterQuality.h"
|
|
#include "include/core/SkImage.h"
|
|
#include "include/core/SkImageInfo.h"
|
|
#include "include/core/SkMaskFilter.h"
|
|
#include "include/core/SkMatrix.h"
|
|
#include "include/core/SkPaint.h"
|
|
#include "include/core/SkPoint.h"
|
|
#include "include/core/SkRect.h"
|
|
#include "include/core/SkRefCnt.h"
|
|
#include "include/core/SkScalar.h"
|
|
#include "include/core/SkShader.h"
|
|
#include "include/core/SkSize.h"
|
|
#include "include/core/SkString.h"
|
|
#include "include/core/SkSurface.h"
|
|
#include "include/core/SkTileMode.h"
|
|
#include "include/core/SkTypes.h"
|
|
#include "include/gpu/GrContextOptions.h"
|
|
#include "include/private/SkTDArray.h"
|
|
#include "src/core/SkBlurMask.h"
|
|
#include "tools/ToolUtils.h"
|
|
|
|
/** Creates an image with two one-pixel wide borders around a checkerboard. The checkerboard is 2x2
|
|
checks where each check has as many pixels as is necessary to fill the interior. It returns
|
|
the image and a src rect that bounds the checkerboard portion. */
|
|
std::tuple<sk_sp<SkImage>, SkIRect> make_ringed_image(int width, int height) {
|
|
|
|
// These are kRGBA_8888_SkColorType values.
|
|
static constexpr uint32_t kOuterRingColor = 0xFFFF0000,
|
|
kInnerRingColor = 0xFF0000FF,
|
|
kCheckColor1 = 0xFF000000,
|
|
kCheckColor2 = 0xFFFFFFFF;
|
|
|
|
SkASSERT(0 == width % 2 && 0 == height % 2);
|
|
SkASSERT(width >= 6 && height >= 6);
|
|
|
|
SkImageInfo info = SkImageInfo::Make(width, height, kRGBA_8888_SkColorType,
|
|
kPremul_SkAlphaType);
|
|
size_t rowBytes = SkAlign4(info.minRowBytes());
|
|
SkBitmap bitmap;
|
|
bitmap.allocPixels(info, rowBytes);
|
|
|
|
uint32_t* scanline = bitmap.getAddr32(0, 0);
|
|
for (int x = 0; x < width; ++x) {
|
|
scanline[x] = kOuterRingColor;
|
|
}
|
|
scanline = bitmap.getAddr32(0, 1);
|
|
scanline[0] = kOuterRingColor;
|
|
for (int x = 1; x < width - 1; ++x) {
|
|
scanline[x] = kInnerRingColor;
|
|
}
|
|
scanline[width - 1] = kOuterRingColor;
|
|
|
|
for (int y = 2; y < height / 2; ++y) {
|
|
scanline = bitmap.getAddr32(0, y);
|
|
scanline[0] = kOuterRingColor;
|
|
scanline[1] = kInnerRingColor;
|
|
for (int x = 2; x < width / 2; ++x) {
|
|
scanline[x] = kCheckColor1;
|
|
}
|
|
for (int x = width / 2; x < width - 2; ++x) {
|
|
scanline[x] = kCheckColor2;
|
|
}
|
|
scanline[width - 2] = kInnerRingColor;
|
|
scanline[width - 1] = kOuterRingColor;
|
|
}
|
|
|
|
for (int y = height / 2; y < height - 2; ++y) {
|
|
scanline = bitmap.getAddr32(0, y);
|
|
scanline[0] = kOuterRingColor;
|
|
scanline[1] = kInnerRingColor;
|
|
for (int x = 2; x < width / 2; ++x) {
|
|
scanline[x] = kCheckColor2;
|
|
}
|
|
for (int x = width / 2; x < width - 2; ++x) {
|
|
scanline[x] = kCheckColor1;
|
|
}
|
|
scanline[width - 2] = kInnerRingColor;
|
|
scanline[width - 1] = kOuterRingColor;
|
|
}
|
|
|
|
scanline = bitmap.getAddr32(0, height - 2);
|
|
scanline[0] = kOuterRingColor;
|
|
for (int x = 1; x < width - 1; ++x) {
|
|
scanline[x] = kInnerRingColor;
|
|
}
|
|
scanline[width - 1] = kOuterRingColor;
|
|
|
|
scanline = bitmap.getAddr32(0, height - 1);
|
|
for (int x = 0; x < width; ++x) {
|
|
scanline[x] = kOuterRingColor;
|
|
}
|
|
bitmap.setImmutable();
|
|
return {SkImage::MakeFromBitmap(bitmap), {2, 2, width - 2, height - 2}};
|
|
}
|
|
|
|
/**
|
|
* This GM exercises the behavior of the drawImageRect and its SrcRectConstraint parameter. It
|
|
* tests various matrices, filter qualities, and interaction with mask filters. It also exercises
|
|
* the tiling image draws of SkGpuDevice by overriding the maximum texture size of the GrContext.
|
|
*/
|
|
class BleedGM : public skiagm::GM {
|
|
public:
|
|
BleedGM() = default;
|
|
|
|
protected:
|
|
|
|
SkString onShortName() override { return SkString("bleed"); }
|
|
|
|
SkISize onISize() override { return SkISize::Make(1200, 1080); }
|
|
|
|
// Draw the area of interest of the small image
|
|
void drawCase1(SkCanvas* canvas, int transX, int transY, bool aa,
|
|
SkCanvas::SrcRectConstraint constraint, SkFilterQuality filter) {
|
|
|
|
SkRect dst = SkRect::MakeXYWH(SkIntToScalar(transX), SkIntToScalar(transY),
|
|
SkIntToScalar(kBlockSize), SkIntToScalar(kBlockSize));
|
|
|
|
SkPaint paint;
|
|
paint.setFilterQuality(filter);
|
|
paint.setColor(SK_ColorBLUE);
|
|
paint.setAntiAlias(aa);
|
|
|
|
canvas->drawImageRect(fSmallImage.get(), fSmallSrcRect, dst, &paint, constraint);
|
|
}
|
|
|
|
// Draw the area of interest of the large image
|
|
void drawCase2(SkCanvas* canvas, int transX, int transY, bool aa,
|
|
SkCanvas::SrcRectConstraint constraint, SkFilterQuality filter) {
|
|
SkRect dst = SkRect::MakeXYWH(SkIntToScalar(transX), SkIntToScalar(transY),
|
|
SkIntToScalar(kBlockSize), SkIntToScalar(kBlockSize));
|
|
|
|
SkPaint paint;
|
|
paint.setFilterQuality(filter);
|
|
paint.setColor(SK_ColorBLUE);
|
|
paint.setAntiAlias(aa);
|
|
|
|
canvas->drawImageRect(fBigImage.get(), fBigSrcRect, dst, &paint, constraint);
|
|
}
|
|
|
|
// Draw upper-left 1/4 of the area of interest of the large image
|
|
void drawCase3(SkCanvas* canvas, int transX, int transY, bool aa,
|
|
SkCanvas::SrcRectConstraint constraint, SkFilterQuality filter) {
|
|
SkIRect src = SkIRect::MakeXYWH(fBigSrcRect.fLeft,
|
|
fBigSrcRect.fTop,
|
|
fBigSrcRect.width()/2,
|
|
fBigSrcRect.height()/2);
|
|
SkRect dst = SkRect::MakeXYWH(SkIntToScalar(transX), SkIntToScalar(transY),
|
|
SkIntToScalar(kBlockSize), SkIntToScalar(kBlockSize));
|
|
|
|
SkPaint paint;
|
|
paint.setFilterQuality(filter);
|
|
paint.setColor(SK_ColorBLUE);
|
|
paint.setAntiAlias(aa);
|
|
|
|
canvas->drawImageRect(fBigImage.get(), src, dst, &paint, constraint);
|
|
}
|
|
|
|
// Draw the area of interest of the small image with a normal blur
|
|
void drawCase4(SkCanvas* canvas, int transX, int transY, bool aa,
|
|
SkCanvas::SrcRectConstraint constraint, SkFilterQuality filter) {
|
|
SkRect dst = SkRect::MakeXYWH(SkIntToScalar(transX), SkIntToScalar(transY),
|
|
SkIntToScalar(kBlockSize), SkIntToScalar(kBlockSize));
|
|
|
|
SkPaint paint;
|
|
paint.setFilterQuality(filter);
|
|
paint.setMaskFilter(SkMaskFilter::MakeBlur(kNormal_SkBlurStyle,
|
|
SkBlurMask::ConvertRadiusToSigma(3)));
|
|
paint.setColor(SK_ColorBLUE);
|
|
paint.setAntiAlias(aa);
|
|
|
|
canvas->drawImageRect(fSmallImage.get(), fSmallSrcRect, dst, &paint, constraint);
|
|
}
|
|
|
|
// Draw the area of interest of the small image with a outer blur
|
|
void drawCase5(SkCanvas* canvas, int transX, int transY, bool aa,
|
|
SkCanvas::SrcRectConstraint constraint, SkFilterQuality filter) {
|
|
SkRect dst = SkRect::MakeXYWH(SkIntToScalar(transX), SkIntToScalar(transY),
|
|
SkIntToScalar(kBlockSize), SkIntToScalar(kBlockSize));
|
|
|
|
SkPaint paint;
|
|
paint.setFilterQuality(filter);
|
|
paint.setMaskFilter(SkMaskFilter::MakeBlur(kOuter_SkBlurStyle,
|
|
SkBlurMask::ConvertRadiusToSigma(7)));
|
|
paint.setColor(SK_ColorBLUE);
|
|
paint.setAntiAlias(aa);
|
|
|
|
canvas->drawImageRect(fSmallImage.get(), fSmallSrcRect, dst, &paint, constraint);
|
|
}
|
|
|
|
void onOnceBeforeDraw() override {
|
|
std::tie(fBigImage, fBigSrcRect) = make_ringed_image(2*kMaxTileSize, 2*kMaxTileSize);
|
|
std::tie(fSmallImage, fSmallSrcRect) = make_ringed_image(kSmallSize, kSmallSize);
|
|
}
|
|
|
|
void onDraw(SkCanvas* canvas) override {
|
|
canvas->clear(SK_ColorGRAY);
|
|
SkTDArray<SkMatrix> matrices;
|
|
// Draw with identity
|
|
*matrices.append() = SkMatrix::I();
|
|
|
|
// Draw with rotation and scale down in x, up in y.
|
|
SkMatrix m;
|
|
constexpr SkScalar kBottom = SkIntToScalar(kRow4Y + kBlockSize + kBlockSpacing);
|
|
m.setTranslate(0, kBottom);
|
|
m.preRotate(15.f, 0, kBottom + kBlockSpacing);
|
|
m.preScale(0.71f, 1.22f);
|
|
*matrices.append() = m;
|
|
|
|
// Align the next set with the middle of the previous in y, translated to the right in x.
|
|
SkPoint corners[] = {{0, 0}, { 0, kBottom }, { kWidth, kBottom }, {kWidth, 0} };
|
|
matrices[matrices.count()-1].mapPoints(corners, 4);
|
|
SkScalar y = (corners[0].fY + corners[1].fY + corners[2].fY + corners[3].fY) / 4;
|
|
SkScalar x = std::max(std::max(corners[0].fX, corners[1].fX),
|
|
std::max(corners[2].fX, corners[3].fX));
|
|
m.setTranslate(x, y);
|
|
m.preScale(0.2f, 0.2f);
|
|
*matrices.append() = m;
|
|
|
|
SkScalar maxX = 0;
|
|
for (int antiAlias = 0; antiAlias < 2; ++antiAlias) {
|
|
canvas->save();
|
|
canvas->translate(maxX, 0);
|
|
for (int m = 0; m < matrices.count(); ++m) {
|
|
canvas->save();
|
|
canvas->concat(matrices[m]);
|
|
bool aa = SkToBool(antiAlias);
|
|
|
|
// First draw a column with no bleeding and no filtering
|
|
this->drawCase1(canvas, kCol0X, kRow0Y, aa, SkCanvas::kStrict_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase2(canvas, kCol0X, kRow1Y, aa, SkCanvas::kStrict_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase3(canvas, kCol0X, kRow2Y, aa, SkCanvas::kStrict_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase4(canvas, kCol0X, kRow3Y, aa, SkCanvas::kStrict_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase5(canvas, kCol0X, kRow4Y, aa, SkCanvas::kStrict_SrcRectConstraint, kNone_SkFilterQuality);
|
|
|
|
// Then draw a column with no bleeding and low filtering
|
|
this->drawCase1(canvas, kCol1X, kRow0Y, aa, SkCanvas::kStrict_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase2(canvas, kCol1X, kRow1Y, aa, SkCanvas::kStrict_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase3(canvas, kCol1X, kRow2Y, aa, SkCanvas::kStrict_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase4(canvas, kCol1X, kRow3Y, aa, SkCanvas::kStrict_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase5(canvas, kCol1X, kRow4Y, aa, SkCanvas::kStrict_SrcRectConstraint, kLow_SkFilterQuality);
|
|
|
|
// Then draw a column with no bleeding and high filtering
|
|
this->drawCase1(canvas, kCol2X, kRow0Y, aa, SkCanvas::kStrict_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase2(canvas, kCol2X, kRow1Y, aa, SkCanvas::kStrict_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase3(canvas, kCol2X, kRow2Y, aa, SkCanvas::kStrict_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase4(canvas, kCol2X, kRow3Y, aa, SkCanvas::kStrict_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase5(canvas, kCol2X, kRow4Y, aa, SkCanvas::kStrict_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
|
|
// Then draw a column with bleeding and no filtering (bleed should have no effect w/out blur)
|
|
this->drawCase1(canvas, kCol3X, kRow0Y, aa, SkCanvas::kFast_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase2(canvas, kCol3X, kRow1Y, aa, SkCanvas::kFast_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase3(canvas, kCol3X, kRow2Y, aa, SkCanvas::kFast_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase4(canvas, kCol3X, kRow3Y, aa, SkCanvas::kFast_SrcRectConstraint, kNone_SkFilterQuality);
|
|
this->drawCase5(canvas, kCol3X, kRow4Y, aa, SkCanvas::kFast_SrcRectConstraint, kNone_SkFilterQuality);
|
|
|
|
// Then draw a column with bleeding and low filtering
|
|
this->drawCase1(canvas, kCol4X, kRow0Y, aa, SkCanvas::kFast_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase2(canvas, kCol4X, kRow1Y, aa, SkCanvas::kFast_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase3(canvas, kCol4X, kRow2Y, aa, SkCanvas::kFast_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase4(canvas, kCol4X, kRow3Y, aa, SkCanvas::kFast_SrcRectConstraint, kLow_SkFilterQuality);
|
|
this->drawCase5(canvas, kCol4X, kRow4Y, aa, SkCanvas::kFast_SrcRectConstraint, kLow_SkFilterQuality);
|
|
|
|
// Finally draw a column with bleeding and high filtering
|
|
this->drawCase1(canvas, kCol5X, kRow0Y, aa, SkCanvas::kFast_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase2(canvas, kCol5X, kRow1Y, aa, SkCanvas::kFast_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase3(canvas, kCol5X, kRow2Y, aa, SkCanvas::kFast_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase4(canvas, kCol5X, kRow3Y, aa, SkCanvas::kFast_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
this->drawCase5(canvas, kCol5X, kRow4Y, aa, SkCanvas::kFast_SrcRectConstraint, kHigh_SkFilterQuality);
|
|
|
|
SkPoint corners[] = { { 0, 0 },{ 0, kBottom },{ kWidth, kBottom },{ kWidth, 0 } };
|
|
matrices[m].mapPoints(corners, 4);
|
|
SkScalar x = kBlockSize + std::max(std::max(corners[0].fX, corners[1].fX),
|
|
std::max(corners[2].fX, corners[3].fX));
|
|
maxX = std::max(maxX, x);
|
|
canvas->restore();
|
|
}
|
|
canvas->restore();
|
|
}
|
|
}
|
|
|
|
void modifyGrContextOptions(GrContextOptions* options) override {
|
|
options->fMaxTileSizeOverride = kMaxTileSize;
|
|
}
|
|
|
|
private:
|
|
static constexpr int kBlockSize = 70;
|
|
static constexpr int kBlockSpacing = 12;
|
|
|
|
static constexpr int kCol0X = kBlockSpacing;
|
|
static constexpr int kCol1X = 2*kBlockSpacing + kBlockSize;
|
|
static constexpr int kCol2X = 3*kBlockSpacing + 2*kBlockSize;
|
|
static constexpr int kCol3X = 4*kBlockSpacing + 3*kBlockSize;
|
|
static constexpr int kCol4X = 5*kBlockSpacing + 4*kBlockSize;
|
|
static constexpr int kCol5X = 6*kBlockSpacing + 5*kBlockSize;
|
|
static constexpr int kWidth = 7*kBlockSpacing + 6*kBlockSize;
|
|
|
|
static constexpr int kRow0Y = kBlockSpacing;
|
|
static constexpr int kRow1Y = 2*kBlockSpacing + kBlockSize;
|
|
static constexpr int kRow2Y = 3*kBlockSpacing + 2*kBlockSize;
|
|
static constexpr int kRow3Y = 4*kBlockSpacing + 3*kBlockSize;
|
|
static constexpr int kRow4Y = 5*kBlockSpacing + 4*kBlockSize;
|
|
|
|
static constexpr int kSmallSize = 6;
|
|
static constexpr int kMaxTileSize = 32;
|
|
|
|
sk_sp<SkImage> fBigImage;
|
|
sk_sp<SkImage> fSmallImage;
|
|
SkIRect fBigSrcRect;
|
|
SkIRect fSmallSrcRect;
|
|
typedef GM INHERITED;
|
|
};
|
|
|
|
DEF_GM(return new BleedGM(););
|
|
|
|
///////////////////////////////////////////////////////////////////////////////////////////////////
|
|
|
|
// Construct an image and return the inner "src" rect. Build the image such that the interior is
|
|
// blue, with a margin of blue (2px) but then an outer margin of red.
|
|
//
|
|
// Show that kFast_SrcRectConstraint sees even the red margin (due to mipmapping) when the image
|
|
// is scaled down far enough.
|
|
//
|
|
static sk_sp<SkImage> make_image(SkCanvas* canvas, SkRect* srcR) {
|
|
// Intentially making the size a power of 2 to avoid the noise from how different GPUs will
|
|
// produce different mipmap filtering when we have an odd sized texture.
|
|
const int N = 10 + 2 + 8 + 2 + 10;
|
|
SkImageInfo info = SkImageInfo::MakeN32Premul(N, N);
|
|
auto surface = ToolUtils::makeSurface(canvas, info);
|
|
SkCanvas* c = surface->getCanvas();
|
|
SkRect r = SkRect::MakeIWH(info.width(), info.height());
|
|
SkPaint paint;
|
|
|
|
paint.setColor(SK_ColorRED);
|
|
c->drawRect(r, paint);
|
|
r.inset(10, 10);
|
|
paint.setColor(SK_ColorBLUE);
|
|
c->drawRect(r, paint);
|
|
|
|
*srcR = r.makeInset(2, 2);
|
|
return surface->makeImageSnapshot();
|
|
}
|
|
|
|
DEF_SIMPLE_GM(bleed_downscale, canvas, 360, 240) {
|
|
SkRect src;
|
|
sk_sp<SkImage> img = make_image(canvas, &src);
|
|
SkPaint paint;
|
|
|
|
canvas->translate(10, 10);
|
|
|
|
const SkCanvas::SrcRectConstraint constraints[] = {
|
|
SkCanvas::kStrict_SrcRectConstraint, SkCanvas::kFast_SrcRectConstraint
|
|
};
|
|
const SkFilterQuality qualities[] = {
|
|
kNone_SkFilterQuality, kLow_SkFilterQuality, kMedium_SkFilterQuality
|
|
};
|
|
for (auto constraint : constraints) {
|
|
canvas->save();
|
|
for (auto quality : qualities) {
|
|
paint.setFilterQuality(quality);
|
|
auto surf = ToolUtils::makeSurface(canvas, SkImageInfo::MakeN32Premul(1, 1));
|
|
surf->getCanvas()->drawImageRect(img, src, SkRect::MakeWH(1, 1), &paint, constraint);
|
|
// now blow up the 1 pixel result
|
|
canvas->drawImageRect(surf->makeImageSnapshot(), SkRect::MakeWH(100, 100), nullptr);
|
|
canvas->translate(120, 0);
|
|
}
|
|
canvas->restore();
|
|
canvas->translate(0, 120);
|
|
}
|
|
}
|
|
|
|
|