9e94812bef
This reverts commit 345d72124d.
Reason for revert: can break ES2 for-loop rules
Original change's description:
> Eliminate inliner temporary variables for functions with a single exit.
>
> When we determine that a function only contains a single return
> statement, there is no need to create a temporary variable and store the
> result expression into a variable. Instead, we can directly replace the
> function-call expression with the return-statement's expression.
>
> This dramatically simplifies the final optimized output from chains of
> very simple inlined functions, which is a very common pattern for trees
> of Skia fragment processors.
>
> Change-Id: I6789064a321daf43db2e1cef4915f25ed74d6131
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344665
> Commit-Queue: John Stiles <johnstiles@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>
TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
Change-Id: I60845f22159605a06047b030e2686a769121a35a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345120
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
59 lines
2.1 KiB
C++
59 lines
2.1 KiB
C++
|
|
|
|
/**************************************************************************************************
|
|
*** This file was autogenerated from GrInlinedFunction.fp; do not modify.
|
|
**************************************************************************************************/
|
|
#include "GrInlinedFunction.h"
|
|
|
|
#include "src/core/SkUtils.h"
|
|
#include "src/gpu/GrTexture.h"
|
|
#include "src/gpu/glsl/GrGLSLFragmentProcessor.h"
|
|
#include "src/gpu/glsl/GrGLSLFragmentShaderBuilder.h"
|
|
#include "src/gpu/glsl/GrGLSLProgramBuilder.h"
|
|
#include "src/sksl/SkSLCPP.h"
|
|
#include "src/sksl/SkSLUtil.h"
|
|
class GrGLSLInlinedFunction : public GrGLSLFragmentProcessor {
|
|
public:
|
|
GrGLSLInlinedFunction() {}
|
|
void emitCode(EmitArgs& args) override {
|
|
GrGLSLFPFragmentBuilder* fragBuilder = args.fFragBuilder;
|
|
const GrInlinedFunction& _outer = args.fFp.cast<GrInlinedFunction>();
|
|
(void) _outer;
|
|
colorVar = args.fUniformHandler->addUniform(&_outer, kFragment_GrShaderFlag, kHalf4_GrSLType, "color");
|
|
fragBuilder->codeAppendf(
|
|
R"SkSL(half4 _0_flip;
|
|
_0_flip = %s.wzyx;
|
|
|
|
return _0_flip;
|
|
|
|
)SkSL"
|
|
, args.fUniformHandler->getUniformCStr(colorVar));
|
|
}
|
|
private:
|
|
void onSetData(const GrGLSLProgramDataManager& pdman, const GrFragmentProcessor& _proc) override {
|
|
}
|
|
UniformHandle colorVar;
|
|
};
|
|
GrGLSLFragmentProcessor* GrInlinedFunction::onCreateGLSLInstance() const {
|
|
return new GrGLSLInlinedFunction();
|
|
}
|
|
void GrInlinedFunction::onGetGLSLProcessorKey(const GrShaderCaps& caps, GrProcessorKeyBuilder* b) const {
|
|
}
|
|
bool GrInlinedFunction::onIsEqual(const GrFragmentProcessor& other) const {
|
|
const GrInlinedFunction& that = other.cast<GrInlinedFunction>();
|
|
(void) that;
|
|
return true;
|
|
}
|
|
GrInlinedFunction::GrInlinedFunction(const GrInlinedFunction& src)
|
|
: INHERITED(kGrInlinedFunction_ClassID, src.optimizationFlags()) {
|
|
this->cloneAndRegisterAllChildProcessors(src);
|
|
}
|
|
std::unique_ptr<GrFragmentProcessor> GrInlinedFunction::clone() const {
|
|
return std::make_unique<GrInlinedFunction>(*this);
|
|
}
|
|
#if GR_TEST_UTILS
|
|
SkString GrInlinedFunction::onDumpInfo() const {
|
|
return SkString();
|
|
}
|
|
#endif
|