AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
9e94812bef
skia2/tests/sksl/fp/golden
History
John Stiles 9e94812bef Revert "Eliminate inliner temporary variables for functions with a single exit." 
This reverts commit 345d72124d.

Reason for revert: can break ES2 for-loop rules

Original change's description:
> Eliminate inliner temporary variables for functions with a single exit.
>
> When we determine that a function only contains a single return
> statement, there is no need to create a temporary variable and store the
> result expression into a variable. Instead, we can directly replace the
> function-call expression with the return-statement's expression.
>
> This dramatically simplifies the final optimized output from chains of
> very simple inlined functions, which is a very common pattern for trees
> of Skia fragment processors.
>
> Change-Id: I6789064a321daf43db2e1cef4915f25ed74d6131
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344665
> Commit-Queue: John Stiles <johnstiles@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I60845f22159605a06047b030e2686a769121a35a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345120
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-12-16 18:24:57 +00:00
..
GrChildProcessorAndGlobal.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorAndGlobal.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorFieldAccess.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorFieldAccess.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorInlineFieldAccess.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorInlineFieldAccess.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessors.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessors.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleCoords.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleCoords.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixAndCoords.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixAndCoords.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixConstant.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixConstant.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixConstantAndCoords.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixConstantAndCoords.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixMultipleUniforms.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixMultipleUniforms.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixSingleInUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixSingleInUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixSingleUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixSingleUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixSingleUniformExpr.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorSampleMatrixSingleUniformExpr.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorsWithInput.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorsWithInput.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorWithInputExpression.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrChildProcessorWithInputExpression.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrConditionalInUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrConditionalInUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrFunction.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrFunction.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrGrSLTypesAreSupported.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrGrSLTypesAreSupported.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrHelloWorld.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrHelloWorld.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrInlinedFunction.cpp Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
GrInlinedFunction.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrInUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrInUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrInUniformCType.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrInUniformCType.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrKeyIn.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrKeyIn.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrLayoutWhen.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrLayoutWhen.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrMainCoords.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrMainCoords.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrModuloOp.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrModuloOp.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNestedCall.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNestedCall.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNestedChildProcessors.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNestedChildProcessors.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNonInlinedInUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNonInlinedInUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNullableChildProcessor.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrNullableChildProcessor.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionClass.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionClass.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionConstructor.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionConstructor.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionConstructorParams.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionConstructorParams.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionCpp.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionCpp.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionDumpInfo.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionDumpInfo.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionEmitCode.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionEmitCode.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionFields.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionFields.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionHeader.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionHeader.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionInitializers.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionInitializers.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionMake.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionMake.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionSetData.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionSetData.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionTest.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrSectionTest.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrTrackedInUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrTrackedInUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrUniform.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrUniform.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrUniformArrays.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrUniformArrays.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrUseExplicitReturn.cpp Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00
GrUseExplicitReturn.h Remove GrFragmentProcessor::usesExplicitReturn. 2020-12-15 18:06:12 +00:00