10805961ce
Reason for revert: nanobech failing on Android Original issue's description: > Make the Sk GL context class an abstract base class > > Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before, > it depended on ifdefs to implement the platform dependent polymorphism. Move > the logic to subclasses of the various platform implementations. > > This a step to enable Skia embedders to compile dm and bench_pictures. The > concrete goal is to support running these test apps with Chromium command buffer. > > With this change, Chromium can implement its own version of SkGLNativeContext > that uses command buffer, and host the implementation in its own repository. > > Implements the above by renaming the SkGLContextHelper to SkGLContext and > removing the unneeded SkGLNativeContext. Also removes > SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused: > no use in Skia code, and no tests. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/a90ed4e83897b45d6331ee4c54e1edd4054de9a8 TBR=kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/639793002 |
||
---|---|---|
.. | ||
bug_chomper | ||
chromium | ||
copyright | ||
flags | ||
lua | ||
skpdiff | ||
tests | ||
timer | ||
__init__.py | ||
add_codereview_message.py | ||
bbh_shootout.cpp | ||
bench_pictures_cfg_helper.py | ||
bench_pictures_main.cpp | ||
bench_pictures.cfg | ||
buildbot_globals.py | ||
compare_codereview.py | ||
CopyTilesRenderer.cpp | ||
CopyTilesRenderer.h | ||
coverage.sh | ||
CrashHandler.cpp | ||
CrashHandler.h | ||
create_test_font.cpp | ||
doxygen_footer.txt | ||
dump_record.cpp | ||
DumpRecord.cpp | ||
DumpRecord.h | ||
filtermain.cpp | ||
find_bad_images_in_skps.py | ||
find_run_binary.py | ||
fix_pythonpath.py | ||
gcov_shim | ||
gen_bench_expectations_from_codereview.py | ||
generate_fir_coeff.py | ||
git-skia-verify | ||
git-sync-deps | ||
gpuveto.cpp | ||
image_expectations.cpp | ||
image_expectations.h | ||
install_dependencies.sh | ||
iOSShell.cpp | ||
iOSShell.h | ||
jsondiff.py | ||
LazyDecodeBitmap.cpp | ||
LazyDecodeBitmap.h | ||
lsan.supp | ||
merge_static_libs.py | ||
misc_utils.py | ||
OverwriteLine.h | ||
pathops_sorter.htm | ||
pathops_visualizer.htm | ||
picture_utils.cpp | ||
picture_utils.h | ||
PictureBenchmark.cpp | ||
PictureBenchmark.h | ||
PictureRenderer.cpp | ||
PictureRenderer.h | ||
PictureRenderingFlags.cpp | ||
PictureRenderingFlags.h | ||
PictureResultsWriter.h | ||
pinspect.cpp | ||
ProcStats.cpp | ||
ProcStats.h | ||
reformat-json.py | ||
render_pdfs_main.cpp | ||
render_pictures_main.cpp | ||
Resources.cpp | ||
Resources.h | ||
retrieve_from_googlesource.py | ||
roll_deps.py | ||
sanitize_source_files.py | ||
sk_tool_utils_flags.h | ||
sk_tool_utils_font.cpp | ||
sk_tool_utils.cpp | ||
sk_tool_utils.h | ||
skdiff_html.cpp | ||
skdiff_html.h | ||
skdiff_image.cpp | ||
skdiff_main.cpp | ||
skdiff_utils.cpp | ||
skdiff_utils.h | ||
skdiff.cpp | ||
skdiff.h | ||
skhello.cpp | ||
skimage_main.cpp | ||
skpinfo.cpp | ||
skpmaker.cpp | ||
Stats.h | ||
submit_try | ||
submit_try.bat | ||
svn.py | ||
svndiff.py | ||
test_all.py | ||
test_font_data_chars.cpp | ||
test_font_data.cpp | ||
test_gpuveto.py | ||
test_image_decoder.cpp | ||
test_pdfs.py | ||
tsan.supp | ||
valgrind.supp | ||
win_dbghelp.cpp | ||
win_dbghelp.h | ||
win_lcid.cpp | ||
xsan_build |