skia2/modules/canvaskit
dependabot[bot] 98b1cc92c7 Bump karma from 6.3.2 to 6.3.16 in /modules/canvaskit
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.2 to 6.3.16.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/karma-runner/karma/releases">karma's releases</a>.</em></p>
<blockquote>
<h2>v6.3.16</h2>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.15...v6.3.16">6.3.16</a> (2022-02-10)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>security:</strong> mitigate the &quot;Open Redirect Vulnerability&quot; (<a href="ff7edbb2ff">ff7edbb</a>)</li>
</ul>
<h2>v6.3.15</h2>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.14...v6.3.15">6.3.15</a> (2022-02-05)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>helper:</strong> make mkdirIfNotExists helper resilient to concurrent calls (<a href="d9dade2f00">d9dade2</a>), closes <a href="https://github-redirect.dependabot.com//github-redirect.dependabot.com/karma-runner/karma-coverage/issues/434/issues/issuecomment-1017939333">karma-runner/karma-coverage#434</a></li>
</ul>
<h2>v6.3.14</h2>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.13...v6.3.14">6.3.14</a> (2022-02-05)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>remove string template from client code (<a href="91d5acda63">91d5acd</a>)</li>
<li>warn when <code>singleRun</code> and <code>autoWatch</code> are <code>false</code> (<a href="69cfc763c8">69cfc76</a>)</li>
<li><strong>security:</strong> remove XSS vulnerability in <code>returnUrl</code> query param (<a href="839578c45a">839578c</a>)</li>
</ul>
<h2>v6.3.13</h2>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.12...v6.3.13">6.3.13</a> (2022-01-31)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump log4js to resolve security issue (<a href="5bf2df3044">5bf2df3</a>), closes <a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3751">#3751</a></li>
</ul>
<h2>v6.3.12</h2>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.11...v6.3.12">6.3.12</a> (2022-01-24)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>remove depreciation warning from log4js (<a href="41bed33bf4">41bed33</a>)</li>
</ul>
<h2>v6.3.11</h2>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.10...v6.3.11">6.3.11</a> (2022-01-13)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> pin colors package to 1.4.0 due to security vulnerability (<a href="a5219c52e2">a5219c5</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/karma-runner/karma/blob/master/CHANGELOG.md">karma's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.15...v6.3.16">6.3.16</a> (2022-02-10)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>security:</strong> mitigate the &quot;Open Redirect Vulnerability&quot; (<a href="ff7edbb2ff">ff7edbb</a>)</li>
</ul>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.14...v6.3.15">6.3.15</a> (2022-02-05)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>helper:</strong> make mkdirIfNotExists helper resilient to concurrent calls (<a href="d9dade2f00">d9dade2</a>), closes <a href="https://github-redirect.dependabot.com//github-redirect.dependabot.com/karma-runner/karma-coverage/issues/434/issues/issuecomment-1017939333">karma-runner/karma-coverage#434</a></li>
</ul>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.13...v6.3.14">6.3.14</a> (2022-02-05)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>remove string template from client code (<a href="91d5acda63">91d5acd</a>)</li>
<li>warn when <code>singleRun</code> and <code>autoWatch</code> are <code>false</code> (<a href="69cfc763c8">69cfc76</a>)</li>
<li><strong>security:</strong> remove XSS vulnerability in <code>returnUrl</code> query param (<a href="839578c45a">839578c</a>)</li>
</ul>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.12...v6.3.13">6.3.13</a> (2022-01-31)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> bump log4js to resolve security issue (<a href="5bf2df3044">5bf2df3</a>), closes <a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3751">#3751</a></li>
</ul>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.11...v6.3.12">6.3.12</a> (2022-01-24)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>remove depreciation warning from log4js (<a href="41bed33bf4">41bed33</a>)</li>
</ul>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.10...v6.3.11">6.3.11</a> (2022-01-13)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> pin colors package to 1.4.0 due to security vulnerability (<a href="a5219c52e2">a5219c5</a>)</li>
</ul>
<h2><a href="https://github.com/karma-runner/karma/compare/v6.3.9...v6.3.10">6.3.10</a> (2022-01-08)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>logger:</strong> create parent folders if they are missing (<a href="0d24bd937f">0d24bd9</a>), closes <a href="https://github-redirect.dependabot.com/karma-runner/karma/issues/3734">#3734</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ab4b32898b"><code>ab4b328</code></a> chore(release): 6.3.16 [skip ci]</li>
<li><a href="ff7edbb2ff"><code>ff7edbb</code></a> fix(security): mitigate the &quot;Open Redirect Vulnerability&quot;</li>
<li><a href="c1befa04b3"><code>c1befa0</code></a> chore(release): 6.3.15 [skip ci]</li>
<li><a href="d9dade2f00"><code>d9dade2</code></a> fix(helper): make mkdirIfNotExists helper resilient to concurrent calls</li>
<li><a href="653c762be4"><code>653c762</code></a> ci: prevent duplicate CI tasks on creating a PR</li>
<li><a href="c97e562319"><code>c97e562</code></a> chore(release): 6.3.14 [skip ci]</li>
<li><a href="91d5acda63"><code>91d5acd</code></a> fix: remove string template from client code</li>
<li><a href="69cfc763c8"><code>69cfc76</code></a> fix: warn when <code>singleRun</code> and <code>autoWatch</code> are <code>false</code></li>
<li><a href="839578c45a"><code>839578c</code></a> fix(security): remove XSS vulnerability in <code>returnUrl</code> query param</li>
<li><a href="db53785b3e"><code>db53785</code></a> chore(release): 6.3.13 [skip ci]</li>
<li>Additional commits viewable in <a href="https://github.com/karma-runner/karma/compare/v6.3.2...v6.3.16">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=karma&package-manager=npm_and_yarn&previous-version=6.3.2&new-version=6.3.16)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/google/skia/network/alerts).

</details>

This is an imported pull request from
https://github.com/google/skia/pull/95

GitOrigin-RevId: ae940f93cbf5ebba6d02f722e0c9bc44f49c35c5
Change-Id: Ic9abd882cba29cdd130d5811f7c56fdfae9290de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/514659
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2022-03-02 14:36:51 +00:00
..
external_test [canvaskit] Add tests/examples for using CanvasKit with Typescript. 2021-11-05 20:18:30 +00:00
fonts [canvaskit] Clean up embedded fonts 2019-10-09 14:51:39 +00:00
future_apis Add a future_apis folder to canvaskit. future_apis contains notes on 2020-06-17 18:17:25 +00:00
go/gold_test_env [canvaskit] Run JS tests in Bazel 2022-02-28 21:30:21 +00:00
htmlcanvas [canvaskit] Add rough measureText to Canvas2D emulation layer 2021-12-09 13:07:24 +00:00
npm_build Remove isOpaque parameter from CanvasKit SkRuntimeEffect APIs 2022-02-10 17:15:13 +00:00
tests [canvaskit] Run JS tests in Bazel 2022-02-28 21:30:21 +00:00
wasm_tools [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
.gitignore [infra] Add initial Bazel rules and files 2021-11-09 12:32:25 +00:00
BUILD.bazel [canvaskit] Run JS tests in Bazel 2022-02-28 21:30:21 +00:00
BUILD.gn [canvaskit] Add legacy drawvertices mode to npm build 2022-02-23 19:38:18 +00:00
canvaskit_bindings.cpp Rename GrSwizzle to skgpu::Swizzle 2022-02-16 13:30:14 +00:00
canvaskit.gni [canvaskit] Add legacy drawvertices mode to npm build 2022-02-23 19:38:18 +00:00
catchExceptionNop.js JS files to support running jasmine tests in google3 2020-03-09 14:20:27 +00:00
CHANGELOG.md Reland "Build CanvasKit using GN/Ninja" 2022-02-15 16:31:10 +00:00
color.js [canvaskit] Remove *Builders in favor of Malloc. 2021-06-03 17:43:58 +00:00
compile_gm.sh Reland "Build CanvasKit using GN/Ninja" 2022-02-15 16:31:10 +00:00
compile.sh [canvaskit] Add legacy drawvertices mode to npm build 2022-02-23 19:38:18 +00:00
cpu.js [canvaskit] Remove the need for users to keep track of contexts. 2021-08-25 18:23:06 +00:00
debug.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
externs.js [canvaskit] Expose SkPicture.makeShader 2022-02-04 15:12:46 +00:00
font.js [canvaskit] Remove deprecated MakeTypefaceFromData and RefDefault 2021-10-21 16:45:42 +00:00
gm_bindings.cpp Followup fixes to gm bindings 2021-10-13 19:26:05 +00:00
gm.js [canvaskit] Load resources into wasm gms/unit tests. 2020-10-21 20:40:29 +00:00
gpu.js [canvaskit] Change contexts when making surfaces from GrContext 2022-02-01 15:56:04 +00:00
interface.js [canvaskit] Expose SkPicture.makeShader 2022-02-04 15:12:46 +00:00
karma.bazel.js [canvaskit] Run JS tests in Bazel 2022-02-28 21:30:21 +00:00
karma.conf.js [canvaskit] Fix test search path 2021-12-07 19:43:27 +00:00
karma.google3.conf.js Fixes for canvaskit karma tests in google3 2020-09-23 14:51:27 +00:00
Makefile [canvaskit] Run JS tests in Bazel 2022-02-28 21:30:21 +00:00
matrix.js [canvaskit] Move matrix helpers to their own file and make optional. 2021-02-01 20:01:07 +00:00
memory.js [canvaskit] Improve error when non-matrix argument passed in 2022-02-10 17:15:55 +00:00
package-lock.json Bump karma from 6.3.2 to 6.3.16 in /modules/canvaskit 2022-03-02 14:36:51 +00:00
package.json Bump karma from 6.3.2 to 6.3.16 in /modules/canvaskit 2022-03-02 14:36:51 +00:00
paragraph_bindings_gen.cpp [canvaskit] Add TextHeightBehavior 2021-04-22 18:21:44 +00:00
paragraph_bindings.cpp [ck] Expose ParagraphBuilderImpl::Reset to CanvasKit 2022-02-02 15:54:21 +00:00
paragraph.js [canvaskit] Remove deprecated MakeTypefaceFromData and RefDefault 2021-10-21 16:45:42 +00:00
particles_bindings.cpp [canvaskit] Introduce self-documenting pointer types 2021-05-27 12:30:54 +00:00
particles.js [canvaskit] Fix particles.setPosition and add test. 2021-02-03 15:52:23 +00:00
pathops.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
postamble.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
preamble.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
README.md Reland "Build CanvasKit using GN/Ninja" 2022-02-15 16:31:10 +00:00
release.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
rt_shader.js Remove isOpaque parameter from CanvasKit SkRuntimeEffect APIs 2022-02-10 17:15:13 +00:00
skottie_bindings.cpp [canvaskit] Rename some CK-specific defines 2022-02-15 22:42:17 +00:00
skottie.js [skottie/wasm] Plumb text properties in WASM bindings 2021-03-10 18:34:04 +00:00
skp.js [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
util.js [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
viewer_bindings.cpp Reland "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" 2020-10-06 18:59:11 +00:00
WasmCommon.h [canvaskit] Use copy1darray to send arrays to JSSpan 2021-06-02 14:18:59 +00:00

Prerequisites

Node v14 or later is required to run tests. We use npm (the Node Package Manager) to install test dependencies. Recent installations of Node have npm as well. CanvasKit has no other external source dependencies.

Compiling with GN

To build with GN, you need to have followed the instructions to download Skia and its deps https://skia.org/user/download.

To compile CanvasKit, you will first need to download and activate emscripten using the script in //bin/activate-emsdk (or //bin/git-sync-deps which also calls activate-emsdk). This places the associated files in //third_party/externals/emsdk and the GN2 build scripts will use those by default. The compile.sh script automates the default GN settings; users are free to set their own. If users want to use their own version of emscripten, they should set the skia_emsdk_dir argument (see //skia/gn/toolchain/wasm.gni). For other available arguments, see //modules/canvaskit/BUILD.gn.

MacOS specific notes

Make sure you have Python3 installed, otherwise the downloading emscripten toolchain can fail with errors about SSL certificates. https://github.com/emscripten-core/emsdk/pull/273

See also https://github.com/emscripten-core/emscripten/issues/9036#issuecomment-532092743 for a solution to Python3 using the wrong certificates.

Compile and Run Local Example

# The following installs all npm dependencies and only needs to be when setting up
# or if our npm dependencies have changed (rarely).
npm ci

make release  # make debug is much faster and has better error messages
make local-example

This will print a local endpoint for viewing the example. You can experiment with the CanvasKit API by modifying ./npm_build/example.html and refreshing the page. For some more experimental APIs, there's also ./npm_build/extra.html.

For other available build targets, see Makefile and compile.sh. For example, building a stripped-down version of CanvasKit with no text support or any of the "extras", one might run:

./compile.sh no_skottie no_particles no_font

Such a stripped-down version is about half the size of the default release build.

Unit tests, performance tests, and coverage.

To run unit tests and compute test coverage on a debug gpu build

make debug
make test-continuous

This reads karma.conf.js, and opens a Chrome browser and begins running all the test in test/ it will detect changes to the tests in that directory and automatically run again, however it will automatically rebuild and reload CanvasKit. Closing the chrome window will just cause it to re-opened. Kill the karma process to stop continuous monitoring for changes.

The tests are run with whichever build of CanvasKit you last made. be sure to also test with release, debug_cpu, and release_cpu. testing with release builds will expose problems in closure compilation and usually forgotten externs.

Coverage

Coverage will be automatically computed when running test-continuous locally. Note that the results will only be useful when testing a debug build. Open coverage/<browser version>/index.html For a summary and detailed line-by-line result.

Measuring Performance

We use puppeteer to run a Chrome browser to gather performance data in a consistent way. See //tools/perf-canvaskit-puppeteer for more.

Adding tests

The tests in tests/ are grouped into files by topic. Within each file there are describe blocks further organizing the tests, and within those it() functions which test particular behaviors. describe and it are jasmine methods which can both be temporarily renamed fdescribe and fit. Which causes jasmine to only those.

We have also defined gm which is a method for defining a test which draws something to a canvas that is shapshotted and reported to gold.skia.org, where you can compare it with the snapshot at head.

Testing from Gerrit

When submitting a CL in gerrit, click "choose tryjobs" and type CanvasKit to filter them. select all of them, which at the time of this writing is four jobs, for each combination of perf/test gpu/cpu.

The performance results are reported to [perf.skia.org] and correctness results are reported to [gold.skia.org].

Coverage is not measured while running tests this way.

Inspecting output WASM

The wasm2wat tool from the WebAssembly Binary Toolkit can be used to produce a human-readable text version of a .wasm file.

The output of wasm2wat --version should be 1.0.13 (1.0.17). This version has been checked to work with the tools in wasm_tools/SIMD/. These tools programmatically inspect the .wasm output of a CanvasKit build to detect the presence of wasm SIMD operations.

Infrastructure Playbook

When dealing with CanvasKit (or PathKit) on our bots, we use Docker. Check out $SKIA_ROOT/infra/wasm-common/docker/README.md for more on building/editing the images used for building and testing.

Updating the version of Emscripten we build/test with

This presumes you have updated emscripten locally to a newer version of the sdk and verified/fixed any build issues that have arisen.

  1. Edit //bin/activate-emsdk to install and activate the desired version of Emscripten.
  2. Upload a CL with all the changes. Run all Test.+CanvasKit, Perf.+Puppeteer, Test.+PathKit, Perf.+PathKit jobs to make sure the new builds pass all tests and don't crash the perf harnesses.
  3. Send out CL for review. Feel free to point the reviewer at these steps.

Running Skia's GMs and Unit Tests against wasm+WebGL

TODO(kjlubick)

General Tips:

  • Make use of the skip lists and start indexes in the run-wasm-gm-tests.html to focus in on problematic tests.
  • Uncaught (in promise) RuntimeError: function signature mismatch tends to mean null was dereferenced somewhere. Add SkASSERT to verify.