ef57b7e653
The main meat of things is in SkThreadPool. We can now give SkThreadPool a type for each thread to create and destroy on its local stack. It's TLS without going through SkTLS. I've split the DM tasks into CpuTasks that run on threads with no TLS, and GpuTasks that run on threads with a thread local GrContextFactory. The old CpuTask and GpuTask have been renamed to CpuGMTask and GpuGMTask. Upshot: default run of out/Debug/dm goes from ~45 seconds to ~20 seconds. BUG=skia: R=bsalomon@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/179233005 git-svn-id: http://skia.googlecode.com/svn/trunk@13632 2bbb7eff-a529-9590-31e7-b0007b416f81 |
||
---|---|---|
.. | ||
DM.cpp | ||
DMBenchTask.cpp | ||
DMBenchTask.h | ||
DMCpuGMTask.cpp | ||
DMCpuGMTask.h | ||
DMExpectations.h | ||
DMExpectationsTask.cpp | ||
DMExpectationsTask.h | ||
DMGpuGMTask.cpp | ||
DMGpuGMTask.h | ||
DMPipeTask.cpp | ||
DMPipeTask.h | ||
DMReplayTask.cpp | ||
DMReplayTask.h | ||
DMReporter.cpp | ||
DMReporter.h | ||
DMSerializeTask.cpp | ||
DMSerializeTask.h | ||
DMTask.cpp | ||
DMTask.h | ||
DMTaskRunner.cpp | ||
DMTaskRunner.h | ||
DMTestTask.cpp | ||
DMTestTask.h | ||
DMTileGridTask.cpp | ||
DMTileGridTask.h | ||
DMUtil.cpp | ||
DMUtil.h | ||
DMWriteTask.cpp | ||
DMWriteTask.h | ||
README |
DM is like GM, but multithreaded. It doesn't do everything GM does yet. Current approximate list of missing features: --config pdf --mismatchPath --missingExpectationsPath --writePicturePath --deferred DM's design is based around Tasks and a TaskRunner. A Task represents an independent unit of work that might fail. We make a task for each GM/configuration pair we want to run. Tasks can kick off new tasks themselves. For example, a CpuTask can kick off a ReplayTask to make sure recording and playing back an SkPicture gives the same result as direct rendering. The TaskRunner runs all tasks on one of two threadpools, whose sizes are configurable by --cpuThreads and --gpuThreads. Ideally we'd run these on a single threadpool but it can swamp the GPU if we shove too much work into it at once. --cpuThreads defaults to the number of cores on the machine. --gpuThreads defaults to 1, but you may find 2 or 4 runs a little faster. So the main flow of DM is: for each GM: for each configuration: kick off a new task < tasks run, maybe fail, and maybe kick off new tasks > wait for all tasks to finish report failures