skia2/modules/canvaskit
Mike Klein dd8f8ed384 clean up defines that do nothing
These are leftovers.  Should be a noop.

Change-Id: I9897841e63b417a63d6f2d681a8ac4ae50ebb485
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/399797
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-04-22 18:02:59 +00:00
..
fonts [canvaskit] Clean up embedded fonts 2019-10-09 14:51:39 +00:00
future_apis Add a future_apis folder to canvaskit. future_apis contains notes on 2020-06-17 18:17:25 +00:00
htmlcanvas [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
npm_build [canvaskit] Add halfLeading to TextStyle and StrutStyle 2021-04-20 20:21:56 +00:00
tests [canvaskit] Add halfLeading to TextStyle and StrutStyle 2021-04-20 20:21:56 +00:00
wasm_tools [canvaskit] Add unit tests to wasm_gm_tests 2020-11-02 16:51:23 +00:00
.gitignore [canvaskit] Add full build to npm release. 2021-02-23 14:40:43 +00:00
BUILD.gn Get CanvasKit viewer compiling again 2020-12-15 01:10:48 +00:00
canvaskit_bindings.cpp Use SkRuntimeEffect::MakeForShader in CanvasKit 2021-04-21 17:44:12 +00:00
catchExceptionNop.js JS files to support running jasmine tests in google3 2020-03-09 14:20:27 +00:00
CHANGELOG.md [canvaskit] Add halfLeading to TextStyle and StrutStyle 2021-04-20 20:21:56 +00:00
color.js Reland "[canvaskit] Break up helper.js into smaller files" 2021-02-01 20:00:16 +00:00
compile_gm.sh clean up defines that do nothing 2021-04-22 18:02:59 +00:00
compile.sh [canvaskit] Split paragraph_bindings into two files for generation POC 2021-04-20 18:11:45 +00:00
cpu.js [canvaskit] Revert raster change. 2020-11-12 14:49:47 +00:00
debug.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
externs.js Show text hilites 2021-04-19 17:45:51 +00:00
font.js Change GlyphIDArray to 16bit 2021-04-14 13:44:48 +00:00
gm_bindings.cpp Run the Programs unit test on all rendering backends 2021-02-18 17:40:58 +00:00
gm.js [canvaskit] Load resources into wasm gms/unit tests. 2020-10-21 20:40:29 +00:00
gpu.js [canvaskit] Fix bug if webgl context not available 2020-12-28 14:47:43 +00:00
helper.js Reland "[canvaskit] Break up helper.js into smaller files" 2021-02-01 20:00:16 +00:00
interface.js Fix up quotes and prototype decl from prev CL 2021-04-15 12:38:29 +00:00
karma.conf.js [canvaskit] Add full build to npm release. 2021-02-23 14:40:43 +00:00
karma.google3.conf.js Fixes for canvaskit karma tests in google3 2020-09-23 14:51:27 +00:00
Makefile [canvaskit] Remove unreliable perf jobs. 2021-03-08 14:48:35 +00:00
matrix.js [canvaskit] Move matrix helpers to their own file and make optional. 2021-02-01 20:01:07 +00:00
memory.js [canvaskit] Remove value_array for vector3 2021-02-02 15:22:07 +00:00
package-lock.json [canvaskit] Update npm dev dependencies 2020-12-14 15:03:24 +00:00
package.json [canvaskit] Update npm dev dependencies 2020-12-14 15:03:24 +00:00
paragraph_bindings_gen.cpp [canvaskit] Split paragraph_bindings into two files for generation POC 2021-04-20 18:11:45 +00:00
paragraph_bindings.cpp [canvaskit] Add halfLeading to TextStyle and StrutStyle 2021-04-20 20:21:56 +00:00
paragraph.js [canvaskit] Add halfLeading to TextStyle and StrutStyle 2021-04-20 20:21:56 +00:00
particles_bindings.cpp Move code generators to codegen/ directory. 2021-04-13 15:34:24 +00:00
particles.js [canvaskit] Fix particles.setPosition and add test. 2021-02-03 15:52:23 +00:00
pathops.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
postamble.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
preamble.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
README.md [canvaskit] Remove unreliable perf jobs. 2021-03-08 14:48:35 +00:00
release.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
rt_shader.js [canvaskit] Add error callback for runtime effect constructor 2021-02-03 17:35:23 +00:00
serve.py [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
skottie_bindings.cpp [skottie/wasm] Plumb text properties in WASM bindings 2021-03-10 18:34:04 +00:00
skottie.js [skottie/wasm] Plumb text properties in WASM bindings 2021-03-10 18:34:04 +00:00
skp.js [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
util.js [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
viewer_bindings.cpp Reland "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" 2020-10-06 18:59:11 +00:00
WasmCommon.h Expose proposed Shaper API to JS 2021-04-17 15:16:23 +00:00

Prerequisites

To compile CanvasKit, you will first need to install emscripten. This will set the environment EMSDK (among others) which is required for compilation. Which version should you use? /infra/wasm-common/docker/emsdk-base/Dockerfile shows the version we build and test with. We try to keep this up-to-date.

This document also assumes you have followed the instructions to download Skia and its deps https://skia.org/user/download.

MacOS specific notes

Make sure you have Python3 installed, otherwise the downloading emscripten toolchain can fail with errors about SSL certificates. https://github.com/emscripten-core/emsdk/pull/273

See also https://github.com/emscripten-core/emscripten/issues/9036#issuecomment-532092743 for a solution to Python3 using the wrong certificates.

Compile and Run Local Example

make release  # make debug is much faster and has better error messages
make local-example

This will print a local endpoint for viewing the example. You can experiment with the CanvasKit API by modifying ./npm_build/example.html and refreshing the page. For some more experimental APIs, there's also ./npm_build/extra.html.

For other available build targets, see Makefile and compile.sh. For example, building a stripped-down version of CanvasKit with no text support or any of the "extras", one might run:

./compile.sh no_skottie no_particles no_font

Such a stripped-down version is about half the size of the default release build.

Unit tests, performance tests, and coverage.

To run unit tests and compute test coverage on a debug gpu build

make debug
make test-continuous

This reads karma.conf.js, and opens a chrome browser and begins running all the test in test/ it will detect changes to the tests in that directory and automatically run again, however it will automatically rebuild and reload canvaskit. Closing the chrome window will just cause it to re-opened. Kill the karma process to stop continuous monitoring for changes.

The tests are run with whichever build of canvaskit you last made. be sure to also test with release, debug_cpu, and release_cpu. testing with release builds will expose problems in closure compilation and usually forgotten externs.

Coverage

Coverage will be automatically computed when running test-continuous locally. Note that the results will only be useful when testing a debug build. Open coverage/<browser version>/index.html For a summary and detailed line-by-line result.

Measuring Performance

We use puppeteer to run a Chrome browser to gather performance data in a consistent way. See //tools/perf-canvaskit-puppeteer for more.

Adding tests

The tests in tests/ are grouped into files by topic. Within each file there are describe blocks further organizing the tests, and within those it() functions which test particular behaviors. describe and it are jasmine methods which can both be temporarily renamed fdescribe and fit. Which causes jasmine to only those.

We have also defined gm which is a method for defining a test which draws something to a canvas that is shapshotted and reported to gold.skia.org, where you can compare it with the snapshot at head.

Testing from Gerrit

When submitting a CL in gerrit, click "choose tryjobs" and type canvaskit to filter them. select all of them, which at the time of this writing is four jobs, for each combination of perf/test gpu/cpu.

The performance results are reported to perf.skia.org gold results are reported to gold.skia.org

Coverage is not measured while running tests this way.

Inspecting output WASM

The wasm2wat tool from the WebAssembly Binary Toolkit can be used to produce a human-readable text version of a .wasm file.

The output of wasm2wat --version should be 1.0.13 (1.0.17). This version has been checked to work with the tools in wasm_tools/SIMD/. These tools programmatically inspect the .wasm output of a CanvasKit build to detect the presence of wasm SIMD operations.

Infrastructure Playbook

When dealing with CanvasKit (or PathKit) on our bots, we use Docker. Check out $SKIA_ROOT/infra/wasm-common/docker/README.md for more on building/editing the images used for building and testing.

Updating the version of Emscripten we build/test with

This presumes you have updated emscripten locally to a newer version of the sdk and verified/fixed any build issues that have arisen.

  1. Edit $SKIA_ROOT/infra/wasm-common/docker/emsdk-base/Dockerfile to install and activate the desired version of Emscripten.
  2. Edit $SKIA_ROOT/infra/wasm-common/docker/Makefile to have EMSDK_VERSION be set to that desired version. If there is a suffix that is not _v1, reset it to be _v1. If testing the image later does not work and edits are made to the emsdk-base Dockerfile to correct that, increment to _v2,_v3, etc to force the bots to pick up the new image.
  3. In $SKIA_ROOT/infra/wasm-common/docker/, run make publish_emsdk_base
  4. Edit $SKIA_ROOT/infra/canvaskit/docker/canvaskit-emsdk/Dockerfile to be based off the new version from step 2. CanvasKit has its own docker image because it needs a few extra dependencies to build with font support.
  5. Edit $SKIA_ROOT/infra/canvaskit/docker/Makefile to have the same version from step 2. It's easiest to keep the emsdk-base and canvaskit-emsdk versions be in lock-step.
  6. In $SKIA_ROOT/infra/canvaskit/docker/, run make publish_canvaskit_emsdk.
  7. In $SKIA_ROOT/infra/bots/recipe_modules/build/, update canvaskit.py and pathkit.py to have DOCKER_IMAGE point to the desired tagged Docker containers from steps 2 and 5 (which should be the same).
  8. In $SKIA_ROOT/infra/bots/task_drivers/compile_wasm_gm_tests.go, update dockerImage to refer to the desired Docker containers from steps 2 and 5.
  9. In $SKIA_ROOT/infra/bots/, run make train to re-train the recipes.
  10. Optional: Run something like git grep 1\\.38\\. in $SKIA_ROOT to see if there are any other references that need updating.
  11. Upload a CL with all the changes. Run all Test.+CanvasKit, Perf.+Puppeteer, Test.+PathKit, Perf.+PathKit jobs to make sure the new builds pass all tests and don't crash the perf harnesses.
  12. Send out CL for review. Feel free to point the reviewer at these steps.