73b0df10f7
When we pretend the SkScalerContextRec is 4 bytes bigger than it is, we copy 4 bytes more than we should, and that's freaking out the ASAN bots. Let's just say it's a little small. Still wrong, no stack overflow. Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-ASAN Change-Id: I03b292b9751289782cc0afcb860ca9196130985a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/200557 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Adrienne Walker <enne@chromium.org>
102 lines
3.3 KiB
C++
102 lines
3.3 KiB
C++
/*
|
|
* Copyright 2019 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkDescriptor.h"
|
|
#include "Test.h"
|
|
|
|
class SkDescriptorTestHelper {
|
|
public:
|
|
static void SetLength(SkDescriptor* desc, size_t length) { desc->fLength = length; }
|
|
};
|
|
|
|
DEF_TEST(Descriptor_empty, r) {
|
|
const size_t size = sizeof(SkDescriptor);
|
|
|
|
auto desc = SkDescriptor::Alloc(size);
|
|
desc->init();
|
|
REPORTER_ASSERT(r, desc->isValid());
|
|
REPORTER_ASSERT(r, desc->getLength() == size);
|
|
}
|
|
|
|
DEF_TEST(Descriptor_valid_simple, r) {
|
|
const size_t size =
|
|
sizeof(SkDescriptor) + sizeof(SkDescriptor::Entry) + sizeof(SkScalerContextRec);
|
|
|
|
auto desc = SkDescriptor::Alloc(size);
|
|
desc->init();
|
|
SkScalerContextRec rec;
|
|
desc->addEntry(kRec_SkDescriptorTag, sizeof(rec), &rec);
|
|
REPORTER_ASSERT(r, desc->isValid());
|
|
REPORTER_ASSERT(r, desc->getLength() == size);
|
|
|
|
SkDescriptorTestHelper::SetLength(desc.get(), size - 4);
|
|
REPORTER_ASSERT(r, !desc->isValid());
|
|
}
|
|
|
|
DEF_TEST(Descriptor_valid_simple_extra_space, r) {
|
|
const size_t extra_space = 100;
|
|
const size_t size =
|
|
sizeof(SkDescriptor) + sizeof(SkDescriptor::Entry) + sizeof(SkScalerContextRec);
|
|
|
|
auto desc = SkDescriptor::Alloc(size + extra_space);
|
|
desc->init();
|
|
SkScalerContextRec rec;
|
|
desc->addEntry(kRec_SkDescriptorTag, sizeof(rec), &rec);
|
|
REPORTER_ASSERT(r, desc->isValid());
|
|
REPORTER_ASSERT(r, desc->getLength() == size);
|
|
|
|
SkDescriptorTestHelper::SetLength(desc.get(), size - 4);
|
|
REPORTER_ASSERT(r, !desc->isValid());
|
|
}
|
|
|
|
DEF_TEST(Descriptor_valid_more_tags, r) {
|
|
const size_t effectSize = 16;
|
|
const size_t testSize = 32;
|
|
const size_t size = sizeof(SkDescriptor) + 3 * sizeof(SkDescriptor::Entry) +
|
|
sizeof(SkScalerContextRec) + effectSize + testSize;
|
|
|
|
auto desc = SkDescriptor::Alloc(size);
|
|
desc->init();
|
|
SkScalerContextRec rec;
|
|
desc->addEntry(kRec_SkDescriptorTag, sizeof(rec), &rec);
|
|
desc->addEntry(kEffects_SkDescriptorTag, effectSize, nullptr);
|
|
desc->addEntry(SkSetFourByteTag('t', 'e', 's', 't'), testSize, nullptr);
|
|
REPORTER_ASSERT(r, desc->isValid());
|
|
REPORTER_ASSERT(r, desc->getLength() == size);
|
|
|
|
SkDescriptorTestHelper::SetLength(desc.get(), size - 4);
|
|
REPORTER_ASSERT(r, !desc->isValid());
|
|
}
|
|
|
|
DEF_TEST(Descriptor_invalid_rec_size, r) {
|
|
const size_t size =
|
|
sizeof(SkDescriptor) + sizeof(SkDescriptor::Entry) + sizeof(SkScalerContextRec) - 4;
|
|
|
|
auto desc = SkDescriptor::Alloc(size);
|
|
desc->init();
|
|
SkScalerContextRec rec;
|
|
desc->addEntry(kRec_SkDescriptorTag, sizeof(rec) - 4, &rec);
|
|
REPORTER_ASSERT(r, desc->getLength() == size);
|
|
REPORTER_ASSERT(r, !desc->isValid());
|
|
}
|
|
|
|
DEF_TEST(Descriptor_invalid_length, r) {
|
|
const size_t size = sizeof(SkDescriptor) + sizeof(SkDescriptor::Entry);
|
|
const size_t effect_size = 1000;
|
|
|
|
auto desc = SkDescriptor::Alloc(size);
|
|
desc->init();
|
|
SkScalerContextRec rec;
|
|
desc->addEntry(kEffects_SkDescriptorTag, effect_size, nullptr);
|
|
|
|
SkDescriptorTestHelper::SetLength(desc.get(), size);
|
|
REPORTER_ASSERT(r, !desc->isValid());
|
|
|
|
SkDescriptorTestHelper::SetLength(desc.get(), size + effect_size);
|
|
REPORTER_ASSERT(r, desc->isValid());
|
|
}
|