AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
edf2367346
skia2/include/utils
History
commit-bot@chromium.org edf2367346 Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. 
We're writing fDone without holding the mutex.  Bad form, says tsan.

In practice this is fairly innocuous, as fDone only ever goes from false to
true and only once.  Though, I wouldn't be surprised if there were some way
this could leak a thread that never got the signal to die.

BUG=
R=scroggo@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/25371003

git-svn-id: http://skia.googlecode.com/svn/trunk@11563 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-01 18:44:18 +00:00
..
ios Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
mac oops, fix name for SkCreateDataProviderFromData 2013-03-25 20:21:26 +00:00
win Replace SkTScopedPtr with SkAutoTDelete in Skia. 2013-08-29 22:14:04 +00:00
SkBoundaryPatch.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkCamera.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkCanvasStateUtils.h Create a semi-stable API for capturing the state of an SkCanvas and reconstructing that state across different versions of Skia. 2013-08-29 20:20:40 +00:00
SkCondVar.h Implement SkCondVar for windows. 2012-10-31 19:29:13 +00:00
SkCountdown.h Add SkThreadPool for managing threads. 2012-10-31 15:52:16 +00:00
SkCubicInterval.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkCullPoints.h Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
SkDebugUtils.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-02-15 07:16:57 +00:00
SkDeferredCanvas.h Split SkDevice into SkBaseDevice and SkBitmapDevice 2013-08-29 11:54:56 +00:00
SkDumpCanvas.h This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path. 2013-08-16 10:24:37 +00:00
SkFrontBufferedStream.h Add a buffered SkStream class. 2013-09-26 21:35:39 +00:00
SkInterpolator.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkJSON.h Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
SkLayer.h Extended Inst counting to find "unknown" leaked object (SkTMaskGamma) 2012-08-16 14:58:06 +00:00
SkLua.h add script to scrape glyph usage in drawText calls 2013-05-30 18:55:14 +00:00
SkLuaCanvas.h This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path. 2013-08-16 10:24:37 +00:00
SkMatrix44.h Add getFloat/setFloat funcs to SkMatrix44 2013-09-18 18:52:09 +00:00
SkMeshUtils.h Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
SkNinePatch.h Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
SkNullCanvas.h Add SK_API to null canvas create method 2012-06-11 15:41:25 +00:00
SkNWayCanvas.h Add SkCanvasStack and update the Canvas utilities to use it. 2013-09-04 17:16:00 +00:00
SkParse.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkParsePaint.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkParsePath.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkPathUtils.h Animated the PathUtils Sample to show path contours# Enter a description of the change. 2013-07-09 16:30:38 +00:00
SkPictureUtils.h Add missing SK_API definition at request of Chromium callers 2012-12-05 06:15:42 +00:00
SkProxyCanvas.h This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path. 2013-08-16 10:24:37 +00:00
SkRandom.h Change old PRG to be SkLCGRandom; change new one to SkRandom 2013-09-09 20:09:12 +00:00
SkRTConf.h Fix size_t to int conversion warning on Win64 in SkRTConf.h. 2013-08-19 20:05:38 +00:00
SkRunnable.h Fixed remaining clang compiler warnings 2012-12-03 17:35:19 +00:00
SkThreadPool.h Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. 2013-10-01 18:44:18 +00:00
SkUnitMappers.h Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkWGL.h Rip out CSAA support 2013-09-06 20:00:41 +00:00