AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
fa87f9c7b9
skia2/modules/canvaskit
History
Kevin Lubick 5feaeb24d0 [canvaskit] Fix particles.setPosition and add test. 
Change-Id: I49043df9e8fdf9ac7f5b25164a1c577f3c569b94
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365478
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-03 15:52:23 +00:00
..
canvaskit Update all example particle data to new single-code-chunk format 2021-02-02 18:07:53 +00:00
fonts [canvaskit] Clean up embedded fonts 2019-10-09 14:51:39 +00:00
future_apis Add a future_apis folder to canvaskit. future_apis contains notes on 2020-06-17 18:17:25 +00:00
htmlcanvas [canvaskit] Remove filterquality on paint. 2020-12-11 20:27:27 +00:00
perf [canvaskit] Update Chrome version and use npm ci for tests 2020-12-14 15:03:42 +00:00
tests [canvaskit] Fix particles.setPosition and add test. 2021-02-03 15:52:23 +00:00
wasm_tools [canvaskit] Add unit tests to wasm_gm_tests 2020-11-02 16:51:23 +00:00
.gitignore [canvaskit] Update to 0.22.0 2020-12-17 15:10:15 +00:00
BUILD.gn Get CanvasKit viewer compiling again 2020-12-15 01:10:48 +00:00
canvaskit_bindings.cpp [canvaskit] Replace Postan value array with Float32Array. 2021-02-02 15:22:07 +00:00
catchExceptionNop.js JS files to support running jasmine tests in google3 2020-03-09 14:20:27 +00:00
CHANGELOG.md [canvaskit] Replace Postan value array with Float32Array. 2021-02-02 15:22:07 +00:00
color.js Reland "[canvaskit] Break up helper.js into smaller files" 2021-02-01 20:00:16 +00:00
compile_gm.sh [canvaskit] Skip particles gms 2021-01-29 19:17:08 +00:00
compile.sh [canvaskit] Move matrix helpers to their own file and make optional. 2021-02-01 20:01:07 +00:00
cpu.js [canvaskit] Revert raster change. 2020-11-12 14:49:47 +00:00
debug.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
externs.js [canvaskit] Replace Postan value array with Float32Array. 2021-02-02 15:22:07 +00:00
font.js [canvaskit] Replace Postan value array with Float32Array. 2021-02-02 15:22:07 +00:00
gm_bindings.cpp Fix most remaining wasm gm unit tests by correctly providing gl context 2021-01-21 20:46:19 +00:00
gm.js [canvaskit] Load resources into wasm gms/unit tests. 2020-10-21 20:40:29 +00:00
gpu.js [canvaskit] Fix bug if webgl context not available 2020-12-28 14:47:43 +00:00
helper.js Reland "[canvaskit] Break up helper.js into smaller files" 2021-02-01 20:00:16 +00:00
interface.js [canvaskit] Replace Postan value array with Float32Array. 2021-02-02 15:22:07 +00:00
karma.bench.conf.js [canvaskit] Update Chrome version and use npm ci for tests 2020-12-14 15:03:42 +00:00
karma.conf.js [canvaskit] Update Chrome version and use npm ci for tests 2020-12-14 15:03:42 +00:00
karma.google3.conf.js Fixes for canvaskit karma tests in google3 2020-09-23 14:51:27 +00:00
Makefile debug build for wasm gm tests 2021-01-08 16:46:49 +00:00
matrix.js [canvaskit] Move matrix helpers to their own file and make optional. 2021-02-01 20:01:07 +00:00
memory.js [canvaskit] Remove value_array for vector3 2021-02-02 15:22:07 +00:00
package-lock.json [canvaskit] Update npm dev dependencies 2020-12-14 15:03:24 +00:00
package.json [canvaskit] Update npm dev dependencies 2020-12-14 15:03:24 +00:00
paragraph_bindings.cpp [canvaskit] Properly expose getLineMetrics 2020-11-04 14:49:16 +00:00
paragraph.js [canvaskit] Remove 2d point arrays from API. 2020-12-07 11:09:49 +00:00
particles_bindings.cpp [canvaskit] Replace Point value_array with Float32Array 2021-02-02 15:22:07 +00:00
particles.js [canvaskit] Fix particles.setPosition and add test. 2021-02-03 15:52:23 +00:00
pathops.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
postamble.js
preamble.js
README.md [canvaskit] Make build docs more clear 2020-10-20 15:51:40 +00:00
release.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
rt_shader.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
serve.py
skottie_bindings.cpp [canvaskit] Replace Point value_array with Float32Array 2021-02-02 15:22:07 +00:00
skottie.js [canvaskit] Replace Point value_array with Float32Array 2021-02-02 15:22:07 +00:00
skp.js [canvaskit] Remove Sk from nearly all function/type names. 2020-10-07 21:01:32 +00:00
util.js Reland "[canvaskit] Break up helper.js into smaller files" 2021-02-01 20:00:16 +00:00
viewer_bindings.cpp Reland "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" 2020-10-06 18:59:11 +00:00
WasmCommon.h Pass 4f colors to private functions with float pointers 2020-05-05 13:17:28 +00:00

README.md

Prerequisites

To compile CanvasKit, you will first need to install emscripten. This will set the environment EMSDK (among others) which is required for compilation. Which version should you use? /infra/wasm-common/docker/emsdk-base/Dockerfile shows the version we build and test with. We try to keep this up-to-date.

This document also assumes you have followed the instructions to download Skia and its deps https://skia.org/user/download.

MacOS specific notes

Make sure you have Python3 installed, otherwise the downloading emscripten toolchain can fail with errors about SSL certificates. https://github.com/emscripten-core/emsdk/pull/273

See also https://github.com/emscripten-core/emscripten/issues/9036#issuecomment-532092743 for a solution to Python3 using the wrong certificates.

Compile and Run Local Example

make release  # make debug is much faster and has better error messages
make local-example

This will print a local endpoint for viewing the example. You can experiment with the CanvasKit API by modifying ./canvaskit/example.html and refreshing the page. For some more experimental APIs, there's also ./canvaskit/extra.html.

For other available build targets, see Makefile and compile.sh. For example, building a stripped-down version of CanvasKit with no text support or any of the "extras", one might run:

./compile.sh no_skottie no_particles no_font

Such a stripped-down version is about half the size of the default release build.

Unit tests, performance tests, and coverage.

To run unit tests and compute test coverage on a debug gpu build

make debug
make test-continuous

This reads karma.conf.js, and opens a chrome browser and begins running all the test in test/ it will detect changes to the tests in that directory and automatically run again, however it will automatically rebuild and reload canvaskit. Closing the chrome window will just cause it to re-opened. Kill the karma process to stop continuous monitoring for changes.

The tests are run with whichever build of canvaskit you last made. be sure to also test with release, debug_cpu, and release_cpu. testing with release builds will expose problems in closure compilation and usually forgotten externs.

Coverage

Coverage will be automatically computed when running test-continuous locally. Note that the results will only be useful when testing a debug build. Open coverage/<browser version>/index.html For a summary and detailed line-by-line result.

Measuring Performance

To measure the runtime of all benchmarks in perf/

make release
make perf

Performacnce benchmarks also use karma, with a different config karma.bench.conf.js. It will run once and print results.

Typically, you'd want to run these at head, and with your CL to observe the effect of some optimization.

Adding tests

The tests in tests/ and perf/ are grouped into files by topic. Within each file there are describe blocks further organizing the tests, and within those it() functions which test particular behaviors. describe and it are jasmine methods which can both be temporarily renamed fdescribe and fit. Which causes jasmine to only those.

We have also defined gm which is a method for defining a test which draws something to a canvas that is shapshotted and reported to gold.skia.org, where you can compare it with the snapshot at head.

Testing from Gerrit

When submitting a CL in gerrit, click "choose tryjobs" and type canvaskit to filter them. select all of them, which at the time of this writing is four jobs, for each combination of perf/test gpu/cpu.

The performance results are reported to perf.skia.org gold results are reported to gold.skia.org

Coverage is not measured while running tests this way.

Inspecting output WASM

The wasm2wat tool from the WebAssembly Binary Toolkit can be used to produce a human-readable text version of a .wasm file.

The output of wasm2wat --version should be 1.0.13 (1.0.17). This version has been checked to work with the tools in wasm_tools/SIMD/. These tools programmatically inspect the .wasm output of a CanvasKit build to detect the presence of wasm SIMD operations.

Infrastructure Playbook

When dealing with CanvasKit (or PathKit) on our bots, we use Docker. Check out $SKIA_ROOT/infra/wasm-common/docker/README.md for more on building/editing the images used for building and testing.

Updating the version of Emscripten we build/test with

This presumes you have updated emscripten locally to a newer version of the sdk and verified/fixed any build issues that have arisen.

  1. Edit $SKIA_ROOT/infra/wasm-common/docker/emsdk-base/Dockerfile to install and activate the desired version of Emscripten.
  2. Edit $SKIA_ROOT/infra/wasm-common/docker/Makefile to have EMSDK_VERSION be set to that desired version. If there is a suffix that is not _v1, reset it to be _v1. If testing the image later does not work and edits are made to the emsdk-base Dockerfile to correct that, increment to _v2,_v3, etc to force the bots to pick up the new image.
  3. In $SKIA_ROOT/infra/wasm-common/docker/, run make publish_emsdk_base
  4. Edit $SKIA_ROOT/infra/canvaskit/docker/canvaskit-emsdk/Dockerfile to be based off the new version from step 2. CanvasKit has its own docker image because it needs a few extra dependencies to build with font support.
  5. Edit $SKIA_ROOT/infra/canvaskit/docker/Makefile to have the same version from step 2. It's easiest to keep the emsdk-base and canvaskit-emsdk versions be in lock-step.
  6. In $SKIA_ROOT/infra/canvaskit/docker/, run make publish_canvaskit_emsdk.
  7. In $SKIA_ROOT/infra/bots/recipe_modules/build/, update canvaskit.py and pathkit.py to have DOCKER_IMAGE point to the desired tagged Docker containers from steps 2 and 5 (which should be the same).
  8. In $SKIA_ROOT/infra/bots/task_drivers/compile_wasm_gm_tests.go, update dockerImage to refer to the desired Docker containers from steps 2 and 5.
  9. In $SKIA_ROOT/infra/bots/, run make train to re-train the recipes.
  10. Optional: Run something like git grep 1\\.38\\. in $SKIA_ROOT to see if there are any other references that need updating.
  11. Upload a CL with all the changes. Run all Test.+CanvasKit, Perf.+CanvasKit, Test.+PathKit, Perf.+PathKit jobs to make sure the new builds pass all tests and don't crash the perf harnesses.
  12. Send out CL for review. Feel free to point the reviewer at these steps.