2014-08-08 07:04:07 +00:00
|
|
|
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file.
|
|
|
|
|
2014-10-01 08:34:25 +00:00
|
|
|
#include "test/unittests/compiler/instruction-selector-unittest.h"
|
2014-08-08 07:04:07 +00:00
|
|
|
|
2015-02-20 10:11:45 +00:00
|
|
|
#include "src/compiler/graph.h"
|
2015-02-25 16:37:49 +00:00
|
|
|
#include "src/compiler/schedule.h"
|
2014-08-14 06:33:50 +00:00
|
|
|
#include "src/flags.h"
|
2014-10-01 08:34:25 +00:00
|
|
|
#include "test/unittests/compiler/compiler-test-utils.h"
|
2014-08-14 06:33:50 +00:00
|
|
|
|
2014-08-08 07:04:07 +00:00
|
|
|
namespace v8 {
|
|
|
|
namespace internal {
|
|
|
|
namespace compiler {
|
|
|
|
|
2014-08-20 09:16:30 +00:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
typedef RawMachineAssembler::Label MLabel;
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
|
2014-08-14 06:33:50 +00:00
|
|
|
InstructionSelectorTest::InstructionSelectorTest() : rng_(FLAG_random_seed) {}
|
|
|
|
|
|
|
|
|
2014-09-04 08:44:03 +00:00
|
|
|
InstructionSelectorTest::~InstructionSelectorTest() {}
|
|
|
|
|
|
|
|
|
2014-08-08 07:04:07 +00:00
|
|
|
InstructionSelectorTest::Stream InstructionSelectorTest::StreamBuilder::Build(
|
|
|
|
InstructionSelector::Features features,
|
2015-04-30 09:56:24 +00:00
|
|
|
InstructionSelectorTest::StreamBuilderMode mode,
|
|
|
|
InstructionSelector::SourcePositionMode source_position_mode) {
|
2014-08-08 07:04:07 +00:00
|
|
|
Schedule* schedule = Export();
|
2014-08-14 06:33:50 +00:00
|
|
|
if (FLAG_trace_turbo) {
|
|
|
|
OFStream out(stdout);
|
2014-09-30 10:29:32 +00:00
|
|
|
out << "=== Schedule before instruction selection ===" << std::endl
|
|
|
|
<< *schedule;
|
2014-08-14 06:33:50 +00:00
|
|
|
}
|
2015-01-08 14:13:18 +00:00
|
|
|
size_t const node_count = graph()->NodeCount();
|
|
|
|
EXPECT_NE(0u, node_count);
|
2015-02-11 14:12:03 +00:00
|
|
|
Linkage linkage(call_descriptor());
|
2014-11-03 13:26:46 +00:00
|
|
|
InstructionBlocks* instruction_blocks =
|
|
|
|
InstructionSequence::InstructionBlocksFor(test_->zone(), schedule);
|
2015-01-23 15:19:34 +00:00
|
|
|
InstructionSequence sequence(test_->isolate(), test_->zone(),
|
|
|
|
instruction_blocks);
|
2014-08-08 07:04:07 +00:00
|
|
|
SourcePositionTable source_position_table(graph());
|
2015-01-08 14:13:18 +00:00
|
|
|
InstructionSelector selector(test_->zone(), node_count, &linkage, &sequence,
|
2015-04-30 09:56:24 +00:00
|
|
|
schedule, &source_position_table,
|
|
|
|
source_position_mode, features);
|
2014-08-08 07:04:07 +00:00
|
|
|
selector.SelectInstructions();
|
|
|
|
if (FLAG_trace_turbo) {
|
|
|
|
OFStream out(stdout);
|
2014-11-04 09:21:12 +00:00
|
|
|
PrintableInstructionSequence printable = {
|
|
|
|
RegisterConfiguration::ArchDefault(), &sequence};
|
2014-09-30 10:29:32 +00:00
|
|
|
out << "=== Code sequence after instruction selection ===" << std::endl
|
2014-11-04 09:21:12 +00:00
|
|
|
<< printable;
|
2014-08-08 07:04:07 +00:00
|
|
|
}
|
|
|
|
Stream s;
|
2015-01-08 14:13:18 +00:00
|
|
|
s.virtual_registers_ = selector.GetVirtualRegistersForTesting();
|
2014-10-06 14:30:55 +00:00
|
|
|
// Map virtual registers.
|
2015-01-08 14:13:18 +00:00
|
|
|
for (Instruction* const instr : sequence) {
|
2014-08-08 07:04:07 +00:00
|
|
|
if (instr->opcode() < 0) continue;
|
|
|
|
if (mode == kTargetInstructions) {
|
|
|
|
switch (instr->arch_opcode()) {
|
|
|
|
#define CASE(Name) \
|
|
|
|
case k##Name: \
|
|
|
|
break;
|
|
|
|
TARGET_ARCH_OPCODE_LIST(CASE)
|
|
|
|
#undef CASE
|
|
|
|
default:
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
2014-08-27 15:56:11 +00:00
|
|
|
if (mode == kAllExceptNopInstructions && instr->arch_opcode() == kArchNop) {
|
|
|
|
continue;
|
|
|
|
}
|
2014-08-08 07:04:07 +00:00
|
|
|
for (size_t i = 0; i < instr->OutputCount(); ++i) {
|
|
|
|
InstructionOperand* output = instr->OutputAt(i);
|
|
|
|
EXPECT_NE(InstructionOperand::IMMEDIATE, output->kind());
|
|
|
|
if (output->IsConstant()) {
|
2015-04-09 09:15:28 +00:00
|
|
|
int vreg = ConstantOperand::cast(output)->virtual_register();
|
|
|
|
s.constants_.insert(std::make_pair(vreg, sequence.GetConstant(vreg)));
|
2014-08-08 07:04:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
for (size_t i = 0; i < instr->InputCount(); ++i) {
|
|
|
|
InstructionOperand* input = instr->InputAt(i);
|
|
|
|
EXPECT_NE(InstructionOperand::CONSTANT, input->kind());
|
|
|
|
if (input->IsImmediate()) {
|
2015-04-09 14:06:19 +00:00
|
|
|
auto imm = ImmediateOperand::cast(input);
|
|
|
|
if (imm->type() == ImmediateOperand::INDEXED) {
|
|
|
|
int index = imm->indexed_value();
|
|
|
|
s.immediates_.insert(
|
|
|
|
std::make_pair(index, sequence.GetImmediate(imm)));
|
|
|
|
}
|
2014-08-08 07:04:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
s.instructions_.push_back(instr);
|
|
|
|
}
|
2015-01-08 14:13:18 +00:00
|
|
|
for (auto i : s.virtual_registers_) {
|
|
|
|
int const virtual_register = i.second;
|
2015-04-29 19:36:16 +00:00
|
|
|
if (sequence.IsFloat(virtual_register)) {
|
2014-08-20 09:16:30 +00:00
|
|
|
EXPECT_FALSE(sequence.IsReference(virtual_register));
|
|
|
|
s.doubles_.insert(virtual_register);
|
|
|
|
}
|
|
|
|
if (sequence.IsReference(virtual_register)) {
|
2015-04-29 19:36:16 +00:00
|
|
|
EXPECT_FALSE(sequence.IsFloat(virtual_register));
|
2014-08-20 09:16:30 +00:00
|
|
|
s.references_.insert(virtual_register);
|
|
|
|
}
|
|
|
|
}
|
2014-09-01 09:31:14 +00:00
|
|
|
for (int i = 0; i < sequence.GetFrameStateDescriptorCount(); i++) {
|
|
|
|
s.deoptimization_entries_.push_back(sequence.GetFrameStateDescriptor(
|
|
|
|
InstructionSequence::StateId::FromInt(i)));
|
2014-08-27 15:56:11 +00:00
|
|
|
}
|
2014-08-08 07:04:07 +00:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-06 14:30:55 +00:00
|
|
|
int InstructionSelectorTest::Stream::ToVreg(const Node* node) const {
|
|
|
|
VirtualRegisters::const_iterator i = virtual_registers_.find(node->id());
|
|
|
|
CHECK(i != virtual_registers_.end());
|
|
|
|
return i->second;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-24 09:36:40 +00:00
|
|
|
bool InstructionSelectorTest::Stream::IsFixed(const InstructionOperand* operand,
|
|
|
|
Register reg) const {
|
|
|
|
if (!operand->IsUnallocated()) return false;
|
|
|
|
const UnallocatedOperand* unallocated = UnallocatedOperand::cast(operand);
|
|
|
|
if (!unallocated->HasFixedRegisterPolicy()) return false;
|
2015-10-02 16:55:12 +00:00
|
|
|
return unallocated->fixed_register_index() == reg.code();
|
2014-10-24 09:36:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-31 06:41:07 +00:00
|
|
|
bool InstructionSelectorTest::Stream::IsSameAsFirst(
|
|
|
|
const InstructionOperand* operand) const {
|
|
|
|
if (!operand->IsUnallocated()) return false;
|
|
|
|
const UnallocatedOperand* unallocated = UnallocatedOperand::cast(operand);
|
|
|
|
return unallocated->HasSameAsInputPolicy();
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-24 09:36:40 +00:00
|
|
|
bool InstructionSelectorTest::Stream::IsUsedAtStart(
|
|
|
|
const InstructionOperand* operand) const {
|
|
|
|
if (!operand->IsUnallocated()) return false;
|
|
|
|
const UnallocatedOperand* unallocated = UnallocatedOperand::cast(operand);
|
|
|
|
return unallocated->IsUsedAtStart();
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-06-23 07:17:07 +00:00
|
|
|
const FrameStateFunctionInfo*
|
|
|
|
InstructionSelectorTest::StreamBuilder::GetFrameStateFunctionInfo(
|
|
|
|
int parameter_count, int local_count) {
|
|
|
|
return common()->CreateFrameStateFunctionInfo(
|
|
|
|
FrameStateType::kJavaScriptFunction, parameter_count, local_count,
|
[turbofan]: Add a context relaxation Reducer
In many cases, the context that TurboFan's ASTGraphBuilder or subsequent
reduction operations attaches to nodes does not need to be that exact
context, but rather only needs to be one with the same native context,
because it is used internally only to fetch the native context, e.g. for
creating and throwing exceptions.
This reducer recognizes common cases where the context that is specified
for a node can be relaxed to a canonical, less specific one. This
relaxed context can either be the enclosing function's context or a specific
Module or Script context that is explicitly created within the function.
This optimization is especially important for TurboFan-generated code stubs
which use context specialization and inlining to generate optimal code.
Without context relaxation, many extraneous moves are generated to pass
exactly the right context to internal functions like ToNumber and
AllocateHeapNumber, which only need the native context. By turning context
relaxation on, these moves disappear because all these common internal
context uses are unified to the context passed into the stub function, which
is typically already in the correct context register and remains there for
short stubs. It also eliminates the explicit use of a specialized context
constant in the code stub in these cases, which could cause memory leaks.
Review URL: https://codereview.chromium.org/1244583003
Cr-Commit-Position: refs/heads/master@{#29763}
2015-07-20 17:15:59 +00:00
|
|
|
Handle<SharedFunctionInfo>(), CALL_MAINTAINS_NATIVE_CONTEXT);
|
2015-06-23 07:17:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-20 04:01:00 +00:00
|
|
|
// -----------------------------------------------------------------------------
|
|
|
|
// Return.
|
|
|
|
|
|
|
|
|
2014-09-25 08:56:02 +00:00
|
|
|
TARGET_TEST_F(InstructionSelectorTest, ReturnFloat32Constant) {
|
|
|
|
const float kValue = 4.2f;
|
|
|
|
StreamBuilder m(this, kMachFloat32);
|
|
|
|
m.Return(m.Float32Constant(kValue));
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2015-01-15 09:05:52 +00:00
|
|
|
ASSERT_EQ(3U, s.size());
|
2014-09-25 08:56:02 +00:00
|
|
|
EXPECT_EQ(kArchNop, s[0]->arch_opcode());
|
|
|
|
ASSERT_EQ(InstructionOperand::CONSTANT, s[0]->OutputAt(0)->kind());
|
|
|
|
EXPECT_FLOAT_EQ(kValue, s.ToFloat32(s[0]->OutputAt(0)));
|
|
|
|
EXPECT_EQ(kArchRet, s[1]->arch_opcode());
|
|
|
|
EXPECT_EQ(1U, s[1]->InputCount());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-14 06:33:50 +00:00
|
|
|
TARGET_TEST_F(InstructionSelectorTest, ReturnParameter) {
|
2014-08-14 09:19:54 +00:00
|
|
|
StreamBuilder m(this, kMachInt32, kMachInt32);
|
2014-08-08 07:04:07 +00:00
|
|
|
m.Return(m.Parameter(0));
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2015-01-15 09:05:52 +00:00
|
|
|
ASSERT_EQ(3U, s.size());
|
2014-08-08 07:04:07 +00:00
|
|
|
EXPECT_EQ(kArchNop, s[0]->arch_opcode());
|
|
|
|
ASSERT_EQ(1U, s[0]->OutputCount());
|
|
|
|
EXPECT_EQ(kArchRet, s[1]->arch_opcode());
|
|
|
|
EXPECT_EQ(1U, s[1]->InputCount());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-14 06:33:50 +00:00
|
|
|
TARGET_TEST_F(InstructionSelectorTest, ReturnZero) {
|
2014-08-14 09:19:54 +00:00
|
|
|
StreamBuilder m(this, kMachInt32);
|
2014-08-08 07:04:07 +00:00
|
|
|
m.Return(m.Int32Constant(0));
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2015-01-15 09:05:52 +00:00
|
|
|
ASSERT_EQ(3U, s.size());
|
2014-08-08 07:04:07 +00:00
|
|
|
EXPECT_EQ(kArchNop, s[0]->arch_opcode());
|
|
|
|
ASSERT_EQ(1U, s[0]->OutputCount());
|
|
|
|
EXPECT_EQ(InstructionOperand::CONSTANT, s[0]->OutputAt(0)->kind());
|
|
|
|
EXPECT_EQ(0, s.ToInt32(s[0]->OutputAt(0)));
|
|
|
|
EXPECT_EQ(kArchRet, s[1]->arch_opcode());
|
|
|
|
EXPECT_EQ(1U, s[1]->InputCount());
|
|
|
|
}
|
|
|
|
|
2014-08-20 04:01:00 +00:00
|
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
|
|
|
// Conversions.
|
|
|
|
|
|
|
|
|
|
|
|
TARGET_TEST_F(InstructionSelectorTest, TruncateFloat64ToInt32WithParameter) {
|
|
|
|
StreamBuilder m(this, kMachInt32, kMachFloat64);
|
2015-07-08 06:48:52 +00:00
|
|
|
m.Return(
|
|
|
|
m.TruncateFloat64ToInt32(TruncationMode::kJavaScript, m.Parameter(0)));
|
2014-08-20 04:01:00 +00:00
|
|
|
Stream s = m.Build(kAllInstructions);
|
2015-01-15 09:05:52 +00:00
|
|
|
ASSERT_EQ(4U, s.size());
|
2014-08-20 04:01:00 +00:00
|
|
|
EXPECT_EQ(kArchNop, s[0]->arch_opcode());
|
|
|
|
EXPECT_EQ(kArchTruncateDoubleToI, s[1]->arch_opcode());
|
|
|
|
EXPECT_EQ(1U, s[1]->InputCount());
|
|
|
|
EXPECT_EQ(1U, s[1]->OutputCount());
|
|
|
|
EXPECT_EQ(kArchRet, s[2]->arch_opcode());
|
|
|
|
}
|
|
|
|
|
2014-08-20 09:16:30 +00:00
|
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
|
|
|
// Parameters.
|
|
|
|
|
|
|
|
|
|
|
|
TARGET_TEST_F(InstructionSelectorTest, DoubleParameter) {
|
|
|
|
StreamBuilder m(this, kMachFloat64, kMachFloat64);
|
|
|
|
Node* param = m.Parameter(0);
|
|
|
|
m.Return(param);
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_TRUE(s.IsDouble(param));
|
2014-08-20 09:16:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
TARGET_TEST_F(InstructionSelectorTest, ReferenceParameter) {
|
|
|
|
StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged);
|
|
|
|
Node* param = m.Parameter(0);
|
|
|
|
m.Return(param);
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_TRUE(s.IsReference(param));
|
2014-08-20 09:16:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
2015-10-14 14:53:04 +00:00
|
|
|
// FinishRegion.
|
2014-08-20 09:16:30 +00:00
|
|
|
|
|
|
|
|
2015-10-14 14:53:04 +00:00
|
|
|
TARGET_TEST_F(InstructionSelectorTest, FinishRegion) {
|
2014-09-03 08:49:21 +00:00
|
|
|
StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged);
|
2014-08-20 09:16:30 +00:00
|
|
|
Node* param = m.Parameter(0);
|
2015-10-14 14:53:04 +00:00
|
|
|
Node* finish =
|
|
|
|
m.AddNode(m.common()->FinishRegion(), param, m.graph()->start());
|
2014-08-20 09:16:30 +00:00
|
|
|
m.Return(finish);
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2015-01-15 09:05:52 +00:00
|
|
|
ASSERT_EQ(4U, s.size());
|
2014-08-20 09:16:30 +00:00
|
|
|
EXPECT_EQ(kArchNop, s[0]->arch_opcode());
|
|
|
|
ASSERT_EQ(1U, s[0]->OutputCount());
|
|
|
|
ASSERT_TRUE(s[0]->Output()->IsUnallocated());
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(param), s.ToVreg(s[0]->Output()));
|
2014-08-20 09:16:30 +00:00
|
|
|
EXPECT_EQ(kArchNop, s[1]->arch_opcode());
|
|
|
|
ASSERT_EQ(1U, s[1]->InputCount());
|
|
|
|
ASSERT_TRUE(s[1]->InputAt(0)->IsUnallocated());
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(param), s.ToVreg(s[1]->InputAt(0)));
|
2014-08-20 09:16:30 +00:00
|
|
|
ASSERT_EQ(1U, s[1]->OutputCount());
|
|
|
|
ASSERT_TRUE(s[1]->Output()->IsUnallocated());
|
|
|
|
EXPECT_TRUE(UnallocatedOperand::cast(s[1]->Output())->HasSameAsInputPolicy());
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(finish), s.ToVreg(s[1]->Output()));
|
|
|
|
EXPECT_TRUE(s.IsReference(finish));
|
2014-08-20 09:16:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
2014-09-03 08:49:21 +00:00
|
|
|
// Phi.
|
2014-08-20 09:16:30 +00:00
|
|
|
|
|
|
|
|
|
|
|
typedef InstructionSelectorTestWithParam<MachineType>
|
|
|
|
InstructionSelectorPhiTest;
|
|
|
|
|
|
|
|
|
2014-09-05 11:44:31 +00:00
|
|
|
TARGET_TEST_P(InstructionSelectorPhiTest, Doubleness) {
|
2014-08-20 09:16:30 +00:00
|
|
|
const MachineType type = GetParam();
|
|
|
|
StreamBuilder m(this, type, type, type);
|
|
|
|
Node* param0 = m.Parameter(0);
|
|
|
|
Node* param1 = m.Parameter(1);
|
|
|
|
MLabel a, b, c;
|
|
|
|
m.Branch(m.Int32Constant(0), &a, &b);
|
|
|
|
m.Bind(&a);
|
|
|
|
m.Goto(&c);
|
|
|
|
m.Bind(&b);
|
|
|
|
m.Goto(&c);
|
|
|
|
m.Bind(&c);
|
2014-09-05 11:44:31 +00:00
|
|
|
Node* phi = m.Phi(type, param0, param1);
|
2014-08-20 09:16:30 +00:00
|
|
|
m.Return(phi);
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_EQ(s.IsDouble(phi), s.IsDouble(param0));
|
|
|
|
EXPECT_EQ(s.IsDouble(phi), s.IsDouble(param1));
|
2014-08-20 09:16:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-09-05 11:44:31 +00:00
|
|
|
TARGET_TEST_P(InstructionSelectorPhiTest, Referenceness) {
|
2014-08-20 09:16:30 +00:00
|
|
|
const MachineType type = GetParam();
|
|
|
|
StreamBuilder m(this, type, type, type);
|
|
|
|
Node* param0 = m.Parameter(0);
|
|
|
|
Node* param1 = m.Parameter(1);
|
|
|
|
MLabel a, b, c;
|
|
|
|
m.Branch(m.Int32Constant(1), &a, &b);
|
|
|
|
m.Bind(&a);
|
|
|
|
m.Goto(&c);
|
|
|
|
m.Bind(&b);
|
|
|
|
m.Goto(&c);
|
|
|
|
m.Bind(&c);
|
2014-09-05 11:44:31 +00:00
|
|
|
Node* phi = m.Phi(type, param0, param1);
|
2014-08-20 09:16:30 +00:00
|
|
|
m.Return(phi);
|
|
|
|
Stream s = m.Build(kAllInstructions);
|
2014-10-06 14:30:55 +00:00
|
|
|
EXPECT_EQ(s.IsReference(phi), s.IsReference(param0));
|
|
|
|
EXPECT_EQ(s.IsReference(phi), s.IsReference(param1));
|
2014-08-20 09:16:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
INSTANTIATE_TEST_CASE_P(InstructionSelectorTest, InstructionSelectorPhiTest,
|
|
|
|
::testing::Values(kMachFloat64, kMachInt8, kMachUint8,
|
|
|
|
kMachInt16, kMachUint16, kMachInt32,
|
|
|
|
kMachUint32, kMachInt64, kMachUint64,
|
|
|
|
kMachPtr, kMachAnyTagged));
|
|
|
|
|
|
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
|
|
|
// ValueEffect.
|
|
|
|
|
|
|
|
|
|
|
|
TARGET_TEST_F(InstructionSelectorTest, ValueEffect) {
|
|
|
|
StreamBuilder m1(this, kMachInt32, kMachPtr);
|
|
|
|
Node* p1 = m1.Parameter(0);
|
|
|
|
m1.Return(m1.Load(kMachInt32, p1, m1.Int32Constant(0)));
|
|
|
|
Stream s1 = m1.Build(kAllInstructions);
|
|
|
|
StreamBuilder m2(this, kMachInt32, kMachPtr);
|
|
|
|
Node* p2 = m2.Parameter(0);
|
2015-10-14 14:53:04 +00:00
|
|
|
m2.Return(
|
|
|
|
m2.AddNode(m2.machine()->Load(kMachInt32), p2, m2.Int32Constant(0),
|
|
|
|
m2.AddNode(m2.common()->BeginRegion(), m2.graph()->start())));
|
2014-08-20 09:16:30 +00:00
|
|
|
Stream s2 = m2.Build(kAllInstructions);
|
|
|
|
EXPECT_LE(3U, s1.size());
|
|
|
|
ASSERT_EQ(s1.size(), s2.size());
|
|
|
|
TRACED_FORRANGE(size_t, i, 0, s1.size() - 1) {
|
|
|
|
const Instruction* i1 = s1[i];
|
|
|
|
const Instruction* i2 = s2[i];
|
|
|
|
EXPECT_EQ(i1->arch_opcode(), i2->arch_opcode());
|
|
|
|
EXPECT_EQ(i1->InputCount(), i2->InputCount());
|
|
|
|
EXPECT_EQ(i1->OutputCount(), i2->OutputCount());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
|
|
|
// Calls with deoptimization.
|
2014-09-25 08:56:02 +00:00
|
|
|
|
|
|
|
|
2014-08-28 11:06:26 +00:00
|
|
|
TARGET_TEST_F(InstructionSelectorTest, CallJSFunctionWithDeopt) {
|
2014-09-03 10:13:21 +00:00
|
|
|
StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged, kMachAnyTagged,
|
|
|
|
kMachAnyTagged);
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
BailoutId bailout_id(42);
|
|
|
|
|
|
|
|
Node* function_node = m.Parameter(0);
|
|
|
|
Node* receiver = m.Parameter(1);
|
2014-09-03 10:13:21 +00:00
|
|
|
Node* context = m.Parameter(2);
|
2014-08-27 15:56:11 +00:00
|
|
|
|
2015-03-19 14:00:28 +00:00
|
|
|
ZoneVector<MachineType> int32_type(1, kMachInt32, zone());
|
|
|
|
ZoneVector<MachineType> empty_types(zone());
|
|
|
|
|
2015-08-25 11:31:09 +00:00
|
|
|
CallDescriptor* descriptor = Linkage::GetJSCallDescriptor(
|
|
|
|
zone(), false, 1, CallDescriptor::kNeedsFrameState);
|
|
|
|
|
2015-03-19 14:00:28 +00:00
|
|
|
Node* parameters =
|
2015-09-23 09:08:15 +00:00
|
|
|
m.AddNode(m.common()->TypedStateValues(&int32_type), m.Int32Constant(1));
|
|
|
|
Node* locals = m.AddNode(m.common()->TypedStateValues(&empty_types));
|
|
|
|
Node* stack = m.AddNode(m.common()->TypedStateValues(&empty_types));
|
2014-09-01 09:31:14 +00:00
|
|
|
Node* context_dummy = m.Int32Constant(0);
|
2014-08-27 15:56:11 +00:00
|
|
|
|
2015-09-23 09:08:15 +00:00
|
|
|
Node* state_node = m.AddNode(
|
2015-06-23 07:17:07 +00:00
|
|
|
m.common()->FrameState(bailout_id, OutputFrameStateCombine::Push(),
|
|
|
|
m.GetFrameStateFunctionInfo(1, 0)),
|
|
|
|
parameters, locals, stack, context_dummy, function_node,
|
|
|
|
m.UndefinedConstant());
|
2015-08-25 11:31:09 +00:00
|
|
|
Node* args[] = {receiver, context};
|
|
|
|
Node* call =
|
|
|
|
m.CallNWithFrameState(descriptor, function_node, args, state_node);
|
2014-09-01 09:31:14 +00:00
|
|
|
m.Return(call);
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
Stream s = m.Build(kAllExceptNopInstructions);
|
|
|
|
|
|
|
|
// Skip until kArchCallJSFunction.
|
|
|
|
size_t index = 0;
|
|
|
|
for (; index < s.size() && s[index]->arch_opcode() != kArchCallJSFunction;
|
|
|
|
index++) {
|
|
|
|
}
|
2014-09-01 09:31:14 +00:00
|
|
|
// Now we should have two instructions: call and return.
|
|
|
|
ASSERT_EQ(index + 2, s.size());
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
EXPECT_EQ(kArchCallJSFunction, s[index++]->arch_opcode());
|
|
|
|
EXPECT_EQ(kArchRet, s[index++]->arch_opcode());
|
2014-09-01 09:31:14 +00:00
|
|
|
|
|
|
|
// TODO(jarin) Check deoptimization table.
|
2014-08-27 15:56:11 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-28 11:06:26 +00:00
|
|
|
TARGET_TEST_F(InstructionSelectorTest, CallFunctionStubWithDeopt) {
|
2014-08-27 15:56:11 +00:00
|
|
|
StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged, kMachAnyTagged,
|
|
|
|
kMachAnyTagged);
|
|
|
|
|
|
|
|
BailoutId bailout_id_before(42);
|
|
|
|
|
|
|
|
// Some arguments for the call node.
|
|
|
|
Node* function_node = m.Parameter(0);
|
|
|
|
Node* receiver = m.Parameter(1);
|
|
|
|
Node* context = m.Int32Constant(1); // Context is ignored.
|
|
|
|
|
2015-03-19 14:00:28 +00:00
|
|
|
ZoneVector<MachineType> int32_type(1, kMachInt32, zone());
|
|
|
|
ZoneVector<MachineType> float64_type(1, kMachFloat64, zone());
|
|
|
|
ZoneVector<MachineType> tagged_type(1, kMachAnyTagged, zone());
|
|
|
|
|
2014-08-27 15:56:11 +00:00
|
|
|
// Build frame state for the state before the call.
|
2015-03-19 14:00:28 +00:00
|
|
|
Node* parameters =
|
2015-09-23 09:08:15 +00:00
|
|
|
m.AddNode(m.common()->TypedStateValues(&int32_type), m.Int32Constant(43));
|
|
|
|
Node* locals = m.AddNode(m.common()->TypedStateValues(&float64_type),
|
2015-03-19 14:00:28 +00:00
|
|
|
m.Float64Constant(0.5));
|
2015-09-23 09:08:15 +00:00
|
|
|
Node* stack = m.AddNode(m.common()->TypedStateValues(&tagged_type),
|
2015-03-19 14:00:28 +00:00
|
|
|
m.UndefinedConstant());
|
2014-09-03 14:10:20 +00:00
|
|
|
|
2014-09-01 09:31:14 +00:00
|
|
|
Node* context_sentinel = m.Int32Constant(0);
|
2015-09-23 09:08:15 +00:00
|
|
|
Node* frame_state_before = m.AddNode(
|
2015-06-23 07:17:07 +00:00
|
|
|
m.common()->FrameState(bailout_id_before, OutputFrameStateCombine::Push(),
|
|
|
|
m.GetFrameStateFunctionInfo(1, 1)),
|
|
|
|
parameters, locals, stack, context_sentinel, function_node,
|
|
|
|
m.UndefinedConstant());
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
// Build the call.
|
2014-09-01 09:31:14 +00:00
|
|
|
Node* call = m.CallFunctionStub0(function_node, receiver, context,
|
|
|
|
frame_state_before, CALL_AS_METHOD);
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
m.Return(call);
|
|
|
|
|
|
|
|
Stream s = m.Build(kAllExceptNopInstructions);
|
|
|
|
|
|
|
|
// Skip until kArchCallJSFunction.
|
|
|
|
size_t index = 0;
|
|
|
|
for (; index < s.size() && s[index]->arch_opcode() != kArchCallCodeObject;
|
|
|
|
index++) {
|
|
|
|
}
|
2014-09-01 09:31:14 +00:00
|
|
|
// Now we should have two instructions: call, return.
|
|
|
|
ASSERT_EQ(index + 2, s.size());
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
// Check the call instruction
|
|
|
|
const Instruction* call_instr = s[index++];
|
|
|
|
EXPECT_EQ(kArchCallCodeObject, call_instr->arch_opcode());
|
|
|
|
size_t num_operands =
|
|
|
|
1 + // Code object.
|
|
|
|
1 +
|
2015-05-15 12:17:15 +00:00
|
|
|
5 + // Frame state deopt id + one input for each value in frame state.
|
2014-08-27 15:56:11 +00:00
|
|
|
1 + // Function.
|
2014-09-01 09:31:14 +00:00
|
|
|
1; // Context.
|
2014-08-27 15:56:11 +00:00
|
|
|
ASSERT_EQ(num_operands, call_instr->InputCount());
|
|
|
|
|
|
|
|
// Code object.
|
|
|
|
EXPECT_TRUE(call_instr->InputAt(0)->IsImmediate());
|
|
|
|
|
|
|
|
// Deoptimization id.
|
|
|
|
int32_t deopt_id_before = s.ToInt32(call_instr->InputAt(1));
|
2014-09-01 09:31:14 +00:00
|
|
|
FrameStateDescriptor* desc_before =
|
|
|
|
s.GetFrameStateDescriptor(deopt_id_before);
|
2014-08-27 15:56:11 +00:00
|
|
|
EXPECT_EQ(bailout_id_before, desc_before->bailout_id());
|
2014-09-29 13:37:58 +00:00
|
|
|
EXPECT_EQ(OutputFrameStateCombine::kPushOutput,
|
|
|
|
desc_before->state_combine().kind());
|
2014-09-18 08:56:52 +00:00
|
|
|
EXPECT_EQ(1u, desc_before->parameters_count());
|
|
|
|
EXPECT_EQ(1u, desc_before->locals_count());
|
|
|
|
EXPECT_EQ(1u, desc_before->stack_count());
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(43, s.ToInt32(call_instr->InputAt(3)));
|
|
|
|
EXPECT_EQ(0, s.ToInt32(call_instr->InputAt(4))); // This should be a context.
|
2014-10-08 08:47:29 +00:00
|
|
|
// We inserted 0 here.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(0.5, s.ToFloat64(call_instr->InputAt(5)));
|
|
|
|
EXPECT_TRUE(s.ToHeapObject(call_instr->InputAt(6))->IsUndefined());
|
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before->GetType(0)); // function is always
|
|
|
|
// tagged/any.
|
|
|
|
EXPECT_EQ(kMachInt32, desc_before->GetType(1));
|
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before->GetType(2)); // context is always
|
2014-10-08 08:47:29 +00:00
|
|
|
// tagged/any.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(kMachFloat64, desc_before->GetType(3));
|
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before->GetType(4));
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
// Function.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(function_node), s.ToVreg(call_instr->InputAt(7)));
|
2014-08-27 15:56:11 +00:00
|
|
|
// Context.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(context), s.ToVreg(call_instr->InputAt(8)));
|
2014-08-27 15:56:11 +00:00
|
|
|
|
|
|
|
EXPECT_EQ(kArchRet, s[index++]->arch_opcode());
|
|
|
|
|
|
|
|
EXPECT_EQ(index, s.size());
|
|
|
|
}
|
|
|
|
|
2014-09-03 14:10:20 +00:00
|
|
|
|
|
|
|
TARGET_TEST_F(InstructionSelectorTest,
|
|
|
|
CallFunctionStubDeoptRecursiveFrameState) {
|
|
|
|
StreamBuilder m(this, kMachAnyTagged, kMachAnyTagged, kMachAnyTagged,
|
|
|
|
kMachAnyTagged);
|
|
|
|
|
|
|
|
BailoutId bailout_id_before(42);
|
|
|
|
BailoutId bailout_id_parent(62);
|
|
|
|
|
|
|
|
// Some arguments for the call node.
|
|
|
|
Node* function_node = m.Parameter(0);
|
|
|
|
Node* receiver = m.Parameter(1);
|
|
|
|
Node* context = m.Int32Constant(66);
|
|
|
|
|
2015-03-19 14:00:28 +00:00
|
|
|
ZoneVector<MachineType> int32_type(1, kMachInt32, zone());
|
|
|
|
ZoneVector<MachineType> int32x2_type(2, kMachInt32, zone());
|
|
|
|
ZoneVector<MachineType> float64_type(1, kMachFloat64, zone());
|
|
|
|
|
2014-09-03 14:10:20 +00:00
|
|
|
// Build frame state for the state before the call.
|
2015-03-19 14:00:28 +00:00
|
|
|
Node* parameters =
|
2015-09-23 09:08:15 +00:00
|
|
|
m.AddNode(m.common()->TypedStateValues(&int32_type), m.Int32Constant(63));
|
2015-03-19 14:00:28 +00:00
|
|
|
Node* locals =
|
2015-09-23 09:08:15 +00:00
|
|
|
m.AddNode(m.common()->TypedStateValues(&int32_type), m.Int32Constant(64));
|
2015-03-19 14:00:28 +00:00
|
|
|
Node* stack =
|
2015-09-23 09:08:15 +00:00
|
|
|
m.AddNode(m.common()->TypedStateValues(&int32_type), m.Int32Constant(65));
|
|
|
|
Node* frame_state_parent = m.AddNode(
|
2015-06-23 07:17:07 +00:00
|
|
|
m.common()->FrameState(bailout_id_parent,
|
|
|
|
OutputFrameStateCombine::Ignore(),
|
|
|
|
m.GetFrameStateFunctionInfo(1, 1)),
|
2015-05-15 12:17:15 +00:00
|
|
|
parameters, locals, stack, context, function_node, m.UndefinedConstant());
|
2014-09-03 14:10:20 +00:00
|
|
|
|
|
|
|
Node* context2 = m.Int32Constant(46);
|
|
|
|
Node* parameters2 =
|
2015-09-23 09:08:15 +00:00
|
|
|
m.AddNode(m.common()->TypedStateValues(&int32_type), m.Int32Constant(43));
|
|
|
|
Node* locals2 = m.AddNode(m.common()->TypedStateValues(&float64_type),
|
2015-03-19 14:00:28 +00:00
|
|
|
m.Float64Constant(0.25));
|
2015-09-23 09:08:15 +00:00
|
|
|
Node* stack2 = m.AddNode(m.common()->TypedStateValues(&int32x2_type),
|
2015-03-19 14:00:28 +00:00
|
|
|
m.Int32Constant(44), m.Int32Constant(45));
|
2015-09-23 09:08:15 +00:00
|
|
|
Node* frame_state_before = m.AddNode(
|
2015-06-23 07:17:07 +00:00
|
|
|
m.common()->FrameState(bailout_id_before, OutputFrameStateCombine::Push(),
|
|
|
|
m.GetFrameStateFunctionInfo(1, 1)),
|
|
|
|
parameters2, locals2, stack2, context2, function_node,
|
|
|
|
frame_state_parent);
|
2014-09-03 14:10:20 +00:00
|
|
|
|
|
|
|
// Build the call.
|
|
|
|
Node* call = m.CallFunctionStub0(function_node, receiver, context2,
|
|
|
|
frame_state_before, CALL_AS_METHOD);
|
|
|
|
|
|
|
|
m.Return(call);
|
|
|
|
|
|
|
|
Stream s = m.Build(kAllExceptNopInstructions);
|
|
|
|
|
|
|
|
// Skip until kArchCallJSFunction.
|
|
|
|
size_t index = 0;
|
|
|
|
for (; index < s.size() && s[index]->arch_opcode() != kArchCallCodeObject;
|
|
|
|
index++) {
|
|
|
|
}
|
|
|
|
// Now we should have three instructions: call, return.
|
|
|
|
EXPECT_EQ(index + 2, s.size());
|
|
|
|
|
|
|
|
// Check the call instruction
|
|
|
|
const Instruction* call_instr = s[index++];
|
|
|
|
EXPECT_EQ(kArchCallCodeObject, call_instr->arch_opcode());
|
|
|
|
size_t num_operands =
|
|
|
|
1 + // Code object.
|
|
|
|
1 + // Frame state deopt id
|
2015-05-15 12:17:15 +00:00
|
|
|
6 + // One input for each value in frame state + context.
|
|
|
|
5 + // One input for each value in the parent frame state + context.
|
2014-09-03 14:10:20 +00:00
|
|
|
1 + // Function.
|
|
|
|
1; // Context.
|
|
|
|
EXPECT_EQ(num_operands, call_instr->InputCount());
|
|
|
|
// Code object.
|
|
|
|
EXPECT_TRUE(call_instr->InputAt(0)->IsImmediate());
|
|
|
|
|
|
|
|
// Deoptimization id.
|
|
|
|
int32_t deopt_id_before = s.ToInt32(call_instr->InputAt(1));
|
|
|
|
FrameStateDescriptor* desc_before =
|
|
|
|
s.GetFrameStateDescriptor(deopt_id_before);
|
2014-10-08 08:47:29 +00:00
|
|
|
FrameStateDescriptor* desc_before_outer = desc_before->outer_state();
|
2014-09-03 14:10:20 +00:00
|
|
|
EXPECT_EQ(bailout_id_before, desc_before->bailout_id());
|
2014-10-08 08:47:29 +00:00
|
|
|
EXPECT_EQ(1u, desc_before_outer->parameters_count());
|
|
|
|
EXPECT_EQ(1u, desc_before_outer->locals_count());
|
|
|
|
EXPECT_EQ(1u, desc_before_outer->stack_count());
|
|
|
|
// Values from parent environment.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before->GetType(0));
|
|
|
|
EXPECT_EQ(63, s.ToInt32(call_instr->InputAt(3)));
|
|
|
|
EXPECT_EQ(kMachInt32, desc_before_outer->GetType(1));
|
2014-09-03 14:10:20 +00:00
|
|
|
// Context:
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(66, s.ToInt32(call_instr->InputAt(4)));
|
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before_outer->GetType(2));
|
|
|
|
EXPECT_EQ(64, s.ToInt32(call_instr->InputAt(5)));
|
2014-10-08 08:47:29 +00:00
|
|
|
EXPECT_EQ(kMachInt32, desc_before_outer->GetType(3));
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(65, s.ToInt32(call_instr->InputAt(6)));
|
|
|
|
EXPECT_EQ(kMachInt32, desc_before_outer->GetType(4));
|
2014-10-08 08:47:29 +00:00
|
|
|
// Values from the nested frame.
|
|
|
|
EXPECT_EQ(1u, desc_before->parameters_count());
|
|
|
|
EXPECT_EQ(1u, desc_before->locals_count());
|
|
|
|
EXPECT_EQ(2u, desc_before->stack_count());
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before->GetType(0));
|
|
|
|
EXPECT_EQ(43, s.ToInt32(call_instr->InputAt(8)));
|
|
|
|
EXPECT_EQ(kMachInt32, desc_before->GetType(1));
|
|
|
|
EXPECT_EQ(46, s.ToInt32(call_instr->InputAt(9)));
|
|
|
|
EXPECT_EQ(kMachAnyTagged, desc_before->GetType(2));
|
|
|
|
EXPECT_EQ(0.25, s.ToFloat64(call_instr->InputAt(10)));
|
|
|
|
EXPECT_EQ(kMachFloat64, desc_before->GetType(3));
|
|
|
|
EXPECT_EQ(44, s.ToInt32(call_instr->InputAt(11)));
|
2014-10-08 08:47:29 +00:00
|
|
|
EXPECT_EQ(kMachInt32, desc_before->GetType(4));
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(45, s.ToInt32(call_instr->InputAt(12)));
|
|
|
|
EXPECT_EQ(kMachInt32, desc_before->GetType(5));
|
2014-09-03 14:10:20 +00:00
|
|
|
|
|
|
|
// Function.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(function_node), s.ToVreg(call_instr->InputAt(13)));
|
2014-09-03 14:10:20 +00:00
|
|
|
// Context.
|
2015-05-15 12:17:15 +00:00
|
|
|
EXPECT_EQ(s.ToVreg(context2), s.ToVreg(call_instr->InputAt(14)));
|
2014-09-03 14:10:20 +00:00
|
|
|
// Continuation.
|
|
|
|
|
|
|
|
EXPECT_EQ(kArchRet, s[index++]->arch_opcode());
|
|
|
|
EXPECT_EQ(index, s.size());
|
|
|
|
}
|
|
|
|
|
2014-08-08 07:04:07 +00:00
|
|
|
} // namespace compiler
|
|
|
|
} // namespace internal
|
|
|
|
} // namespace v8
|