Removed IsTransitionType predicate.
With the upcoming changes to CALLBACKS properties, a predicate on the transition
type alone doesn't make sense anymore: For CALLBACKS one has to look into the
property's value to decide, and there is even the possibility of having a an
accessor function *and* a transition in the same property.
I am not completely happy with some parts of this CL, because they contain
redundant code, but given the various representations we currently have for
property type/value pairs, I can see no easy way around that. Perhaps one can
improve this a bit in a different CL, the current diversity really, really hurts
productivity...
As a bonus, this CL includes a few minor things:
* CaseClause::RecordTypeFeedback has been cleaned up and it handles the
NULL_DESCRIPTOR case correctly now. Under some (very unlikely) circumstances,
we previously missed some opportunities for monomorphic calls. In general, it
is rather unfortunate that NULL_DESCRIPTOR "shines through", it is just a
hack for the inability to remove a descriptor entry during GC, something
callers shouldn't have to be aware of.
* DescriptorArray::CopyInsert has been cleaned up a bit, preparing it for later
CALLBACKS-related changes.
* LookupResult::Print is now more informative for CONSTANT_TRANSITION.
Review URL: https://chromiumcodereview.appspot.com/9320066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-02-03 13:37:13 +00:00
|
|
|
// Copyright 2012 the V8 project authors. All rights reserved.
|
2008-07-03 15:10:15 +00:00
|
|
|
// Redistribution and use in source and binary forms, with or without
|
|
|
|
// modification, are permitted provided that the following conditions are
|
|
|
|
// met:
|
|
|
|
//
|
|
|
|
// * Redistributions of source code must retain the above copyright
|
|
|
|
// notice, this list of conditions and the following disclaimer.
|
|
|
|
// * Redistributions in binary form must reproduce the above
|
|
|
|
// copyright notice, this list of conditions and the following
|
|
|
|
// disclaimer in the documentation and/or other materials provided
|
|
|
|
// with the distribution.
|
|
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
|
|
// contributors may be used to endorse or promote products derived
|
|
|
|
// from this software without specific prior written permission.
|
|
|
|
//
|
|
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
|
|
#include "v8.h"
|
|
|
|
|
2009-05-25 10:05:56 +00:00
|
|
|
namespace v8 {
|
|
|
|
namespace internal {
|
2008-07-03 15:10:15 +00:00
|
|
|
|
|
|
|
|
2011-10-18 11:18:55 +00:00
|
|
|
void LookupResult::Iterate(ObjectVisitor* visitor) {
|
|
|
|
LookupResult* current = this; // Could be NULL.
|
|
|
|
while (current != NULL) {
|
|
|
|
visitor->VisitPointer(BitCast<Object**>(¤t->holder_));
|
|
|
|
current = current->next_;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2010-12-20 10:38:19 +00:00
|
|
|
#ifdef OBJECT_PRINT
|
|
|
|
void LookupResult::Print(FILE* out) {
|
2010-02-18 15:10:35 +00:00
|
|
|
if (!IsFound()) {
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, "Not Found\n");
|
2008-07-03 15:10:15 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, "LookupResult:\n");
|
|
|
|
PrintF(out, " -cacheable = %s\n", IsCacheable() ? "true" : "false");
|
|
|
|
PrintF(out, " -attributes = %x\n", GetAttributes());
|
2008-07-03 15:10:15 +00:00
|
|
|
switch (type()) {
|
|
|
|
case NORMAL:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = normal\n");
|
|
|
|
PrintF(out, " -entry = %d", GetDictionaryEntry());
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
|
|
|
case MAP_TRANSITION:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = map transition\n");
|
|
|
|
PrintF(out, " -map:\n");
|
|
|
|
GetTransitionMap()->Print(out);
|
|
|
|
PrintF(out, "\n");
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
2011-09-09 14:47:37 +00:00
|
|
|
case ELEMENTS_TRANSITION:
|
|
|
|
PrintF(out, " -type = elements transition\n");
|
2011-03-23 09:57:12 +00:00
|
|
|
PrintF(out, " -map:\n");
|
|
|
|
GetTransitionMap()->Print(out);
|
|
|
|
PrintF(out, "\n");
|
|
|
|
break;
|
2008-07-03 15:10:15 +00:00
|
|
|
case CONSTANT_FUNCTION:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = constant function\n");
|
|
|
|
PrintF(out, " -function:\n");
|
|
|
|
GetConstantFunction()->Print(out);
|
|
|
|
PrintF(out, "\n");
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
|
|
|
case FIELD:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = field\n");
|
|
|
|
PrintF(out, " -index = %d", GetFieldIndex());
|
|
|
|
PrintF(out, "\n");
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
|
|
|
case CALLBACKS:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = call backs\n");
|
|
|
|
PrintF(out, " -callback object:\n");
|
|
|
|
GetCallbackObject()->Print(out);
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
2011-05-16 16:33:58 +00:00
|
|
|
case HANDLER:
|
|
|
|
PrintF(out, " -type = lookup proxy\n");
|
|
|
|
break;
|
2008-07-03 15:10:15 +00:00
|
|
|
case INTERCEPTOR:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = lookup interceptor\n");
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
|
|
|
case CONSTANT_TRANSITION:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " -type = constant property transition\n");
|
Removed IsTransitionType predicate.
With the upcoming changes to CALLBACKS properties, a predicate on the transition
type alone doesn't make sense anymore: For CALLBACKS one has to look into the
property's value to decide, and there is even the possibility of having a an
accessor function *and* a transition in the same property.
I am not completely happy with some parts of this CL, because they contain
redundant code, but given the various representations we currently have for
property type/value pairs, I can see no easy way around that. Perhaps one can
improve this a bit in a different CL, the current diversity really, really hurts
productivity...
As a bonus, this CL includes a few minor things:
* CaseClause::RecordTypeFeedback has been cleaned up and it handles the
NULL_DESCRIPTOR case correctly now. Under some (very unlikely) circumstances,
we previously missed some opportunities for monomorphic calls. In general, it
is rather unfortunate that NULL_DESCRIPTOR "shines through", it is just a
hack for the inability to remove a descriptor entry during GC, something
callers shouldn't have to be aware of.
* DescriptorArray::CopyInsert has been cleaned up a bit, preparing it for later
CALLBACKS-related changes.
* LookupResult::Print is now more informative for CONSTANT_TRANSITION.
Review URL: https://chromiumcodereview.appspot.com/9320066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-02-03 13:37:13 +00:00
|
|
|
PrintF(out, " -map:\n");
|
|
|
|
GetTransitionMap()->Print(out);
|
|
|
|
PrintF(out, "\n");
|
2008-07-03 15:10:15 +00:00
|
|
|
break;
|
2008-08-27 10:11:39 +00:00
|
|
|
case NULL_DESCRIPTOR:
|
2010-12-20 10:38:19 +00:00
|
|
|
PrintF(out, " =type = null descriptor\n");
|
2008-08-27 10:11:39 +00:00
|
|
|
break;
|
2008-07-03 15:10:15 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2010-12-20 10:38:19 +00:00
|
|
|
void Descriptor::Print(FILE* out) {
|
|
|
|
PrintF(out, "Descriptor ");
|
|
|
|
GetKey()->ShortPrint(out);
|
|
|
|
PrintF(out, " @ ");
|
|
|
|
GetValue()->ShortPrint(out);
|
|
|
|
PrintF(out, " %d\n", GetDetails().index());
|
2008-07-03 15:10:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
Removed IsTransitionType predicate.
With the upcoming changes to CALLBACKS properties, a predicate on the transition
type alone doesn't make sense anymore: For CALLBACKS one has to look into the
property's value to decide, and there is even the possibility of having a an
accessor function *and* a transition in the same property.
I am not completely happy with some parts of this CL, because they contain
redundant code, but given the various representations we currently have for
property type/value pairs, I can see no easy way around that. Perhaps one can
improve this a bit in a different CL, the current diversity really, really hurts
productivity...
As a bonus, this CL includes a few minor things:
* CaseClause::RecordTypeFeedback has been cleaned up and it handles the
NULL_DESCRIPTOR case correctly now. Under some (very unlikely) circumstances,
we previously missed some opportunities for monomorphic calls. In general, it
is rather unfortunate that NULL_DESCRIPTOR "shines through", it is just a
hack for the inability to remove a descriptor entry during GC, something
callers shouldn't have to be aware of.
* DescriptorArray::CopyInsert has been cleaned up a bit, preparing it for later
CALLBACKS-related changes.
* LookupResult::Print is now more informative for CONSTANT_TRANSITION.
Review URL: https://chromiumcodereview.appspot.com/9320066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-02-03 13:37:13 +00:00
|
|
|
bool Descriptor::ContainsTransition() {
|
|
|
|
switch (details_.type()) {
|
|
|
|
case MAP_TRANSITION:
|
|
|
|
case CONSTANT_TRANSITION:
|
|
|
|
case ELEMENTS_TRANSITION:
|
|
|
|
return true;
|
|
|
|
case CALLBACKS: {
|
|
|
|
if (!value_->IsAccessorPair()) return false;
|
|
|
|
AccessorPair* accessors = AccessorPair::cast(value_);
|
|
|
|
return accessors->getter()->IsMap() || accessors->setter()->IsMap();
|
|
|
|
}
|
|
|
|
case NORMAL:
|
|
|
|
case FIELD:
|
|
|
|
case CONSTANT_FUNCTION:
|
|
|
|
case HANDLER:
|
|
|
|
case INTERCEPTOR:
|
|
|
|
case NULL_DESCRIPTOR:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
UNREACHABLE(); // Keep the compiler happy.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-07-03 15:10:15 +00:00
|
|
|
} } // namespace v8::internal
|