2011-08-03 12:48:30 +00:00
|
|
|
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
|
|
// Redistribution and use in source and binary forms, with or without
|
|
|
|
// modification, are permitted provided that the following conditions are
|
|
|
|
// met:
|
|
|
|
//
|
|
|
|
// * Redistributions of source code must retain the above copyright
|
|
|
|
// notice, this list of conditions and the following disclaimer.
|
|
|
|
// * Redistributions in binary form must reproduce the above
|
|
|
|
// copyright notice, this list of conditions and the following
|
|
|
|
// disclaimer in the documentation and/or other materials provided
|
|
|
|
// with the distribution.
|
|
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
|
|
// contributors may be used to endorse or promote products derived
|
|
|
|
// from this software without specific prior written permission.
|
|
|
|
//
|
|
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
2013-12-18 08:09:37 +00:00
|
|
|
#include <utility>
|
|
|
|
|
2019-05-22 07:55:37 +00:00
|
|
|
#include "src/execution/isolate.h"
|
2021-09-17 14:40:54 +00:00
|
|
|
#include "src/handles/global-handles-inl.h"
|
2018-04-09 19:11:22 +00:00
|
|
|
#include "src/heap/factory.h"
|
2019-02-14 21:10:30 +00:00
|
|
|
#include "src/heap/heap-inl.h"
|
2018-05-17 12:28:56 +00:00
|
|
|
#include "src/objects/hash-table-inl.h"
|
2018-05-23 13:29:02 +00:00
|
|
|
#include "src/objects/js-collection-inl.h"
|
2019-05-23 08:51:46 +00:00
|
|
|
#include "src/objects/objects-inl.h"
|
2022-08-25 07:20:52 +00:00
|
|
|
#include "test/unittests/heap/heap-utils.h"
|
|
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
2011-08-03 12:48:30 +00:00
|
|
|
|
2017-08-11 11:22:28 +00:00
|
|
|
namespace v8 {
|
|
|
|
namespace internal {
|
2017-09-21 03:29:52 +00:00
|
|
|
namespace test_weakmaps {
|
2011-08-03 12:48:30 +00:00
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
using WeakMapsTest = TestWithHeapInternalsAndContext;
|
2013-02-25 14:46:09 +00:00
|
|
|
|
2011-08-03 12:48:30 +00:00
|
|
|
static int NumberOfWeakCalls = 0;
|
2016-05-06 12:29:00 +00:00
|
|
|
static void WeakPointerCallback(const v8::WeakCallbackInfo<void>& data) {
|
2013-12-18 08:09:37 +00:00
|
|
|
std::pair<v8::Persistent<v8::Value>*, int>* p =
|
|
|
|
reinterpret_cast<std::pair<v8::Persistent<v8::Value>*, int>*>(
|
|
|
|
data.GetParameter());
|
2015-12-07 05:36:41 +00:00
|
|
|
CHECK_EQ(1234, p->second);
|
2011-08-03 12:48:30 +00:00
|
|
|
NumberOfWeakCalls++;
|
2013-12-18 08:09:37 +00:00
|
|
|
p->first->Reset();
|
2011-08-03 12:48:30 +00:00
|
|
|
}
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, Weakness) {
|
2012-04-19 10:32:38 +00:00
|
|
|
FLAG_incremental_marking = false;
|
2022-08-25 07:20:52 +00:00
|
|
|
Isolate* isolate = i_isolate();
|
2013-03-12 07:06:36 +00:00
|
|
|
Factory* factory = isolate->factory();
|
2013-03-15 12:06:53 +00:00
|
|
|
HandleScope scope(isolate);
|
2017-12-07 13:02:05 +00:00
|
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
2013-03-12 07:06:36 +00:00
|
|
|
GlobalHandles* global_handles = isolate->global_handles();
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Keep global reference to the key.
|
|
|
|
Handle<Object> key;
|
|
|
|
{
|
2021-10-18 16:01:20 +00:00
|
|
|
HandleScope inner_scope(isolate);
|
2013-03-12 07:06:36 +00:00
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
2011-08-03 12:48:30 +00:00
|
|
|
key = global_handles->Create(*object);
|
|
|
|
}
|
|
|
|
CHECK(!global_handles->IsWeak(key.location()));
|
|
|
|
|
2014-12-02 11:23:51 +00:00
|
|
|
// Put two chained entries into weak map.
|
2011-08-03 12:48:30 +00:00
|
|
|
{
|
2021-10-18 16:01:20 +00:00
|
|
|
HandleScope inner_scope(isolate);
|
2014-12-02 11:23:51 +00:00
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
2015-02-05 09:40:13 +00:00
|
|
|
Handle<Smi> smi(Smi::FromInt(23), isolate);
|
2017-08-21 23:05:53 +00:00
|
|
|
int32_t hash = key->GetOrCreateHash(isolate).value();
|
2017-06-15 21:35:42 +00:00
|
|
|
JSWeakCollection::Set(weakmap, key, object, hash);
|
2017-08-21 23:05:53 +00:00
|
|
|
int32_t object_hash = object->GetOrCreateHash(isolate).value();
|
2017-06-15 21:35:42 +00:00
|
|
|
JSWeakCollection::Set(weakmap, object, smi, object_hash);
|
2011-08-03 12:48:30 +00:00
|
|
|
}
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(2, EphemeronHashTable::cast(weakmap->table()).NumberOfElements());
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Force a full GC.
|
2022-08-25 07:20:52 +00:00
|
|
|
PreciseCollectAllGarbage();
|
2011-08-03 12:48:30 +00:00
|
|
|
CHECK_EQ(0, NumberOfWeakCalls);
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(2, EphemeronHashTable::cast(weakmap->table()).NumberOfElements());
|
2011-10-04 16:32:34 +00:00
|
|
|
CHECK_EQ(
|
2018-06-07 05:57:16 +00:00
|
|
|
0, EphemeronHashTable::cast(weakmap->table()).NumberOfDeletedElements());
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Make the global reference to the key weak.
|
2017-01-25 10:46:01 +00:00
|
|
|
std::pair<Handle<Object>*, int> handle_and_id(&key, 1234);
|
|
|
|
GlobalHandles::MakeWeak(
|
|
|
|
key.location(), reinterpret_cast<void*>(&handle_and_id),
|
|
|
|
&WeakPointerCallback, v8::WeakCallbackType::kParameter);
|
2011-08-03 12:48:30 +00:00
|
|
|
CHECK(global_handles->IsWeak(key.location()));
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
PreciseCollectAllGarbage();
|
2011-08-03 12:48:30 +00:00
|
|
|
CHECK_EQ(1, NumberOfWeakCalls);
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(0, EphemeronHashTable::cast(weakmap->table()).NumberOfElements());
|
|
|
|
CHECK_EQ(
|
|
|
|
2, EphemeronHashTable::cast(weakmap->table()).NumberOfDeletedElements());
|
2011-08-03 12:48:30 +00:00
|
|
|
}
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, Shrinking) {
|
|
|
|
Isolate* isolate = i_isolate();
|
2013-03-12 07:06:36 +00:00
|
|
|
Factory* factory = isolate->factory();
|
2013-03-15 12:06:53 +00:00
|
|
|
HandleScope scope(isolate);
|
2017-12-07 13:02:05 +00:00
|
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Check initial capacity.
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(32, EphemeronHashTable::cast(weakmap->table()).Capacity());
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Fill up weak map to trigger capacity change.
|
|
|
|
{
|
2021-10-18 16:01:20 +00:00
|
|
|
HandleScope inner_scope(isolate);
|
2013-03-12 07:06:36 +00:00
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
2011-08-03 12:48:30 +00:00
|
|
|
for (int i = 0; i < 32; i++) {
|
2013-03-12 07:06:36 +00:00
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
2015-02-05 09:40:13 +00:00
|
|
|
Handle<Smi> smi(Smi::FromInt(i), isolate);
|
2017-08-21 23:05:53 +00:00
|
|
|
int32_t object_hash = object->GetOrCreateHash(isolate).value();
|
2017-06-15 21:35:42 +00:00
|
|
|
JSWeakCollection::Set(weakmap, object, smi, object_hash);
|
2011-08-03 12:48:30 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check increased capacity.
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(128, EphemeronHashTable::cast(weakmap->table()).Capacity());
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Force a full GC.
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(32, EphemeronHashTable::cast(weakmap->table()).NumberOfElements());
|
2011-10-04 16:32:34 +00:00
|
|
|
CHECK_EQ(
|
2018-06-07 05:57:16 +00:00
|
|
|
0, EphemeronHashTable::cast(weakmap->table()).NumberOfDeletedElements());
|
2022-08-25 07:20:52 +00:00
|
|
|
PreciseCollectAllGarbage();
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(0, EphemeronHashTable::cast(weakmap->table()).NumberOfElements());
|
2011-10-04 16:32:34 +00:00
|
|
|
CHECK_EQ(
|
2018-06-07 05:57:16 +00:00
|
|
|
32, EphemeronHashTable::cast(weakmap->table()).NumberOfDeletedElements());
|
2011-08-03 12:48:30 +00:00
|
|
|
|
|
|
|
// Check shrunk capacity.
|
2018-06-07 05:57:16 +00:00
|
|
|
CHECK_EQ(32, EphemeronHashTable::cast(weakmap->table()).Capacity());
|
2011-08-03 12:48:30 +00:00
|
|
|
}
|
2012-04-11 09:14:29 +00:00
|
|
|
|
2019-03-28 08:41:09 +00:00
|
|
|
namespace {
|
|
|
|
bool EphemeronHashTableContainsKey(EphemeronHashTable table, HeapObject key) {
|
2019-10-16 12:24:54 +00:00
|
|
|
for (InternalIndex i : table.IterateEntries()) {
|
2019-03-28 08:41:09 +00:00
|
|
|
if (table.KeyAt(i) == key) return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
} // namespace
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, WeakMapPromotionMarkCompact) {
|
|
|
|
Isolate* isolate = i_isolate();
|
2019-03-28 08:41:09 +00:00
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectAllGarbage();
|
2019-10-17 11:36:31 +00:00
|
|
|
|
2021-11-09 18:07:34 +00:00
|
|
|
CHECK(!ObjectInYoungGeneration(weakmap->table()));
|
2019-03-28 08:41:09 +00:00
|
|
|
|
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
|
|
Handle<Smi> smi(Smi::FromInt(1), isolate);
|
|
|
|
int32_t object_hash = object->GetOrCreateHash(isolate).value();
|
|
|
|
JSWeakCollection::Set(weakmap, object, smi, object_hash);
|
|
|
|
|
|
|
|
CHECK(EphemeronHashTableContainsKey(
|
|
|
|
EphemeronHashTable::cast(weakmap->table()), *object));
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectAllGarbage();
|
2019-03-28 08:41:09 +00:00
|
|
|
|
2021-11-09 18:07:34 +00:00
|
|
|
CHECK(!ObjectInYoungGeneration(*object));
|
2019-03-28 08:41:09 +00:00
|
|
|
CHECK(!ObjectInYoungGeneration(weakmap->table()));
|
|
|
|
CHECK(EphemeronHashTableContainsKey(
|
|
|
|
EphemeronHashTable::cast(weakmap->table()), *object));
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectAllGarbage();
|
2019-03-28 08:41:09 +00:00
|
|
|
CHECK(!ObjectInYoungGeneration(*object));
|
|
|
|
CHECK(!ObjectInYoungGeneration(weakmap->table()));
|
|
|
|
CHECK(EphemeronHashTableContainsKey(
|
|
|
|
EphemeronHashTable::cast(weakmap->table()), *object));
|
|
|
|
}
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, WeakMapScavenge) {
|
2022-04-05 10:53:59 +00:00
|
|
|
if (i::FLAG_single_generation || i::FLAG_stress_incremental_marking) return;
|
2022-08-25 07:20:52 +00:00
|
|
|
Isolate* isolate = i_isolate();
|
2019-03-28 08:41:09 +00:00
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
HandleScope scope(isolate);
|
|
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
GcAndSweep(NEW_SPACE);
|
2019-03-28 08:41:09 +00:00
|
|
|
CHECK(ObjectInYoungGeneration(weakmap->table()));
|
|
|
|
|
|
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
|
|
Handle<Smi> smi(Smi::FromInt(1), isolate);
|
|
|
|
int32_t object_hash = object->GetOrCreateHash(isolate).value();
|
|
|
|
JSWeakCollection::Set(weakmap, object, smi, object_hash);
|
|
|
|
|
|
|
|
CHECK(EphemeronHashTableContainsKey(
|
|
|
|
EphemeronHashTable::cast(weakmap->table()), *object));
|
|
|
|
|
2022-08-09 21:49:12 +00:00
|
|
|
if (!FLAG_minor_mc) {
|
2022-08-25 07:20:52 +00:00
|
|
|
GcAndSweep(NEW_SPACE);
|
2022-08-09 21:49:12 +00:00
|
|
|
CHECK(ObjectInYoungGeneration(*object));
|
|
|
|
CHECK(!ObjectInYoungGeneration(weakmap->table()));
|
|
|
|
CHECK(EphemeronHashTableContainsKey(
|
|
|
|
EphemeronHashTable::cast(weakmap->table()), *object));
|
|
|
|
}
|
2019-03-28 08:41:09 +00:00
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
GcAndSweep(OLD_SPACE);
|
2019-03-28 08:41:09 +00:00
|
|
|
CHECK(!ObjectInYoungGeneration(*object));
|
|
|
|
CHECK(!ObjectInYoungGeneration(weakmap->table()));
|
|
|
|
CHECK(EphemeronHashTableContainsKey(
|
|
|
|
EphemeronHashTable::cast(weakmap->table()), *object));
|
|
|
|
}
|
2012-04-11 09:14:29 +00:00
|
|
|
|
|
|
|
// Test that weak map values on an evacuation candidate which are not reachable
|
|
|
|
// by other paths are correctly recorded in the slots buffer.
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, Regress2060a) {
|
2021-11-10 08:07:47 +00:00
|
|
|
if (!i::FLAG_compact) return;
|
2021-04-30 02:54:25 +00:00
|
|
|
if (i::FLAG_enable_third_party_heap) return;
|
2021-11-10 08:07:47 +00:00
|
|
|
FLAG_compact_on_every_full_gc = true;
|
2020-09-03 10:33:46 +00:00
|
|
|
FLAG_stress_concurrent_allocation = false; // For SimulateFullSpace.
|
2022-08-25 07:20:52 +00:00
|
|
|
Isolate* isolate = i_isolate();
|
2013-03-12 07:06:36 +00:00
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
Heap* heap = isolate->heap();
|
2013-03-15 12:06:53 +00:00
|
|
|
HandleScope scope(isolate);
|
2017-11-08 12:56:08 +00:00
|
|
|
Handle<JSFunction> function =
|
2020-11-10 11:22:49 +00:00
|
|
|
factory->NewFunctionForTesting(factory->function_string());
|
2013-03-12 07:06:36 +00:00
|
|
|
Handle<JSObject> key = factory->NewJSObject(function);
|
2017-12-07 13:02:05 +00:00
|
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
2012-04-11 09:14:29 +00:00
|
|
|
|
|
|
|
// Start second old-space page so that values land on evacuation candidate.
|
2018-05-22 16:58:12 +00:00
|
|
|
Page* first_page = heap->old_space()->first_page();
|
2022-08-25 07:20:52 +00:00
|
|
|
SimulateFullSpace(heap->old_space());
|
2012-04-11 09:14:29 +00:00
|
|
|
|
|
|
|
// Fill up weak map with values on an evacuation candidate.
|
|
|
|
{
|
2021-10-18 16:01:20 +00:00
|
|
|
HandleScope inner_scope(isolate);
|
2012-04-11 09:14:29 +00:00
|
|
|
for (int i = 0; i < 32; i++) {
|
2019-03-11 19:04:02 +00:00
|
|
|
Handle<JSObject> object =
|
|
|
|
factory->NewJSObject(function, AllocationType::kOld);
|
2019-02-11 15:07:56 +00:00
|
|
|
CHECK(!Heap::InYoungGeneration(*object));
|
2021-04-30 02:54:25 +00:00
|
|
|
CHECK_IMPLIES(!FLAG_enable_third_party_heap,
|
|
|
|
!first_page->Contains(object->address()));
|
2017-10-11 22:50:51 +00:00
|
|
|
int32_t hash = key->GetOrCreateHash(isolate).value();
|
2017-06-15 21:35:42 +00:00
|
|
|
JSWeakCollection::Set(weakmap, key, object, hash);
|
2012-04-11 09:14:29 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Force compacting garbage collection.
|
2021-11-10 08:07:47 +00:00
|
|
|
CHECK(FLAG_compact_on_every_full_gc);
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectAllGarbage();
|
2012-04-11 09:14:29 +00:00
|
|
|
}
|
2012-04-11 15:32:31 +00:00
|
|
|
|
|
|
|
// Test that weak map keys on an evacuation candidate which are reachable by
|
|
|
|
// other strong paths are correctly recorded in the slots buffer.
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, Regress2060b) {
|
2021-11-10 08:07:47 +00:00
|
|
|
if (!i::FLAG_compact) return;
|
|
|
|
FLAG_compact_on_every_full_gc = true;
|
2012-10-12 11:41:14 +00:00
|
|
|
#ifdef VERIFY_HEAP
|
2012-04-11 15:32:31 +00:00
|
|
|
FLAG_verify_heap = true;
|
2012-04-11 15:47:46 +00:00
|
|
|
#endif
|
2020-09-03 10:33:46 +00:00
|
|
|
FLAG_stress_concurrent_allocation = false; // For SimulateFullSpace.
|
2012-10-12 11:41:14 +00:00
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
Isolate* isolate = i_isolate();
|
2013-03-12 07:06:36 +00:00
|
|
|
Factory* factory = isolate->factory();
|
|
|
|
Heap* heap = isolate->heap();
|
2013-03-15 12:06:53 +00:00
|
|
|
HandleScope scope(isolate);
|
2017-11-08 12:56:08 +00:00
|
|
|
Handle<JSFunction> function =
|
2020-11-10 11:22:49 +00:00
|
|
|
factory->NewFunctionForTesting(factory->function_string());
|
2012-04-11 15:32:31 +00:00
|
|
|
|
|
|
|
// Start second old-space page so that keys land on evacuation candidate.
|
2018-05-22 16:58:12 +00:00
|
|
|
Page* first_page = heap->old_space()->first_page();
|
2022-08-25 07:20:52 +00:00
|
|
|
SimulateFullSpace(heap->old_space());
|
2012-04-11 15:32:31 +00:00
|
|
|
|
|
|
|
// Fill up weak map with keys on an evacuation candidate.
|
|
|
|
Handle<JSObject> keys[32];
|
|
|
|
for (int i = 0; i < 32; i++) {
|
2019-03-11 19:04:02 +00:00
|
|
|
keys[i] = factory->NewJSObject(function, AllocationType::kOld);
|
2019-02-11 15:07:56 +00:00
|
|
|
CHECK(!Heap::InYoungGeneration(*keys[i]));
|
2021-04-30 02:54:25 +00:00
|
|
|
CHECK_IMPLIES(!FLAG_enable_third_party_heap,
|
|
|
|
!first_page->Contains(keys[i]->address()));
|
2012-04-11 15:32:31 +00:00
|
|
|
}
|
2017-12-07 13:02:05 +00:00
|
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
2012-04-11 15:32:31 +00:00
|
|
|
for (int i = 0; i < 32; i++) {
|
2015-02-05 09:40:13 +00:00
|
|
|
Handle<Smi> smi(Smi::FromInt(i), isolate);
|
2017-08-21 23:05:53 +00:00
|
|
|
int32_t hash = keys[i]->GetOrCreateHash(isolate).value();
|
2017-06-15 21:35:42 +00:00
|
|
|
JSWeakCollection::Set(weakmap, keys[i], smi, hash);
|
2012-04-11 15:32:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Force compacting garbage collection. The subsequent collections are used
|
|
|
|
// to verify that key references were actually updated.
|
2021-11-10 08:07:47 +00:00
|
|
|
CHECK(FLAG_compact_on_every_full_gc);
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectAllGarbage();
|
|
|
|
CollectAllGarbage();
|
|
|
|
CollectAllGarbage();
|
2012-04-11 15:32:31 +00:00
|
|
|
}
|
2014-08-05 07:29:13 +00:00
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, Regress399527) {
|
2016-11-18 12:55:53 +00:00
|
|
|
if (!FLAG_incremental_marking) return;
|
2022-08-25 07:20:52 +00:00
|
|
|
v8::HandleScope scope(v8_isolate());
|
|
|
|
Isolate* isolate = i_isolate();
|
2014-08-05 07:29:13 +00:00
|
|
|
Heap* heap = isolate->heap();
|
|
|
|
{
|
2021-10-18 16:01:20 +00:00
|
|
|
HandleScope inner_scope(isolate);
|
2017-12-07 13:02:05 +00:00
|
|
|
isolate->factory()->NewJSWeakMap();
|
2022-08-25 07:20:52 +00:00
|
|
|
SimulateIncrementalMarking(heap);
|
2014-08-05 07:29:13 +00:00
|
|
|
}
|
|
|
|
// The weak map is marked black here but leaving the handle scope will make
|
|
|
|
// the object unreachable. Aborting incremental marking will clear all the
|
|
|
|
// marking bits which makes the weak map garbage.
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectAllGarbage();
|
2014-08-05 07:29:13 +00:00
|
|
|
}
|
2017-08-11 11:22:28 +00:00
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
TEST_F(WeakMapsTest, WeakMapsWithChainedEntries) {
|
|
|
|
ManualGCScope manual_gc_scope(i_isolate());
|
|
|
|
v8::Isolate* isolate = v8_isolate();
|
2019-02-10 19:24:47 +00:00
|
|
|
v8::HandleScope scope(isolate);
|
|
|
|
|
2022-08-25 07:20:52 +00:00
|
|
|
const int initial_gc_count = i_isolate()->heap()->gc_count();
|
|
|
|
Handle<JSWeakMap> weakmap1 = i_isolate()->factory()->NewJSWeakMap();
|
|
|
|
Handle<JSWeakMap> weakmap2 = i_isolate()->factory()->NewJSWeakMap();
|
2019-02-10 19:24:47 +00:00
|
|
|
v8::Global<v8::Object> g1;
|
|
|
|
v8::Global<v8::Object> g2;
|
|
|
|
{
|
2021-10-18 16:01:20 +00:00
|
|
|
v8::HandleScope inner_scope(isolate);
|
2019-02-10 19:24:47 +00:00
|
|
|
v8::Local<v8::Object> o1 = v8::Object::New(isolate);
|
|
|
|
g1.Reset(isolate, o1);
|
|
|
|
g1.SetWeak();
|
|
|
|
v8::Local<v8::Object> o2 = v8::Object::New(isolate);
|
|
|
|
g2.Reset(isolate, o2);
|
|
|
|
g2.SetWeak();
|
|
|
|
Handle<Object> i_o1 = v8::Utils::OpenHandle(*o1);
|
|
|
|
Handle<Object> i_o2 = v8::Utils::OpenHandle(*o2);
|
2022-08-25 07:20:52 +00:00
|
|
|
int32_t hash1 = i_o1->GetOrCreateHash(i_isolate()).value();
|
|
|
|
int32_t hash2 = i_o2->GetOrCreateHash(i_isolate()).value();
|
2019-02-10 19:24:47 +00:00
|
|
|
JSWeakCollection::Set(weakmap1, i_o1, i_o2, hash1);
|
|
|
|
JSWeakCollection::Set(weakmap2, i_o2, i_o1, hash2);
|
|
|
|
}
|
2022-08-25 07:20:52 +00:00
|
|
|
CollectGarbage(OLD_SPACE);
|
2019-02-10 19:24:47 +00:00
|
|
|
CHECK(g1.IsEmpty());
|
|
|
|
CHECK(g2.IsEmpty());
|
2022-08-25 07:20:52 +00:00
|
|
|
CHECK_EQ(1, i_isolate()->heap()->gc_count() - initial_gc_count);
|
2019-02-10 19:24:47 +00:00
|
|
|
}
|
|
|
|
|
2017-09-21 03:29:52 +00:00
|
|
|
} // namespace test_weakmaps
|
2017-08-11 11:22:28 +00:00
|
|
|
} // namespace internal
|
|
|
|
} // namespace v8
|