2011-05-05 18:55:31 +00:00
|
|
|
// Copyright 2007-2011 the V8 project authors. All rights reserved.
|
|
|
|
// Redistribution and use in source and binary forms, with or without
|
|
|
|
// modification, are permitted provided that the following conditions are
|
|
|
|
// met:
|
|
|
|
//
|
|
|
|
// * Redistributions of source code must retain the above copyright
|
|
|
|
// notice, this list of conditions and the following disclaimer.
|
|
|
|
// * Redistributions in binary form must reproduce the above
|
|
|
|
// copyright notice, this list of conditions and the following
|
|
|
|
// disclaimer in the documentation and/or other materials provided
|
|
|
|
// with the distribution.
|
|
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
|
|
// contributors may be used to endorse or promote products derived
|
|
|
|
// from this software without specific prior written permission.
|
|
|
|
//
|
|
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
|
|
#include <limits.h>
|
|
|
|
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "src/v8.h"
|
2011-05-05 18:55:31 +00:00
|
|
|
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "src/api.h"
|
2014-06-30 13:25:46 +00:00
|
|
|
#include "src/base/platform/platform.h"
|
2015-07-13 12:38:06 +00:00
|
|
|
#include "src/base/smart-pointers.h"
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "src/compilation-cache.h"
|
|
|
|
#include "src/execution.h"
|
|
|
|
#include "src/isolate.h"
|
2015-11-26 16:22:34 +00:00
|
|
|
#include "src/parsing/parser.h"
|
2014-06-03 08:12:43 +00:00
|
|
|
#include "src/unicode-inl.h"
|
|
|
|
#include "src/utils.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
using ::v8::Context;
|
|
|
|
using ::v8::Extension;
|
|
|
|
using ::v8::Function;
|
|
|
|
using ::v8::HandleScope;
|
|
|
|
using ::v8::Local;
|
|
|
|
using ::v8::Object;
|
|
|
|
using ::v8::ObjectTemplate;
|
|
|
|
using ::v8::Persistent;
|
|
|
|
using ::v8::Script;
|
|
|
|
using ::v8::String;
|
|
|
|
using ::v8::Value;
|
|
|
|
using ::v8::V8;
|
|
|
|
|
|
|
|
|
|
|
|
// Migrating an isolate
|
2014-06-30 13:25:46 +00:00
|
|
|
class KangarooThread : public v8::base::Thread {
|
2011-05-05 18:55:31 +00:00
|
|
|
public:
|
2015-11-18 08:22:07 +00:00
|
|
|
KangarooThread(v8::Isolate* isolate, v8::Local<v8::Context> context)
|
2014-08-12 13:33:35 +00:00
|
|
|
: Thread(Options("KangarooThread")),
|
2013-04-24 14:23:46 +00:00
|
|
|
isolate_(isolate),
|
|
|
|
context_(isolate, context) {}
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
void Run() {
|
|
|
|
{
|
|
|
|
v8::Locker locker(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2015-11-23 12:38:18 +00:00
|
|
|
CHECK_EQ(isolate_, v8::Isolate::GetCurrent());
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope scope(isolate_);
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
|
|
|
v8::Local<v8::Context>::New(isolate_, context_);
|
|
|
|
v8::Context::Scope context_scope(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
Local<Value> v = CompileRun("getValue()");
|
|
|
|
CHECK(v->IsNumber());
|
2015-11-18 08:22:07 +00:00
|
|
|
CHECK_EQ(30, static_cast<int>(v->NumberValue(context).FromJust()));
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
{
|
|
|
|
v8::Locker locker(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope scope(isolate_);
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
|
|
|
v8::Local<v8::Context>::New(isolate_, context_);
|
|
|
|
v8::Context::Scope context_scope(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
Local<Value> v = CompileRun("getValue()");
|
|
|
|
CHECK(v->IsNumber());
|
2015-11-18 08:22:07 +00:00
|
|
|
CHECK_EQ(30, static_cast<int>(v->NumberValue(context).FromJust()));
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
isolate_->Dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
Persistent<v8::Context> context_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Migrates an isolate from one thread to another
|
|
|
|
TEST(KangarooIsolates) {
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2015-07-13 12:38:06 +00:00
|
|
|
v8::base::SmartPointer<KangarooThread> thread1;
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Locker locker(isolate);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate);
|
2013-04-24 14:23:46 +00:00
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
2011-05-05 18:55:31 +00:00
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-23 12:38:18 +00:00
|
|
|
CHECK_EQ(isolate, v8::Isolate::GetCurrent());
|
2011-05-05 18:55:31 +00:00
|
|
|
CompileRun("function getValue() { return 30; }");
|
2013-04-24 14:23:46 +00:00
|
|
|
thread1.Reset(new KangarooThread(isolate, context));
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
2013-04-24 14:23:46 +00:00
|
|
|
thread1->Start();
|
|
|
|
thread1->Join();
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2015-11-18 08:22:07 +00:00
|
|
|
static void CalcFibAndCheck(v8::Local<v8::Context> context) {
|
2011-05-05 18:55:31 +00:00
|
|
|
Local<Value> v = CompileRun("function fib(n) {"
|
|
|
|
" if (n <= 2) return 1;"
|
|
|
|
" return fib(n-1) + fib(n-2);"
|
|
|
|
"}"
|
|
|
|
"fib(10)");
|
|
|
|
CHECK(v->IsNumber());
|
2015-11-18 08:22:07 +00:00
|
|
|
CHECK_EQ(55, static_cast<int>(v->NumberValue(context).FromJust()));
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
class JoinableThread {
|
|
|
|
public:
|
|
|
|
explicit JoinableThread(const char* name)
|
|
|
|
: name_(name),
|
2013-09-02 12:26:06 +00:00
|
|
|
semaphore_(0),
|
2011-05-05 18:55:31 +00:00
|
|
|
thread_(this) {
|
|
|
|
}
|
|
|
|
|
2013-09-02 12:26:06 +00:00
|
|
|
virtual ~JoinableThread() {}
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
void Start() {
|
|
|
|
thread_.Start();
|
|
|
|
}
|
|
|
|
|
|
|
|
void Join() {
|
2013-09-02 12:26:06 +00:00
|
|
|
semaphore_.Wait();
|
2014-10-08 08:17:04 +00:00
|
|
|
thread_.Join();
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
virtual void Run() = 0;
|
2011-09-08 19:57:14 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
private:
|
2014-06-30 13:25:46 +00:00
|
|
|
class ThreadWithSemaphore : public v8::base::Thread {
|
2011-05-05 18:55:31 +00:00
|
|
|
public:
|
2011-06-10 09:42:08 +00:00
|
|
|
explicit ThreadWithSemaphore(JoinableThread* joinable_thread)
|
2014-08-12 13:33:35 +00:00
|
|
|
: Thread(Options(joinable_thread->name_)),
|
|
|
|
joinable_thread_(joinable_thread) {}
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
virtual void Run() {
|
|
|
|
joinable_thread_->Run();
|
2013-09-02 12:26:06 +00:00
|
|
|
joinable_thread_->semaphore_.Signal();
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
JoinableThread* joinable_thread_;
|
|
|
|
};
|
|
|
|
|
|
|
|
const char* name_;
|
2014-06-30 13:25:46 +00:00
|
|
|
v8::base::Semaphore semaphore_;
|
2011-05-05 18:55:31 +00:00
|
|
|
ThreadWithSemaphore thread_;
|
|
|
|
|
|
|
|
friend class ThreadWithSemaphore;
|
|
|
|
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(JoinableThread);
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
class IsolateLockingThreadWithLocalContext : public JoinableThread {
|
|
|
|
public:
|
|
|
|
explicit IsolateLockingThreadWithLocalContext(v8::Isolate* isolate)
|
|
|
|
: JoinableThread("IsolateLockingThread"),
|
|
|
|
isolate_(isolate) {
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void Run() {
|
|
|
|
v8::Locker locker(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate_);
|
2013-09-19 10:31:04 +00:00
|
|
|
LocalContext local_context(isolate_);
|
2015-11-23 12:38:18 +00:00
|
|
|
CHECK_EQ(isolate_, v8::Isolate::GetCurrent());
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(local_context.local());
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
static void StartJoinAndDeleteThreads(const i::List<JoinableThread*>& threads) {
|
|
|
|
for (int i = 0; i < threads.length(); i++) {
|
|
|
|
threads[i]->Start();
|
|
|
|
}
|
|
|
|
for (int i = 0; i < threads.length(); i++) {
|
|
|
|
threads[i]->Join();
|
|
|
|
}
|
|
|
|
for (int i = 0; i < threads.length(); i++) {
|
|
|
|
delete threads[i];
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// Run many threads all locking on the same isolate
|
|
|
|
TEST(IsolateLockingStress) {
|
2015-04-17 09:13:37 +00:00
|
|
|
i::FLAG_always_opt = false;
|
2013-06-28 15:34:48 +00:00
|
|
|
#if V8_TARGET_ARCH_MIPS
|
2011-11-23 08:36:03 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-11-23 08:36:03 +00:00
|
|
|
#endif
|
2011-05-05 18:55:31 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2011-05-05 18:55:31 +00:00
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new IsolateLockingThreadWithLocalContext(isolate));
|
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
|
|
|
isolate->Dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
class IsolateNestedLockingThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
explicit IsolateNestedLockingThread(v8::Isolate* isolate)
|
|
|
|
: JoinableThread("IsolateNestedLocking"), isolate_(isolate) {
|
|
|
|
}
|
|
|
|
virtual void Run() {
|
|
|
|
v8::Locker lock(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate_);
|
2013-09-19 10:31:04 +00:00
|
|
|
LocalContext local_context(isolate_);
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Locker another_lock(isolate_);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(local_context.local());
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
{
|
|
|
|
v8::Locker another_lock(isolate_);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(local_context.local());
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Run many threads with nested locks
|
|
|
|
TEST(IsolateNestedLocking) {
|
2015-04-17 09:13:37 +00:00
|
|
|
i::FLAG_always_opt = false;
|
2013-06-28 15:34:48 +00:00
|
|
|
#if V8_TARGET_ARCH_MIPS
|
2011-11-23 08:36:03 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-11-23 08:36:03 +00:00
|
|
|
#endif
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2011-05-05 18:55:31 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new IsolateNestedLockingThread(isolate));
|
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
2013-02-12 11:57:51 +00:00
|
|
|
isolate->Dispose();
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
class SeparateIsolatesLocksNonexclusiveThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
SeparateIsolatesLocksNonexclusiveThread(v8::Isolate* isolate1,
|
|
|
|
v8::Isolate* isolate2)
|
|
|
|
: JoinableThread("SeparateIsolatesLocksNonexclusiveThread"),
|
|
|
|
isolate1_(isolate1), isolate2_(isolate2) {
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void Run() {
|
|
|
|
v8::Locker lock(isolate1_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate1_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate1_);
|
2013-09-19 10:31:04 +00:00
|
|
|
LocalContext local_context(isolate1_);
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
IsolateLockingThreadWithLocalContext threadB(isolate2_);
|
|
|
|
threadB.Start();
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(local_context.local());
|
2011-05-05 18:55:31 +00:00
|
|
|
threadB.Join();
|
|
|
|
}
|
|
|
|
private:
|
|
|
|
v8::Isolate* isolate1_;
|
|
|
|
v8::Isolate* isolate2_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Run parallel threads that lock and access different isolates in parallel
|
|
|
|
TEST(SeparateIsolatesLocksNonexclusive) {
|
2015-04-17 09:13:37 +00:00
|
|
|
i::FLAG_always_opt = false;
|
2016-03-15 18:07:43 +00:00
|
|
|
#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_S390
|
2011-07-11 12:17:10 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-07-11 12:17:10 +00:00
|
|
|
#endif
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate1 = v8::Isolate::New(create_params);
|
|
|
|
v8::Isolate* isolate2 = v8::Isolate::New(create_params);
|
2011-05-05 18:55:31 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new SeparateIsolatesLocksNonexclusiveThread(isolate1,
|
|
|
|
isolate2));
|
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
|
|
|
isolate2->Dispose();
|
|
|
|
isolate1->Dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
class LockIsolateAndCalculateFibSharedContextThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
explicit LockIsolateAndCalculateFibSharedContextThread(
|
2015-11-18 08:22:07 +00:00
|
|
|
v8::Isolate* isolate, v8::Local<v8::Context> context)
|
|
|
|
: JoinableThread("LockIsolateAndCalculateFibThread"),
|
|
|
|
isolate_(isolate),
|
|
|
|
context_(isolate, context) {}
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
virtual void Run() {
|
|
|
|
v8::Locker lock(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
HandleScope handle_scope(isolate_);
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
|
|
|
v8::Local<v8::Context>::New(isolate_, context_);
|
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
Persistent<v8::Context> context_;
|
|
|
|
};
|
|
|
|
|
|
|
|
class LockerUnlockerThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
explicit LockerUnlockerThread(v8::Isolate* isolate)
|
|
|
|
: JoinableThread("LockerUnlockerThread"),
|
|
|
|
isolate_(isolate) {
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void Run() {
|
Add Isolate::DiscardThreadSpecificMetadata method to embedder API.
If many threads use the same Isolate (or many Isolates) and then
terminate, their PerIsolateThreadData objects are never cleaned
up, resulting in a slow memory leak and, worse, the
PerIsolateThreadData chain getting larger and larger, adversely
affecting performance.
In this situation, embedders will now be encouraged to apply
DiscardThreadSpecificMetadata against any Isolate a thread is
done with, especially if the thread is about to terminate.
Note that it is harmless to run DiscardThreadSpecificMetadata
against an Isolate for which a thread has no thread data and
per-Isolate thread data can be reestablished if a thread starts
using an Isolate again after running DiscardThreadSpecificMetadata
against it.
It is, however, an embedder error to run
DiscardThreadSpecificMetadata against an Isolate in thread with a
Locker for the Isolate in the stack or against an Entered Isolate.
This change cannot cause any change in behavior in existing apps
as the only added coded can only be reached via the new
DiscardThreadSpecificMetadata method.
R=Jakob, jochen
BUG=
Review URL: https://codereview.chromium.org/1522703002
Cr-Commit-Position: refs/heads/master@{#32909}
2015-12-16 15:49:28 +00:00
|
|
|
isolate_->DiscardThreadSpecificMetadata(); // No-op
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
Add Isolate::DiscardThreadSpecificMetadata method to embedder API.
If many threads use the same Isolate (or many Isolates) and then
terminate, their PerIsolateThreadData objects are never cleaned
up, resulting in a slow memory leak and, worse, the
PerIsolateThreadData chain getting larger and larger, adversely
affecting performance.
In this situation, embedders will now be encouraged to apply
DiscardThreadSpecificMetadata against any Isolate a thread is
done with, especially if the thread is about to terminate.
Note that it is harmless to run DiscardThreadSpecificMetadata
against an Isolate for which a thread has no thread data and
per-Isolate thread data can be reestablished if a thread starts
using an Isolate again after running DiscardThreadSpecificMetadata
against it.
It is, however, an embedder error to run
DiscardThreadSpecificMetadata against an Isolate in thread with a
Locker for the Isolate in the stack or against an Entered Isolate.
This change cannot cause any change in behavior in existing apps
as the only added coded can only be reached via the new
DiscardThreadSpecificMetadata method.
R=Jakob, jochen
BUG=
Review URL: https://codereview.chromium.org/1522703002
Cr-Commit-Position: refs/heads/master@{#32909}
2015-12-16 15:49:28 +00:00
|
|
|
v8::Locker lock(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
|
|
|
v8::HandleScope handle_scope(isolate_);
|
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate_);
|
|
|
|
{
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
CalcFibAndCheck(context);
|
|
|
|
}
|
|
|
|
{
|
|
|
|
LockIsolateAndCalculateFibSharedContextThread thread(isolate_, context);
|
|
|
|
isolate_->Exit();
|
|
|
|
v8::Unlocker unlocker(isolate_);
|
|
|
|
thread.Start();
|
|
|
|
thread.Join();
|
|
|
|
}
|
|
|
|
isolate_->Enter();
|
|
|
|
{
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
CalcFibAndCheck(context);
|
|
|
|
}
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
Add Isolate::DiscardThreadSpecificMetadata method to embedder API.
If many threads use the same Isolate (or many Isolates) and then
terminate, their PerIsolateThreadData objects are never cleaned
up, resulting in a slow memory leak and, worse, the
PerIsolateThreadData chain getting larger and larger, adversely
affecting performance.
In this situation, embedders will now be encouraged to apply
DiscardThreadSpecificMetadata against any Isolate a thread is
done with, especially if the thread is about to terminate.
Note that it is harmless to run DiscardThreadSpecificMetadata
against an Isolate for which a thread has no thread data and
per-Isolate thread data can be reestablished if a thread starts
using an Isolate again after running DiscardThreadSpecificMetadata
against it.
It is, however, an embedder error to run
DiscardThreadSpecificMetadata against an Isolate in thread with a
Locker for the Isolate in the stack or against an Entered Isolate.
This change cannot cause any change in behavior in existing apps
as the only added coded can only be reached via the new
DiscardThreadSpecificMetadata method.
R=Jakob, jochen
BUG=
Review URL: https://codereview.chromium.org/1522703002
Cr-Commit-Position: refs/heads/master@{#32909}
2015-12-16 15:49:28 +00:00
|
|
|
isolate_->DiscardThreadSpecificMetadata();
|
|
|
|
isolate_->DiscardThreadSpecificMetadata(); // No-op
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
2011-09-08 19:57:14 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Use unlocker inside of a Locker, multiple threads.
|
|
|
|
TEST(LockerUnlocker) {
|
2015-04-17 09:13:37 +00:00
|
|
|
i::FLAG_always_opt = false;
|
2016-03-15 18:07:43 +00:00
|
|
|
#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_S390
|
2011-07-11 12:17:10 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-07-11 12:17:10 +00:00
|
|
|
#endif
|
2011-05-05 18:55:31 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2011-05-05 18:55:31 +00:00
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new LockerUnlockerThread(isolate));
|
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
|
|
|
isolate->Dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
class LockTwiceAndUnlockThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
explicit LockTwiceAndUnlockThread(v8::Isolate* isolate)
|
|
|
|
: JoinableThread("LockTwiceAndUnlockThread"),
|
|
|
|
isolate_(isolate) {
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void Run() {
|
|
|
|
v8::Locker lock(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate_);
|
2013-04-24 14:23:46 +00:00
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate_);
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
{
|
|
|
|
v8::Locker second_lock(isolate_);
|
|
|
|
{
|
2013-04-24 14:23:46 +00:00
|
|
|
LockIsolateAndCalculateFibSharedContextThread thread(isolate_, context);
|
2011-05-05 18:55:31 +00:00
|
|
|
isolate_->Exit();
|
|
|
|
v8::Unlocker unlocker(isolate_);
|
|
|
|
thread.Start();
|
|
|
|
thread.Join();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
isolate_->Enter();
|
|
|
|
{
|
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
}
|
2011-09-08 19:57:14 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Use Unlocker inside two Lockers.
|
|
|
|
TEST(LockTwiceAndUnlock) {
|
2015-04-17 09:13:37 +00:00
|
|
|
i::FLAG_always_opt = false;
|
2016-03-15 18:07:43 +00:00
|
|
|
#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_S390
|
2011-07-11 12:17:10 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-07-11 12:17:10 +00:00
|
|
|
#endif
|
2011-05-05 18:55:31 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2011-05-05 18:55:31 +00:00
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new LockTwiceAndUnlockThread(isolate));
|
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
|
|
|
isolate->Dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
class LockAndUnlockDifferentIsolatesThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
LockAndUnlockDifferentIsolatesThread(v8::Isolate* isolate1,
|
|
|
|
v8::Isolate* isolate2)
|
|
|
|
: JoinableThread("LockAndUnlockDifferentIsolatesThread"),
|
|
|
|
isolate1_(isolate1),
|
|
|
|
isolate2_(isolate2) {
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void Run() {
|
2015-07-13 12:38:06 +00:00
|
|
|
v8::base::SmartPointer<LockIsolateAndCalculateFibSharedContextThread>
|
|
|
|
thread;
|
2011-05-05 18:55:31 +00:00
|
|
|
v8::Locker lock1(isolate1_);
|
|
|
|
CHECK(v8::Locker::IsLocked(isolate1_));
|
|
|
|
CHECK(!v8::Locker::IsLocked(isolate2_));
|
|
|
|
{
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate1_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate1_);
|
2015-11-18 08:22:07 +00:00
|
|
|
v8::Local<v8::Context> context1 = v8::Context::New(isolate1_);
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Context::Scope context_scope(context1);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context1);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
2013-05-02 20:18:42 +00:00
|
|
|
thread.Reset(new LockIsolateAndCalculateFibSharedContextThread(
|
|
|
|
isolate1_, context1));
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
v8::Locker lock2(isolate2_);
|
|
|
|
CHECK(v8::Locker::IsLocked(isolate1_));
|
|
|
|
CHECK(v8::Locker::IsLocked(isolate2_));
|
|
|
|
{
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate2_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate2_);
|
2015-11-18 08:22:07 +00:00
|
|
|
v8::Local<v8::Context> context2 = v8::Context::New(isolate2_);
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Context::Scope context_scope(context2);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context2);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
v8::Unlocker unlock1(isolate1_);
|
|
|
|
CHECK(!v8::Locker::IsLocked(isolate1_));
|
|
|
|
CHECK(v8::Locker::IsLocked(isolate2_));
|
|
|
|
v8::Context::Scope context_scope(context2);
|
2013-04-24 14:23:46 +00:00
|
|
|
thread->Start();
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context2);
|
2013-04-24 14:23:46 +00:00
|
|
|
thread->Join();
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
}
|
2011-09-08 19:57:14 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
private:
|
|
|
|
v8::Isolate* isolate1_;
|
|
|
|
v8::Isolate* isolate2_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Lock two isolates and unlock one of them.
|
|
|
|
TEST(LockAndUnlockDifferentIsolates) {
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate1 = v8::Isolate::New(create_params);
|
|
|
|
v8::Isolate* isolate2 = v8::Isolate::New(create_params);
|
2011-05-05 18:55:31 +00:00
|
|
|
LockAndUnlockDifferentIsolatesThread thread(isolate1, isolate2);
|
|
|
|
thread.Start();
|
|
|
|
thread.Join();
|
|
|
|
isolate2->Dispose();
|
|
|
|
isolate1->Dispose();
|
|
|
|
}
|
|
|
|
|
|
|
|
class LockUnlockLockThread : public JoinableThread {
|
|
|
|
public:
|
2015-11-18 08:22:07 +00:00
|
|
|
LockUnlockLockThread(v8::Isolate* isolate, v8::Local<v8::Context> context)
|
|
|
|
: JoinableThread("LockUnlockLockThread"),
|
|
|
|
isolate_(isolate),
|
|
|
|
context_(isolate, context) {}
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
virtual void Run() {
|
|
|
|
v8::Locker lock1(isolate_);
|
|
|
|
CHECK(v8::Locker::IsLocked(isolate_));
|
2013-09-19 09:56:09 +00:00
|
|
|
CHECK(!v8::Locker::IsLocked(CcTest::isolate()));
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate_);
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
|
|
|
v8::Local<v8::Context>::New(isolate_, context_);
|
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
{
|
|
|
|
v8::Unlocker unlock1(isolate_);
|
|
|
|
CHECK(!v8::Locker::IsLocked(isolate_));
|
2013-09-19 09:56:09 +00:00
|
|
|
CHECK(!v8::Locker::IsLocked(CcTest::isolate()));
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Locker lock2(isolate_);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate_);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate_);
|
2011-05-05 18:55:31 +00:00
|
|
|
CHECK(v8::Locker::IsLocked(isolate_));
|
2013-09-19 09:56:09 +00:00
|
|
|
CHECK(!v8::Locker::IsLocked(CcTest::isolate()));
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
|
|
|
v8::Local<v8::Context>::New(isolate_, context_);
|
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
v8::Isolate* isolate_;
|
|
|
|
v8::Persistent<v8::Context> context_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Locker inside an Unlocker inside a Locker.
|
|
|
|
TEST(LockUnlockLockMultithreaded) {
|
2013-06-28 15:34:48 +00:00
|
|
|
#if V8_TARGET_ARCH_MIPS
|
2011-11-23 08:36:03 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-11-23 08:36:03 +00:00
|
|
|
#endif
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2013-04-24 14:23:46 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
|
|
|
v8::Locker locker_(isolate);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate);
|
2015-11-18 08:22:07 +00:00
|
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
2013-04-24 14:23:46 +00:00
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new LockUnlockLockThread(
|
2013-05-02 20:18:42 +00:00
|
|
|
isolate, context));
|
2013-04-24 14:23:46 +00:00
|
|
|
}
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
2013-02-12 11:57:51 +00:00
|
|
|
isolate->Dispose();
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
class LockUnlockLockDefaultIsolateThread : public JoinableThread {
|
|
|
|
public:
|
2015-11-18 08:22:07 +00:00
|
|
|
explicit LockUnlockLockDefaultIsolateThread(v8::Local<v8::Context> context)
|
2013-04-24 14:23:46 +00:00
|
|
|
: JoinableThread("LockUnlockLockDefaultIsolateThread"),
|
2013-09-19 09:56:09 +00:00
|
|
|
context_(CcTest::isolate(), context) {}
|
2011-05-05 18:55:31 +00:00
|
|
|
|
|
|
|
virtual void Run() {
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::Locker lock1(CcTest::isolate());
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
2013-09-20 10:52:20 +00:00
|
|
|
v8::Isolate::Scope isolate_scope(CcTest::isolate());
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::HandleScope handle_scope(CcTest::isolate());
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::Local<v8::Context>::New(CcTest::isolate(), context_);
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
{
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::Unlocker unlock1(CcTest::isolate());
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::Locker lock2(CcTest::isolate());
|
2013-09-20 10:52:20 +00:00
|
|
|
v8::Isolate::Scope isolate_scope(CcTest::isolate());
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::HandleScope handle_scope(CcTest::isolate());
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Local<v8::Context> context =
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::Local<v8::Context>::New(CcTest::isolate(), context_);
|
2013-05-28 10:36:21 +00:00
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
CalcFibAndCheck(context);
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
v8::Persistent<v8::Context> context_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-05-05 18:55:31 +00:00
|
|
|
// Locker inside an Unlocker inside a Locker for default isolate.
|
2013-09-20 10:52:20 +00:00
|
|
|
TEST(LockUnlockLockDefaultIsolateMultithreaded) {
|
2013-06-28 15:34:48 +00:00
|
|
|
#if V8_TARGET_ARCH_MIPS
|
2011-11-23 08:36:03 +00:00
|
|
|
const int kNThreads = 50;
|
|
|
|
#else
|
2011-05-05 18:55:31 +00:00
|
|
|
const int kNThreads = 100;
|
2011-11-23 08:36:03 +00:00
|
|
|
#endif
|
2013-05-08 07:45:16 +00:00
|
|
|
Local<v8::Context> context;
|
2013-04-24 14:23:46 +00:00
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
2011-05-05 18:55:31 +00:00
|
|
|
{
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::Locker locker_(CcTest::isolate());
|
2013-09-20 10:52:20 +00:00
|
|
|
v8::Isolate::Scope isolate_scope(CcTest::isolate());
|
2013-09-19 09:56:09 +00:00
|
|
|
v8::HandleScope handle_scope(CcTest::isolate());
|
|
|
|
context = v8::Context::New(CcTest::isolate());
|
2013-04-24 14:23:46 +00:00
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
2013-05-08 07:45:16 +00:00
|
|
|
threads.Add(new LockUnlockLockDefaultIsolateThread(context));
|
2013-04-24 14:23:46 +00:00
|
|
|
}
|
2011-05-05 18:55:31 +00:00
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
|
|
|
}
|
2011-06-07 18:33:03 +00:00
|
|
|
|
|
|
|
|
|
|
|
TEST(Regress1433) {
|
|
|
|
for (int i = 0; i < 10; i++) {
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2011-06-07 18:33:03 +00:00
|
|
|
{
|
|
|
|
v8::Locker lock(isolate);
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
2013-03-15 12:06:53 +00:00
|
|
|
v8::HandleScope handle_scope(isolate);
|
2015-11-18 08:22:07 +00:00
|
|
|
v8::Local<Context> context = v8::Context::New(isolate);
|
2011-06-07 18:33:03 +00:00
|
|
|
v8::Context::Scope context_scope(context);
|
2015-11-18 08:22:07 +00:00
|
|
|
v8::Local<String> source = v8_str("1+1");
|
|
|
|
v8::Local<Script> script =
|
|
|
|
v8::Script::Compile(context, source).ToLocalChecked();
|
|
|
|
v8::Local<Value> result = script->Run(context).ToLocalChecked();
|
2013-05-13 14:18:05 +00:00
|
|
|
v8::String::Utf8Value utf8(result);
|
2011-06-07 18:33:03 +00:00
|
|
|
}
|
|
|
|
isolate->Dispose();
|
|
|
|
}
|
|
|
|
}
|
2011-11-15 22:48:55 +00:00
|
|
|
|
|
|
|
|
|
|
|
static const char* kSimpleExtensionSource =
|
|
|
|
"(function Foo() {"
|
|
|
|
" return 4;"
|
|
|
|
"})() ";
|
|
|
|
|
|
|
|
class IsolateGenesisThread : public JoinableThread {
|
|
|
|
public:
|
|
|
|
IsolateGenesisThread(int count, const char* extension_names[])
|
|
|
|
: JoinableThread("IsolateGenesisThread"),
|
|
|
|
count_(count),
|
|
|
|
extension_names_(extension_names)
|
|
|
|
{}
|
|
|
|
|
|
|
|
virtual void Run() {
|
2015-04-29 09:54:34 +00:00
|
|
|
v8::Isolate::CreateParams create_params;
|
|
|
|
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
2011-11-15 22:48:55 +00:00
|
|
|
{
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
2015-11-23 12:38:18 +00:00
|
|
|
CHECK(
|
|
|
|
!reinterpret_cast<i::Isolate*>(isolate)->has_installed_extensions());
|
2011-11-15 22:48:55 +00:00
|
|
|
v8::ExtensionConfiguration extensions(count_, extension_names_);
|
2013-05-08 07:45:16 +00:00
|
|
|
v8::HandleScope handle_scope(isolate);
|
|
|
|
v8::Context::New(isolate, &extensions);
|
2015-11-23 12:38:18 +00:00
|
|
|
CHECK(reinterpret_cast<i::Isolate*>(isolate)->has_installed_extensions());
|
2011-11-15 22:48:55 +00:00
|
|
|
}
|
|
|
|
isolate->Dispose();
|
|
|
|
}
|
2015-04-29 09:54:34 +00:00
|
|
|
|
2011-11-15 22:48:55 +00:00
|
|
|
private:
|
|
|
|
int count_;
|
|
|
|
const char** extension_names_;
|
|
|
|
};
|
|
|
|
|
2013-07-05 09:52:11 +00:00
|
|
|
|
2011-11-15 22:48:55 +00:00
|
|
|
// Test installing extensions in separate isolates concurrently.
|
|
|
|
// http://code.google.com/p/v8/issues/detail?id=1821
|
|
|
|
TEST(ExtensionsRegistration) {
|
2013-06-28 15:34:48 +00:00
|
|
|
#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_MIPS
|
2011-11-22 18:51:53 +00:00
|
|
|
const int kNThreads = 10;
|
2014-06-24 05:27:44 +00:00
|
|
|
#elif V8_TARGET_ARCH_X64 && V8_TARGET_ARCH_32_BIT
|
|
|
|
const int kNThreads = 4;
|
2016-03-15 18:07:43 +00:00
|
|
|
#elif V8_TARGET_ARCH_S390 && V8_TARGET_ARCH_32_BIT
|
|
|
|
const int kNThreads = 10;
|
2011-11-22 18:51:53 +00:00
|
|
|
#else
|
2011-11-15 22:48:55 +00:00
|
|
|
const int kNThreads = 40;
|
2011-11-22 18:51:53 +00:00
|
|
|
#endif
|
2011-11-15 22:48:55 +00:00
|
|
|
v8::RegisterExtension(new v8::Extension("test0",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test1",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test2",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test3",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test4",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test5",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test6",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
v8::RegisterExtension(new v8::Extension("test7",
|
|
|
|
kSimpleExtensionSource));
|
|
|
|
const char* extension_names[] = { "test0", "test1",
|
|
|
|
"test2", "test3", "test4",
|
|
|
|
"test5", "test6", "test7" };
|
|
|
|
i::List<JoinableThread*> threads(kNThreads);
|
|
|
|
for (int i = 0; i < kNThreads; i++) {
|
|
|
|
threads.Add(new IsolateGenesisThread(8, extension_names));
|
|
|
|
}
|
|
|
|
StartJoinAndDeleteThreads(threads);
|
|
|
|
}
|