AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
ccf0998d63
v8/test/cctest/wasm/test-run-wasm.cc

2869 lines
96 KiB
C++
Raw Normal View History

Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Remove wasm compile time option and enable wasm behind a runtime flag. Deferring enabling of tests to separate per platform CLs. R=machenbach@chromium.org,titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/1553083003 Cr-Commit-Position: refs/heads/master@{#33123}
2016-01-05 18:06:34 +00:00
#include <stdint.h>
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
#include <stdlib.h>
#include <string.h>
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
#include "src/base/platform/elapsed-timer.h"
[turbofan] Add Float32(Max|Min) machine operators. The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2252863003 Cr-Commit-Position: refs/heads/master@{#38784}
2016-08-22 13:50:23 +00:00
#include "src/utils.h"
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
#include "src/wasm/wasm-macro-gen.h"
#include "test/cctest/cctest.h"
#include "test/cctest/compiler/value-helper.h"
Reland of [wasm] Add tests for JS wrappers to test-run-wasm. Fix: pass global object as receiver when calling WASM->JS. R=bradnelson@chromium.org, ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1581393003 Cr-Commit-Position: refs/heads/master@{#33286}
2016-01-14 09:48:45 +00:00
#include "test/cctest/wasm/wasm-run-utils.h"
[wasm] Move test-signatures.h from test/cctest to test/common R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2395743003 Cr-Commit-Position: refs/heads/master@{#39988}
2016-10-05 11:59:47 +00:00
#include "test/common/wasm/test-signatures.h"
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
using namespace v8::base;
using namespace v8::internal;
using namespace v8::internal::compiler;
using namespace v8::internal::wasm;
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
// for even shorter tests.
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
#define B1(a) WASM_BLOCK(a)
#define B2(a, b) WASM_BLOCK(a, b)
#define B3(a, b, c) WASM_BLOCK(a, b, c)
#define RET(x) x, kExprReturn
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
#define RET_I8(x) WASM_I32V_2(x), kExprReturn
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Const) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int32_t kExpectedValue = 0x11223344;
// return(kExpectedValue)
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
BUILD(r, WASM_I32V_5(kExpectedValue));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(kExpectedValue, r.Call());
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Const_many) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int32_t kExpectedValue = *i;
// return(kExpectedValue)
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
BUILD(r, WASM_I32V(kExpectedValue));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(kExpectedValue, r.Call());
}
}
[wasm] Trim graph before scheduling. The scheduler expects a trimmed graph, so we have to trim the graph before scheduling. R=titzer@chromium.org, bmeurer@chromium.org TEST=cctest/test-run-wasm/RunWasmCompiled_GraphTrimming Review-Url: https://chromiumcodereview.appspot.com/2428443002 Cr-Commit-Position: refs/heads/master@{#40446}
2016-10-19 16:21:03 +00:00
WASM_EXEC_TEST(GraphTrimming) {
// This WebAssembly code requires graph trimming in the TurboFan compiler.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Trim graph before scheduling. The scheduler expects a trimmed graph, so we have to trim the graph before scheduling. R=titzer@chromium.org, bmeurer@chromium.org TEST=cctest/test-run-wasm/RunWasmCompiled_GraphTrimming Review-Url: https://chromiumcodereview.appspot.com/2428443002 Cr-Commit-Position: refs/heads/master@{#40446}
2016-10-19 16:21:03 +00:00
BUILD(r, kExprGetLocal, 0, kExprGetLocal, 0, kExprGetLocal, 0, kExprI32RemS,
kExprI32Eq, kExprGetLocal, 0, kExprI32DivS, kExprUnreachable);
r.Call(1);
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Param0) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// return(local[0])
BUILD(r, WASM_GET_LOCAL(0));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Param0_fallthru) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// local[0]
BUILD(r, WASM_GET_LOCAL(0));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Param1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// local[1]
BUILD(r, WASM_GET_LOCAL(1));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(-111, *i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Add) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// 11 + 44
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_I32_ADD(WASM_I32V_1(11), WASM_I32V_1(44)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(55, r.Call());
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Add_P) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// p0 + 13
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_I32_ADD(WASM_I32V_1(13), WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i + 13, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Add_P_fallthru) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// p0 + 13
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_I32_ADD(WASM_I32V_1(13), WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i + 13, r.Call(*i)); }
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
static void RunInt32AddTest(WasmExecutionMode execution_mode, const byte* code,
size_t size) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
r.Build(code, code + size);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
FOR_INT32_INPUTS(j) {
int32_t expected = static_cast<int32_t>(static_cast<uint32_t>(*i) +
static_cast<uint32_t>(*j));
CHECK_EQ(expected, r.Call(*i, *j));
}
}
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(Int32Add_P2) {
FLAG_wasm_mv_prototype = true;
static const byte code[] = {
WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1))};
RunInt32AddTest(execution_mode, code, sizeof(code));
}
WASM_EXEC_TEST(Int32Add_block1) {
FLAG_wasm_mv_prototype = true;
static const byte code[] = {
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
WASM_BLOCK_TT(kWasmI32, kWasmI32, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
kExprI32Add};
RunInt32AddTest(execution_mode, code, sizeof(code));
}
WASM_EXEC_TEST(Int32Add_block2) {
FLAG_wasm_mv_prototype = true;
static const byte code[] = {
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
WASM_BLOCK_TT(kWasmI32, kWasmI32, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
kExprBr, DEPTH_0),
kExprI32Add};
RunInt32AddTest(execution_mode, code, sizeof(code));
}
WASM_EXEC_TEST(Int32Add_multi_if) {
FLAG_wasm_mv_prototype = true;
static const byte code[] = {
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
WASM_IF_ELSE_TT(kWasmI32, kWasmI32, WASM_GET_LOCAL(0),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_SEQ(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)),
WASM_SEQ(WASM_GET_LOCAL(1), WASM_GET_LOCAL(0))),
kExprI32Add};
RunInt32AddTest(execution_mode, code, sizeof(code));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float32Add) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// int(11.5f + 44.5f)
BUILD(r,
WASM_I32_SCONVERT_F32(WASM_F32_ADD(WASM_F32(11.5f), WASM_F32(44.5f))));
CHECK_EQ(56, r.Call());
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float64Add) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// return int(13.5d + 43.5d)
BUILD(r, WASM_I32_SCONVERT_F64(WASM_F64_ADD(WASM_F64(13.5), WASM_F64(43.5))));
CHECK_EQ(57, r.Call());
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestInt32Binop(WasmExecutionMode execution_mode, WasmOpcode opcode,
int32_t expected, int32_t a, int32_t b) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// K op K
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
BUILD(r, WASM_BINOP(opcode, WASM_I32V(a), WASM_I32V(b)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// a op b
BUILD(r, WASM_BINOP(opcode, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
CHECK_EQ(expected, r.Call(a, b));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Binops) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestInt32Binop(execution_mode, kExprI32Add, 88888888, 33333333, 55555555);
TestInt32Binop(execution_mode, kExprI32Sub, -1111111, 7777777, 8888888);
TestInt32Binop(execution_mode, kExprI32Mul, 65130756, 88734, 734);
TestInt32Binop(execution_mode, kExprI32DivS, -66, -4777344, 72384);
TestInt32Binop(execution_mode, kExprI32DivU, 805306368, 0xF0000000, 5);
TestInt32Binop(execution_mode, kExprI32RemS, -3, -3003, 1000);
TestInt32Binop(execution_mode, kExprI32RemU, 4, 4004, 1000);
TestInt32Binop(execution_mode, kExprI32And, 0xEE, 0xFFEE, 0xFF0000FF);
TestInt32Binop(execution_mode, kExprI32Ior, 0xF0FF00FF, 0xF0F000EE,
0x000F0011);
TestInt32Binop(execution_mode, kExprI32Xor, 0xABCDEF01, 0xABCDEFFF, 0xFE);
TestInt32Binop(execution_mode, kExprI32Shl, 0xA0000000, 0xA, 28);
TestInt32Binop(execution_mode, kExprI32ShrU, 0x07000010, 0x70000100, 4);
TestInt32Binop(execution_mode, kExprI32ShrS, 0xFF000000, 0x80000000, 7);
TestInt32Binop(execution_mode, kExprI32Ror, 0x01000000, 0x80000000, 7);
TestInt32Binop(execution_mode, kExprI32Ror, 0x01000000, 0x80000000, 39);
TestInt32Binop(execution_mode, kExprI32Rol, 0x00000040, 0x80000000, 7);
TestInt32Binop(execution_mode, kExprI32Rol, 0x00000040, 0x80000000, 39);
TestInt32Binop(execution_mode, kExprI32Eq, 1, -99, -99);
TestInt32Binop(execution_mode, kExprI32Ne, 0, -97, -97);
TestInt32Binop(execution_mode, kExprI32LtS, 1, -4, 4);
TestInt32Binop(execution_mode, kExprI32LeS, 0, -2, -3);
TestInt32Binop(execution_mode, kExprI32LtU, 1, 0, -6);
TestInt32Binop(execution_mode, kExprI32LeU, 1, 98978, 0xF0000000);
TestInt32Binop(execution_mode, kExprI32GtS, 1, 4, -4);
TestInt32Binop(execution_mode, kExprI32GeS, 0, -3, -2);
TestInt32Binop(execution_mode, kExprI32GtU, 1, -6, 0);
TestInt32Binop(execution_mode, kExprI32GeU, 1, 0xF0000000, 98978);
}
void TestInt32Unop(WasmExecutionMode execution_mode, WasmOpcode opcode,
int32_t expected, int32_t a) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// return op K
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
BUILD(r, WASM_UNOP(opcode, WASM_I32V(a)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// return op a
BUILD(r, WASM_UNOP(opcode, WASM_GET_LOCAL(0)));
CHECK_EQ(expected, r.Call(a));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Clz) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestInt32Unop(execution_mode, kExprI32Clz, 0, 0x80001000);
TestInt32Unop(execution_mode, kExprI32Clz, 1, 0x40000500);
TestInt32Unop(execution_mode, kExprI32Clz, 2, 0x20000300);
TestInt32Unop(execution_mode, kExprI32Clz, 3, 0x10000003);
TestInt32Unop(execution_mode, kExprI32Clz, 4, 0x08050000);
TestInt32Unop(execution_mode, kExprI32Clz, 5, 0x04006000);
TestInt32Unop(execution_mode, kExprI32Clz, 6, 0x02000000);
TestInt32Unop(execution_mode, kExprI32Clz, 7, 0x010000a0);
TestInt32Unop(execution_mode, kExprI32Clz, 8, 0x00800c00);
TestInt32Unop(execution_mode, kExprI32Clz, 9, 0x00400000);
TestInt32Unop(execution_mode, kExprI32Clz, 10, 0x0020000d);
TestInt32Unop(execution_mode, kExprI32Clz, 11, 0x00100f00);
TestInt32Unop(execution_mode, kExprI32Clz, 12, 0x00080000);
TestInt32Unop(execution_mode, kExprI32Clz, 13, 0x00041000);
TestInt32Unop(execution_mode, kExprI32Clz, 14, 0x00020020);
TestInt32Unop(execution_mode, kExprI32Clz, 15, 0x00010300);
TestInt32Unop(execution_mode, kExprI32Clz, 16, 0x00008040);
TestInt32Unop(execution_mode, kExprI32Clz, 17, 0x00004005);
TestInt32Unop(execution_mode, kExprI32Clz, 18, 0x00002050);
TestInt32Unop(execution_mode, kExprI32Clz, 19, 0x00001700);
TestInt32Unop(execution_mode, kExprI32Clz, 20, 0x00000870);
TestInt32Unop(execution_mode, kExprI32Clz, 21, 0x00000405);
TestInt32Unop(execution_mode, kExprI32Clz, 22, 0x00000203);
TestInt32Unop(execution_mode, kExprI32Clz, 23, 0x00000101);
TestInt32Unop(execution_mode, kExprI32Clz, 24, 0x00000089);
TestInt32Unop(execution_mode, kExprI32Clz, 25, 0x00000041);
TestInt32Unop(execution_mode, kExprI32Clz, 26, 0x00000022);
TestInt32Unop(execution_mode, kExprI32Clz, 27, 0x00000013);
TestInt32Unop(execution_mode, kExprI32Clz, 28, 0x00000008);
TestInt32Unop(execution_mode, kExprI32Clz, 29, 0x00000004);
TestInt32Unop(execution_mode, kExprI32Clz, 30, 0x00000002);
TestInt32Unop(execution_mode, kExprI32Clz, 31, 0x00000001);
TestInt32Unop(execution_mode, kExprI32Clz, 32, 0x00000000);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Ctz) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestInt32Unop(execution_mode, kExprI32Ctz, 32, 0x00000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 31, 0x80000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 30, 0x40000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 29, 0x20000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 28, 0x10000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 27, 0xa8000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 26, 0xf4000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 25, 0x62000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 24, 0x91000000);
TestInt32Unop(execution_mode, kExprI32Ctz, 23, 0xcd800000);
TestInt32Unop(execution_mode, kExprI32Ctz, 22, 0x09400000);
TestInt32Unop(execution_mode, kExprI32Ctz, 21, 0xaf200000);
TestInt32Unop(execution_mode, kExprI32Ctz, 20, 0xac100000);
TestInt32Unop(execution_mode, kExprI32Ctz, 19, 0xe0b80000);
TestInt32Unop(execution_mode, kExprI32Ctz, 18, 0x9ce40000);
TestInt32Unop(execution_mode, kExprI32Ctz, 17, 0xc7920000);
TestInt32Unop(execution_mode, kExprI32Ctz, 16, 0xb8f10000);
TestInt32Unop(execution_mode, kExprI32Ctz, 15, 0x3b9f8000);
TestInt32Unop(execution_mode, kExprI32Ctz, 14, 0xdb4c4000);
TestInt32Unop(execution_mode, kExprI32Ctz, 13, 0xe9a32000);
TestInt32Unop(execution_mode, kExprI32Ctz, 12, 0xfca61000);
TestInt32Unop(execution_mode, kExprI32Ctz, 11, 0x6c8a7800);
TestInt32Unop(execution_mode, kExprI32Ctz, 10, 0x8ce5a400);
TestInt32Unop(execution_mode, kExprI32Ctz, 9, 0xcb7d0200);
TestInt32Unop(execution_mode, kExprI32Ctz, 8, 0xcb4dc100);
TestInt32Unop(execution_mode, kExprI32Ctz, 7, 0xdfbec580);
TestInt32Unop(execution_mode, kExprI32Ctz, 6, 0x27a9db40);
TestInt32Unop(execution_mode, kExprI32Ctz, 5, 0xde3bcb20);
TestInt32Unop(execution_mode, kExprI32Ctz, 4, 0xd7e8a610);
TestInt32Unop(execution_mode, kExprI32Ctz, 3, 0x9afdbc88);
TestInt32Unop(execution_mode, kExprI32Ctz, 2, 0x9afdbc84);
TestInt32Unop(execution_mode, kExprI32Ctz, 1, 0x9afdbc82);
TestInt32Unop(execution_mode, kExprI32Ctz, 0, 0x9afdbc81);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Popcnt) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestInt32Unop(execution_mode, kExprI32Popcnt, 32, 0xffffffff);
TestInt32Unop(execution_mode, kExprI32Popcnt, 0, 0x00000000);
TestInt32Unop(execution_mode, kExprI32Popcnt, 1, 0x00008000);
TestInt32Unop(execution_mode, kExprI32Popcnt, 13, 0x12345678);
TestInt32Unop(execution_mode, kExprI32Popcnt, 19, 0xfedcba09);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(I32Eqz) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestInt32Unop(execution_mode, kExprI32Eqz, 0, 1);
TestInt32Unop(execution_mode, kExprI32Eqz, 0, -1);
TestInt32Unop(execution_mode, kExprI32Eqz, 0, -827343);
TestInt32Unop(execution_mode, kExprI32Eqz, 0, 8888888);
TestInt32Unop(execution_mode, kExprI32Eqz, 1, 0);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(I32Shl) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Mask shift counts on architectures that don't implicitly mask. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1845443003 Cr-Commit-Position: refs/heads/master@{#35136}
2016-03-30 12:38:47 +00:00
BUILD(r, WASM_I32_SHL(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_UINT32_INPUTS(i) {
FOR_UINT32_INPUTS(j) {
uint32_t expected = (*i) << (*j & 0x1f);
CHECK_EQ(expected, r.Call(*i, *j));
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(I32Shr) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Mask shift counts on architectures that don't implicitly mask. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1845443003 Cr-Commit-Position: refs/heads/master@{#35136}
2016-03-30 12:38:47 +00:00
BUILD(r, WASM_I32_SHR(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_UINT32_INPUTS(i) {
FOR_UINT32_INPUTS(j) {
uint32_t expected = (*i) >> (*j & 0x1f);
CHECK_EQ(expected, r.Call(*i, *j));
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(I32Sar) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Mask shift counts on architectures that don't implicitly mask. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1845443003 Cr-Commit-Position: refs/heads/master@{#35136}
2016-03-30 12:38:47 +00:00
BUILD(r, WASM_I32_SAR(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_INT32_INPUTS(i) {
FOR_INT32_INPUTS(j) {
int32_t expected = (*i) >> (*j & 0x1f);
CHECK_EQ(expected, r.Call(*i, *j));
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32DivS_trap) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_I32_DIVS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
const int32_t kMin = std::numeric_limits<int32_t>::min();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(0, 100));
CHECK_TRAP(r.Call(100, 0));
CHECK_TRAP(r.Call(-1001, 0));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
CHECK_TRAP(r.Call(kMin, -1));
CHECK_TRAP(r.Call(kMin, 0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32RemS_trap) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_I32_REMS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
const int32_t kMin = std::numeric_limits<int32_t>::min();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(33, r.Call(133, 100));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
CHECK_EQ(0, r.Call(kMin, -1));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(100, 0));
CHECK_TRAP(r.Call(-1001, 0));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
CHECK_TRAP(r.Call(kMin, 0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32DivU_trap) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_I32_DIVU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
const int32_t kMin = std::numeric_limits<int32_t>::min();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(0, 100));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
CHECK_EQ(0, r.Call(kMin, -1));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(100, 0));
CHECK_TRAP(r.Call(-1001, 0));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
CHECK_TRAP(r.Call(kMin, 0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32RemU_trap) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_I32_REMU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
CHECK_EQ(17, r.Call(217, 100));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
const int32_t kMin = std::numeric_limits<int32_t>::min();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(100, 0));
CHECK_TRAP(r.Call(-1001, 0));
[wasm] Fix asm.js semantics for divide by zero in WASM translation. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1839333002 Cr-Commit-Position: refs/heads/master@{#35134}
2016-03-30 11:37:24 +00:00
CHECK_TRAP(r.Call(kMin, 0));
CHECK_EQ(kMin, r.Call(kMin, -1));
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32DivS_byzero_const) {
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int8_t denom = -2; denom < 8; ++denom) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_I32_DIVS(WASM_GET_LOCAL(0), WASM_I32V_1(denom)));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int32_t val = -7; val < 8; ++val) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
if (denom == 0) {
CHECK_TRAP(r.Call(val));
} else {
CHECK_EQ(val / denom, r.Call(val));
}
}
}
}
[asmjs] Do constant folding for I32Asmjs(Div|Rem)S to avoid checks of constant divisors This change makes the embenchen/copy benchmark a factor of 2 faster and brings back the performance loss through graph trimming. R=titzer@chromium.org CC=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2453343002 Cr-Commit-Position: refs/heads/master@{#40628}
2016-10-27 16:02:24 +00:00
WASM_EXEC_TEST(Int32AsmjsDivS_byzero_const) {
for (int8_t denom = -2; denom < 8; ++denom) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
r.module().ChangeOriginToAsmjs();
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_I32_ASMJS_DIVS(WASM_GET_LOCAL(0), WASM_I32V_1(denom)));
[asmjs] Do constant folding for I32Asmjs(Div|Rem)S to avoid checks of constant divisors This change makes the embenchen/copy benchmark a factor of 2 faster and brings back the performance loss through graph trimming. R=titzer@chromium.org CC=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2453343002 Cr-Commit-Position: refs/heads/master@{#40628}
2016-10-27 16:02:24 +00:00
FOR_INT32_INPUTS(i) {
if (denom == 0) {
CHECK_EQ(0, r.Call(*i));
} else if (denom == -1 && *i == std::numeric_limits<int32_t>::min()) {
CHECK_EQ(std::numeric_limits<int32_t>::min(), r.Call(*i));
} else {
CHECK_EQ(*i / denom, r.Call(*i));
}
}
}
}
WASM_EXEC_TEST(Int32AsmjsRemS_byzero_const) {
for (int8_t denom = -2; denom < 8; ++denom) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
r.module().ChangeOriginToAsmjs();
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_I32_ASMJS_REMS(WASM_GET_LOCAL(0), WASM_I32V_1(denom)));
[asmjs] Do constant folding for I32Asmjs(Div|Rem)S to avoid checks of constant divisors This change makes the embenchen/copy benchmark a factor of 2 faster and brings back the performance loss through graph trimming. R=titzer@chromium.org CC=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2453343002 Cr-Commit-Position: refs/heads/master@{#40628}
2016-10-27 16:02:24 +00:00
FOR_INT32_INPUTS(i) {
if (denom == 0) {
CHECK_EQ(0, r.Call(*i));
} else if (denom == -1 && *i == std::numeric_limits<int32_t>::min()) {
CHECK_EQ(0, r.Call(*i));
} else {
CHECK_EQ(*i % denom, r.Call(*i));
}
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32DivU_byzero_const) {
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t denom = 0xfffffffe; denom < 8; ++denom) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t> r(execution_mode);
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
BUILD(r, WASM_I32_DIVU(WASM_GET_LOCAL(0), WASM_I32V_1(denom)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t val = 0xfffffff0; val < 8; ++val) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
if (denom == 0) {
CHECK_TRAP(r.Call(val));
} else {
CHECK_EQ(val / denom, r.Call(val));
}
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32DivS_trap_effect) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
r.module().AddMemoryElems<int32_t>(8);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_IF_ELSE_I(
WASM_GET_LOCAL(0),
WASM_I32_DIVS(
WASM_BLOCK_I(WASM_STORE_MEM(MachineType::Int8(), WASM_ZERO,
WASM_GET_LOCAL(0)),
WASM_GET_LOCAL(0)),
WASM_GET_LOCAL(1)),
WASM_I32_DIVS(
WASM_BLOCK_I(WASM_STORE_MEM(MachineType::Int8(), WASM_ZERO,
WASM_GET_LOCAL(0)),
WASM_GET_LOCAL(0)),
WASM_GET_LOCAL(1))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(0, 100));
CHECK_TRAP(r.Call(8, 0));
CHECK_TRAP(r.Call(4, 0));
CHECK_TRAP(r.Call(0, 0));
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestFloat32Binop(WasmExecutionMode execution_mode, WasmOpcode opcode,
int32_t expected, float a, float b) {
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return K op K
BUILD(r, WASM_BINOP(opcode, WASM_F32(a), WASM_F32(b)));
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, float, float> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return a op b
BUILD(r, WASM_BINOP(opcode, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
CHECK_EQ(expected, r.Call(a, b));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestFloat32BinopWithConvert(WasmExecutionMode execution_mode,
WasmOpcode opcode, int32_t expected, float a,
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
float b) {
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(K op K)
BUILD(r,
WASM_I32_SCONVERT_F32(WASM_BINOP(opcode, WASM_F32(a), WASM_F32(b))));
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, float, float> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(a op b)
BUILD(r, WASM_I32_SCONVERT_F32(
WASM_BINOP(opcode, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1))));
CHECK_EQ(expected, r.Call(a, b));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestFloat32UnopWithConvert(WasmExecutionMode execution_mode,
WasmOpcode opcode, int32_t expected, float a) {
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(op(K))
BUILD(r, WASM_I32_SCONVERT_F32(WASM_UNOP(opcode, WASM_F32(a))));
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, float> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(op(a))
BUILD(r, WASM_I32_SCONVERT_F32(WASM_UNOP(opcode, WASM_GET_LOCAL(0))));
CHECK_EQ(expected, r.Call(a));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestFloat64Binop(WasmExecutionMode execution_mode, WasmOpcode opcode,
int32_t expected, double a, double b) {
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return K op K
BUILD(r, WASM_BINOP(opcode, WASM_F64(a), WASM_F64(b)));
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, double, double> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return a op b
BUILD(r, WASM_BINOP(opcode, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
CHECK_EQ(expected, r.Call(a, b));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestFloat64BinopWithConvert(WasmExecutionMode execution_mode,
WasmOpcode opcode, int32_t expected, double a,
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
double b) {
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(K op K)
BUILD(r,
WASM_I32_SCONVERT_F64(WASM_BINOP(opcode, WASM_F64(a), WASM_F64(b))));
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, double, double> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
BUILD(r, WASM_I32_SCONVERT_F64(
WASM_BINOP(opcode, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1))));
CHECK_EQ(expected, r.Call(a, b));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
void TestFloat64UnopWithConvert(WasmExecutionMode execution_mode,
WasmOpcode opcode, int32_t expected, double a) {
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
{
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(op(K))
BUILD(r, WASM_I32_SCONVERT_F64(WASM_UNOP(opcode, WASM_F64(a))));
CHECK_EQ(expected, r.Call());
}
{
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, double> r(execution_mode);
[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1562883003 Cr-Commit-Position: refs/heads/master@{#33152}
2016-01-07 10:55:27 +00:00
// return int(op(a))
BUILD(r, WASM_I32_SCONVERT_F64(WASM_UNOP(opcode, WASM_GET_LOCAL(0))));
CHECK_EQ(expected, r.Call(a));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float32Binops) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestFloat32Binop(execution_mode, kExprF32Eq, 1, 8.125f, 8.125f);
TestFloat32Binop(execution_mode, kExprF32Ne, 1, 8.125f, 8.127f);
TestFloat32Binop(execution_mode, kExprF32Lt, 1, -9.5f, -9.0f);
TestFloat32Binop(execution_mode, kExprF32Le, 1, -1111.0f, -1111.0f);
TestFloat32Binop(execution_mode, kExprF32Gt, 1, -9.0f, -9.5f);
TestFloat32Binop(execution_mode, kExprF32Ge, 1, -1111.0f, -1111.0f);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestFloat32BinopWithConvert(execution_mode, kExprF32Add, 10, 3.5f, 6.5f);
TestFloat32BinopWithConvert(execution_mode, kExprF32Sub, 2, 44.5f, 42.5f);
TestFloat32BinopWithConvert(execution_mode, kExprF32Mul, -66, -132.1f, 0.5f);
TestFloat32BinopWithConvert(execution_mode, kExprF32Div, 11, 22.1f, 2.0f);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float32Unops) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestFloat32UnopWithConvert(execution_mode, kExprF32Abs, 8, 8.125f);
TestFloat32UnopWithConvert(execution_mode, kExprF32Abs, 9, -9.125f);
TestFloat32UnopWithConvert(execution_mode, kExprF32Neg, -213, 213.125f);
TestFloat32UnopWithConvert(execution_mode, kExprF32Sqrt, 12, 144.4f);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float64Binops) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestFloat64Binop(execution_mode, kExprF64Eq, 1, 16.25, 16.25);
TestFloat64Binop(execution_mode, kExprF64Ne, 1, 16.25, 16.15);
TestFloat64Binop(execution_mode, kExprF64Lt, 1, -32.4, 11.7);
TestFloat64Binop(execution_mode, kExprF64Le, 1, -88.9, -88.9);
TestFloat64Binop(execution_mode, kExprF64Gt, 1, 11.7, -32.4);
TestFloat64Binop(execution_mode, kExprF64Ge, 1, -88.9, -88.9);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestFloat64BinopWithConvert(execution_mode, kExprF64Add, 100, 43.5, 56.5);
TestFloat64BinopWithConvert(execution_mode, kExprF64Sub, 200, 12200.1,
12000.1);
TestFloat64BinopWithConvert(execution_mode, kExprF64Mul, -33, 134, -0.25);
TestFloat64BinopWithConvert(execution_mode, kExprF64Div, -1111, -2222.3, 2);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float64Unops) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
TestFloat64UnopWithConvert(execution_mode, kExprF64Abs, 108, 108.125);
TestFloat64UnopWithConvert(execution_mode, kExprF64Abs, 209, -209.125);
TestFloat64UnopWithConvert(execution_mode, kExprF64Neg, -209, 209.125);
TestFloat64UnopWithConvert(execution_mode, kExprF64Sqrt, 13, 169.4);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float32Neg) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
[wasm] Fixed F32Neg and F64Neg for -0.0. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1516143004 Cr-Commit-Position: refs/heads/master@{#32802}
2015-12-11 15:29:24 +00:00
BUILD(r, WASM_F32_NEG(WASM_GET_LOCAL(0)));
[wasm] Fixed FxxNeg for inputs of NaN. The new implementation also changes the sign bit if the input is NaN. (https://github.com/WebAssembly/v8-native-prototype/issues/99) R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1532513002 Cr-Commit-Position: refs/heads/master@{#32894}
2015-12-16 11:44:46 +00:00
FOR_FLOAT32_INPUTS(i) {
CHECK_EQ(0x80000000,
bit_cast<uint32_t>(*i) ^ bit_cast<uint32_t>(r.Call(*i)));
}
[wasm] Fixed F32Neg and F64Neg for -0.0. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1516143004 Cr-Commit-Position: refs/heads/master@{#32802}
2015-12-11 15:29:24 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float64Neg) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
[wasm] Fixed F32Neg and F64Neg for -0.0. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1516143004 Cr-Commit-Position: refs/heads/master@{#32802}
2015-12-11 15:29:24 +00:00
BUILD(r, WASM_F64_NEG(WASM_GET_LOCAL(0)));
[wasm] Fixed FxxNeg for inputs of NaN. The new implementation also changes the sign bit if the input is NaN. (https://github.com/WebAssembly/v8-native-prototype/issues/99) R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1532513002 Cr-Commit-Position: refs/heads/master@{#32894}
2015-12-16 11:44:46 +00:00
FOR_FLOAT64_INPUTS(i) {
CHECK_EQ(0x8000000000000000,
bit_cast<uint64_t>(*i) ^ bit_cast<uint64_t>(r.Call(*i)));
}
[wasm] Fixed F32Neg and F64Neg for -0.0. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1516143004 Cr-Commit-Position: refs/heads/master@{#32802}
2015-12-11 15:29:24 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfElse_P) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// if (p0) return 11; else return 22;
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_IF_ELSE_I(WASM_GET_LOCAL(0), // --
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_1(11), // --
WASM_I32V_1(22))); // --
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 11 : 22;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
#define EMPTY
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(If_empty1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_GET_LOCAL(0), kExprIf, kLocalVoid, kExprEnd, WASM_GET_LOCAL(1));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i - 9, *i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfElse_empty1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_GET_LOCAL(0), kExprIf, kLocalVoid, kExprElse, kExprEnd,
WASM_GET_LOCAL(1));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i - 8, *i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfElse_empty2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_GET_LOCAL(0), kExprIf, kLocalVoid, WASM_NOP, kExprElse,
kExprEnd, WASM_GET_LOCAL(1));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i - 7, *i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfElse_empty3) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_GET_LOCAL(0), kExprIf, kLocalVoid, kExprElse, WASM_NOP,
kExprEnd, WASM_GET_LOCAL(1));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i - 6, *i)); }
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(If_chain1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
// if (p0) 13; if (p0) 14; 15
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_IF(WASM_GET_LOCAL(0), WASM_NOP),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_IF(WASM_GET_LOCAL(0), WASM_NOP), WASM_I32V_1(15));
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(15, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(If_chain_set) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
// if (p0) p1 = 73; if (p0) p1 = 74; p1
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_IF(WASM_GET_LOCAL(0), WASM_SET_LOCAL(1, WASM_I32V_2(73))),
WASM_IF(WASM_GET_LOCAL(0), WASM_SET_LOCAL(1, WASM_I32V_2(74))),
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
WASM_GET_LOCAL(1));
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 74 : *i;
CHECK_EQ(expected, r.Call(*i, *i));
}
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfElse_Unreachable1) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
// 0 ? unreachable : 27
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_IF_ELSE_I(WASM_ZERO, // --
WASM_UNREACHABLE, // --
WASM_I32V_1(27))); // --
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(27, r.Call());
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(IfElse_Unreachable2) {
WasmRunner<int32_t> r(execution_mode);
// 1 ? 28 : unreachable
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_IF_ELSE_I(WASM_I32V_1(1), // --
WASM_I32V_1(28), // --
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_UNREACHABLE)); // --
CHECK_EQ(28, r.Call());
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Return12) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, RET_I8(12));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(12, r.Call());
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Return17) {
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK(RET_I8(17)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(17, r.Call());
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Return_I32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, RET(WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Return_F32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, RET(WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_FLOAT32_INPUTS(i) {
float expect = *i;
float result = r.Call(expect);
if (std::isnan(expect)) {
CHECK(std::isnan(result));
} else {
CHECK_EQ(expect, result);
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Return_F64) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, RET(WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_FLOAT64_INPUTS(i) {
double expect = *i;
double result = r.Call(expect);
if (std::isnan(expect)) {
CHECK(std::isnan(result));
} else {
CHECK_EQ(expect, result);
}
}
}
[wasm] Use correct parameter type in wasm-run-utils.h Due to a typo wasm-run-utils used the type of the first parameter for all parameters. This caused problems if not all parameters had the same type. R=titzer@chromium.org, clemensh@chromium.org Review-Url: https://codereview.chromium.org/2463743002 Cr-Commit-Position: refs/heads/master@{#40667}
2016-10-31 10:51:17 +00:00
WASM_EXEC_TEST(Select_float_parameters) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float, float, int32_t> r(execution_mode);
[wasm] Use correct parameter type in wasm-run-utils.h Due to a typo wasm-run-utils used the type of the first parameter for all parameters. This caused problems if not all parameters had the same type. R=titzer@chromium.org, clemensh@chromium.org Review-Url: https://codereview.chromium.org/2463743002 Cr-Commit-Position: refs/heads/master@{#40667}
2016-10-31 10:51:17 +00:00
// return select(11, 22, a);
BUILD(r,
WASM_SELECT(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1), WASM_GET_LOCAL(2)));
CHECK_FLOAT_EQ(2.0f, r.Call(2.0f, 1.0f, 1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Select) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
// return select(11, 22, a);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_SELECT(WASM_I32V_1(11), WASM_I32V_1(22), WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 11 : 22;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Select_strict1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
// select(a=0, a=1, a=2); return a
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_SELECT(WASM_TEE_LOCAL(0, WASM_ZERO),
WASM_TEE_LOCAL(0, WASM_I32V_1(1)),
WASM_TEE_LOCAL(0, WASM_I32V_1(2))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_DROP, WASM_GET_LOCAL(0));
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(2, r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Select_strict2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
r.AllocateLocal(kWasmI32);
r.AllocateLocal(kWasmI32);
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
// select(b=5, c=6, a)
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_SELECT(WASM_TEE_LOCAL(1, WASM_I32V_1(5)),
WASM_TEE_LOCAL(2, WASM_I32V_1(6)), WASM_GET_LOCAL(0)));
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 5 : 6;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Select_strict3) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
r.AllocateLocal(kWasmI32);
r.AllocateLocal(kWasmI32);
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
// select(b=5, c=6, a=b)
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_SELECT(WASM_TEE_LOCAL(1, WASM_I32V_1(5)),
WASM_TEE_LOCAL(2, WASM_I32V_1(6)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_TEE_LOCAL(0, WASM_GET_LOCAL(1))));
[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Review URL: https://codereview.chromium.org/1624323003 Cr-Commit-Position: refs/heads/master@{#33776}
2016-02-05 13:34:41 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = 5;
CHECK_EQ(expected, r.Call(*i));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrIf_strict) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV_IF(0, WASM_GET_LOCAL(0),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_TEE_LOCAL(0, WASM_I32V_2(99)))));
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/2345593003 Cr-Commit-Position: refs/heads/master@{#39678}
2016-09-23 15:56:42 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/2345593003 Cr-Commit-Position: refs/heads/master@{#39678}
2016-09-23 15:56:42 +00:00
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(Br_height) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BLOCK_I(WASM_BRV_IFD(0, WASM_GET_LOCAL(0),
WASM_GET_LOCAL(0)),
WASM_RETURN1(WASM_I32V_1(9)),
WASM_I32V_1(7), WASM_I32V_1(7)),
WASM_BRV(0, WASM_I32V_1(8))));
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
for (int32_t i = 0; i < 5; i++) {
int32_t expected = i != 0 ? 8 : 9;
CHECK_EQ(expected, r.Call(i));
}
}
[wasm] Fix br_table in the wasm interpreter to use varuint32. The wasm interpreter crashed because it interpreted the table of br_table as a table of uint8, but according to the spec it is a table of varint32. Therefore the wasm interpreter misinterpreted 0x80 0x00 as 128 and not as 0, which caused a crash. R=tizer@chromium.org BUG=chromium:660262 TEST=cctest/test-run-wasm/RunWasmInterpreted_Regression_660262 Review-Url: https://codereview.chromium.org/2463063002 Cr-Commit-Position: refs/heads/master@{#40708}
2016-11-02 17:06:38 +00:00
WASM_EXEC_TEST(Regression_660262) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
r.module().AddMemoryElems<int32_t>(8);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, kExprI32Const, 0x00, kExprI32Const, 0x00, kExprI32LoadMem, 0x00,
0x0f, kExprBrTable, 0x00, 0x80, 0x00); // entries=0
[wasm] Fix br_table in the wasm interpreter to use varuint32. The wasm interpreter crashed because it interpreted the table of br_table as a table of uint8, but according to the spec it is a table of varint32. Therefore the wasm interpreter misinterpreted 0x80 0x00 as 128 and not as 0, which caused a crash. R=tizer@chromium.org BUG=chromium:660262 TEST=cctest/test-run-wasm/RunWasmInterpreted_Regression_660262 Review-Url: https://codereview.chromium.org/2463063002 Cr-Commit-Position: refs/heads/master@{#40708}
2016-11-02 17:06:38 +00:00
r.Call();
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(BrTable0a) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, B1(B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 0, BR_TARGET(0)))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(91));
[wasm] Fix decoding failures for tableswitch. R=ahaas@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1642043002 Cr-Commit-Position: refs/heads/master@{#33581}
2016-01-28 12:54:12 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(91, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable0b) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r,
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
B1(B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 1, BR_TARGET(0), BR_TARGET(0)))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(92));
[wasm] Fix decoding failures for tableswitch. R=ahaas@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1642043002 Cr-Commit-Position: refs/heads/master@{#33581}
2016-01-28 12:54:12 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(92, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable0c) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(
r,
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
B1(B2(B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 1, BR_TARGET(0), BR_TARGET(1))),
RET_I8(76))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(77));
[wasm] Fix decoding failures for tableswitch. R=ahaas@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1642043002 Cr-Commit-Position: refs/heads/master@{#33581}
2016-01-28 12:54:12 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i == 0 ? 76 : 77;
CHECK_EQ(expected, r.Call(*i));
}
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 0, BR_TARGET(0))), RET_I8(93));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(93, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable_loop) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r,
B2(B1(WASM_LOOP(WASM_BR_TABLE(WASM_INC_LOCAL_BYV(0, 1), 2, BR_TARGET(2),
BR_TARGET(1), BR_TARGET(0)))),
RET_I8(99)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(98));
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
CHECK_EQ(99, r.Call(0));
CHECK_EQ(98, r.Call(-1));
CHECK_EQ(98, r.Call(-2));
CHECK_EQ(98, r.Call(-3));
CHECK_EQ(98, r.Call(-100));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable_br) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r,
B2(B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 1, BR_TARGET(1), BR_TARGET(0))),
RET_I8(91)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(99));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(99, r.Call(0));
CHECK_EQ(91, r.Call(1));
CHECK_EQ(91, r.Call(2));
CHECK_EQ(91, r.Call(3));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable_br2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, B2(B2(B2(B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 3, BR_TARGET(1),
BR_TARGET(2), BR_TARGET(3), BR_TARGET(0))),
RET_I8(85)),
RET_I8(86)),
RET_I8(87)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(88));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(86, r.Call(0));
CHECK_EQ(87, r.Call(1));
CHECK_EQ(88, r.Call(2));
CHECK_EQ(85, r.Call(3));
CHECK_EQ(85, r.Call(4));
CHECK_EQ(85, r.Call(5));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable4) {
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < 4; ++i) {
for (int t = 0; t < 4; ++t) {
[Wasm] Convert many of the fixed-size values to LEB128. This CL modifies the following to be LEB128: * Function table indices * Import table signature indices * Export table function indices * Function signature param count * br/br_if break depth * br_table target count * block/loop expression count Still to do: * Import/export names (LEB128 count + inline data) * Data segments (LEB128 offset + size + inline data) * Function header stuff (should seperate into function sig and body sections) * Memory access alignment + offset (still discussing) BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/1775873002 Cr-Commit-Position: refs/heads/master@{#34603}
2016-03-08 22:54:43 +00:00
uint32_t cases[] = {0, 1, 2, 3};
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
cases[i] = t;
byte code[] = {B2(B2(B2(B2(B1(WASM_BR_TABLE(
WASM_GET_LOCAL(0), 3, BR_TARGET(cases[0]),
BR_TARGET(cases[1]), BR_TARGET(cases[2]),
BR_TARGET(cases[3]))),
RET_I8(70)),
RET_I8(71)),
RET_I8(72)),
RET_I8(73)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(75)};
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
r.Build(code, code + arraysize(code));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int x = -3; x < 50; ++x) {
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
int index = (x > 3 || x < 0) ? 3 : x;
int32_t expected = 70 + cases[index];
CHECK_EQ(expected, r.Call(x));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable4x4) {
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (byte a = 0; a < 4; ++a) {
for (byte b = 0; b < 4; ++b) {
for (byte c = 0; c < 4; ++c) {
for (byte d = 0; d < 4; ++d) {
for (int i = 0; i < 4; ++i) {
[Wasm] Convert many of the fixed-size values to LEB128. This CL modifies the following to be LEB128: * Function table indices * Import table signature indices * Export table function indices * Function signature param count * br/br_if break depth * br_table target count * block/loop expression count Still to do: * Import/export names (LEB128 count + inline data) * Data segments (LEB128 offset + size + inline data) * Function header stuff (should seperate into function sig and body sections) * Memory access alignment + offset (still discussing) BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/1775873002 Cr-Commit-Position: refs/heads/master@{#34603}
2016-03-08 22:54:43 +00:00
uint32_t cases[] = {a, b, c, d};
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
byte code[] = {
B2(B2(B2(B2(B1(WASM_BR_TABLE(
WASM_GET_LOCAL(0), 3, BR_TARGET(cases[0]),
BR_TARGET(cases[1]), BR_TARGET(cases[2]),
BR_TARGET(cases[3]))),
RET_I8(50)),
RET_I8(51)),
RET_I8(52)),
RET_I8(53)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(55)};
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
r.Build(code, code + arraysize(code));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int x = -6; x < 47; ++x) {
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
int index = (x > 3 || x < 0) ? 3 : x;
int32_t expected = 50 + cases[index];
CHECK_EQ(expected, r.Call(x));
}
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(BrTable4_fallthru) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
byte code[] = {
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
B2(B2(B2(B2(B1(WASM_BR_TABLE(WASM_GET_LOCAL(0), 3, BR_TARGET(0),
BR_TARGET(1), BR_TARGET(2), BR_TARGET(3))),
WASM_INC_LOCAL_BY(1, 1)),
WASM_INC_LOCAL_BY(1, 2)),
WASM_INC_LOCAL_BY(1, 4)),
WASM_INC_LOCAL_BY(1, 8)),
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
WASM_GET_LOCAL(1)};
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
r.Build(code, code + arraysize(code));
CHECK_EQ(15, r.Call(0, 0));
CHECK_EQ(14, r.Call(1, 0));
CHECK_EQ(12, r.Call(2, 0));
CHECK_EQ(8, r.Call(3, 0));
CHECK_EQ(8, r.Call(4, 0));
CHECK_EQ(115, r.Call(0, 100));
CHECK_EQ(114, r.Call(1, 100));
CHECK_EQ(112, r.Call(2, 100));
CHECK_EQ(108, r.Call(3, 100));
CHECK_EQ(108, r.Call(4, 100));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32ReinterpretI32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(8);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_I32_REINTERPRET_F32(
WASM_LOAD_MEM(MachineType::Float32(), WASM_ZERO)));
FOR_INT32_INPUTS(i) {
int32_t expected = *i;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], expected);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(expected, r.Call());
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(I32ReinterpretF32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(8);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_STORE_MEM(MachineType::Float32(), WASM_ZERO,
WASM_F32_REINTERPRET_I32(WASM_GET_LOCAL(0))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(107));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i;
CHECK_EQ(107, r.Call(expected));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(expected, r.module().ReadMemory(&memory[0]));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(LoadMaxUint32Offset) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
r.module().AddMemoryElems<int32_t>(8);
[wasm] Always trap for memory accesses with offset=uint32_max. We handle this case specially because otherwise we would have to do complicated overflow detection. R=titzer@chromium.org TEST=cctest/test-run-wasm/RunWasmCompiled_LoadMaxUint32Offset Review-Url: https://codereview.chromium.org/2490533003 Cr-Commit-Position: refs/heads/master@{#40844}
2016-11-08 15:46:55 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, kExprI32Const, 0, // index
[wasm] Always trap for memory accesses with offset=uint32_max. We handle this case specially because otherwise we would have to do complicated overflow detection. R=titzer@chromium.org TEST=cctest/test-run-wasm/RunWasmCompiled_LoadMaxUint32Offset Review-Url: https://codereview.chromium.org/2490533003 Cr-Commit-Position: refs/heads/master@{#40844}
2016-11-08 15:46:55 +00:00
static_cast<byte>(v8::internal::wasm::WasmOpcodes::LoadStoreOpcodeOf(
MachineType::Int32(), false)), // --
0, // alignment
U32V_5(0xffffffff)); // offset
CHECK_TRAP32(r.Call());
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(LoadStoreLoad) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(8);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_STORE_MEM(MachineType::Int32(), WASM_ZERO,
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_LOAD_MEM(MachineType::Int32(), WASM_ZERO)),
WASM_LOAD_MEM(MachineType::Int32(), WASM_ZERO));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], expected);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(expected, r.Call());
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(VoidReturn1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
const int32_t kExpected = -414444;
WasmRunner<int32_t> r(execution_mode);
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
// Build the test function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& test_func = r.NewFunction<void>();
BUILD(test_func, kExprNop);
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
// Build the calling function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION0(test_func.function_index()),
WASM_I32V_3(kExpected));
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
// Call and check.
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
int32_t result = r.Call();
CHECK_EQ(kExpected, result);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(VoidReturn2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
const int32_t kExpected = -414444;
WasmRunner<int32_t> r(execution_mode);
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
// Build the test function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& test_func = r.NewFunction<void>();
BUILD(test_func, WASM_RETURN0);
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
// Build the calling function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION0(test_func.function_index()),
WASM_I32V_3(kExpected));
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
// Call and check.
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner. The BufferedRawMachineAssemblerTester caused problems for the Int64Lowering. Instead we construct a TF graph now which is compiled by Pipeline::GenerateCodeForTesting. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1702023002 Cr-Commit-Position: refs/heads/master@{#34107}
2016-02-18 09:55:25 +00:00
int32_t result = r.Call();
CHECK_EQ(kExpected, result);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(BrEmpty) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BRV(0, WASM_GET_LOCAL(0)));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
WASM_EXEC_TEST(BrIfEmpty) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BRV_IF(0, WASM_GET_LOCAL(0), WASM_GET_LOCAL(0)));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_empty) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, kExprBlock, kLocalVoid, kExprEnd, WASM_GET_LOCAL(0));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_empty_br1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
BUILD(r, B1(WASM_BR(0)), WASM_GET_LOCAL(0));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_empty_brif1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK(WASM_BR_IF(0, WASM_ZERO)), WASM_GET_LOCAL(0));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_empty_brif2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK(WASM_BR_IF(0, WASM_GET_LOCAL(1))), WASM_GET_LOCAL(0));
[wasm] Fix -Wsign-compare warnings. BUG=v8:5614 Review-Url: https://codereview.chromium.org/2487673004 Cr-Commit-Position: refs/heads/master@{#40891}
2016-11-10 12:50:51 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i, *i + 1)); }
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(Block_i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_I(WASM_GET_LOCAL(0)));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
WASM_EXEC_TEST(Block_f) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_F(WASM_GET_LOCAL(0)));
FOR_FLOAT32_INPUTS(i) { CHECK_FLOAT_EQ(*i, r.Call(*i)); }
}
WASM_EXEC_TEST(Block_d) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_D(WASM_GET_LOCAL(0)));
FOR_FLOAT64_INPUTS(i) { CHECK_FLOAT_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_br2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV(0, WASM_GET_LOCAL(0))));
[wasm] Fix -Wsign-compare warnings. BUG=v8:5614 Review-Url: https://codereview.chromium.org/2487673004 Cr-Commit-Position: refs/heads/master@{#40891}
2016-11-10 12:50:51 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, static_cast<uint32_t>(r.Call(*i))); }
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_If_P) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
// block { if (p0) break 51; 52; }
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I( // --
WASM_IF(WASM_GET_LOCAL(0), // --
WASM_BRV(1, WASM_I32V_1(51))), // --
WASM_I32V_1(52))); // --
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 51 : 52;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Loop_empty) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, kExprLoop, kLocalVoid, kExprEnd, WASM_GET_LOCAL(0));
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
WASM_EXEC_TEST(Loop_i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP_I(WASM_GET_LOCAL(0)));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(Loop_f) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP_F(WASM_GET_LOCAL(0)));
FOR_FLOAT32_INPUTS(i) { CHECK_FLOAT_EQ(*i, r.Call(*i)); }
}
WASM_EXEC_TEST(Loop_d) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP_D(WASM_GET_LOCAL(0)));
FOR_FLOAT64_INPUTS(i) { CHECK_FLOAT_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Loop_empty_br1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, B1(WASM_LOOP(WASM_BR(1))), WASM_GET_LOCAL(0));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Loop_empty_brif1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, B1(WASM_LOOP(WASM_BR_IF(1, WASM_ZERO))), WASM_GET_LOCAL(0));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_INT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i)); }
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Loop_empty_brif2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP_I(WASM_BRV_IF(1, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1))));
[wasm] Add some tests for control flow corner cases. R=ahaas@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1960143002 Cr-Commit-Position: refs/heads/master@{#36112}
2016-05-09 14:45:38 +00:00
FOR_UINT32_INPUTS(i) { CHECK_EQ(*i, r.Call(*i, *i + 1)); }
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(Loop_empty_brif3) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, uint32_t, uint32_t, uint32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP(WASM_BRV_IFD(1, WASM_GET_LOCAL(2), WASM_GET_LOCAL(0))),
WASM_GET_LOCAL(1));
FOR_UINT32_INPUTS(i) {
FOR_UINT32_INPUTS(j) {
CHECK_EQ(*i, r.Call(0, *i, *j));
CHECK_EQ(*j, r.Call(1, *i, *j));
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_BrIf_P) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV_IFD(0, WASM_I32V_1(51), WASM_GET_LOCAL(0)),
WASM_I32V_1(52)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 51 : 52;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_IfElse_P_assign) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// { if (p0) p0 = 71; else p0 = 72; return p0; }
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, // --
WASM_IF_ELSE(WASM_GET_LOCAL(0), // --
WASM_SET_LOCAL(0, WASM_I32V_2(71)), // --
WASM_SET_LOCAL(0, WASM_I32V_2(72))), // --
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 71 : 72;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_IfElse_P_return) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// if (p0) return 81; else return 82;
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, // --
WASM_IF_ELSE(WASM_GET_LOCAL(0), // --
RET_I8(81), // --
RET_I8(82))); // --
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 81 : 82;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Block_If_P_assign) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// { if (p0) p0 = 61; p0; }
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_IF(WASM_GET_LOCAL(0), WASM_SET_LOCAL(0, WASM_I32V_1(61))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 61 : *i;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(DanglingAssign) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 Review URL: https://codereview.chromium.org/1573053003 Cr-Commit-Position: refs/heads/master@{#33213}
2016-01-11 17:37:59 +00:00
// { return 0; p0 = 0; }
[wasm] Remove TableSwitch and replace with br_table. R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
2016-03-04 23:48:00 +00:00
BUILD(r, B2(RET_I8(99), WASM_SET_LOCAL(0, WASM_ZERO)));
[wasm] Fix set_local appearing in unreachable code. R=ahaas@chromium.org LOG=Y BUG=chromium:575861 Review URL: https://codereview.chromium.org/1573053003 Cr-Commit-Position: refs/heads/master@{#33213}
2016-01-11 17:37:59 +00:00
CHECK_EQ(99, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprIf_P) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// p0 ? 11 : 22;
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_IF_ELSE_I(WASM_GET_LOCAL(0), // --
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_1(11), // --
WASM_I32V_1(22))); // --
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
int32_t expected = *i ? 11 : 22;
CHECK_EQ(expected, r.Call(*i));
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CountDown) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_LOOP(WASM_IFB(WASM_GET_LOCAL(0),
WASM_SET_LOCAL(0, WASM_I32_SUB(WASM_GET_LOCAL(0),
WASM_I32V_1(1))),
WASM_BR(1))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(1));
CHECK_EQ(0, r.Call(10));
CHECK_EQ(0, r.Call(100));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CountDown_fallthru) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(
r,
WASM_LOOP(
WASM_IF(WASM_NOT(WASM_GET_LOCAL(0)), WASM_BRV(2, WASM_GET_LOCAL(0))),
WASM_SET_LOCAL(0, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_I32V_1(1))),
WASM_CONTINUE(0)),
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(1));
CHECK_EQ(0, r.Call(10));
CHECK_EQ(0, r.Call(100));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(WhileCountDown) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_WHILE(WASM_GET_LOCAL(0),
WASM_SET_LOCAL(
0, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_I32V_1(1)))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(1));
CHECK_EQ(0, r.Call(10));
CHECK_EQ(0, r.Call(100));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Loop_if_break1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP(WASM_IF(WASM_GET_LOCAL(0), WASM_BRV(2, WASM_GET_LOCAL(1))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_SET_LOCAL(0, WASM_I32V_2(99))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
CHECK_EQ(99, r.Call(0, 11));
CHECK_EQ(65, r.Call(3, 65));
CHECK_EQ(10001, r.Call(10000, 10001));
CHECK_EQ(-29, r.Call(-28, -29));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Loop_if_break2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP(WASM_BRV_IF(1, WASM_GET_LOCAL(1), WASM_GET_LOCAL(0)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_DROP, WASM_SET_LOCAL(0, WASM_I32V_2(99))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
CHECK_EQ(99, r.Call(0, 33));
CHECK_EQ(3, r.Call(1, 3));
CHECK_EQ(10000, r.Call(99, 10000));
CHECK_EQ(-29, r.Call(-11, -29));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
Revert of [wasm] Master CL for Binary 0xC changes. (patchset #26 id:490001 of https://codereview.chromium.org/2345593003/ ) Reason for revert: Main suspect for tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893 Also changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10036 +mips builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4032 Original issue's description: > [wasm] Master CL for Binary 0xC changes. > > [0xC] Convert to stack machine semantics. > [0xC] Use section codes instead of names. > [0xC] Add elements section decoding. > [0xC] Decoding of globals section. > [0xC] Decoding of memory section. > [0xC] Decoding of imports section. > [0xC] Decoding of exports section. > [0xC] Decoding of data section. > [0xC] Remove CallImport bytecode. > [0xC] Function bodies have an implicit block. > [0xC] Remove the bottom label from loops. > [0xC] Add signatures to blocks. > [0xC] Remove arities from branches. > Add tests for init expression decoding. > Rework compilation of import wrappers and how they are patched. > Rework function indices in debugging. > Fix ASM->WASM builder for stack machine. > Reorganize asm.js foreign functions due to import indices change. > > R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org > BUG=chromium:575167 > LOG=Y > > Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 > Cr-Commit-Position: refs/heads/master@{#39678} TBR=ahaas@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org,rossberg@chromium.org,bradnelson@google.com,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2361053004 Cr-Commit-Position: refs/heads/master@{#39685}
2016-09-23 17:58:07 +00:00
WASM_EXEC_TEST(Loop_if_break_fallthru) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, B1(WASM_LOOP(WASM_IF(WASM_GET_LOCAL(0), WASM_BR(2)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_SET_LOCAL(0, WASM_I32V_2(93)))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/2345593003 Cr-Commit-Position: refs/heads/master@{#39678}
2016-09-23 15:56:42 +00:00
WASM_GET_LOCAL(0));
CHECK_EQ(93, r.Call(0));
CHECK_EQ(3, r.Call(3));
CHECK_EQ(10001, r.Call(10001));
CHECK_EQ(-22, r.Call(-22));
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(Loop_if_break_fallthru2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, B1(B1(WASM_LOOP(WASM_IF(WASM_GET_LOCAL(0), WASM_BR(2)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_SET_LOCAL(0, WASM_I32V_2(93))))),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0));
CHECK_EQ(93, r.Call(0));
CHECK_EQ(3, r.Call(3));
CHECK_EQ(10001, r.Call(10001));
CHECK_EQ(-22, r.Call(-22));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfBreak1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
BUILD(r, WASM_IF(WASM_GET_LOCAL(0), WASM_SEQ(WASM_BR(0), WASM_UNREACHABLE)),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(91));
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
CHECK_EQ(91, r.Call(0));
CHECK_EQ(91, r.Call(1));
CHECK_EQ(91, r.Call(-8734));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(IfBreak2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
BUILD(r, WASM_IF(WASM_GET_LOCAL(0), WASM_SEQ(WASM_BR(0), RET_I8(77))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_I32V_2(81));
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
CHECK_EQ(81, r.Call(0));
CHECK_EQ(81, r.Call(1));
CHECK_EQ(81, r.Call(-8734));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(LoadMemI32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(8);
r.module().RandomizeMemory(1111);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_LOAD_MEM(MachineType::Int32(), WASM_ZERO));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 99999999);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(99999999, r.Call(0));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 88888888);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(88888888, r.Call(0));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 77777777);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(77777777, r.Call(0));
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WASM_EXEC_TEST(LoadMemI32_alignment) {
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (byte alignment = 0; alignment <= 2; ++alignment) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(8);
r.module().RandomizeMemory(1111);
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
BUILD(r,
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_LOAD_MEM_ALIGNMENT(MachineType::Int32(), WASM_ZERO, alignment));
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 0x1a2b3c4d);
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
CHECK_EQ(0x1a2b3c4d, r.Call(0));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 0x5e6f7a8b);
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
CHECK_EQ(0x5e6f7a8b, r.Call(0));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 0x7ca0b1c2);
Reland of "Implement WASM big-endian support". Reland of https://codereview.chromium.org/2034093002 (reverted by https://codereview.chromium.org/2080153002). Original commit message: Implement WASM support on big-endian platforms. WASM has an implicit requirement that it is running on little-endian machine. We achieve WASM support on BE by keeping data in memory in little-endian order, and changing data endianness before storing to memory and after loading from memory. BUG= Review-Url: https://codereview.chromium.org/2083523002 Cr-Commit-Position: refs/heads/master@{#37373}
2016-06-29 09:25:24 +00:00
CHECK_EQ(0x7ca0b1c2, r.Call(0));
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(LoadMemI32_oob) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, uint32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(8);
r.module().RandomizeMemory(1111);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_LOAD_MEM(MachineType::Int32(), WASM_GET_LOCAL(0)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 88888888);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(88888888, r.Call(0u));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t offset = 29; offset < 40; ++offset) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(offset));
}
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t offset = 0x80000000; offset < 0x80000010; ++offset) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(offset));
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(LoadMem_offset_oob) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
static const MachineType machineTypes[] = {
MachineType::Int8(), MachineType::Uint8(), MachineType::Int16(),
MachineType::Uint16(), MachineType::Int32(), MachineType::Uint32(),
MachineType::Int64(), MachineType::Uint64(), MachineType::Float32(),
MachineType::Float64()};
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (size_t m = 0; m < arraysize(machineTypes); ++m) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, uint32_t> r(execution_mode);
r.module().AddMemoryElems<int32_t>(8);
r.module().RandomizeMemory(1116 + static_cast<int>(m));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
uint32_t boundary = 24 - WasmOpcodes::MemSize(machineTypes[m]);
BUILD(r, WASM_LOAD_MEM_OFFSET(machineTypes[m], 8, WASM_GET_LOCAL(0)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_DROP, WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(boundary)); // in bounds.
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t offset = boundary + 1; offset < boundary + 19; ++offset) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(offset)); // out of bounds.
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(LoadMemI32_offset) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(4);
r.module().RandomizeMemory(1111);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_LOAD_MEM_OFFSET(MachineType::Int32(), 4, WASM_GET_LOCAL(0)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 66666666);
r.module().WriteMemory(&memory[1], 77777777);
r.module().WriteMemory(&memory[2], 88888888);
r.module().WriteMemory(&memory[3], 99999999);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(77777777, r.Call(0));
CHECK_EQ(88888888, r.Call(4));
CHECK_EQ(99999999, r.Call(8));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], 11111111);
r.module().WriteMemory(&memory[1], 22222222);
r.module().WriteMemory(&memory[2], 33333333);
r.module().WriteMemory(&memory[3], 44444444);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(22222222, r.Call(0));
CHECK_EQ(33333333, r.Call(4));
CHECK_EQ(44444444, r.Call(8));
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(LoadMemI32_const_oob_misaligned) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kMemSize = 12;
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
// TODO(titzer): Fix misaligned accesses on MIPS and re-enable.
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int offset = 0; offset < kMemSize + 5; ++offset) {
for (int index = 0; index < kMemSize + 5; ++index) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
r.module().AddMemoryElems<byte>(kMemSize);
r.module().RandomizeMemory();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_LOAD_MEM_OFFSET(MachineType::Int32(), offset,
WASM_I32V_2(index)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Fix -Wsign-compare warnings. BUG=v8:5614 Review-Url: https://codereview.chromium.org/2487673004 Cr-Commit-Position: refs/heads/master@{#40891}
2016-11-10 12:50:51 +00:00
if ((offset + index) <= static_cast<int>((kMemSize - sizeof(int32_t)))) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(r.module().raw_val_at<int32_t>(offset + index), r.Call());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
} else {
CHECK_TRAP(r.Call());
}
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(LoadMemI32_const_oob) {
[wasm] Add test for non-misaligned OOB access. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1601843002 Cr-Commit-Position: refs/heads/master@{#33374}
2016-01-18 17:33:53 +00:00
const int kMemSize = 24;
for (int offset = 0; offset < kMemSize + 5; offset += 4) {
for (int index = 0; index < kMemSize + 5; index += 4) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
r.module().AddMemoryElems<byte>(kMemSize);
r.module().RandomizeMemory();
[wasm] Add test for non-misaligned OOB access. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1601843002 Cr-Commit-Position: refs/heads/master@{#33374}
2016-01-18 17:33:53 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_LOAD_MEM_OFFSET(MachineType::Int32(), offset,
WASM_I32V_2(index)));
[wasm] Add test for non-misaligned OOB access. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1601843002 Cr-Commit-Position: refs/heads/master@{#33374}
2016-01-18 17:33:53 +00:00
[wasm] Fix -Wsign-compare warnings. BUG=v8:5614 Review-Url: https://codereview.chromium.org/2487673004 Cr-Commit-Position: refs/heads/master@{#40891}
2016-11-10 12:50:51 +00:00
if ((offset + index) <= static_cast<int>((kMemSize - sizeof(int32_t)))) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(r.module().raw_val_at<int32_t>(offset + index), r.Call());
[wasm] Add test for non-misaligned OOB access. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1601843002 Cr-Commit-Position: refs/heads/master@{#33374}
2016-01-18 17:33:53 +00:00
} else {
CHECK_TRAP(r.Call());
}
}
}
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WASM_EXEC_TEST(StoreMemI32_alignment) {
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
const int32_t kWritten = 0x12345678;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (byte i = 0; i <= 2; ++i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(4);
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
BUILD(r, WASM_STORE_MEM_ALIGNMENT(MachineType::Int32(), WASM_ZERO, i,
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_GET_LOCAL(0)),
WASM_GET_LOCAL(0));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().RandomizeMemory(1111);
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
memory[0] = 0;
CHECK_EQ(kWritten, r.Call(kWritten));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(kWritten, r.module().ReadMemory(&memory[0]));
Implement UnalignedLoad and UnalignedStore in WASM using combination of LoadByte/Shift/Or and StoreByte/Shift/And. BUG= Review-Url: https://codereview.chromium.org/1928513002 Cr-Commit-Position: refs/heads/master@{#36422}
2016-05-20 17:49:50 +00:00
}
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WASM_EXEC_TEST(StoreMemI32_offset) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(4);
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
const int32_t kWritten = 0xaabbccdd;
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_STORE_MEM_OFFSET(MachineType::Int32(), 4, WASM_GET_LOCAL(0),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_I32V_5(kWritten)),
WASM_I32V_5(kWritten));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < 2; ++i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().RandomizeMemory(1111);
r.module().WriteMemory(&memory[0], 66666666);
r.module().WriteMemory(&memory[1], 77777777);
r.module().WriteMemory(&memory[2], 88888888);
r.module().WriteMemory(&memory[3], 99999999);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(kWritten, r.Call(i * 4));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(66666666, r.module().ReadMemory(&memory[0]));
CHECK_EQ(i == 0 ? kWritten : 77777777, r.module().ReadMemory(&memory[1]));
CHECK_EQ(i == 1 ? kWritten : 88888888, r.module().ReadMemory(&memory[2]));
CHECK_EQ(i == 2 ? kWritten : 99999999, r.module().ReadMemory(&memory[3]));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(StoreMem_offset_oob) {
[wasm] Move 64-bit call tests into test-run-wasm-64.cc so they also run on 32-bit platforms. This duplicates some test code (which hopefully can be factored out later), but increases test coverage. R=ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2042773002 Cr-Commit-Position: refs/heads/master@{#36739}
2016-06-06 10:58:48 +00:00
// 64-bit cases are handled in test-run-wasm-64.cc
[wasm] Fixed a wasm test on ia32. The test Run_Wasm_StoreMem_offset_oob contained an I64STORE instruction, which is not yet implemented on 32 bit platforms. I turned off those parts of the test on 32 bit platforms which contain I64 instructions. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1526573002 Cr-Commit-Position: refs/heads/master@{#32842}
2015-12-14 14:54:49 +00:00
static const MachineType machineTypes[] = {
MachineType::Int8(), MachineType::Uint8(), MachineType::Int16(),
MachineType::Uint16(), MachineType::Int32(), MachineType::Uint32(),
MachineType::Float32(), MachineType::Float64()};
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (size_t m = 0; m < arraysize(machineTypes); ++m) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, uint32_t> r(execution_mode);
byte* memory = r.module().AddMemoryElems<byte>(32);
r.module().RandomizeMemory(1119 + static_cast<int>(m));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_STORE_MEM_OFFSET(machineTypes[m], 8, WASM_GET_LOCAL(0),
WASM_LOAD_MEM(machineTypes[m], WASM_ZERO)),
WASM_ZERO);
byte memsize = WasmOpcodes::MemSize(machineTypes[m]);
uint32_t boundary = 24 - memsize;
CHECK_EQ(0, r.Call(boundary)); // in bounds.
CHECK_EQ(0, memcmp(&memory[0], &memory[8 + boundary], memsize));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t offset = boundary + 1; offset < boundary + 19; ++offset) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_TRAP(r.Call(offset)); // out of bounds.
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(LoadMemI32_P) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumElems = 8;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* memory = r.module().AddMemoryElems<int32_t>(kNumElems);
r.module().RandomizeMemory(2222);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_LOAD_MEM(MachineType::Int32(), WASM_GET_LOCAL(0)));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < kNumElems; ++i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(r.module().ReadMemory(&memory[i]), r.Call(i * 4));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(MemI32_Sum) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumElems = 20;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, int32_t> r(execution_mode);
uint32_t* memory = r.module().AddMemoryElems<uint32_t>(kNumElems);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
const byte kSum = r.AllocateLocal(kWasmI32);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_WHILE(
WASM_GET_LOCAL(0),
WASM_BLOCK(
WASM_SET_LOCAL(
kSum, WASM_I32_ADD(WASM_GET_LOCAL(kSum),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_LOAD_MEM(MachineType::Int32(),
WASM_GET_LOCAL(0)))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_SET_LOCAL(
0, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_I32V_1(4))))),
WASM_GET_LOCAL(1));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Run 4 trials.
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < 3; ++i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().RandomizeMemory(i * 33);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
uint32_t expected = 0;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (size_t j = kNumElems - 1; j > 0; --j) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
expected += r.module().ReadMemory(&memory[j]);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
uint32_t result = r.Call(4 * (kNumElems - 1));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(expected, result);
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CheckMachIntsZero) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumElems = 55;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, int32_t> r(execution_mode);
r.module().AddMemoryElems<uint32_t>(kNumElems);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, // --
/**/ kExprLoop, kLocalVoid, // --
/* */ kExprGetLocal, 0, // --
/* */ kExprIf, kLocalVoid, // --
/* */ kExprGetLocal, 0, // --
/* */ kExprI32LoadMem, 0, 0, // --
/* */ kExprIf, kLocalVoid, // --
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
/* */ kExprI32Const, 127, // --
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
/* */ kExprReturn, // --
/* */ kExprEnd, // --
/* */ kExprGetLocal, 0, // --
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
/* */ kExprI32Const, 4, // --
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
/* */ kExprI32Sub, // --
/* */ kExprTeeLocal, 0, // --
/* */ kExprBr, DEPTH_0, // --
/* */ kExprEnd, // --
/**/ kExprEnd, // --
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
/**/ kExprI32Const, 0); // --
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().BlankMemory();
CHECK_EQ(0, r.Call((kNumElems - 1) * 4));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(MemF32_Sum) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kSize = 5;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
r.module().AddMemoryElems<float>(kSize);
float* buffer = r.module().raw_mem_start<float>();
r.module().WriteMemory(&buffer[0], -99.25f);
r.module().WriteMemory(&buffer[1], -888.25f);
r.module().WriteMemory(&buffer[2], -77.25f);
r.module().WriteMemory(&buffer[3], 66666.25f);
r.module().WriteMemory(&buffer[4], 5555.25f);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
const byte kSum = r.AllocateLocal(kWasmF32);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_WHILE(
WASM_GET_LOCAL(0),
WASM_BLOCK(
WASM_SET_LOCAL(
kSum, WASM_F32_ADD(WASM_GET_LOCAL(kSum),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_LOAD_MEM(MachineType::Float32(),
WASM_GET_LOCAL(0)))),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_SET_LOCAL(
0, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_I32V_1(4))))),
WASM_STORE_MEM(MachineType::Float32(), WASM_ZERO, WASM_GET_LOCAL(kSum)),
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(0, r.Call(4 * (kSize - 1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_NE(-99.25f, r.module().ReadMemory(&buffer[0]));
CHECK_EQ(71256.0f, r.module().ReadMemory(&buffer[0]));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
template <typename T>
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
T GenerateAndRunFold(WasmExecutionMode execution_mode, WasmOpcode binop,
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
T* buffer, uint32_t size, ValueType astType,
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
MachineType memType) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
T* memory = r.module().AddMemoryElems<T>(size);
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (uint32_t i = 0; i < size; ++i) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[i], buffer[i]);
[wasm] Fix MSAN failures for some WASM tests. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1571703002 Cr-Commit-Position: refs/heads/master@{#33171}
2016-01-08 12:35:01 +00:00
}
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
const byte kAccum = r.AllocateLocal(astType);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(
r, WASM_SET_LOCAL(kAccum, WASM_LOAD_MEM(memType, WASM_ZERO)),
WASM_WHILE(
WASM_GET_LOCAL(0),
WASM_BLOCK(WASM_SET_LOCAL(
kAccum,
WASM_BINOP(binop, WASM_GET_LOCAL(kAccum),
WASM_LOAD_MEM(memType, WASM_GET_LOCAL(0)))),
WASM_SET_LOCAL(0, WASM_I32_SUB(WASM_GET_LOCAL(0),
WASM_I32V_1(sizeof(T)))))),
WASM_STORE_MEM(memType, WASM_ZERO, WASM_GET_LOCAL(kAccum)),
WASM_GET_LOCAL(0));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
r.Call(static_cast<int>(sizeof(T) * (size - 1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
return r.module().ReadMemory(&memory[0]);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(MemF64_Mul) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const size_t kSize = 6;
double buffer[kSize] = {1, 2, 2, 2, 2, 2};
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
double result =
GenerateAndRunFold<double>(execution_mode, kExprF64Mul, buffer, kSize,
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
kWasmF64, MachineType::Float64());
[wasm] Fix MSAN failures for some WASM tests. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1571703002 Cr-Commit-Position: refs/heads/master@{#33171}
2016-01-08 12:35:01 +00:00
CHECK_EQ(32, result);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WASM_EXEC_TEST(Build_Wasm_Infinite_Loop) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Only build the graph and compile, don't run.
BUILD(r, WASM_INFINITE_LOOP);
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WASM_EXEC_TEST(Build_Wasm_Infinite_Loop_effect) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
r.module().AddMemoryElems<int8_t>(16);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Only build the graph and compile, don't run.
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_LOOP(WASM_LOAD_MEM(MachineType::Int32(), WASM_ZERO), WASM_DROP),
WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Unreachable0a) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV(0, WASM_I32V_1(9)), RET(WASM_GET_LOCAL(0))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(9, r.Call(0));
CHECK_EQ(9, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Unreachable0b) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV(0, WASM_I32V_1(7)), WASM_UNREACHABLE));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(7, r.Call(0));
CHECK_EQ(7, r.Call(1));
}
TEST(Build_Wasm_Unreachable1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_UNREACHABLE);
}
TEST(Build_Wasm_Unreachable2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_UNREACHABLE, WASM_UNREACHABLE);
}
TEST(Build_Wasm_Unreachable3) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_UNREACHABLE, WASM_UNREACHABLE, WASM_UNREACHABLE);
}
TEST(Build_Wasm_UnreachableIf1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_UNREACHABLE, WASM_IF(WASM_GET_LOCAL(0), WASM_GET_LOCAL(0)));
}
TEST(Build_Wasm_UnreachableIf2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_UNREACHABLE,
WASM_IF_ELSE(WASM_GET_LOCAL(0), WASM_GET_LOCAL(0), WASM_UNREACHABLE));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Unreachable_Load) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV(0, WASM_GET_LOCAL(0)),
WASM_LOAD_MEM(MachineType::Int8(), WASM_GET_LOCAL(0))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(11, r.Call(11));
CHECK_EQ(21, r.Call(21));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Infinite_Loop_not_taken1) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_IF(WASM_GET_LOCAL(0), WASM_INFINITE_LOOP), WASM_I32V_1(45));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Run the code, but don't go into the infinite loop.
CHECK_EQ(45, r.Call(0));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Infinite_Loop_not_taken2) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_IF_ELSE(WASM_GET_LOCAL(0),
WASM_BRV(1, WASM_I32V_1(45)),
WASM_INFINITE_LOOP)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Run the code, but don't go into the infinite loop.
CHECK_EQ(45, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Infinite_Loop_not_taken2_brif) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV_IF(0, WASM_I32V_1(45), WASM_GET_LOCAL(0)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_INFINITE_LOOP));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Run the code, but don't go into the infinite loop.
CHECK_EQ(45, r.Call(1));
}
[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1564053002 Cr-Commit-Position: refs/heads/master@{#33161}
2016-01-07 16:58:17 +00:00
static void TestBuildGraphForSimpleExpression(WasmOpcode opcode) {
Isolate* isolate = CcTest::InitIsolateOnce();
Named all zones in the project This adds more useful information to the v8-heap-stats tool. BUG=v8:5489 Review-Url: https://codereview.chromium.org/2394213003 Cr-Commit-Position: refs/heads/master@{#40361}
2016-10-17 12:12:30 +00:00
Zone zone(isolate->allocator(), ZONE_NAME);
[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1564053002 Cr-Commit-Position: refs/heads/master@{#33161}
2016-01-07 16:58:17 +00:00
HandleScope scope(isolate);
// Enable all optional operators.
CommonOperatorBuilder common(&zone);
MachineOperatorBuilder machine(&zone, MachineType::PointerRepresentation(),
MachineOperatorBuilder::kAllOptionalOps);
Graph graph(&zone);
JSGraph jsgraph(isolate, &graph, &common, nullptr, nullptr, &machine);
FunctionSig* sig = WasmOpcodes::Signature(opcode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1564053002 Cr-Commit-Position: refs/heads/master@{#33161}
2016-01-07 16:58:17 +00:00
if (sig->parameter_count() == 1) {
Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #6 id:100001 of https://codereview.chromium.org/2630553002/ ) Reason for revert: Still breaks Win64 clang build. Original issue's description: > [wasm] Enforce that function bodies end with the \"end\" opcode. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Review-Url: https://codereview.chromium.org/2630553002 > Cr-Original-Commit-Position: refs/heads/master@{#42286} > Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619 > Review-Url: https://codereview.chromium.org/2630553002 > Cr-Commit-Position: refs/heads/master@{#42315} > Committed: https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b8194966 TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2636463002 Cr-Commit-Position: refs/heads/master@{#42317}
2017-01-13 11:32:17 +00:00
byte code[] = {WASM_NO_LOCALS, kExprGetLocal, 0, static_cast<byte>(opcode)};
[wasm] Generate source position information Annotate call nodes in the TF graph with source code information in the form of byte offset relative to the wasm function start. The backend finally outputs those positions as RelocInfo. R=bmeurer@chromium.org, mstarzinger@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1890803002 Cr-Commit-Position: refs/heads/master@{#35793}
2016-04-26 12:46:03 +00:00
TestBuildingGraph(&zone, &jsgraph, nullptr, sig, nullptr, code,
[wasm] Rework encoding of local declarations. Local declarations were previously encoded as an optional set of 4 uint16 values as part of the function declaration. This CL implements the current design of moving these declarations to a list of pairs of (type, count) that is part of the body. R=bradnelson@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1763433002 Cr-Commit-Position: refs/heads/master@{#34564}
2016-03-07 21:04:07 +00:00
code + arraysize(code));
[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1564053002 Cr-Commit-Position: refs/heads/master@{#33161}
2016-01-07 16:58:17 +00:00
} else {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(2, sig->parameter_count());
Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #6 id:100001 of https://codereview.chromium.org/2630553002/ ) Reason for revert: Still breaks Win64 clang build. Original issue's description: > [wasm] Enforce that function bodies end with the \"end\" opcode. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Review-Url: https://codereview.chromium.org/2630553002 > Cr-Original-Commit-Position: refs/heads/master@{#42286} > Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619 > Review-Url: https://codereview.chromium.org/2630553002 > Cr-Commit-Position: refs/heads/master@{#42315} > Committed: https://chromium.googlesource.com/v8/v8/+/74a2f9b7d3c3d9a9284ab8d5a9d08618b8194966 TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2636463002 Cr-Commit-Position: refs/heads/master@{#42317}
2017-01-13 11:32:17 +00:00
byte code[] = {WASM_NO_LOCALS, kExprGetLocal, 0, kExprGetLocal, 1,
static_cast<byte>(opcode)};
[wasm] Generate source position information Annotate call nodes in the TF graph with source code information in the form of byte offset relative to the wasm function start. The backend finally outputs those positions as RelocInfo. R=bmeurer@chromium.org, mstarzinger@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1890803002 Cr-Commit-Position: refs/heads/master@{#35793}
2016-04-26 12:46:03 +00:00
TestBuildingGraph(&zone, &jsgraph, nullptr, sig, nullptr, code,
[wasm] Rework encoding of local declarations. Local declarations were previously encoded as an optional set of 4 uint16 values as part of the function declaration. This CL implements the current design of moving these declarations to a list of pairs of (type, count) that is part of the body. R=bradnelson@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1763433002 Cr-Commit-Position: refs/heads/master@{#34564}
2016-03-07 21:04:07 +00:00
code + arraysize(code));
[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1564053002 Cr-Commit-Position: refs/heads/master@{#33161}
2016-01-07 16:58:17 +00:00
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
TEST(Build_Wasm_SimpleExprs) {
// Test that the decoder can build a graph for all supported simple expressions.
[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1564053002 Cr-Commit-Position: refs/heads/master@{#33161}
2016-01-07 16:58:17 +00:00
#define GRAPH_BUILD_TEST(name, opcode, sig) \
TestBuildGraphForSimpleExpression(kExpr##name);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOREACH_SIMPLE_OPCODE(GRAPH_BUILD_TEST);
#undef GRAPH_BUILD_TEST
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32LoadInt8_signext) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumElems = 16;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
int8_t* memory = r.module().AddMemoryElems<int8_t>(kNumElems);
r.module().RandomizeMemory();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
memory[0] = -1;
BUILD(r, WASM_LOAD_MEM(MachineType::Int8(), WASM_GET_LOCAL(0)));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < kNumElems; ++i) {
CHECK_EQ(memory[i], r.Call(i));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32LoadInt8_zeroext) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumElems = 16;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
byte* memory = r.module().AddMemory(kNumElems);
r.module().RandomizeMemory(77);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
memory[0] = 255;
BUILD(r, WASM_LOAD_MEM(MachineType::Uint8(), WASM_GET_LOCAL(0)));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < kNumElems; ++i) {
CHECK_EQ(memory[i], r.Call(i));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32LoadInt16_signext) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumBytes = 16;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
byte* memory = r.module().AddMemory(kNumBytes);
r.module().RandomizeMemory(888);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
memory[1] = 200;
BUILD(r, WASM_LOAD_MEM(MachineType::Int16(), WASM_GET_LOCAL(0)));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < kNumBytes; i += 2) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
int32_t expected = memory[i] | (static_cast<int8_t>(memory[i + 1]) << 8);
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
CHECK_EQ(expected, r.Call(i));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32LoadInt16_zeroext) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumBytes = 16;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
byte* memory = r.module().AddMemory(kNumBytes);
r.module().RandomizeMemory(9999);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
memory[1] = 204;
BUILD(r, WASM_LOAD_MEM(MachineType::Uint16(), WASM_GET_LOCAL(0)));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < kNumBytes; i += 2) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
int32_t expected = memory[i] | (memory[i + 1] << 8);
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
CHECK_EQ(expected, r.Call(i));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Global) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* global = r.module().AddGlobal<int32_t>();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// global = global + p0
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r,
WASM_SET_GLOBAL(0, WASM_I32_ADD(WASM_GET_GLOBAL(0), WASM_GET_LOCAL(0))),
WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
*global = 116;
for (int i = 9; i < 444444; i += 111111) {
int32_t expected = *global + i;
r.Call(i);
CHECK_EQ(expected, *global);
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Int32Globals_DontAlias) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kNumGlobals = 3;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int g = 0; g < kNumGlobals; ++g) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// global = global + p0
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
int32_t* globals[] = {r.module().AddGlobal<int32_t>(),
r.module().AddGlobal<int32_t>(),
r.module().AddGlobal<int32_t>()};
[wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review-Url: https://codereview.chromium.org/2209433002 Cr-Commit-Position: refs/heads/master@{#38262}
2016-08-02 22:38:54 +00:00
BUILD(r, WASM_SET_GLOBAL(
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
g, WASM_I32_ADD(WASM_GET_GLOBAL(g), WASM_GET_LOCAL(0))),
WASM_GET_GLOBAL(g));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Check that reading/writing global number {g} doesn't alter the others.
*globals[g] = 116 * g;
int32_t before[kNumGlobals];
for (int i = 9; i < 444444; i += 111113) {
int32_t sum = *globals[g] + i;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int j = 0; j < kNumGlobals; ++j) before[j] = *globals[j];
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
int32_t result = r.Call(i);
CHECK_EQ(sum, result);
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int j = 0; j < kNumGlobals; ++j) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
int32_t expected = j == g ? sum : before[j];
CHECK_EQ(expected, *globals[j]);
}
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float32Global) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
float* global = r.module().AddGlobal<float>();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// global = global + p0
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_SET_GLOBAL(
0, WASM_F32_ADD(WASM_GET_GLOBAL(0),
WASM_F32_SCONVERT_I32(WASM_GET_LOCAL(0)))),
WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
*global = 1.25;
for (int i = 9; i < 4444; i += 1111) {
volatile float expected = *global + i;
r.Call(i);
CHECK_EQ(expected, *global);
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Float64Global) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
double* global = r.module().AddGlobal<double>();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// global = global + p0
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_SET_GLOBAL(
0, WASM_F64_ADD(WASM_GET_GLOBAL(0),
WASM_F64_SCONVERT_I32(WASM_GET_LOCAL(0)))),
WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
*global = 1.25;
for (int i = 9; i < 4444; i += 1111) {
volatile double expected = *global + i;
r.Call(i);
CHECK_EQ(expected, *global);
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(MixedGlobals) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
int32_t* unused = r.module().AddGlobal<int32_t>();
byte* memory = r.module().AddMemory(32);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
int32_t* var_int32 = r.module().AddGlobal<int32_t>();
uint32_t* var_uint32 = r.module().AddGlobal<uint32_t>();
float* var_float = r.module().AddGlobal<float>();
double* var_double = r.module().AddGlobal<double>();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_SET_GLOBAL(1, WASM_LOAD_MEM(MachineType::Int32(), WASM_ZERO)),
WASM_SET_GLOBAL(2, WASM_LOAD_MEM(MachineType::Uint32(), WASM_ZERO)),
WASM_SET_GLOBAL(3, WASM_LOAD_MEM(MachineType::Float32(), WASM_ZERO)),
WASM_SET_GLOBAL(4, WASM_LOAD_MEM(MachineType::Float64(), WASM_ZERO)),
WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
memory[0] = 0xaa;
memory[1] = 0xcc;
memory[2] = 0x55;
memory[3] = 0xee;
memory[4] = 0x33;
memory[5] = 0x22;
memory[6] = 0x11;
memory[7] = 0x99;
r.Call(1);
CHECK(static_cast<int32_t>(0xee55ccaa) == *var_int32);
CHECK(static_cast<uint32_t>(0xee55ccaa) == *var_uint32);
CHECK(bit_cast<float>(0xee55ccaa) == *var_float);
CHECK(bit_cast<double>(0x99112233ee55ccaaULL) == *var_double);
USE(unused);
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CallEmpty) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int32_t kExpected = -414444;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Build the target function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& target_func = r.NewFunction<int>();
BUILD(target_func, WASM_I32V_3(kExpected));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Build the calling function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION0(target_func.function_index()));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
int32_t result = r.Call();
CHECK_EQ(kExpected, result);
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CallF32StackParameter) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float> r(execution_mode);
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
// Build the target function.
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
ValueType param_types[20];
for (int i = 0; i < 20; ++i) param_types[i] = kWasmF32;
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
FunctionSig sig(1, 19, param_types);
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t = r.NewFunction(&sig);
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
BUILD(t, WASM_GET_LOCAL(17));
// Build the calling function.
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_CALL_FUNCTION(
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t.function_index(), WASM_F32(1.0f), WASM_F32(2.0f),
WASM_F32(4.0f), WASM_F32(8.0f), WASM_F32(16.0f), WASM_F32(32.0f),
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
WASM_F32(64.0f), WASM_F32(128.0f), WASM_F32(256.0f),
WASM_F32(1.5f), WASM_F32(2.5f), WASM_F32(4.5f), WASM_F32(8.5f),
WASM_F32(16.5f), WASM_F32(32.5f), WASM_F32(64.5f),
WASM_F32(128.5f), WASM_F32(256.5f), WASM_F32(512.5f)));
float result = r.Call();
CHECK_EQ(256.5f, result);
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CallF64StackParameter) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double> r(execution_mode);
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
// Build the target function.
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
ValueType param_types[20];
for (int i = 0; i < 20; ++i) param_types[i] = kWasmF64;
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
FunctionSig sig(1, 19, param_types);
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t = r.NewFunction(&sig);
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
BUILD(t, WASM_GET_LOCAL(17));
// Build the calling function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION(t.function_index(), WASM_F64(1.0), WASM_F64(2.0),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_F64(4.0), WASM_F64(8.0), WASM_F64(16.0),
WASM_F64(32.0), WASM_F64(64.0), WASM_F64(128.0),
WASM_F64(256.0), WASM_F64(1.5), WASM_F64(2.5),
WASM_F64(4.5), WASM_F64(8.5), WASM_F64(16.5),
WASM_F64(32.5), WASM_F64(64.5), WASM_F64(128.5),
WASM_F64(256.5), WASM_F64(512.5)));
[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1529773003 Cr-Commit-Position: refs/heads/master@{#32893}
2015-12-16 11:43:03 +00:00
float result = r.Call();
CHECK_EQ(256.5, result);
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(CallVoid) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const byte kMemOffset = 8;
const int32_t kElemNum = kMemOffset / sizeof(int32_t);
Reland of "Implement WASM big-endian support". Reland of https://codereview.chromium.org/2034093002 (reverted by https://codereview.chromium.org/2080153002). Original commit message: Implement WASM support on big-endian platforms. WASM has an implicit requirement that it is running on little-endian machine. We achieve WASM support on BE by keeping data in memory in little-endian order, and changing data endianness before storing to memory and after loading from memory. BUG= Review-Url: https://codereview.chromium.org/2083523002 Cr-Commit-Position: refs/heads/master@{#37373}
2016-06-29 09:25:24 +00:00
const int32_t kExpected = 414444;
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Build the target function.
TestSignatures sigs;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
int32_t* memory = r.module().AddMemoryElems<int32_t>(16 / sizeof(int32_t));
r.module().RandomizeMemory();
WasmFunctionCompiler& t = r.NewFunction(sigs.v_v());
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(t, WASM_STORE_MEM(MachineType::Int32(), WASM_I32V_1(kMemOffset),
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
WASM_I32V_3(kExpected)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Build the calling function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION0(t.function_index()),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_LOAD_MEM(MachineType::Int32(), WASM_I32V_1(kMemOffset)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
int32_t result = r.Call();
CHECK_EQ(kExpected, result);
Reland of "Implement WASM big-endian support". Reland of https://codereview.chromium.org/2034093002 (reverted by https://codereview.chromium.org/2080153002). Original commit message: Implement WASM support on big-endian platforms. WASM has an implicit requirement that it is running on little-endian machine. We achieve WASM support on BE by keeping data in memory in little-endian order, and changing data endianness before storing to memory and after loading from memory. BUG= Review-Url: https://codereview.chromium.org/2083523002 Cr-Commit-Position: refs/heads/master@{#37373}
2016-06-29 09:25:24 +00:00
CHECK_EQ(static_cast<int64_t>(kExpected),
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
static_cast<int64_t>(r.module().ReadMemory(&memory[kElemNum])));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Call_Int32Add) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Build the target function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t = r.NewFunction<int32_t, int32_t, int32_t>();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(t, WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
// Build the caller function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION(t.function_index(), WASM_GET_LOCAL(0),
WASM_GET_LOCAL(1)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_INT32_INPUTS(i) {
FOR_INT32_INPUTS(j) {
int32_t expected = static_cast<int32_t>(static_cast<uint32_t>(*i) +
static_cast<uint32_t>(*j));
CHECK_EQ(expected, r.Call(*i, *j));
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Call_Float32Sub) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Build the target function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& target_func = r.NewFunction<float, float, float>();
BUILD(target_func, WASM_F32_SUB(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
// Build the caller function.
BUILD(r, WASM_CALL_FUNCTION(target_func.function_index(), WASM_GET_LOCAL(0),
WASM_GET_LOCAL(1)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_FLOAT32_INPUTS(i) {
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT32_INPUTS(j) { CHECK_FLOAT_EQ(*i - *j, r.Call(*i, *j)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(Call_Float64Sub) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
double* memory = r.module().AddMemoryElems<double>(16);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_STORE_MEM(
MachineType::Float64(), WASM_ZERO,
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_F64_SUB(
WASM_LOAD_MEM(MachineType::Float64(), WASM_ZERO),
WASM_LOAD_MEM(MachineType::Float64(), WASM_I32V_1(8)))),
WASM_I32V_2(107));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
FOR_FLOAT64_INPUTS(i) {
FOR_FLOAT64_INPUTS(j) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().WriteMemory(&memory[0], *i);
r.module().WriteMemory(&memory[1], *j);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
double expected = *i - *j;
CHECK_EQ(107, r.Call());
Reland of "Implement WASM big-endian support". Reland of https://codereview.chromium.org/2034093002 (reverted by https://codereview.chromium.org/2080153002). Original commit message: Implement WASM support on big-endian platforms. WASM has an implicit requirement that it is running on little-endian machine. We achieve WASM support on BE by keeping data in memory in little-endian order, and changing data endianness before storing to memory and after loading from memory. BUG= Review-Url: https://codereview.chromium.org/2083523002 Cr-Commit-Position: refs/heads/master@{#37373}
2016-06-29 09:25:24 +00:00
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
if (expected != expected) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK(r.module().ReadMemory(&memory[0]) !=
r.module().ReadMemory(&memory[0]));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
} else {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(expected, r.module().ReadMemory(&memory[0]));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
}
}
#define ADD_CODE(vec, ...) \
do { \
byte __buf[] = {__VA_ARGS__}; \
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (size_t i = 0; i < sizeof(__buf); ++i) vec.push_back(__buf[i]); \
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
} while (false)
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
static void Run_WasmMixedCall_N(WasmExecutionMode execution_mode, int start) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
const int kExpected = 6333;
const int kElemSize = 8;
TestSignatures sigs;
[wasm] Move 64-bit call tests into test-run-wasm-64.cc so they also run on 32-bit platforms. This duplicates some test code (which hopefully can be factored out later), but increases test coverage. R=ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2042773002 Cr-Commit-Position: refs/heads/master@{#36739}
2016-06-06 10:58:48 +00:00
// 64-bit cases handled in test-run-wasm-64.cc.
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
static MachineType mixed[] = {
MachineType::Int32(), MachineType::Float32(), MachineType::Float64(),
MachineType::Float32(), MachineType::Int32(), MachineType::Float64(),
MachineType::Float32(), MachineType::Float64(), MachineType::Int32(),
MachineType::Int32(), MachineType::Int32()};
int num_params = static_cast<int>(arraysize(mixed)) - start;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int which = 0; which < num_params; ++which) {
Moved zones and zone related stuff in its own directory. This is some initial cleanup to keep /src clean. The AccountingAllocator is actually exclusively used by zones and this common subfolder makes that more clear. BUG=v8:5409 Review-Url: https://codereview.chromium.org/2344143003 Cr-Commit-Position: refs/heads/master@{#39558}
2016-09-20 16:07:25 +00:00
v8::internal::AccountingAllocator allocator;
Named all zones in the project This adds more useful information to the v8-heap-stats tool. BUG=v8:5489 Review-Url: https://codereview.chromium.org/2394213003 Cr-Commit-Position: refs/heads/master@{#40361}
2016-10-17 12:12:30 +00:00
Zone zone(&allocator, ZONE_NAME);
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t> r(execution_mode);
r.module().AddMemory(1024);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
MachineType* memtypes = &mixed[start];
MachineType result = memtypes[which];
// =========================================================================
// Build the selector function.
// =========================================================================
FunctionSig::Builder b(&zone, 1, num_params);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
b.AddReturn(WasmOpcodes::ValueTypeFor(result));
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < num_params; ++i) {
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
b.AddParam(WasmOpcodes::ValueTypeFor(memtypes[i]));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t = r.NewFunction(b.Build());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(t, WASM_GET_LOCAL(which));
// =========================================================================
// Build the calling function.
// =========================================================================
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
std::vector<byte> code;
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
// Load the offset for the store.
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
ADD_CODE(code, WASM_ZERO);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
// Load the arguments.
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < num_params; ++i) {
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
int offset = (i + 1) * kElemSize;
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
ADD_CODE(code, WASM_LOAD_MEM(memtypes[i], WASM_I32V_2(offset)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
// Call the selector function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
ADD_CODE(code, WASM_CALL_FUNCTION0(t.function_index()));
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
// Store the result in memory.
ADD_CODE(code,
static_cast<byte>(WasmOpcodes::LoadStoreOpcodeOf(result, true)),
ZERO_ALIGNMENT, ZERO_OFFSET);
// Return the expected value.
[wasm] Update {i32,i64}.const to use signed leb128 Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
2016-03-04 19:05:47 +00:00
ADD_CODE(code, WASM_I32V_2(kExpected));
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
r.Build(&code[0], &code[0] + code.size());
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Run the code.
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int t = 0; t < 10; ++t) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().RandomizeMemory();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(kExpected, r.Call());
int size = WasmOpcodes::MemSize(result);
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (int i = 0; i < size; ++i) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
int base = (which + 1) * kElemSize;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
byte expected = r.module().raw_mem_at<byte>(base + i);
byte result = r.module().raw_mem_at<byte>(i);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(expected, result);
}
}
}
}
[wasm] Implement an interpreter for WASM. This interpreter directly decodes and executes WASM binary code for the purpose of supporting low-level debugging. It is not currently integrated into the main WASM implementation. R=ahaas@chromium.org,clemensh@chromium.org,rossberg@chromium.org,binji@chromium.org BUG= Review-Url: https://codereview.chromium.org/1972153002 Cr-Commit-Position: refs/heads/master@{#36497}
2016-05-25 08:32:37 +00:00
WASM_EXEC_TEST(MixedCall_0) { Run_WasmMixedCall_N(execution_mode, 0); }
WASM_EXEC_TEST(MixedCall_1) { Run_WasmMixedCall_N(execution_mode, 1); }
WASM_EXEC_TEST(MixedCall_2) { Run_WasmMixedCall_N(execution_mode, 2); }
WASM_EXEC_TEST(MixedCall_3) { Run_WasmMixedCall_N(execution_mode, 3); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(AddCall) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
WasmFunctionCompiler& t1 = r.NewFunction<int32_t, int32_t, int32_t>();
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
BUILD(t1, WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
byte local = r.AllocateLocal(kWasmI32);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_SET_LOCAL(local, WASM_I32V_2(99)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_I32_ADD(WASM_CALL_FUNCTION(t1.function_index(), WASM_GET_LOCAL(0),
WASM_GET_LOCAL(0)),
WASM_CALL_FUNCTION(t1.function_index(), WASM_GET_LOCAL(1),
WASM_GET_LOCAL(local))));
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
CHECK_EQ(198, r.Call(0));
CHECK_EQ(200, r.Call(1));
CHECK_EQ(100, r.Call(-49));
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(MultiReturnSub) {
FLAG_wasm_mv_prototype = true;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
ValueType storage[] = {kWasmI32, kWasmI32, kWasmI32, kWasmI32};
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
FunctionSig sig_ii_ii(2, 2, storage);
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t1 = r.NewFunction(&sig_ii_ii);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(t1, WASM_GET_LOCAL(1), WASM_GET_LOCAL(0));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1),
WASM_CALL_FUNCTION0(t1.function_index()), kExprI32Sub);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
FOR_INT32_INPUTS(i) {
FOR_INT32_INPUTS(j) {
int32_t expected = static_cast<int32_t>(static_cast<uint32_t>(*j) -
static_cast<uint32_t>(*i));
CHECK_EQ(expected, r.Call(*i, *j));
}
}
}
template <typename T>
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
void RunMultiReturnSelect(WasmExecutionMode execution_mode, const T* inputs) {
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
FLAG_wasm_mv_prototype = true;
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
ValueType type = WasmOpcodes::ValueTypeFor(MachineTypeForC<T>());
ValueType storage[] = {type, type, type, type, type, type};
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
const size_t kNumReturns = 2;
const size_t kNumParams = arraysize(storage) - kNumReturns;
FunctionSig sig(kNumReturns, kNumParams, storage);
for (size_t i = 0; i < kNumParams; i++) {
for (size_t j = 0; j < kNumParams; j++) {
for (int k = 0; k < 2; k++) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<T, T, T, T, T> r(execution_mode);
WasmFunctionCompiler& r1 = r.NewFunction(&sig);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r1, WASM_GET_LOCAL(i), WASM_GET_LOCAL(j));
if (k == 0) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION(r1.function_index(), WASM_GET_LOCAL(0),
WASM_GET_LOCAL(1), WASM_GET_LOCAL(2),
WASM_GET_LOCAL(3)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_DROP);
} else {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
BUILD(r, WASM_CALL_FUNCTION(r1.function_index(), WASM_GET_LOCAL(0),
WASM_GET_LOCAL(1), WASM_GET_LOCAL(2),
WASM_GET_LOCAL(3)),
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
kExprSetLocal, 0, WASM_DROP, WASM_GET_LOCAL(0));
}
T expected = inputs[k == 0 ? i : j];
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
CHECK_EQ(expected, r.Call(inputs[0], inputs[1], inputs[2], inputs[3]));
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
}
}
}
}
WASM_EXEC_TEST(MultiReturnSelect_i32) {
static const int32_t inputs[] = {3333333, 4444444, -55555555, -7777777};
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
RunMultiReturnSelect<int32_t>(execution_mode, inputs);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
}
WASM_EXEC_TEST(MultiReturnSelect_f32) {
static const float inputs[] = {33.33333f, 444.4444f, -55555.555f, -77777.77f};
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
RunMultiReturnSelect<float>(execution_mode, inputs);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
}
WASM_EXEC_TEST(MultiReturnSelect_i64) {
#if !V8_TARGET_ARCH_32_BIT || V8_TARGET_ARCH_X64
// TODO(titzer): implement int64-lowering for multiple return values
static const int64_t inputs[] = {33333338888, 44444446666, -555555553333,
-77777771111};
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
RunMultiReturnSelect<int64_t>(execution_mode, inputs);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
#endif
}
WASM_EXEC_TEST(MultiReturnSelect_f64) {
static const double inputs[] = {3.333333, 44444.44, -55.555555, -7777.777};
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
RunMultiReturnSelect<double>(execution_mode, inputs);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock2a) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_IF(WASM_GET_LOCAL(0), WASM_BRV(1, WASM_I32V_1(1))),
WASM_I32V_1(1)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(1, r.Call(0));
CHECK_EQ(1, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock2b) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_IF(WASM_GET_LOCAL(0), WASM_BRV(1, WASM_I32V_1(1))),
WASM_I32V_1(2)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(2, r.Call(0));
CHECK_EQ(1, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock2c) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV_IFD(0, WASM_I32V_1(1), WASM_GET_LOCAL(0)),
WASM_I32V_1(1)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(1, r.Call(0));
CHECK_EQ(1, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock2d) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_BRV_IFD(0, WASM_I32V_1(1), WASM_GET_LOCAL(0)),
WASM_I32V_1(2)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(2, r.Call(0));
CHECK_EQ(1, r.Call(1));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock_ManualSwitch) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_IF(WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(1)),
WASM_BRV(1, WASM_I32V_1(11))),
WASM_IF(WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(2)),
WASM_BRV(1, WASM_I32V_1(12))),
WASM_IF(WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(3)),
WASM_BRV(1, WASM_I32V_1(13))),
WASM_IF(WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(4)),
WASM_BRV(1, WASM_I32V_1(14))),
WASM_IF(WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(5)),
WASM_BRV(1, WASM_I32V_1(15))),
WASM_I32V_2(99)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(99, r.Call(0));
CHECK_EQ(11, r.Call(1));
CHECK_EQ(12, r.Call(2));
CHECK_EQ(13, r.Call(3));
CHECK_EQ(14, r.Call(4));
CHECK_EQ(15, r.Call(5));
CHECK_EQ(99, r.Call(6));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock_ManualSwitch_brif) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(
WASM_BRV_IFD(0, WASM_I32V_1(11),
WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(1))),
WASM_BRV_IFD(0, WASM_I32V_1(12),
WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(2))),
WASM_BRV_IFD(0, WASM_I32V_1(13),
WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(3))),
WASM_BRV_IFD(0, WASM_I32V_1(14),
WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(4))),
WASM_BRV_IFD(0, WASM_I32V_1(15),
WASM_I32_EQ(WASM_GET_LOCAL(0), WASM_I32V_1(5))),
WASM_I32V_2(99)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(99, r.Call(0));
CHECK_EQ(11, r.Call(1));
CHECK_EQ(12, r.Call(2));
CHECK_EQ(13, r.Call(3));
CHECK_EQ(14, r.Call(4));
CHECK_EQ(15, r.Call(5));
CHECK_EQ(99, r.Call(6));
}
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
WASM_EXEC_TEST(If_nested) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(
r,
WASM_IF_ELSE_I(
WASM_GET_LOCAL(0),
WASM_IF_ELSE_I(WASM_GET_LOCAL(1), WASM_I32V_1(11), WASM_I32V_1(12)),
WASM_IF_ELSE_I(WASM_GET_LOCAL(1), WASM_I32V_1(13), WASM_I32V_1(14))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(11, r.Call(1, 1));
CHECK_EQ(12, r.Call(1, 0));
CHECK_EQ(13, r.Call(0, 1));
CHECK_EQ(14, r.Call(0, 0));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock_if) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_BLOCK_I(WASM_IF_ELSE_I(WASM_GET_LOCAL(0),
WASM_BRV(0, WASM_I32V_1(11)),
WASM_BRV(1, WASM_I32V_1(14)))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(11, r.Call(1));
CHECK_EQ(14, r.Call(0));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(ExprBlock_nested_ifs) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_BLOCK_I(WASM_IF_ELSE_I(
[wasm] Remove the explicit count from WASM_BLOCK and WASM_LOOP macros. R=ahaas@chromium.org, rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2170773003 Cr-Commit-Position: refs/heads/master@{#37939}
2016-07-21 11:04:06 +00:00
WASM_GET_LOCAL(0),
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
WASM_IF_ELSE_I(WASM_GET_LOCAL(1), WASM_BRV(0, WASM_I32V_1(11)),
WASM_BRV(1, WASM_I32V_1(12))),
WASM_IF_ELSE_I(WASM_GET_LOCAL(1), WASM_BRV(0, WASM_I32V_1(13)),
WASM_BRV(1, WASM_I32V_1(14))))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(11, r.Call(1, 1));
CHECK_EQ(12, r.Call(1, 0));
CHECK_EQ(13, r.Call(0, 1));
CHECK_EQ(14, r.Call(0, 0));
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(SimpleCallIndirect) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
TestSignatures sigs;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t1 = r.NewFunction(sigs.i_ii());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(t1, WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t1.SetSigIndex(1);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t2 = r.NewFunction(sigs.i_ii());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(t2, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t2.SetSigIndex(1);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Signature table.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().AddSignature(sigs.f_ff());
r.module().AddSignature(sigs.i_ii());
r.module().AddSignature(sigs.d_dd());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Function table.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
uint16_t indirect_function_table[] = {
static_cast<uint16_t>(t1.function_index()),
static_cast<uint16_t>(t2.function_index())};
r.module().AddIndirectFunctionTable(indirect_function_table,
arraysize(indirect_function_table));
r.module().PopulateIndirectFunctionTable();
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
// Build the caller function.
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_CALL_INDIRECT2(1, WASM_GET_LOCAL(0), WASM_I32V_2(66),
WASM_I32V_1(22)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(88, r.Call(0));
CHECK_EQ(44, r.Call(1));
CHECK_TRAP(r.Call(2));
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(MultipleCallIndirect) {
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
TestSignatures sigs;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Refactor WASM test usage of TestingModule. This cleans up and makes the tests easier to write and understand. Also prepares for adding the WASM interpreter which needs a different initialization sequence in tests. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1707403002 Cr-Commit-Position: refs/heads/master@{#34123}
2016-02-18 15:58:02 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t1 = r.NewFunction(sigs.i_ii());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(t1, WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t1.SetSigIndex(1);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t2 = r.NewFunction(sigs.i_ii());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(t2, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t2.SetSigIndex(1);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Signature table.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().AddSignature(sigs.f_ff());
r.module().AddSignature(sigs.i_ii());
r.module().AddSignature(sigs.d_dd());
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
// Function table.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
uint16_t indirect_function_table[] = {
static_cast<uint16_t>(t1.function_index()),
static_cast<uint16_t>(t2.function_index())};
r.module().AddIndirectFunctionTable(indirect_function_table,
arraysize(indirect_function_table));
r.module().PopulateIndirectFunctionTable();
// Build the caller function.
[wasm] Binary 11: WASM AST is now postorder. [wasm] Binary 11: br_table takes a value. [wasm] Binary 11: Add implicit blocks to if arms. [wasm] Binary 11: Add arities to call, return, and breaks [wasm] Binary 11: Add experimental version. This CL changes the encoder, decoder, and tests to use a postorder encoding of the AST, which is more efficient in decode time and space. R=bradnelson@chromium.org,rossberg@chromium.org,binji@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/1830663002 Cr-Commit-Position: refs/heads/master@{#35896}
2016-04-29 09:15:26 +00:00
BUILD(r, WASM_I32_ADD(
WASM_CALL_INDIRECT2(1, WASM_GET_LOCAL(0), WASM_GET_LOCAL(1),
WASM_GET_LOCAL(2)),
WASM_CALL_INDIRECT2(1, WASM_GET_LOCAL(1), WASM_GET_LOCAL(2),
WASM_GET_LOCAL(0))));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
CHECK_EQ(5, r.Call(0, 1, 2));
CHECK_EQ(19, r.Call(0, 1, 9));
CHECK_EQ(1, r.Call(1, 0, 2));
CHECK_EQ(1, r.Call(1, 0, 9));
CHECK_TRAP(r.Call(0, 2, 1));
CHECK_TRAP(r.Call(1, 2, 0));
CHECK_TRAP(r.Call(2, 0, 1));
CHECK_TRAP(r.Call(2, 1, 0));
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(CallIndirect_EmptyTable) {
[wasm] Fix canonicalization bug for function signatures in CallIndirect. R=ahaas@chromium.org BUG=chromium:654231 Review-Url: https://chromiumcodereview.appspot.com/2439613003 Cr-Commit-Position: refs/heads/master@{#40463}
2016-10-20 11:26:14 +00:00
TestSignatures sigs;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Fix canonicalization bug for function signatures in CallIndirect. R=ahaas@chromium.org BUG=chromium:654231 Review-Url: https://chromiumcodereview.appspot.com/2439613003 Cr-Commit-Position: refs/heads/master@{#40463}
2016-10-20 11:26:14 +00:00
// One function.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t1 = r.NewFunction(sigs.i_ii());
[wasm] Fix canonicalization bug for function signatures in CallIndirect. R=ahaas@chromium.org BUG=chromium:654231 Review-Url: https://chromiumcodereview.appspot.com/2439613003 Cr-Commit-Position: refs/heads/master@{#40463}
2016-10-20 11:26:14 +00:00
BUILD(t1, WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t1.SetSigIndex(1);
[wasm] Fix canonicalization bug for function signatures in CallIndirect. R=ahaas@chromium.org BUG=chromium:654231 Review-Url: https://chromiumcodereview.appspot.com/2439613003 Cr-Commit-Position: refs/heads/master@{#40463}
2016-10-20 11:26:14 +00:00
// Signature table.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().AddSignature(sigs.f_ff());
r.module().AddSignature(sigs.i_ii());
r.module().AddIndirectFunctionTable(nullptr, 0);
[wasm] Fix canonicalization bug for function signatures in CallIndirect. R=ahaas@chromium.org BUG=chromium:654231 Review-Url: https://chromiumcodereview.appspot.com/2439613003 Cr-Commit-Position: refs/heads/master@{#40463}
2016-10-20 11:26:14 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
// Build the caller function.
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_CALL_INDIRECT2(1, WASM_GET_LOCAL(0), WASM_I32V_2(66),
WASM_I32V_1(22)));
[wasm] Fix canonicalization bug for function signatures in CallIndirect. R=ahaas@chromium.org BUG=chromium:654231 Review-Url: https://chromiumcodereview.appspot.com/2439613003 Cr-Commit-Position: refs/heads/master@{#40463}
2016-10-20 11:26:14 +00:00
CHECK_TRAP(r.Call(0));
CHECK_TRAP(r.Call(1));
CHECK_TRAP(r.Call(2));
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(CallIndirect_canonical) {
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
TestSignatures sigs;
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t> r(execution_mode);
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t1 = r.NewFunction(sigs.i_ii());
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
BUILD(t1, WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t1.SetSigIndex(0);
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t2 = r.NewFunction(sigs.i_ii());
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
BUILD(t2, WASM_I32_SUB(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t2.SetSigIndex(1);
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t3 = r.NewFunction(sigs.f_ff());
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
BUILD(t3, WASM_F32_SUB(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
t3.SetSigIndex(2);
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
// Signature table.
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().AddSignature(sigs.i_ii());
r.module().AddSignature(sigs.i_ii());
r.module().AddSignature(sigs.f_ff());
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
// Function table.
uint16_t i1 = static_cast<uint16_t>(t1.function_index());
uint16_t i2 = static_cast<uint16_t>(t2.function_index());
uint16_t i3 = static_cast<uint16_t>(t3.function_index());
uint16_t indirect_function_table[] = {i1, i2, i3, i1, i2};
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().AddIndirectFunctionTable(indirect_function_table,
arraysize(indirect_function_table));
r.module().PopulateIndirectFunctionTable();
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
// Build the caller function.
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
BUILD(r, WASM_CALL_INDIRECT2(1, WASM_GET_LOCAL(0), WASM_I32V_2(77),
WASM_I32V_1(11)));
[wasm] Canonicalize function signature indices for matching in indirect calls. R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
2016-10-11 12:40:24 +00:00
CHECK_EQ(88, r.Call(0));
CHECK_EQ(66, r.Call(1));
CHECK_TRAP(r.Call(2));
CHECK_EQ(88, r.Call(3));
CHECK_EQ(66, r.Call(4));
CHECK_TRAP(r.Call(5));
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32Floor) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F32_FLOOR(WASM_GET_LOCAL(0)));
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT32_INPUTS(i) { CHECK_FLOAT_EQ(floorf(*i), r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32Ceil) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F32_CEIL(WASM_GET_LOCAL(0)));
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT32_INPUTS(i) { CHECK_FLOAT_EQ(ceilf(*i), r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32Trunc) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
[wasm] Provide backoff implementations for the Fxx rounding instructions If the architecture does not provide rounding instructions, then C implementations of these rounding instructions are called. The C implementations from math.h are used, function pointers are registered as external references so that they can be call from the simulator. R=titzer@chromium.org BUG=575379 LOG=Y Review URL: https://codereview.chromium.org/1661463002 Cr-Commit-Position: refs/heads/master@{#33677}
2016-02-02 12:26:38 +00:00
BUILD(r, WASM_F32_TRUNC(WASM_GET_LOCAL(0)));
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT32_INPUTS(i) { CHECK_FLOAT_EQ(truncf(*i), r.Call(*i)); }
[wasm] Provide backoff implementations for the Fxx rounding instructions If the architecture does not provide rounding instructions, then C implementations of these rounding instructions are called. The C implementations from math.h are used, function pointers are registered as external references so that they can be call from the simulator. R=titzer@chromium.org BUG=575379 LOG=Y Review URL: https://codereview.chromium.org/1661463002 Cr-Commit-Position: refs/heads/master@{#33677}
2016-02-02 12:26:38 +00:00
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32NearestInt) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F32_NEARESTINT(WASM_GET_LOCAL(0)));
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT32_INPUTS(i) { CHECK_FLOAT_EQ(nearbyintf(*i), r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64Floor) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F64_FLOOR(WASM_GET_LOCAL(0)));
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT64_INPUTS(i) { CHECK_DOUBLE_EQ(floor(*i), r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64Ceil) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F64_CEIL(WASM_GET_LOCAL(0)));
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT64_INPUTS(i) { CHECK_DOUBLE_EQ(ceil(*i), r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64Trunc) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
[wasm] Provide backoff implementations for the Fxx rounding instructions If the architecture does not provide rounding instructions, then C implementations of these rounding instructions are called. The C implementations from math.h are used, function pointers are registered as external references so that they can be call from the simulator. R=titzer@chromium.org BUG=575379 LOG=Y Review URL: https://codereview.chromium.org/1661463002 Cr-Commit-Position: refs/heads/master@{#33677}
2016-02-02 12:26:38 +00:00
BUILD(r, WASM_F64_TRUNC(WASM_GET_LOCAL(0)));
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT64_INPUTS(i) { CHECK_DOUBLE_EQ(trunc(*i), r.Call(*i)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64NearestInt) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double> r(execution_mode);
[wasm] Provide backoff implementations for the Fxx rounding instructions If the architecture does not provide rounding instructions, then C implementations of these rounding instructions are called. The C implementations from math.h are used, function pointers are registered as external references so that they can be call from the simulator. R=titzer@chromium.org BUG=575379 LOG=Y Review URL: https://codereview.chromium.org/1661463002 Cr-Commit-Position: refs/heads/master@{#33677}
2016-02-02 12:26:38 +00:00
BUILD(r, WASM_F64_NEARESTINT(WASM_GET_LOCAL(0)));
[wasm] Backoff implementation for F64Trunc using std::trunc. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1638283004 Cr-Commit-Position: refs/heads/master@{#33670}
2016-02-02 10:57:58 +00:00
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT64_INPUTS(i) { CHECK_DOUBLE_EQ(nearbyint(*i), r.Call(*i)); }
[wasm] Backoff implementation for F64Trunc using std::trunc. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1638283004 Cr-Commit-Position: refs/heads/master@{#33670}
2016-02-02 10:57:58 +00:00
}
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32Min) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F32_MIN(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_FLOAT32_INPUTS(i) {
[turbofan] Add Float32(Max|Min) machine operators. The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2252863003 Cr-Commit-Position: refs/heads/master@{#38784}
2016-08-22 13:50:23 +00:00
FOR_FLOAT32_INPUTS(j) { CHECK_DOUBLE_EQ(JSMin(*i, *j), r.Call(*i, *j)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64Min) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double, double> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F64_MIN(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_FLOAT64_INPUTS(i) {
[turbofan] Add Float32(Max|Min) machine operators. The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2252863003 Cr-Commit-Position: refs/heads/master@{#38784}
2016-08-22 13:50:23 +00:00
FOR_FLOAT64_INPUTS(j) { CHECK_DOUBLE_EQ(JSMin(*i, *j), r.Call(*i, *j)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32Max) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F32_MAX(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_FLOAT32_INPUTS(i) {
[turbofan] Add Float32(Max|Min) machine operators. The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2252863003 Cr-Commit-Position: refs/heads/master@{#38784}
2016-08-22 13:50:23 +00:00
FOR_FLOAT32_INPUTS(j) { CHECK_FLOAT_EQ(JSMax(*i, *j), r.Call(*i, *j)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64Max) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double, double> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F64_MAX(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_FLOAT64_INPUTS(i) {
FOR_FLOAT64_INPUTS(j) {
[wasm] Use the Float64Max/Min machine operators to implement F64Max/Min. I had to adjust Float64Max/Min on x64 slightly to return the default wasm NaN (0x7FF0000000000000) instead of the all-ones NaN (0xFFFFFFFFFFFFFFFF). R=titzer@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2204963002 Cr-Commit-Position: refs/heads/master@{#38410}
2016-08-08 06:06:03 +00:00
double result = r.Call(*i, *j);
[turbofan] Add Float32(Max|Min) machine operators. The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2252863003 Cr-Commit-Position: refs/heads/master@{#38784}
2016-08-22 13:50:23 +00:00
CHECK_DOUBLE_EQ(JSMax(*i, *j), result);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(I32SConvertF32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, float> r(execution_mode);
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
BUILD(r, WASM_I32_SCONVERT_F32(WASM_GET_LOCAL(0)));
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
// The upper bound is (INT32_MAX + 1), which is the lowest float-representable
// number above INT32_MAX which cannot be represented as int32.
float upper_bound = 2147483648.0f;
// We use INT32_MIN as a lower bound because (INT32_MIN - 1) is not
// representable as float, and no number between (INT32_MIN - 1) and INT32_MIN
// is.
float lower_bound = static_cast<float>(INT32_MIN);
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
FOR_FLOAT32_INPUTS(i) {
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
if (*i < upper_bound && *i >= lower_bound) {
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
CHECK_EQ(static_cast<int32_t>(*i), r.Call(*i));
} else {
CHECK_TRAP32(r.Call(*i));
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(I32SConvertF64) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, double> r(execution_mode);
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
BUILD(r, WASM_I32_SCONVERT_F64(WASM_GET_LOCAL(0)));
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
// The upper bound is (INT32_MAX + 1), which is the lowest double-
// representable number above INT32_MAX which cannot be represented as int32.
double upper_bound = 2147483648.0;
// The lower bound is (INT32_MIN - 1), which is the greatest double-
// representable number below INT32_MIN which cannot be represented as int32.
double lower_bound = -2147483649.0;
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
FOR_FLOAT64_INPUTS(i) {
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
if (*i<upper_bound&& * i> lower_bound) {
CHECK_EQ(static_cast<int32_t>(*i), r.Call(*i));
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
} else {
CHECK_TRAP32(r.Call(*i));
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(I32UConvertF32) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, float> r(execution_mode);
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
BUILD(r, WASM_I32_UCONVERT_F32(WASM_GET_LOCAL(0)));
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
// The upper bound is (UINT32_MAX + 1), which is the lowest
// float-representable number above UINT32_MAX which cannot be represented as
// uint32.
double upper_bound = 4294967296.0f;
double lower_bound = -1.0f;
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
FOR_FLOAT32_INPUTS(i) {
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
if (*i<upper_bound&& * i> lower_bound) {
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
CHECK_EQ(static_cast<uint32_t>(*i), r.Call(*i));
} else {
CHECK_TRAP32(r.Call(*i));
}
}
}
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(I32UConvertF64) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<uint32_t, double> r(execution_mode);
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
BUILD(r, WASM_I32_UCONVERT_F64(WASM_GET_LOCAL(0)));
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
// The upper bound is (UINT32_MAX + 1), which is the lowest
// double-representable number above UINT32_MAX which cannot be represented as
// uint32.
double upper_bound = 4294967296.0;
double lower_bound = -1.0;
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
FOR_FLOAT64_INPUTS(i) {
[wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. @v8-mips-ports, can you do a similar implementation for mips? R=titzer@chromium.org, Rodolph.Perfetta@arm.com Review-Url: https://codereview.chromium.org/2105313002 Cr-Commit-Position: refs/heads/master@{#37448}
2016-06-30 14:29:36 +00:00
if (*i<upper_bound&& * i> lower_bound) {
[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1537393003 Cr-Commit-Position: refs/heads/master@{#32984}
2015-12-21 10:52:48 +00:00
CHECK_EQ(static_cast<uint32_t>(*i), r.Call(*i));
} else {
CHECK_TRAP32(r.Call(*i));
}
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F64CopySign) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<double, double, double> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F64_COPYSIGN(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_FLOAT64_INPUTS(i) {
x87: fix the use of CheckFloatEq and CheckDoubleEq in test. Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
2016-03-07 12:29:06 +00:00
FOR_FLOAT64_INPUTS(j) { CHECK_DOUBLE_EQ(copysign(*i, *j), r.Call(*i, *j)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
2016-05-18 15:56:11 +00:00
WASM_EXEC_TEST(F32CopySign) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<float, float, float> r(execution_mode);
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
BUILD(r, WASM_F32_COPYSIGN(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
FOR_FLOAT32_INPUTS(i) {
MIPS: Fix Run_Wasm_F32CopySign. Run_Wasm_F32CopySign was failing because function copysign that is used to verify the results does implicit conversion from float to double. In this conversion we lose information about NaN sign and the test fails. Fix by using copysignf to avoid unnecessary float to double conversion. TEST=cctest/test-run-wasm/Run_Wasm_F32CopySign BUG= Review URL: https://codereview.chromium.org/1857753002 Cr-Commit-Position: refs/heads/master@{#35237}
2016-04-04 12:59:24 +00:00
FOR_FLOAT32_INPUTS(j) { CHECK_FLOAT_EQ(copysignf(*i, *j), r.Call(*i, *j)); }
Initial import of v8-native WASM. As discussed in person, this adds the code from v8-native-prototype into V8 proper, guarded by GYP flags that do not build the code by default. Passing wasm=on to 'make' or setting v8_wasm as a GYP flag activates building of this code. An additional header file is added to and exported from the compiler directory, src/compiler/wasm-compiler.h. This exposes a limited interface with opaque Node and Graph types to the decoder to build TF graphs, as well as functions to compile WASM graphs. The mjsunit tests added are blacklisted because they fail without the WASM object exposed to JS, which is also disabled by the build config option. This corresponds closely to https://github.com/WebAssembly/v8-native-prototype/commit/5981e06ebc9b1e578831d03100f17ebb77970ee0, with some formatting fixes and moving some files into src/compiler. R=mstarzinger@chromium.org, bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1504713014 Cr-Commit-Position: refs/heads/master@{#32794}
2015-12-11 12:26:16 +00:00
}
}
Disable more crashing / failing wasm tests. Disabling some tests for ppc, mips, arm. BUG= R=bbudge@chromium.org Review URL: https://codereview.chromium.org/1564553002 Cr-Commit-Position: refs/heads/master@{#33131}
2016-01-05 23:32:32 +00:00
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
static void CompileCallIndirectMany(ValueType param) {
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
// Make sure we don't run out of registers when compiling indirect calls
// with many many parameters.
TestSignatures sigs;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (byte num_params = 0; num_params < 40; ++num_params) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<void> r(kExecuteCompiled);
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
FunctionSig* sig = sigs.many(r.zone(), kWasmStmt, param, num_params);
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
r.module().AddSignature(sig);
r.module().AddSignature(sig);
r.module().AddIndirectFunctionTable(nullptr, 0);
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmFunctionCompiler& t = r.NewFunction(sig);
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
std::vector<byte> code;
[wasm] memory size is an uint32_t, not a size_t. BUG= Review-Url: https://codereview.chromium.org/2077623002 Cr-Commit-Position: refs/heads/master@{#37044}
2016-06-16 22:21:30 +00:00
for (byte p = 0; p < num_params; ++p) {
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
ADD_CODE(code, kExprGetLocal, p);
}
[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141}
2017-01-09 13:57:26 +00:00
ADD_CODE(code, kExprI32Const, 0);
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates. R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG=chromium:575167, chromium:659591 Review-Url: https://codereview.chromium.org/2440953002 Cr-Commit-Position: refs/heads/master@{#40600}
2016-10-26 16:56:05 +00:00
ADD_CODE(code, kExprCallIndirect, 1, TABLE_ZERO);
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
t.Build(&code[0], &code[0] + code.size());
}
}
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
TEST(Compile_Wasm_CallIndirect_Many_i32) { CompileCallIndirectMany(kWasmI32); }
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
TEST(Compile_Wasm_CallIndirect_Many_f32) { CompileCallIndirectMany(kWasmF32); }
[wasm] Add utilities to print out WASM ast directly from the bytes. Motivated by finding a bug in a larger module, this CL adds the ability to dump out a byte-by-byte, nested view of the decoded AST. This byte-by-byte output uses the opcode enum to make it readable, but is suitable for pasting into a byte[] in C or JS and thus making a regression test. Also fix a bug; the case of running out of registers for indirect calls. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1616973004 Cr-Commit-Position: refs/heads/master@{#33442}
2016-01-21 16:10:53 +00:00
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
TEST(Compile_Wasm_CallIndirect_Many_f64) { CompileCallIndirectMany(kWasmF64); }
[turbofan] Handle dead diamonds in scheduling and add a test. The background here is that graphs generated from WASM are not trimmed. That means there can be some floating control diamonds that are not reachable from end. An assertion in the scheduler for phis from floating diamonds checks that the use edge in this situation is the control edge, but in general, any edge could cause this. Scheduling still works without this assertion. The longer term fix is to either trim the graphs (more compile time overhead for WASM) or improve the scheduler's handling of dead code in the graph. Currently it does not schedule dead code but the potential use positions of dead code are used in the computation of the common dominator of uses. We could recognize dead nodes in PrepareUses() and check in GetBlockForUse() as per TODO. R=bradnelson@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1846933002 Cr-Commit-Position: refs/heads/master@{#35245}
2016-04-04 17:44:29 +00:00
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code. Some instructions in WebAssembly trap for some inputs, which means that the execution is terminated and (at least at the moment) a JavaScript exception is thrown. Examples for traps are out-of-bounds memory accesses, or integer divisions by zero. Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5 TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position constant), in addition to the trap condition itself. Additionally, each WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose number of inputs is linear to the number of trap checks in the function. Especially for functions with high numbers of trap checks we observe a significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing a TrapIf common operator only a single node is necessary per trap check, in addition to the trap condition. Also the nodes which are shared between trap checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a speedup of 30-50% on average. This CL only implements TrapIf and TrapUnless on x64. The implementation is also hidden behind the --wasm-trap-if flag. Please take a special look at how the source position is transfered from the instruction selector to the code generator, and at the context that is used for the runtime call. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2562393002 Cr-Commit-Position: refs/heads/master@{#41720}
2016-12-15 13:31:29 +00:00
WASM_EXEC_TEST_WITH_TRAP(Int32RemS_dead) {
[wasm] Make WasmRunner the central test structure The WasmRunner now always holds a TestingModule, and allows to add several functions to it. The prepares a change to always run wasm code with a full module behind it, removing the special handling for "no wasm instance" at runtime (http://crrev.com/2551053002). This CL here also templatizes the WasmRunner such that the Call method must be called with the same signature specified for the WasmRunner. This already catched several mismatches there. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551043002 Cr-Original-Commit-Position: refs/heads/master@{#41728} Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 Review-Url: https://codereview.chromium.org/2551043002 Cr-Commit-Position: refs/heads/master@{#41747}
2016-12-16 10:13:11 +00:00
WasmRunner<int32_t, int32_t, int32_t> r(execution_mode);
[wasm] Master CL for Binary 0xC changes. [0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
2016-09-27 20:46:10 +00:00
BUILD(r, WASM_I32_REMS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)), WASM_DROP,
WASM_ZERO);
[turbofan] Handle dead diamonds in scheduling and add a test. The background here is that graphs generated from WASM are not trimmed. That means there can be some floating control diamonds that are not reachable from end. An assertion in the scheduler for phis from floating diamonds checks that the use edge in this situation is the control edge, but in general, any edge could cause this. Scheduling still works without this assertion. The longer term fix is to either trim the graphs (more compile time overhead for WASM) or improve the scheduler's handling of dead code in the graph. Currently it does not schedule dead code but the potential use positions of dead code are used in the computation of the common dominator of uses. We could recognize dead nodes in PrepareUses() and check in GetBlockForUse() as per TODO. R=bradnelson@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1846933002 Cr-Commit-Position: refs/heads/master@{#35245}
2016-04-04 17:44:29 +00:00
const int32_t kMin = std::numeric_limits<int32_t>::min();
CHECK_EQ(0, r.Call(133, 100));
CHECK_EQ(0, r.Call(kMin, -1));
CHECK_EQ(0, r.Call(0, 1));
CHECK_TRAP(r.Call(100, 0));
CHECK_TRAP(r.Call(-1001, 0));
CHECK_TRAP(r.Call(kMin, 0));
}
Reference in New Issue Copy Permalink