AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Unconditionally unpark the thread during the AssembleCodePhase

Browse Source 
The code generator accesses the heap even without --code-comments set:
remove the related condition from the UnparkedScopeIfNeeded.

Fixed: v8:12794
Change-Id: I0099f22a9382373c4f75538615fbf431c4d71283
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582389
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Auto-Submit: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79953}
This commit is contained in:
Jakob Gruber 2022-04-13 11:29:45 +02:00 committed by V8 LUCI CQ
parent 58a7761bae
commit 094eddd219
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/pipeline.cc
View File

@ -3600,7 +3600,7 @@ void PipelineImpl::AssembleCode(Linkage* linkage) {
data->BeginPhaseKind("V8.TFCodeGeneration"); data->BeginPhaseKind("V8.TFCodeGeneration");
data->InitializeCodeGenerator(linkage); data->InitializeCodeGenerator(linkage);
UnparkedScopeIfNeeded unparked_scope(data->broker(), FLAG_code_comments); UnparkedScopeIfNeeded unparked_scope(data->broker());
Run<AssembleCodePhase>(); Run<AssembleCodePhase>();
if (data->info()->trace_turbo_json()) { if (data->info()->trace_turbo_json()) {