AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[message] Remove deprecated PrintCurrentStackTrace function which take a FILE*

Browse Source 
Change-Id: I598b3e7b0ad349c504d8729eb288d19b14319253
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439336
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Auto-Submit: Harshil Jain <twitharshil@gmail.com>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79074}
This commit is contained in:
Harshil Jain 2022-02-04 13:45:03 +05:30 committed by V8 LUCI CQ
parent 3f5c2dda67
commit 0bca3b4563
3 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -112,6 +112,7 @@ Gus Caplan <me@gus.host>
Gwang Yoon Hwang <ryumiel@company100.net>
Haichuan Wang <hc.opensource@gmail.com>
Hannu Trey <hannu.trey@gmail.com>
Harshil Jain <twitharshil@gmail.com>
Henrique Ferreiro <henrique.ferreiro@gmail.com>
Hirofumi Mako <mkhrfm@gmail.com>
Honggyu Kim <honggyu.kp@gmail.com>

2
include/v8-message.h
View File

@ -189,8 +189,6 @@ class V8_EXPORT Message {
bool IsSharedCrossOrigin() const;
bool IsOpaque() const;
V8_DEPRECATED("Use the version that takes a std::ostream&.")
static void PrintCurrentStackTrace(Isolate* isolate, FILE* out);
static void PrintCurrentStackTrace(Isolate* isolate, std::ostream& out);
static const int kNoLineNumberInfo = 0;

8
src/api/api.cc
View File

@ -3119,14 +3119,6 @@ MaybeLocal<String> Message::GetSourceLine(Local<Context> context) const {
RETURN_ESCAPED(Utils::ToLocal(self->GetSourceLine()));
}
void Message::PrintCurrentStackTrace(Isolate* isolate, FILE* out) {
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);
std::ostringstream stack_trace_stream;
i_isolate->PrintCurrentStackTrace(stack_trace_stream);
i::PrintF(out, "%s", stack_trace_stream.str().c_str());
}
void Message::PrintCurrentStackTrace(Isolate* isolate, std::ostream& out) {
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);