AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Don't unconditionally read heap when printing types

Browse Source 
... since we may be in the background. Print the HeapObjectRef instead,
which will read the heap when it's allowed to do so.

Bug: v8:9541
Change-Id: I201c6dcd83e1b050393d633e4d59aec636772da6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889876
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64655}
This commit is contained in:
Georg Neis 2019-10-30 12:00:57 +01:00 committed by Commit Bot
parent 179a2a51a5
commit 0fb929af25
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/types.cc
View File

@ -1022,7 +1022,7 @@ void Type::PrintTo(std::ostream& os) const {
if (this->IsBitset()) {
BitsetType::Print(os, this->AsBitset());
} else if (this->IsHeapConstant()) {
os << "HeapConstant(" << Brief(*this->AsHeapConstant()->Value()) << ")";
os << "HeapConstant(" << this->AsHeapConstant()->Ref() << ")";
} else if (this->IsOtherNumberConstant()) {
os << "OtherNumberConstant(" << this->AsOtherNumberConstant()->Value()
<< ")";