AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[csa|interpreter] Remove unnecessary SMI tagging.

Browse Source 
Bug: 
Change-Id: Ic872ea78511f0ef3e8cea67b971162b71790a039
Reviewed-on: https://chromium-review.googlesource.com/781690
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49564}
This commit is contained in:
Marja Hölttä 2017-11-21 16:34:53 +01:00 committed by Commit Bot
parent 97becc1bab
commit 25a753383e
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/code-stub-assembler.cc
View File

@ -7978,7 +7978,7 @@ Node* CodeStubAssembler::CreateWeakCellInFeedbackVector(Node* feedback_vector,
// Store the WeakCell in the feedback vector. // Store the WeakCell in the feedback vector.
StoreFeedbackVectorSlot(feedback_vector, slot, cell, UPDATE_WRITE_BARRIER, 0, StoreFeedbackVectorSlot(feedback_vector, slot, cell, UPDATE_WRITE_BARRIER, 0,
CodeStubAssembler::SMI_PARAMETERS); CodeStubAssembler::INTPTR_PARAMETERS);
return cell; return cell;
} }

8
src/interpreter/interpreter-assembler.cc
View File

@ -668,7 +668,7 @@ void InterpreterAssembler::CollectCallableFeedback(Node* target, Node* context,
} }
} }
BIND(&done_loop); BIND(&done_loop);
CreateWeakCellInFeedbackVector(feedback_vector, SmiTag(slot_id), target); CreateWeakCellInFeedbackVector(feedback_vector, slot_id, target);
ReportFeedbackUpdate(feedback_vector, slot_id, "Call:Initialize"); ReportFeedbackUpdate(feedback_vector, slot_id, "Call:Initialize");
Goto(&done); Goto(&done);
} }
@ -875,8 +875,7 @@ Node* InterpreterAssembler::Construct(Node* target, Node* context,
BIND(&create_weak_cell); BIND(&create_weak_cell);
{ {
CreateWeakCellInFeedbackVector(feedback_vector, SmiTag(slot_id), CreateWeakCellInFeedbackVector(feedback_vector, slot_id, new_target);
new_target);
ReportFeedbackUpdate(feedback_vector, slot_id, ReportFeedbackUpdate(feedback_vector, slot_id,
"Construct:CreateWeakCell"); "Construct:CreateWeakCell");
Goto(&construct); Goto(&construct);
@ -994,8 +993,7 @@ Node* InterpreterAssembler::ConstructWithSpread(Node* target, Node* context,
GotoIfNot(WordEqual(LoadNativeContext(context), target_native_context), GotoIfNot(WordEqual(LoadNativeContext(context), target_native_context),
&mark_megamorphic); &mark_megamorphic);
CreateWeakCellInFeedbackVector(feedback_vector, SmiTag(slot_id), CreateWeakCellInFeedbackVector(feedback_vector, slot_id, new_target);
new_target);
ReportFeedbackUpdate(feedback_vector, slot_id, ReportFeedbackUpdate(feedback_vector, slot_id,
"ConstructWithSpread:Initialize"); "ConstructWithSpread:Initialize");
Goto(&construct); Goto(&construct);