AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[riscv64] Delete a confirmed fix me comment

Browse Source 
Change-Id: I5b17019a991f1540c0ecc1db0a94097334e5e335
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3463060
Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
Commit-Queue: ji qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#79112}
This commit is contained in:
Lu Yahan 2022-02-15 09:54:15 +08:00 committed by V8 LUCI CQ
parent 9c25aaa7ad
commit 3053b3b71f
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/codegen/riscv64/macro-assembler-riscv64.cc
View File

@ -4940,10 +4940,6 @@ void TurboAssembler::CallCFunctionHelper(Register function,
Register scratch = t2;
auipc(pc_scratch, 0);
// TODO(RISCV): Does this need an offset? It seems like this should be the
// PC of the call, but MIPS does not seem to do that.
// https://github.com/v8-riscv/v8/issues/378
// See x64 code for reasoning about how to address the isolate data fields.
if (root_array_available()) {
Sd(pc_scratch, MemOperand(kRootRegister,