AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Temporarily remove unsound use of Maybe until we have a proper fix.

Browse Source 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/609073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
neis@chromium.org 2014-09-30 10:37:47 +00:00
parent 7045592947
commit 40a968bec4
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/js-typed-lowering.cc
View File

@ -383,6 +383,7 @@ Reduction JSTypedLowering::ReduceJSStrictEqual(Node* node, bool invert) {
: jsgraph()->TrueConstant()); : jsgraph()->TrueConstant());
} }
} }
/* TODO(neis): This is currently unsound.
if (!r.left_type()->Maybe(r.right_type())) { if (!r.left_type()->Maybe(r.right_type())) {
// Type intersection is empty; === is always false unless both // Type intersection is empty; === is always false unless both
// inputs could be strings (one internalized and one not). // inputs could be strings (one internalized and one not).
@ -391,6 +392,7 @@ Reduction JSTypedLowering::ReduceJSStrictEqual(Node* node, bool invert) {
: jsgraph()->FalseConstant()); : jsgraph()->FalseConstant());
} }
} }
*/
if (r.OneInputIs(Type::Undefined())) { if (r.OneInputIs(Type::Undefined())) {
return r.ChangeToPureOperator( return r.ChangeToPureOperator(
simplified()->ReferenceEqual(Type::Undefined()), invert); simplified()->ReferenceEqual(Type::Undefined()), invert);