AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Relax test expectations for test-cpu-profiler/FunctionApplySample

Browse Source 
The profile may look a bit different on the bots (see below). We expected this only under GC stress testing, the change makes regular expectations the same.

[Top down]:
   68     0   (root) [-1] #0 1
    1     1    (program) [-1] #0 2
   67    65    start [-1] #16 3
    2     0      (unresolved function) [-1] #0 4
    2     2        apply [-1] #0 5

BUG=None
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/18331012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yurys@chromium.org 2013-07-03 14:23:34 +00:00
parent 45264ffbf6
commit 41c9adffc6
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/cctest/test-cpu-profiler.cc
View File

@ -1169,13 +1169,7 @@ TEST(FunctionApplySample) {
CheckChildrenNames(root, names); CheckChildrenNames(root, names);
} }
// In case of GC stress tests all samples may be in GC phase and there
// won't be |start| node in the profile.
bool is_gc_stress_testing =
(i::FLAG_gc_interval != -1) || i::FLAG_stress_compaction;
const v8::CpuProfileNode* startNode = FindChild(root, "start"); const v8::CpuProfileNode* startNode = FindChild(root, "start");
CHECK(is_gc_stress_testing || startNode);
if (startNode) { if (startNode) {
{ {
ScopedVector<v8::Handle<v8::String> > names(2); ScopedVector<v8::Handle<v8::String> > names(2);
@ -1185,7 +1179,6 @@ TEST(FunctionApplySample) {
} }
const v8::CpuProfileNode* testNode = FindChild(startNode, "test"); const v8::CpuProfileNode* testNode = FindChild(startNode, "test");
CHECK(is_gc_stress_testing || testNode);
if (testNode) { if (testNode) {
ScopedVector<v8::Handle<v8::String> > names(2); ScopedVector<v8::Handle<v8::String> > names(2);
names[0] = v8::String::New("bar"); names[0] = v8::String::New("bar");