AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[*] Fixed MSVC cannot initialize CppHeapCreateParams with an initializer list. Furthermore, CppHeapCreateParams is improperly exported. Specifying visibility confuses MSVC. There are no implemented member symbols for visibility to make sense.

Browse Source
This commit is contained in:
Reece Wilson 2022-10-16 01:26:25 +01:00
parent c9b547e373
commit 4c7c7d1a24
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/v8-cppgc.h
View File

@ -76,12 +76,15 @@ struct WrapperDescriptor final {
uint16_t embedder_id_for_garbage_collected;
};
struct V8_EXPORT CppHeapCreateParams {
struct CppHeapCreateParams {
CppHeapCreateParams() = default;
CppHeapCreateParams(const CppHeapCreateParams&) = delete;
CppHeapCreateParams(CppHeapCreateParams&&) = default;
CppHeapCreateParams &operator = (const CppHeapCreateParams&) = delete;
inline CppHeapCreateParams(WrapperDescriptor wrapper_descriptor)
: wrapper_descriptor(wrapper_descriptor) {}
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
WrapperDescriptor wrapper_descriptor;
/**