AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Don't print inlined function ID in --trace-hydrogen

Browse Source 
FunctionLiteral has two purposes: it is a unit of compilation, and it is
also an expression.  Its id() is only for the latter purpose, used by
the continuation of the closure, not by the closure itself.

When we inline, we treat the FunctionLiteral as a unit of compilation,
not as an expression, and as such the FunctionLiteral doesn't have any
meaningful ID.  The right thing to do is not to access the ID when
printing the hydrogen expression.

R=svenpanne@chromium.org, vegorov@google.com
BUG=v8:3680
LOG=N

Review URL: https://codereview.chromium.org/716793003

Cr-Commit-Position: refs/heads/master@{#25267}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
wingo@igalia.com 2014-11-11 15:53:42 +00:00
parent 3b3929fdc7
commit 5044c510cb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hydrogen-instructions.cc
View File

@ -2662,8 +2662,7 @@ void HEnterInlined::RegisterReturnTarget(HBasicBlock* return_target,
std::ostream& HEnterInlined::PrintDataTo(std::ostream& os) const { // NOLINT
return os << function()->debug_name()->ToCString().get()
<< ", id=" << function()->id().ToInt();
return os << function()->debug_name()->ToCString().get();
}