AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[flags] Remove --harmony-namespace-exports

Browse Source 
It's shipped since M72.

Bug: v8:8101
Change-Id: I80856b9e1acfb6e434f20b6174e864f8c4e2896a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509945
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70955}
This commit is contained in:
Shu-yu Guo 2020-10-30 10:16:38 -07:00 committed by Commit Bot
parent a5e33a57d7
commit 5a03fbeba4
7 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flags/flag-definitions.h
View File

@ -278,8 +278,6 @@ DEFINE_IMPLICATION(harmony_weak_refs_with_cleanup_some, harmony_weak_refs)
// Features that are shipping (turned on by default, but internal flag remains).
#define HARMONY_SHIPPING_BASE(V) \
V(harmony_namespace_exports, \
"harmony namespace exports (export * as foo from 'bar')") \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_promise_all_settled, "harmony Promise.allSettled") \

1
src/init/bootstrapper.cc
View File

@ -4126,7 +4126,6 @@ void Genesis::InitializeCallSiteBuiltins() {
#define EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(id) \
void Genesis::InitializeGlobal_##id() {}
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_namespace_exports)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_private_methods)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_regexp_sequence)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_top_level_await)

4
src/parsing/parser.cc
View File

@ -1465,8 +1465,7 @@ void Parser::ParseExportStar() {
int pos = position();
Consume(Token::MUL);
if (!FLAG_harmony_namespace_exports ||
!PeekContextualKeyword(ast_value_factory()->as_string())) {
if (!PeekContextualKeyword(ast_value_factory()->as_string())) {
// 'export' '*' 'from' ModuleSpecifier ';'
Scanner::Location loc = scanner()->location();
ExpectContextualKeyword(ast_value_factory()->from_string());
@ -1478,7 +1477,6 @@ void Parser::ParseExportStar() {
specifier_loc, zone());
return;
}
if (!FLAG_harmony_namespace_exports) return;
// 'export' '*' 'as' IdentifierName 'from' ModuleSpecifier ';'
//

1
test/cctest/test-parsing.cc
View File

@ -7626,7 +7626,6 @@ TEST(NamespaceExportParsing) {
};
// clang-format on
i::FLAG_harmony_namespace_exports = true;
i::Isolate* isolate = CcTest::i_isolate();
i::Factory* factory = isolate->factory();

2
test/message/fail/modules-duplicate-export5.mjs
View File

@ -2,7 +2,5 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-namespace-exports
export let foo = 42;
export * as foo from "./doesnt-even-matter.mjs";

2
test/message/fail/modules-duplicate-export5.out
View File

@ -1,4 +1,4 @@
*%(basename)s:8: SyntaxError: Duplicate export of 'foo'
*%(basename)s:6: SyntaxError: Duplicate export of 'foo'
export * as foo from "./doesnt-even-matter.mjs";
^^^
SyntaxError: Duplicate export of 'foo'

1
test/test262/testcfg.py
View File

@ -49,7 +49,6 @@ FEATURE_FLAGS = {
'Intl.DateTimeFormat-quarter': '--harmony-intl-dateformat-quarter',
'String.prototype.replaceAll': '--harmony_string_replaceall',
'Symbol.prototype.description': '--harmony-symbol-description',
'export-star-as-namespace-from-module': '--harmony-namespace-exports',
'Promise.allSettled': '--harmony-promise-all-settled',
'FinalizationRegistry': '--harmony-weak-refs-with-cleanup-some',
'WeakRef': '--harmony-weak-refs-with-cleanup-some',