AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[bazel] Use v8_enable_handle_zapping only in debug builds.

Browse Source 
This leads to a noticable performance improvements, and this flag
is flipped to "is_debug" by the V8 Autoroller in release branches
for the GN builds, so this change matches that behavior.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Change-Id: I0a6d9798617939f822a6ce347ed2005b1597627a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380246
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78561}
This commit is contained in:
Piotr Sikora 2022-01-11 01:02:54 -08:00 committed by V8 LUCI CQ
parent 5c829be17c
commit 685e6078ff
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.bazelrc
View File

@ -17,6 +17,7 @@ build:debug --compilation_mode=dbg
build:debug --config=v8_enable_debugging_features build:debug --config=v8_enable_debugging_features
build:debug --//:v8_enable_fast_mksnapshot build:debug --//:v8_enable_fast_mksnapshot
build:debug --//:v8_enable_backtrace build:debug --//:v8_enable_backtrace
build:debug --//:v8_enable_handle_zapping
# v8_enable_debugging_features flags # v8_enable_debugging_features flags
build:v8_enable_debugging_features --//:v8_enable_verify_heap build:v8_enable_debugging_features --//:v8_enable_verify_heap

5
BUILD.bazel
View File

@ -104,10 +104,7 @@ v8_flag(name = "v8_enable_debug_code")
v8_flag(name = "v8_enable_disassembler") v8_flag(name = "v8_enable_disassembler")
v8_flag( v8_flag(name = "v8_enable_handle_zapping")
name = "v8_enable_handle_zapping",
default = True,
)
v8_flag(name = "v8_enable_hugepage") v8_flag(name = "v8_enable_hugepage")