AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[codegen] Reduce kScratchDoubleReg usage"

Browse Source 
This reverts commit b9d2c22ad0.

Reason for revert: Reverting due to regressions in multiple JS
performance/memory benchmarks. 

Original change's description:
> [codegen] Reduce kScratchDoubleReg usage
> 
> Bug: v8:10506
> Change-Id: I3fccaf640e23b5fcc7722164e2437b247684f824
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207919
> Reviewed-by: Zhi An Ng <zhin@chromium.org>
> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#67909}

TBR=gdeepti@chromium.org,zhin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:10506
Change-Id: I9a1c960c577f0e0d42c817d03bc56895268a0718
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219339
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68031}
This commit is contained in:
Deepti Gandluri 2020-05-28 01:27:17 +00:00 committed by Commit Bot
parent 061fbbd118
commit 707ef57545
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/codegen/x64/macro-assembler-x64.cc
View File

@ -725,7 +725,7 @@ void TurboAssembler::Cvtsd2ss(XMMRegister dst, Operand src) {
void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Register src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtlsi2sd(dst, dst, src);
vcvtlsi2sd(dst, kScratchDoubleReg, src);
} else {
xorpd(dst, dst);
cvtlsi2sd(dst, src);
@ -735,7 +735,7 @@ void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Register src) {
void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Operand src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtlsi2sd(dst, dst, src);
vcvtlsi2sd(dst, kScratchDoubleReg, src);
} else {
xorpd(dst, dst);
cvtlsi2sd(dst, src);
@ -745,7 +745,7 @@ void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Operand src) {
void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Register src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtlsi2ss(dst, dst, src);
vcvtlsi2ss(dst, kScratchDoubleReg, src);
} else {
xorps(dst, dst);
cvtlsi2ss(dst, src);
@ -755,7 +755,7 @@ void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Register src) {
void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Operand src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtlsi2ss(dst, dst, src);
vcvtlsi2ss(dst, kScratchDoubleReg, src);
} else {
xorps(dst, dst);
cvtlsi2ss(dst, src);
@ -765,7 +765,7 @@ void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Operand src) {
void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Register src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtqsi2ss(dst, dst, src);
vcvtqsi2ss(dst, kScratchDoubleReg, src);
} else {
xorps(dst, dst);
cvtqsi2ss(dst, src);
@ -775,7 +775,7 @@ void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Register src) {
void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Operand src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtqsi2ss(dst, dst, src);
vcvtqsi2ss(dst, kScratchDoubleReg, src);
} else {
xorps(dst, dst);
cvtqsi2ss(dst, src);
@ -785,7 +785,7 @@ void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Operand src) {
void TurboAssembler::Cvtqsi2sd(XMMRegister dst, Register src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtqsi2sd(dst, dst, src);
vcvtqsi2sd(dst, kScratchDoubleReg, src);
} else {
xorpd(dst, dst);
cvtqsi2sd(dst, src);
@ -795,7 +795,7 @@ void TurboAssembler::Cvtqsi2sd(XMMRegister dst, Register src) {
void TurboAssembler::Cvtqsi2sd(XMMRegister dst, Operand src) {
if (CpuFeatures::IsSupported(AVX)) {
CpuFeatureScope scope(this, AVX);
vcvtqsi2sd(dst, dst, src);
vcvtqsi2sd(dst, kScratchDoubleReg, src);
} else {
xorpd(dst, dst);
cvtqsi2sd(dst, src);