AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Build cctest while building V8

Browse Source 
I noticed in a recent build that C++ files from cctest didn't start
compiling until after several slow non-parallel tasks such as running
mksnapshot and linking v8_for_testing. I don't see any reason that
cctest sources should wait for those tasks, so in this change I propose
adjusting the build dependencies for more parallelism.

Change-Id: I2472117c8555ac397fa1232954c8b699d6429d38
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690170
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#80976}
This commit is contained in:
Seth Brenith 2022-06-03 15:56:29 -07:00 committed by V8 LUCI CQ
parent a072a429a4
commit 7787ed2007
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/cctest/BUILD.gn
View File

@ -16,7 +16,13 @@ v8_executable("cctest") {
sources = [ "cctest.cc" ]
deps = [ ":cctest_sources" ]
deps = [
":cctest_sources",
"../..:v8_for_testing",
"../..:v8_libbase",
"../..:v8_libplatform",
"../../tools/debug_helper:v8_debug_helper",
]
data_deps = [ "../../tools:v8_testrunner" ]
@ -340,10 +346,6 @@ v8_source_set("cctest_sources") {
public_deps = [
":cctest_headers",
"..:common_test_headers",
"../..:v8_for_testing",
"../..:v8_libbase",
"../..:v8_libplatform",
"../../tools/debug_helper:v8_debug_helper",
"//build/win:default_exe_manifest",
]