AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Make test-api/ScavengeExternal*String non-threaded test.

Browse Source 
ScavengeExternalString and ScavengeExternalOneByteString clear GC flags,
which confuses concurrent sweeping that was started from another test.

Tests that mutate flags should not be threaded.

Bug: v8:7671
Change-Id: I08656d06fe85ff45baca685ebe5982528aad774c
Reviewed-on: https://chromium-review.googlesource.com/1019102
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52690}
This commit is contained in:
Ulan Degenbaev 2018-04-19 15:13:40 +02:00 committed by Commit Bot
parent 9ab6621ac7
commit 7e61eb337f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/cctest/test-api.cc
View File

@ -786,8 +786,7 @@ THREADED_TEST(NewExternalForVeryLongString) {
}
}
THREADED_TEST(ScavengeExternalString) {
TEST(ScavengeExternalString) {
ManualGCScope manual_gc_scope;
i::FLAG_stress_compaction = false;
i::FLAG_gc_global = false;
@ -811,8 +810,7 @@ THREADED_TEST(ScavengeExternalString) {
CHECK_EQ(1, dispose_count);
}
THREADED_TEST(ScavengeExternalOneByteString) {
TEST(ScavengeExternalOneByteString) {
ManualGCScope manual_gc_scope;
i::FLAG_stress_compaction = false;
i::FLAG_gc_global = false;