AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Don't make any decisions on old space limits after scavenges.

Browse Source 
We just do not possess enough information at that point.

Review URL: http://codereview.chromium.org/2836026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4949 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
vegorov@chromium.org 2010-06-25 08:59:52 +00:00
parent 991af26519
commit 8036035777
2 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/heap.cc
View File

@ -131,7 +131,6 @@ int Heap::high_survival_rate_period_length_ = 0;
double Heap::survival_rate_ = 0;
Heap::SurvivalRateTrend Heap::previous_survival_rate_trend_ = Heap::STABLE;
Heap::SurvivalRateTrend Heap::survival_rate_trend_ = Heap::STABLE;
bool Heap::bumped_old_gen_limits_ = false;
#ifdef DEBUG
bool Heap::allocation_allowed_ = true;
@ -666,7 +665,6 @@ void Heap::PerformGarbageCollection(AllocationSpace space,
// space for the mutation speed.
old_gen_promotion_limit_ *= 2;
old_gen_allocation_limit_ *= 2;
bumped_old_gen_limits_ = true;
}
old_gen_exhausted_ = false;
@ -676,19 +674,6 @@ void Heap::PerformGarbageCollection(AllocationSpace space,
tracer_ = NULL;
UpdateSurvivalRateTrend(start_new_space_size);
if (bumped_old_gen_limits_ &&
!IsHighSurvivalRate() &&
!IsIncreasingSurvivalTrend()) {
// We previously observed high survival rates in young space and decided
// to bump old space allocation limits to trade the space for the speed
// but now survival rates are dropping which indicates that mutator
// finished updating tenured data structure. So we can decrease old space
// limits to guarantee an early full GC cycle and reduce memory footprint.
old_gen_promotion_limit_ /= 2;
old_gen_allocation_limit_ /= 2;
bumped_old_gen_limits_ = false;
}
}
Counters::objs_since_last_young.Set(0);

1
src/heap.h
View File

@ -1285,7 +1285,6 @@ class Heap : public AllStatic {
static double survival_rate_;
static SurvivalRateTrend previous_survival_rate_trend_;
static SurvivalRateTrend survival_rate_trend_;
static bool bumped_old_gen_limits_;
static void set_survival_rate_trend(SurvivalRateTrend survival_rate_trend) {
ASSERT(survival_rate_trend != FLUCTUATING);